提交 ee0bcdc1 编写于 作者: F fengsheng 提交者: Yang Yingliang

drivers : sysctl fixup some param dont check the legitimacy

driver inclusion
category: Bugfix
bugzilla: NA
CVE: NA

1. the variable : sysctl_subctrl_tdh_priv[chip_id] add legitimacy check.
2. the param of sysctl_tdh_mem_access_open: chip_id add legitimacy check.
Signed-off-by: Nfengsheng <fengsheng5@huawei.com>
Reviewed-by: Nzhangmu <zhangmu1@huawei.com>
Signed-off-by: NYang Yingliang <yangyingliang@huawei.com>
上级 fb6d05c2
...@@ -48,7 +48,7 @@ ...@@ -48,7 +48,7 @@
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
#define DEBUG #define DEBUG
#define SYSCTL_DRIVER_VERSION "1.9.32.0" #define SYSCTL_DRIVER_VERSION "1.9.38.0"
unsigned int g_sysctrl_debug; unsigned int g_sysctrl_debug;
......
...@@ -90,6 +90,9 @@ static int sysctl_tdh_reset(u8 chip_id) ...@@ -90,6 +90,9 @@ static int sysctl_tdh_reset(u8 chip_id)
return SYSCTL_ERR_PARAM; return SYSCTL_ERR_PARAM;
} }
if (!sysctl_subctrl_tdh_priv[chip_id])
return SYSCTL_ERR_PARAM;
addr = sysctl_subctrl_tdh_priv[chip_id] + SUBCTRL_TDH_RESET_OFFSET; addr = sysctl_subctrl_tdh_priv[chip_id] + SUBCTRL_TDH_RESET_OFFSET;
writel(0x3, addr); writel(0x3, addr);
...@@ -105,6 +108,9 @@ static int sysctl_tdh_unreset(u8 chip_id) ...@@ -105,6 +108,9 @@ static int sysctl_tdh_unreset(u8 chip_id)
return SYSCTL_ERR_PARAM; return SYSCTL_ERR_PARAM;
} }
if (!sysctl_subctrl_tdh_priv[chip_id])
return SYSCTL_ERR_PARAM;
addr = sysctl_subctrl_tdh_priv[chip_id] + SUBCTRL_TDH_UNRESET_OFFSET; addr = sysctl_subctrl_tdh_priv[chip_id] + SUBCTRL_TDH_UNRESET_OFFSET;
writel(0x3, addr); writel(0x3, addr);
...@@ -115,6 +121,11 @@ static int sysctl_tdh_mem_access_open(u8 chip_id) ...@@ -115,6 +121,11 @@ static int sysctl_tdh_mem_access_open(u8 chip_id)
{ {
void __iomem *addr; void __iomem *addr;
if (chip_id >= CHIP_ID_NUM_MAX) {
pr_err("err chip id %u %s\n", chip_id, __func__);
return SYSCTL_ERR_PARAM;
}
if (!sysctl_tdh_priv[chip_id]) if (!sysctl_tdh_priv[chip_id])
return SYSCTL_ERR_PARAM; return SYSCTL_ERR_PARAM;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册