提交 ebf5112c 编写于 作者: Y Yan Burman 提交者: Jeff Garzik

ep93xx: some minor cleanups to the ep93xx eth driver

Small cleanup in the Cirrus Logic EP93xx ethernet driver: Check for NULL
pointer before dereferencing it instead of after.  Remove unreferenced
variable.
Signed-off-by: NYan Burman <burman.yan@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>
Cc: Russell King <rmk@arm.linux.org.uk>
Signed-off-by: NAndrew Morton <akpm@osdl.org>
Signed-off-by: NJeff Garzik <jeff@garzik.org>
上级 3a960f7e
...@@ -780,12 +780,10 @@ static struct ethtool_ops ep93xx_ethtool_ops = { ...@@ -780,12 +780,10 @@ static struct ethtool_ops ep93xx_ethtool_ops = {
struct net_device *ep93xx_dev_alloc(struct ep93xx_eth_data *data) struct net_device *ep93xx_dev_alloc(struct ep93xx_eth_data *data)
{ {
struct net_device *dev; struct net_device *dev;
struct ep93xx_priv *ep;
dev = alloc_etherdev(sizeof(struct ep93xx_priv)); dev = alloc_etherdev(sizeof(struct ep93xx_priv));
if (dev == NULL) if (dev == NULL)
return NULL; return NULL;
ep = netdev_priv(dev);
memcpy(dev->dev_addr, data->dev_addr, ETH_ALEN); memcpy(dev->dev_addr, data->dev_addr, ETH_ALEN);
...@@ -840,9 +838,9 @@ static int ep93xx_eth_probe(struct platform_device *pdev) ...@@ -840,9 +838,9 @@ static int ep93xx_eth_probe(struct platform_device *pdev)
struct ep93xx_priv *ep; struct ep93xx_priv *ep;
int err; int err;
data = pdev->dev.platform_data;
if (pdev == NULL) if (pdev == NULL)
return -ENODEV; return -ENODEV;
data = pdev->dev.platform_data;
dev = ep93xx_dev_alloc(data); dev = ep93xx_dev_alloc(data);
if (dev == NULL) { if (dev == NULL) {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册