提交 dda094a3 编写于 作者: A Alexey Khoroshilov 提交者: Jeff Kirsher

i40e: Fix memory leak at failure path in i40e_dbg_command_write()

The patch fixes a leak of 'cmd_buf' when copy_from_user() failed
in i40e_dbg_command_write().

Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: NAlexey Khoroshilov <khoroshilov@ispras.ru>
Tested-by: NJim Young <james.m.young@intel.com>
Signed-off-by: NJeff Kirsher <jeffrey.t.kirsher@intel.com>
上级 31639b94
...@@ -989,8 +989,10 @@ static ssize_t i40e_dbg_command_write(struct file *filp, ...@@ -989,8 +989,10 @@ static ssize_t i40e_dbg_command_write(struct file *filp,
if (!cmd_buf) if (!cmd_buf)
return count; return count;
bytes_not_copied = copy_from_user(cmd_buf, buffer, count); bytes_not_copied = copy_from_user(cmd_buf, buffer, count);
if (bytes_not_copied < 0) if (bytes_not_copied < 0) {
kfree(cmd_buf);
return bytes_not_copied; return bytes_not_copied;
}
if (bytes_not_copied > 0) if (bytes_not_copied > 0)
count -= bytes_not_copied; count -= bytes_not_copied;
cmd_buf[count] = '\0'; cmd_buf[count] = '\0';
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册
新手
引导
客服 返回
顶部