提交 cb9eaba4 编写于 作者: N Nicholas Mc Guire 提交者: Wolfram Sang

i2c: imx: fix handling of wait_for_completion_timeout result

wait_for_completion_timeout does not return negative values so
"result" handling here should be simplified to cover the actually
possible cases only.
Signed-off-by: NNicholas Mc Guire <der.herr@hofr.at>
Signed-off-by: NWolfram Sang <wsa@the-dreams.de>
上级 387f0de6
......@@ -628,9 +628,9 @@ static int i2c_imx_dma_write(struct imx_i2c_struct *i2c_imx,
result = wait_for_completion_timeout(
&i2c_imx->dma->cmd_complete,
msecs_to_jiffies(DMA_TIMEOUT));
if (result <= 0) {
if (result == 0) {
dmaengine_terminate_all(dma->chan_using);
return result ?: -ETIMEDOUT;
return -ETIMEDOUT;
}
/* Waiting for transfer complete. */
......@@ -686,9 +686,9 @@ static int i2c_imx_dma_read(struct imx_i2c_struct *i2c_imx,
result = wait_for_completion_timeout(
&i2c_imx->dma->cmd_complete,
msecs_to_jiffies(DMA_TIMEOUT));
if (result <= 0) {
if (result == 0) {
dmaengine_terminate_all(dma->chan_using);
return result ?: -ETIMEDOUT;
return -ETIMEDOUT;
}
/* waiting for transfer complete. */
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册