提交 c443dca1 编写于 作者: S Suwan Kim 提交者: Xie XiuQi

usbip: Fix free of unallocated memory in vhci tx

[ Upstream commit d4d8257754c3300ea2a465dadf8d2b02c713c920 ]

iso_buffer should be set to NULL after use and free in the while loop.
In the case of isochronous URB in the while loop, iso_buffer is
allocated and after sending it to server, buffer is deallocated. And
then, if the next URB in the while loop is not a isochronous pipe,
iso_buffer still holds the previously deallocated buffer address and
kfree tries to free wrong buffer address.

Fixes: ea44d190764b ("usbip: Implement SG support to vhci-hcd and stub driver")
Reported-by: Nkbuild test robot <lkp@intel.com>
Reported-by: NJulia Lawall <julia.lawall@lip6.fr>
Signed-off-by: NSuwan Kim <suwan.kim027@gmail.com>
Reviewed-by: NJulia Lawall <julia.lawall@lip6.fr>
Acked-by: NShuah Khan <skhan@linuxfoundation.org>
Link: https://lore.kernel.org/r/20191022093017.8027-1-suwan.kim027@gmail.comSigned-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: NSasha Levin <sashal@kernel.org>
Signed-off-by: NYang Yingliang <yangyingliang@huawei.com>
上级 3dc25e27
...@@ -147,7 +147,10 @@ static int vhci_send_cmd_submit(struct vhci_device *vdev) ...@@ -147,7 +147,10 @@ static int vhci_send_cmd_submit(struct vhci_device *vdev)
} }
kfree(iov); kfree(iov);
/* This is only for isochronous case */
kfree(iso_buffer); kfree(iso_buffer);
iso_buffer = NULL;
usbip_dbg_vhci_tx("send txdata\n"); usbip_dbg_vhci_tx("send txdata\n");
total_size += txsize; total_size += txsize;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册