提交 bf7b8760 编写于 作者: M Michael Buesch 提交者: John W. Linville

[PATCH] bcm43xx: Workaround init_board vs IRQ race.

The proper fix for this is to move IRQ enabling to the end of
init_board. But this is nontrivial and needs to be done with care.
Stay with this cheap workaround for now.
Signed-off-by: NMichael Buesch <mbuesch@freenet.de>
Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
上级 c4c3beb7
...@@ -2079,12 +2079,19 @@ static irqreturn_t bcm43xx_interrupt_handler(int irq, void *dev_id, struct pt_re ...@@ -2079,12 +2079,19 @@ static irqreturn_t bcm43xx_interrupt_handler(int irq, void *dev_id, struct pt_re
bcm43xx_interrupt_ack(bcm, reason, mask); bcm43xx_interrupt_ack(bcm, reason, mask);
/* disable all IRQs. They are enabled again in the bottom half. */ /* Only accept IRQs, if we are initialized properly.
bcm->irq_savedstate = bcm43xx_interrupt_disable(bcm, BCM43xx_IRQ_ALL); * This avoids an RX race while initializing.
* We should probably not enable IRQs before we are initialized
/* save the reason code and call our bottom half. */ * completely, but some careful work is needed to fix this. I think it
bcm->irq_reason = reason; * is best to stay with this cheap workaround for now... .
tasklet_schedule(&bcm->isr_tasklet); */
if (likely(bcm->initialized)) {
/* disable all IRQs. They are enabled again in the bottom half. */
bcm->irq_savedstate = bcm43xx_interrupt_disable(bcm, BCM43xx_IRQ_ALL);
/* save the reason code and call our bottom half. */
bcm->irq_reason = reason;
tasklet_schedule(&bcm->isr_tasklet);
}
spin_unlock(&bcm->lock); spin_unlock(&bcm->lock);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册