提交 bf05c663 编写于 作者: K Kangjie Lu 提交者: Xie XiuQi

thunderbolt: property: Fix a missing check of kzalloc

[ Upstream commit 6183d5a51866f3acdeeb66b75e87d44025b01a55 ]

No check is enforced for the return value of kzalloc,
which may lead to NULL-pointer dereference.

The patch fixes this issue.
Signed-off-by: NKangjie Lu <kjlu@umn.edu>
Reviewed-by: NMukesh Ojha <mojha@codeaurora.org>
Signed-off-by: NMika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: NSasha Levin <sashal@kernel.org>
Signed-off-by: NYang Yingliang <yangyingliang@huawei.com>
上级 3390419e
...@@ -581,7 +581,12 @@ int tb_property_add_text(struct tb_property_dir *parent, const char *key, ...@@ -581,7 +581,12 @@ int tb_property_add_text(struct tb_property_dir *parent, const char *key,
return -ENOMEM; return -ENOMEM;
property->length = size / 4; property->length = size / 4;
property->value.data = kzalloc(size, GFP_KERNEL); property->value.text = kzalloc(size, GFP_KERNEL);
if (!property->value.text) {
kfree(property);
return -ENOMEM;
}
strcpy(property->value.text, text); strcpy(property->value.text, text);
list_add_tail(&property->list, &parent->properties); list_add_tail(&property->list, &parent->properties);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册