提交 9d89c01d 编写于 作者: H Huazhong Tan 提交者: Xie XiuQi

net: hns3: fix a memory leak issue for hclge_map_unmap_ring_to_vf_vector

driver inclusion
category: bugfix
bugzilla: NA
CVE: NA

When hclge_bind_ring_with_vector() fails,
hclge_map_unmap_ring_to_vf_vector() will return the error
directly, so nobody will free the memory allocated by
hclge_get_ring_chain_from_mbx().

So hclge_free_vector_ring_chain() should be called no matter
hclge_bind_ring_with_vector() fails or not.

Fixes: 84e095d6 ("net: hns3: Change PF to add ring-vect binding & resetQ to mailbox")
Signed-off-by: NHuazhong Tan <tanhuazhong@huawei.com>
Reviewed-by: Nlipeng <lipeng321@huawei.com>
Reviewed-by: NXie XiuQi <xiexiuqi@huawei.com>
Signed-off-by: NYang Yingliang <yangyingliang@huawei.com>
上级 3b79232b
...@@ -220,12 +220,10 @@ static int hclge_map_unmap_ring_to_vf_vector(struct hclge_vport *vport, bool en, ...@@ -220,12 +220,10 @@ static int hclge_map_unmap_ring_to_vf_vector(struct hclge_vport *vport, bool en,
return ret; return ret;
ret = hclge_bind_ring_with_vector(vport, vector_id, en, &ring_chain); ret = hclge_bind_ring_with_vector(vport, vector_id, en, &ring_chain);
if (ret)
return ret;
hclge_free_vector_ring_chain(&ring_chain); hclge_free_vector_ring_chain(&ring_chain);
return 0; return ret;
} }
static int hclge_set_vf_promisc_mode(struct hclge_vport *vport, static int hclge_set_vf_promisc_mode(struct hclge_vport *vport,
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册