提交 9a7e0c2a 编写于 作者: C Chris Wilson 提交者: Daniel Vetter

drm/i915: Rearrange the comments in i915_add_request()

The comments were a little out-of-sequence with the code, forcing the
reader to jump around whilst reading. Whilst moving the comments around,
add one to explain the context reference.
Signed-off-by: NChris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: NDamien Lespiau <damien.lespiau@intel.com>
Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
上级 c0321e2c
...@@ -2062,8 +2062,6 @@ int __i915_add_request(struct intel_ring_buffer *ring, ...@@ -2062,8 +2062,6 @@ int __i915_add_request(struct intel_ring_buffer *ring,
request->ring = ring; request->ring = ring;
request->head = request_start; request->head = request_start;
request->tail = request_ring_position; request->tail = request_ring_position;
request->ctx = ring->last_context;
request->batch_obj = obj;
/* Whilst this request exists, batch_obj will be on the /* Whilst this request exists, batch_obj will be on the
* active_list, and so will hold the active reference. Only when this * active_list, and so will hold the active reference. Only when this
...@@ -2071,7 +2069,12 @@ int __i915_add_request(struct intel_ring_buffer *ring, ...@@ -2071,7 +2069,12 @@ int __i915_add_request(struct intel_ring_buffer *ring,
* inactive_list and lose its active reference. Hence we do not need * inactive_list and lose its active reference. Hence we do not need
* to explicitly hold another reference here. * to explicitly hold another reference here.
*/ */
request->batch_obj = obj;
/* Hold a reference to the current context so that we can inspect
* it later in case a hangcheck error event fires.
*/
request->ctx = ring->last_context;
if (request->ctx) if (request->ctx)
i915_gem_context_reference(request->ctx); i915_gem_context_reference(request->ctx);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册