提交 986a80d5 编写于 作者: J Jesper Juhl 提交者: Tony Luck

[PATCH] avoid signed vs unsigned comparison in efi_range_is_wc()

warning when building with gcc -W : 

 include/linux/efi.h: In function `efi_range_is_wc':
 include/linux/efi.h:320: warning: comparison between signed and unsigned

It looks to me like a significantly large 'len' passed in could cause the 
loop to never end. Isn't it safer to make 'i' an unsigned long as well? 
Like this little patch below (which of course also kills the warning) :
Signed-off-by: NJesper Juhl <juhl-lkml@dif.dk>
Signed-off-by: NTony Luck <tony.luck@intel.com>
上级 4845f333
......@@ -315,7 +315,7 @@ extern struct efi_memory_map memmap;
*/
static inline int efi_range_is_wc(unsigned long start, unsigned long len)
{
int i;
unsigned long i;
for (i = 0; i < len; i += (1UL << EFI_PAGE_SHIFT)) {
unsigned long paddr = __pa(start + i);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册