提交 9393943b 编写于 作者: D Daniel Vetter

drm/i915: Remove irq-related FIXME in reset code

With the two-step reset counter increments which braket the actual
reset code and the subsequent wake-up we're guaranteeing that all the
lockless waiters _will_ be woken up. And since we unconditionally bail
out of waits with -EAGAIN (or -EIO) in that case there is not risk of
lost interrupt enabling bits when the lockless wait code races against
a gpu reset.

Let's remove this FIXME as resolved then.
Signed-off-by: NDaniel Vetter <daniel.vetter@intel.com>
Reviewed-by: NRodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
上级 fd0753cf
...@@ -881,12 +881,6 @@ int i915_reset(struct drm_device *dev) ...@@ -881,12 +881,6 @@ int i915_reset(struct drm_device *dev)
return ret; return ret;
} }
/*
* FIXME: This races pretty badly against concurrent holders of
* ring interrupts. This is possible since we've started to drop
* dev->struct_mutex in select places when waiting for the gpu.
*/
/* /*
* rps/rc6 re-init is necessary to restore state lost after the * rps/rc6 re-init is necessary to restore state lost after the
* reset and the re-install of gt irqs. Skip for ironlake per * reset and the re-install of gt irqs. Skip for ironlake per
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册