提交 77eaae8d 编写于 作者: J J. Bruce Fields

nfsd4: simplify check_open logic

Sometimes the single-exit style is good, sometimes it's unnecessarily
convoluted....
Signed-off-by: NJ. Bruce Fields <bfields@redhat.com>
上级 7a8711c9
...@@ -2573,7 +2573,6 @@ static __be32 ...@@ -2573,7 +2573,6 @@ static __be32
nfs4_check_open(struct nfs4_file *fp, struct nfsd4_open *open, struct nfs4_stateid **stpp) nfs4_check_open(struct nfs4_file *fp, struct nfsd4_open *open, struct nfs4_stateid **stpp)
{ {
struct nfs4_stateid *local; struct nfs4_stateid *local;
__be32 status = nfserr_share_denied;
struct nfs4_stateowner *sop = open->op_stateowner; struct nfs4_stateowner *sop = open->op_stateowner;
list_for_each_entry(local, &fp->fi_stateids, st_perfile) { list_for_each_entry(local, &fp->fi_stateids, st_perfile) {
...@@ -2585,11 +2584,9 @@ nfs4_check_open(struct nfs4_file *fp, struct nfsd4_open *open, struct nfs4_state ...@@ -2585,11 +2584,9 @@ nfs4_check_open(struct nfs4_file *fp, struct nfsd4_open *open, struct nfs4_state
*stpp = local; *stpp = local;
/* check for conflicting share reservations */ /* check for conflicting share reservations */
if (!test_share(local, open)) if (!test_share(local, open))
goto out; return nfserr_share_denied;
} }
status = 0; return nfs_ok;
out:
return status;
} }
static inline struct nfs4_stateid * static inline struct nfs4_stateid *
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册