提交 69bdfc26 编写于 作者: H huangguangbin2 提交者: Xie XiuQi

net: hns3: fix a repeat code warning in two functions.

driver inclusion
category: bugfix
bugzilla: NA
CVE: NA

This patch fixes a repeat code warning in two functions,
and wrap the same codes into a function.

Feature or Bugfix:Bugfix
Signed-off-by: Nhuangguangbin (A) <huangguangbin2@huawei.com>
Reviewed-by: Nlipeng <lipeng321@huawei.com>
Reviewed-by: NYang Yingliang <yangyingliang@huawei.com>
Signed-off-by: NYang Yingliang <yangyingliang@huawei.com>
上级 f1323258
...@@ -16,15 +16,7 @@ static int hclge_dbg_get_dfx_bd_num(struct hclge_dev *hdev, int offset) ...@@ -16,15 +16,7 @@ static int hclge_dbg_get_dfx_bd_num(struct hclge_dev *hdev, int offset)
int index; int index;
int ret; int ret;
hclge_cmd_setup_basic_desc(&desc[0], HCLGE_OPC_DFX_BD_NUM, true); ret = hclge_query_bd_num_cmd_send(hdev, desc);
desc[0].flag |= cpu_to_le16(HCLGE_CMD_FLAG_NEXT);
hclge_cmd_setup_basic_desc(&desc[1], HCLGE_OPC_DFX_BD_NUM, true);
desc[1].flag |= cpu_to_le16(HCLGE_CMD_FLAG_NEXT);
hclge_cmd_setup_basic_desc(&desc[2], HCLGE_OPC_DFX_BD_NUM, true);
desc[2].flag |= cpu_to_le16(HCLGE_CMD_FLAG_NEXT);
hclge_cmd_setup_basic_desc(&desc[3], HCLGE_OPC_DFX_BD_NUM, true);
ret = hclge_cmd_send(&hdev->hw, desc, 4);
if (ret != HCLGE_CMD_EXEC_SUCCESS) { if (ret != HCLGE_CMD_EXEC_SUCCESS) {
dev_err(&hdev->pdev->dev, dev_err(&hdev->pdev->dev,
"get dfx bdnum fail, status is %d.\n", ret); "get dfx bdnum fail, status is %d.\n", ret);
......
...@@ -9596,13 +9596,8 @@ static int hclge_get_64_bit_regs(struct hclge_dev *hdev, u32 regs_num, ...@@ -9596,13 +9596,8 @@ static int hclge_get_64_bit_regs(struct hclge_dev *hdev, u32 regs_num,
#define REG_NUM_REMAIN_MASK 3 #define REG_NUM_REMAIN_MASK 3
#define BD_LIST_MAX_NUM 30 #define BD_LIST_MAX_NUM 30
static int hclge_get_dfx_reg_bd_num(struct hclge_dev *hdev, int hclge_query_bd_num_cmd_send(struct hclge_dev *hdev, struct hclge_desc *desc)
int *bd_num_list,
u32 type_num)
{ {
u32 entries_per_desc, desc_index, index, i;
enum hclge_dfx_reg_offset offset;
struct hclge_desc desc[4];
int ret; int ret;
/*prepare 4 commands to query DFX BD number*/ /*prepare 4 commands to query DFX BD number*/
...@@ -9615,9 +9610,23 @@ static int hclge_get_dfx_reg_bd_num(struct hclge_dev *hdev, ...@@ -9615,9 +9610,23 @@ static int hclge_get_dfx_reg_bd_num(struct hclge_dev *hdev,
hclge_cmd_setup_basic_desc(&desc[3], HCLGE_OPC_DFX_BD_NUM, true); hclge_cmd_setup_basic_desc(&desc[3], HCLGE_OPC_DFX_BD_NUM, true);
ret = hclge_cmd_send(&hdev->hw, desc, 4); ret = hclge_cmd_send(&hdev->hw, desc, 4);
return ret;
}
static int hclge_get_dfx_reg_bd_num(struct hclge_dev *hdev,
int *bd_num_list,
u32 type_num)
{
u32 entries_per_desc, desc_index, index, i;
enum hclge_dfx_reg_offset offset;
struct hclge_desc desc[4];
int ret;
ret = hclge_query_bd_num_cmd_send(hdev, desc);
if (ret != HCLGE_CMD_EXEC_SUCCESS) { if (ret != HCLGE_CMD_EXEC_SUCCESS) {
dev_err(&hdev->pdev->dev, dev_err(&hdev->pdev->dev,
"Query dfx bd num fail, status is %d.\n", ret); "Get dfx bd num fail, status is %d.\n", ret);
return ret; return ret;
} }
......
...@@ -1032,4 +1032,6 @@ int hclge_push_vf_port_base_vlan_info(struct hclge_vport *vport, u8 vfid, ...@@ -1032,4 +1032,6 @@ int hclge_push_vf_port_base_vlan_info(struct hclge_vport *vport, u8 vfid,
enum hnae3_reset_type hclge_get_reset_level(struct hnae3_ae_dev *ae_dev, enum hnae3_reset_type hclge_get_reset_level(struct hnae3_ae_dev *ae_dev,
unsigned long *addr); unsigned long *addr);
void hclge_link_status_change(struct hclge_dev *hdev, int state); void hclge_link_status_change(struct hclge_dev *hdev, int state);
int hclge_query_bd_num_cmd_send(struct hclge_dev *hdev,
struct hclge_desc *desc);
#endif #endif
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册