提交 68eb0731 编写于 作者: M Mel Gorman 提交者: Linus Torvalds

mm, pagevec: release/reacquire lru_lock on pgdat change

With node-lru, the locking is based on the pgdat.  Previously it was
required that a pagevec drain released one zone lru_lock and acquired
another zone lru_lock on every zone change.  Now, it's only necessary if
the node changes.  The end-result is fewer lock release/acquires if the
pages are all on the same node but in different zones.

Link: http://lkml.kernel.org/r/1468588165-12461-4-git-send-email-mgorman@techsingularity.netSigned-off-by: NMel Gorman <mgorman@techsingularity.net>
Acked-by: NMinchan Kim <minchan@kernel.org>
Acked-by: NJohannes Weiner <hannes@cmpxchg.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
上级 9cb937e2
...@@ -179,26 +179,26 @@ static void pagevec_lru_move_fn(struct pagevec *pvec, ...@@ -179,26 +179,26 @@ static void pagevec_lru_move_fn(struct pagevec *pvec,
void *arg) void *arg)
{ {
int i; int i;
struct zone *zone = NULL; struct pglist_data *pgdat = NULL;
struct lruvec *lruvec; struct lruvec *lruvec;
unsigned long flags = 0; unsigned long flags = 0;
for (i = 0; i < pagevec_count(pvec); i++) { for (i = 0; i < pagevec_count(pvec); i++) {
struct page *page = pvec->pages[i]; struct page *page = pvec->pages[i];
struct zone *pagezone = page_zone(page); struct pglist_data *pagepgdat = page_pgdat(page);
if (pagezone != zone) { if (pagepgdat != pgdat) {
if (zone) if (pgdat)
spin_unlock_irqrestore(zone_lru_lock(zone), flags); spin_unlock_irqrestore(&pgdat->lru_lock, flags);
zone = pagezone; pgdat = pagepgdat;
spin_lock_irqsave(zone_lru_lock(zone), flags); spin_lock_irqsave(&pgdat->lru_lock, flags);
} }
lruvec = mem_cgroup_page_lruvec(page, zone->zone_pgdat); lruvec = mem_cgroup_page_lruvec(page, pgdat);
(*move_fn)(page, lruvec, arg); (*move_fn)(page, lruvec, arg);
} }
if (zone) if (pgdat)
spin_unlock_irqrestore(zone_lru_lock(zone), flags); spin_unlock_irqrestore(&pgdat->lru_lock, flags);
release_pages(pvec->pages, pvec->nr, pvec->cold); release_pages(pvec->pages, pvec->nr, pvec->cold);
pagevec_reinit(pvec); pagevec_reinit(pvec);
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册