提交 5cb44ee2 编写于 作者: A Andy Shevchenko

platform/x86: intel_mid_powerbtn: Move comment to where it belongs

The comments is about initial interrupt acknowledgment only. So, move it
back to where it belongs.
Signed-off-by: NAndy Shevchenko <andriy.shevchenko@linux.intel.com>
上级 b30f3f8e
...@@ -76,16 +76,6 @@ static int mid_pbstat(struct mid_pb_ddata *ddata, int *value) ...@@ -76,16 +76,6 @@ static int mid_pbstat(struct mid_pb_ddata *ddata, int *value)
static int mfld_ack(struct mid_pb_ddata *ddata) static int mfld_ack(struct mid_pb_ddata *ddata)
{ {
/*
* SCU firmware might send power button interrupts to IA core before
* kernel boots and doesn't get EOI from IA core. The first bit of
* MSIC reg 0x21 is kept masked, and SCU firmware doesn't send new
* power interrupt to Android kernel. Unmask the bit when probing
* power button in kernel.
* There is a very narrow race between irq handler and power button
* initialization. The race happens rarely. So we needn't worry
* about it.
*/
return intel_msic_reg_update(INTEL_MSIC_IRQLVL1MSK, 0, MSIC_PWRBTNM); return intel_msic_reg_update(INTEL_MSIC_IRQLVL1MSK, 0, MSIC_PWRBTNM);
} }
...@@ -202,6 +192,16 @@ static int mid_pb_probe(struct platform_device *pdev) ...@@ -202,6 +192,16 @@ static int mid_pb_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, ddata); platform_set_drvdata(pdev, ddata);
/*
* SCU firmware might send power button interrupts to IA core before
* kernel boots and doesn't get EOI from IA core. The first bit of
* MSIC reg 0x21 is kept masked, and SCU firmware doesn't send new
* power interrupt to Android kernel. Unmask the bit when probing
* power button in kernel.
* There is a very narrow race between irq handler and power button
* initialization. The race happens rarely. So we needn't worry
* about it.
*/
error = ddata->ack(ddata); error = ddata->ack(ddata);
if (error) { if (error) {
dev_err(&pdev->dev, dev_err(&pdev->dev,
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册