提交 5bfa2a17 编写于 作者: S Sriram 提交者: David S. Miller

TI Davinci EMAC : Fix Console Hang when bringing the interface down

In the NAPI poll function(emac_poll), check for netif_running()
is unnecassary. In addition to associated runtime overhead, it
also results in a continuous softirq loop when the interface is
brought down under heavy traffic(tested wit Traffic Generator).
Once the interface is disabled, the poll function always returns
zero(with the check for netif_running) and napi_complete() would
never get called resulting in softirq loop.
Signed-off-by: NSriramakrishnan <srk@ti.com>
Acked-by: NChaithrika U S <chaithrika@ti.com>
Signed-off-by: NDavid S. Miller <davem@davemloft.net>
上级 f88c5b98
...@@ -2140,9 +2140,6 @@ static int emac_poll(struct napi_struct *napi, int budget) ...@@ -2140,9 +2140,6 @@ static int emac_poll(struct napi_struct *napi, int budget)
u32 status = 0; u32 status = 0;
u32 num_pkts = 0; u32 num_pkts = 0;
if (!netif_running(ndev))
return 0;
/* Check interrupt vectors and call packet processing */ /* Check interrupt vectors and call packet processing */
status = emac_read(EMAC_MACINVECTOR); status = emac_read(EMAC_MACINVECTOR);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册