提交 571d2f0c 编写于 作者: M Mickaël Salaün 提交者: Richard Weinberger

um: Do not set unsecure permission for temporary file

Remove the insecure 0777 mode for temporary file to prohibit other users
to change the executable mapped code.

An attacker could gain access to the mapped file descriptor from the
temporary file (before it is unlinked) in a read-only mode but it should
not be accessible in write mode to avoid arbitrary code execution.

To not change the hostfs behavior, the temporary file creation
permission now depends on the current umask(2) and the implementation of
mkstemp(3).
Signed-off-by: NMickaël Salaün <mic@digikod.net>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Richard Weinberger <richard@nod.at>
Acked-by: NTristan Schmelcher <tschmelcher@google.com>
Signed-off-by: NRichard Weinberger <richard@nod.at>
上级 42d91f61
......@@ -142,12 +142,6 @@ static int __init create_tmp_file(unsigned long long len)
if (fd < 0)
exit(1);
err = fchmod(fd, 0777);
if (err < 0) {
perror("fchmod");
exit(1);
}
/*
* Seek to len - 1 because writing a character there will
* increase the file size by one byte, to the desired length.
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册