提交 4b8a8262 编写于 作者: M Markus Elfring 提交者: Jiri Kosina

HID: picoLCD: Deletion of unnecessary checks before three function calls

The functions backlight_device_unregister(), lcd_device_unregister() and
rc_unregister_device() test whether their argument is NULL and then
return immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.
Signed-off-by: NMarkus Elfring <elfring@users.sourceforge.net>
Reviewed-by: NBruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: NJiri Kosina <jkosina@suse.com>
上级 67db8a80
...@@ -94,8 +94,7 @@ void picolcd_exit_backlight(struct picolcd_data *data) ...@@ -94,8 +94,7 @@ void picolcd_exit_backlight(struct picolcd_data *data)
struct backlight_device *bdev = data->backlight; struct backlight_device *bdev = data->backlight;
data->backlight = NULL; data->backlight = NULL;
if (bdev) backlight_device_unregister(bdev);
backlight_device_unregister(bdev);
} }
int picolcd_resume_backlight(struct picolcd_data *data) int picolcd_resume_backlight(struct picolcd_data *data)
......
...@@ -145,7 +145,6 @@ void picolcd_exit_cir(struct picolcd_data *data) ...@@ -145,7 +145,6 @@ void picolcd_exit_cir(struct picolcd_data *data)
struct rc_dev *rdev = data->rc_dev; struct rc_dev *rdev = data->rc_dev;
data->rc_dev = NULL; data->rc_dev = NULL;
if (rdev) rc_unregister_device(rdev);
rc_unregister_device(rdev);
} }
...@@ -92,8 +92,7 @@ void picolcd_exit_lcd(struct picolcd_data *data) ...@@ -92,8 +92,7 @@ void picolcd_exit_lcd(struct picolcd_data *data)
struct lcd_device *ldev = data->lcd; struct lcd_device *ldev = data->lcd;
data->lcd = NULL; data->lcd = NULL;
if (ldev) lcd_device_unregister(ldev);
lcd_device_unregister(ldev);
} }
int picolcd_resume_lcd(struct picolcd_data *data) int picolcd_resume_lcd(struct picolcd_data *data)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册