提交 272e4f99 编写于 作者: J Joerg Roedel

iommu/amd: WARN when __[attach|detach]_device are called with irqs enabled

These functions rely on being called with IRQs disabled. Add
a WARN_ON to detect early when its not.
Signed-off-by: NJoerg Roedel <jroedel@suse.de>
上级 f1dd0a8b
...@@ -2030,6 +2030,12 @@ static int __attach_device(struct iommu_dev_data *dev_data, ...@@ -2030,6 +2030,12 @@ static int __attach_device(struct iommu_dev_data *dev_data,
{ {
int ret; int ret;
/*
* Must be called with IRQs disabled. Warn here to detect early
* when its not.
*/
WARN_ON(!irqs_disabled());
/* lock domain */ /* lock domain */
spin_lock(&domain->lock); spin_lock(&domain->lock);
...@@ -2190,6 +2196,12 @@ static void __detach_device(struct iommu_dev_data *dev_data) ...@@ -2190,6 +2196,12 @@ static void __detach_device(struct iommu_dev_data *dev_data)
{ {
struct protection_domain *domain; struct protection_domain *domain;
/*
* Must be called with IRQs disabled. Warn here to detect early
* when its not.
*/
WARN_ON(!irqs_disabled());
if (WARN_ON(!dev_data->domain)) if (WARN_ON(!dev_data->domain))
return; return;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册