提交 1cbc8703 编写于 作者: T Tomi Valkeinen

OMAP: DSS2: Taal: add locks to taal_bl_update_status

taal_bl_update_status was missing locks to protect taal_data. This caused
a kernel crash randomly, as the code attempted to set the brightness while
the OMAP's DSI block was actually disabled.
Signed-off-by: NTomi Valkeinen <tomi.valkeinen@nokia.com>
上级 4ffa3571
...@@ -290,24 +290,26 @@ static int taal_bl_update_status(struct backlight_device *dev) ...@@ -290,24 +290,26 @@ static int taal_bl_update_status(struct backlight_device *dev)
dev_dbg(&dssdev->dev, "update brightness to %d\n", level); dev_dbg(&dssdev->dev, "update brightness to %d\n", level);
mutex_lock(&td->lock);
if (td->use_dsi_bl) { if (td->use_dsi_bl) {
if (td->enabled) { if (td->enabled) {
dsi_bus_lock(); dsi_bus_lock();
r = taal_dcs_write_1(DCS_BRIGHTNESS, level); r = taal_dcs_write_1(DCS_BRIGHTNESS, level);
dsi_bus_unlock(); dsi_bus_unlock();
if (r) } else {
return r; r = 0;
} }
} else { } else {
if (!dssdev->set_backlight) if (!dssdev->set_backlight)
return -EINVAL; r = -EINVAL;
else
r = dssdev->set_backlight(dssdev, level); r = dssdev->set_backlight(dssdev, level);
if (r)
return r;
} }
return 0; mutex_unlock(&td->lock);
return r;
} }
static int taal_bl_get_intensity(struct backlight_device *dev) static int taal_bl_get_intensity(struct backlight_device *dev)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册