提交 1bfaf1d5 编写于 作者: M Marek Vasut 提交者: Matthew Garrett

ACER: Fix Smatch double-free issue

The patch 6ae3a0876185: "ACER: Add support for accelerometer sensor"
from Jun 1, 2012, leads to the following Smatch warning:
drivers/platform/x86/acer-wmi.c:1886 acer_wmi_accel_destroy()
         error: don't call input_free_device() after input_unregister_device()

drivers/platform/x86/acer-wmi.c
  1883  static void acer_wmi_accel_destroy(void)
  1884  {
  1885          input_unregister_device(acer_wmi_accel_dev);
  1886          input_free_device(acer_wmi_accel_dev);
  1887  }
Reported-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NMarek Vasut <marex@denx.de>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Fengguang Wu <wfg@linux.intel.com>
Cc: joeyli <jlee@suse.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NMatthew Garrett <mjg@redhat.com>
上级 24237c43
......@@ -1883,7 +1883,6 @@ static int __init acer_wmi_accel_setup(void)
static void acer_wmi_accel_destroy(void)
{
input_unregister_device(acer_wmi_accel_dev);
input_free_device(acer_wmi_accel_dev);
}
static int __init acer_wmi_input_setup(void)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册