• V
    drm/i915: Fix AVI/HDMI/SPD infoframes on HSW+ · ffc85dab
    Ville Syrjälä 提交于
    I broke AVI/HDMI/SPD infoframes on HSW+ with the register type
    safety changes. We were supposed to check that the infoframe data
    register is valid before writing the infoframe data, but the check
    ended up inverted, and so in practice we never wrote or enabled
    these infoframes.
    
    We were still sending out the GCP infoframe when the sink was
    deep-color capable. That and the fact that we use a single
    bool to track our infoframe state meant that the state checker
    only caught this when a HDMI sink that doesn't do deep-color was
    used.
    
    We really need to fix our infoframe state checking to be much
    more anal. But in the meantime let's just fix the regression.
    In fact let's just throw out the register validity check and
    convert some of the "unknown info frame type" debug messages
    into MISSING_CASE(). So far we support the same set of infoframe
    types on all platforms, so the silent debug messages make no
    sense.
    
    Cc: drm-intel-fixes@lists.freedesktop.org
    Fixes: f0f59a00 ("drm/i915: Type safe register read/write")
    Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> (irc)
    Tested-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> (irc)
    Signed-off-by: NVille Syrjälä <ville.syrjala@linux.intel.com>
    Link: http://patchwork.freedesktop.org/patch/msgid/1450282200-4203-1-git-send-email-ville.syrjala@linux.intel.com
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93119Reviewed-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
    ffc85dab
intel_hdmi.c 65.6 KB