• P
    staging: drop kbuild workaround dummy module from top dir · e223da96
    Paul Gortmaker 提交于
    This is essentially a revert of 86f69fe9
    ("Staging: workaround build system bug"), but to call it a revert would
    imply it was wrong -- rather it seems more like it is just no longer
    required anymore.
    
    It doesn't list the full details of the failing use case, but the most
    obvious would appear to be a "make allnoconfig" that subsequently had set
    just CONFIG_STAGING=y in the .config file, to give:
    
      paul@builder:~/git/linux-head$ grep STAGING ../staging-allno/.config
      CONFIG_STAGING=y
      # CONFIG_STAGING_MEDIA is not set
      # CONFIG_STAGING_BOARD is not set
      paul@builder:~/git/linux-head$
    
    After building this .config (on ARM, just to be different), we see that
    built-in.o is created, and the final vmlinux links OK:
    
      paul@builder:~/git/linux-head$ ls -l ../staging-allno/drivers/staging/built-in.o
      -rw-rw-r-- 1 paul paul 257 Nov 16 18:06 ../staging-allno/drivers/staging/built-in.o
      paul@builder:~/git/linux-head$ file ../staging-allno/drivers/staging/built-in.o
      ../staging-allno/drivers/staging/built-in.o: ELF 32-bit LSB relocatable, ARM, version 1, not stripped
      paul@builder:~/git/linux-head$ nm ../staging-allno/drivers/staging/built-in.o
      nm: ../staging-allno/drivers/staging/built-in.o: no symbols
      paul@builder:~/git/linux-head$ ls -l ../staging-allno/vmlinux
      -rwxrwxr-x 1 paul paul 1236326 Nov 16 18:07 ../staging-allno/vmlinux
      paul@builder:~/git/linux-head$
    
    I also tested an "allmodconfig" and did not see any problems there
    either.  Switching back to x86-64 and testing several things there didn't
    show any issues either.  So it appears we do not need to carry the
    workaround in tree any longer.
    
    Cc: linux-kbuild@vger.kernel.org
    Signed-off-by: NPaul Gortmaker <paul.gortmaker@windriver.com>
    Acked-by: NMichal Marek <mmarek@suse.com>
    Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    e223da96
Makefile 1.5 KB