• T
    spi: spi-mxs: Fix extra CS pulses and read mode in multi-transfer messages · df23286e
    Trent Piepho 提交于
    There are two bits which control the CS line in the CTRL0 register:
    LOCK_CS and IGNORE_CRC.  The latter would be better named DEASSERT_CS
    in SPI mode.
    
    Setting DEASSERT_CS causes CS to be de-asserted at the end of the transfer.
    It should normally be set only for the final segment of the final transfer.
    The DMA code explicitly sets it in this case, but because it never clears
    the bit from the ctrl0 register, it will remain set for all transfers in
    subsequent messages.  This results in a CS pulse between transfers.
    
    There is a similar problem with the read mode bit never being cleared
    in DMA mode.
    
    This patch fixes DEASSERT_CS and READ being left on in DMA mode.
    Signed-off-by: NTrent Piepho <tpiepho@gmail.com>
    Cc: Marek Vasut <marex@denx.de>
    Cc: Fabio Estevam <fabio.estevam@freescale.com>
    Cc: Shawn Guo <shawn.guo@linaro.org>
    Signed-off-by: NMark Brown <broonie@linaro.org>
    df23286e
spi-mxs.c 14.7 KB