• D
    Btrfs: kfree()ing ERR_PTRs · c47ca32d
    Dan Carpenter 提交于
    The "inherit" in btrfs_ioctl_snap_create_v2() and "vol_args" in
    btrfs_ioctl_rm_dev() are ERR_PTRs so we can't call kfree() on them.
    
    These kind of bugs are "One Err Bugs" where there is just one error
    label that does everything.  I could set the "inherit = NULL" and keep
    the single out label but it ends up being more complicated that way.  It
    makes the code simpler to re-order the unwind so it's in the mirror
    order of the allocation and introduce some new error labels.
    Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: NChris Mason <clm@fb.com>
    c47ca32d
ioctl.c 128.1 KB