• X
    pci: lock the pci_cfg_wait queue for the consistency of data · c16fd413
    Xiang Zheng 提交于
    hulk inclusion
    category: bugfix
    bugzilla: 24273
    CVE: NA
    -----------------------
    
    Commit "7ea7e98f" suggests that the "pci_lock" is sufficient,
    and all the callers of pci_wait_cfg() are wrapped with the "pci_lock".
    
    However, since the commit "cdcb33f9" merged, the accesses to
    the pci_cfg_wait queue are not safe anymore. A "pci_lock" is
    insufficient and we need to hold an additional queue lock while
    read/write the wait queue.
    
    So let's use the add_wait_queue()/remove_wait_queue() instead of
    __add_wait_queue()/__remove_wait_queue(). Also move the wait queue
    functionality around the "schecdule()" function to avoid reintroduce
    the deadlock addressed by "cdcb33f9".
    Signed-off-by: NXiang Zheng <zhengxiang9@huawei.com>
    Cc: Heyi Guo <guoheyi@huawei.com>
    Cc: Biaoxiang Ye <yebiaoxiang@huawei.com>
    Reviewed-by: NHanjun Guo <guohanjun@huawei.com>
    Signed-off-by: NYang Yingliang <yangyingliang@huawei.com>
    c16fd413
access.c 15.1 KB