• S
    xhci: Fix full speed bInterval encoding. · b513d447
    Sarah Sharp 提交于
    Dmitry's patch
    
    dfa49c4a USB: xhci - fix math in xhci_get_endpoint_interval()
    
    introduced a bug.  The USB 2.0 spec says that full speed isochronous endpoints'
    bInterval must be decoded as an exponent to a power of two (e.g. interval =
    2^(bInterval - 1)).  Full speed interrupt endpoints, on the other hand, don't
    use exponents, and the interval in frames is encoded straight into bInterval.
    
    Dmitry's patch was supposed to fix up the full speed isochronous to parse
    bInterval as an exponent, but instead it changed the *interrupt* endpoint
    bInterval decoding.  The isochronous endpoint encoding was the same.
    
    This caused full speed devices with interrupt endpoints (including mice, hubs,
    and USB to ethernet devices) to fail under NEC 0.96 xHCI host controllers:
    
    [  100.909818] xhci_hcd 0000:06:00.0: add ep 0x83, slot id 1, new drop flags = 0x0, new add flags = 0x99, new slot info = 0x38100000
    [  100.909821] xhci_hcd 0000:06:00.0: xhci_check_bandwidth called for udev ffff88011f0ea000
    ...
    [  100.910187] xhci_hcd 0000:06:00.0: ERROR: unexpected command completion code 0x11.
    [  100.910190] xhci_hcd 0000:06:00.0: xhci_reset_bandwidth called for udev ffff88011f0ea000
    
    When the interrupt endpoint was added and a Configure Endpoint command was
    issued to the host, the host controller would return a very odd error message
    (0x11 means "Slot Not Enabled", which isn't true because the slot was enabled).
    Probably the host controller was getting very confused with the bad encoding.
    Signed-off-by: NSarah Sharp <sarah.a.sharp@linux.intel.com>
    Cc: Dmitry Torokhov <dtor@vmware.com>
    Reported-by: NThomas Lindroth <thomas.lindroth@gmail.com>
    Tested-by: NThomas Lindroth <thomas.lindroth@gmail.com>
    Cc: stable <stable@kernel.org>
    Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
    b513d447
xhci-mem.c 63.9 KB