• A
    gpiolib: always initialize *flags from of_get_named_gpio_flags · 427e0dc5
    Arnd Bergmann 提交于
    The of_get_named_gpio_flags() function does nothing other than returning
    an error when CONFIG_OF_GPIO is disabled, but that causes spurious
    warnings about possible use of uninitialized variables in any code that
    does not check the of_get_named_gpio_flags() return value before trying
    to use the flags:
    
    drivers/input/misc/rotary_encoder.c: In function 'rotary_encoder_probe':
    drivers/input/misc/rotary_encoder.c:223:28: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]
    drivers/power/bq24735-charger.c: In function 'bq24735_charger_probe':
    drivers/power/bq24735-charger.c:227:12: warning: 'flags' may be used uninitialized in this function [-Wmaybe-uninitialized]
    drivers/power/sbs-battery.c: In function 'sbs_probe':
    drivers/power/sbs-battery.c:782:17: warning: 'gpio_flags' may be used uninitialized in this function [-Wmaybe-uninitialized]
    
    This changes the behavior of the inline helper to set the flags to zero
    when OF_GPIO is disabled, to avoid the warnings. In all cases I've
    encountered, we don't actually get to the place that uses the flags
    if CONFIG_OF is disabled because we won't enter the DT parser code.
    Signed-off-by: NArnd Bergmann <arnd@arndb.de>
    Signed-off-by: NLinus Walleij <linus.walleij@linaro.org>
    427e0dc5
of_gpio.h 4.4 KB