• P
    eeepc-laptop: simplify parse_arg() · 95369a73
    Paul Bolle 提交于
    parse_arg() has three possible return values:
        -EINVAL if sscanf(), in short, fails;
        zero if "count" is zero; and
        "count" in all other cases
    
    But "count" will never be zero. See, parse_arg() is called by the
    various store functions. And the callchain of these functions starts
    with sysfs_kf_write(). And that function checks for a zero "count". So
    we can stop checking for a zero "count", drop the "count" argument
    entirely, and transform parse_arg() into a function that returns zero on
    success or a negative error. That, in turn, allows to make those store
    functions just return "count" on success. The net effect is that the
    code becomes a bit easier to understand.
    
    A nice side effect is that this GCC warning is silenced too:
        drivers/platform/x86/eeepc-laptop.c: In function ‘store_sys_acpi’:
        drivers/platform/x86/eeepc-laptop.c:279:10: warning: ‘value’ may be used uninitialized in this function [-Wmaybe-uninitialized]
          int rv, value;
    
    Which is, of course, the reason to have a look at parse_arg().
    Signed-off-by: NPaul Bolle <pebolle@tiscali.nl>
    Signed-off-by: NDarren Hart <dvhart@linux.intel.com>
    95369a73
eeepc-laptop.c 36.0 KB