• D
    dev-core: fix build break when DEBUG is enabled · 8ef2d651
    Dmitry Kasatkin 提交于
    When DEBUG is defined, dev_dbg_ratelimited uses dynamic debug data
    structures even when CONFIG_DYNAMIC_DEBUG is not defined.
    It leads to build break.
    For example, when I try to use dev_dbg_ratelimited in USB code and
    CONFIG_USB_DEBUG is enabled, but CONFIG_DYNAMIC_DEBUG is not, I get:
    
      CC [M]  drivers/usb/host/xhci-ring.o
      drivers/usb/host/xhci-ring.c: In function ‘xhci_queue_intr_tx’:
      drivers/usb/host/xhci-ring.c:3059:3: error: implicit declaration of function ‘DEFINE_DYNAMIC_DEBUG_METADATA’ [-Werror=implicit-function-declaration]
      drivers/usb/host/xhci-ring.c:3059:3: error: ‘descriptor’ undeclared (first use in this function)
      drivers/usb/host/xhci-ring.c:3059:3: note: each undeclared identifier is reported only once for each function it appears in
      drivers/usb/host/xhci-ring.c:3059:3: error: implicit declaration of function ‘__dynamic_pr_debug’ [-Werror=implicit-function-declaration]
      drivers/usb/host/xhci-ring.c: In function ‘xhci_queue_isoc_tx_prepare’:
      drivers/usb/host/xhci-ring.c:3847:3: error: ‘descriptor’ undeclared (first use in this function)
      cc1: some warnings being treated as errors
      make[2]: *** [drivers/usb/host/xhci-ring.o] Error 1
      make[1]: *** [drivers/usb/host] Error 2
      make: *** [drivers/usb/] Error 2
    
    This patch separates definition for CONFIG_DYNAMIC_DEBUG and DEBUG cases.
    
    [Note, Sarah moved the comment above the macro to avoid checkpatch
    warnings.]
    Signed-off-by: NDmitry Kasatkin <d.kasatkin@samsung.com>
    Signed-off-by: NSarah Sharp <sarah.a.sharp@linux.intel.com>
    Acked-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    8ef2d651
device.h 41.2 KB