• L
    p54: use request_firmware_direct() for optional EEPROM override · 80140b71
    Luis R. Rodriguez 提交于
    The p54 driver uses request_firmware() twice, once for actual
    firmware and then another time for an optional user overide on
    EEPROM, 3826.eeprom. The custom EEPROM  is optional but if not
    present we'll introduce an extra lag of 60 seconds with udev
    present. Annotate we don't want udev nonsense here to avoid
    the lag in case its not present.
    
    This was found with the following SmPL patch.
    
    @ firmware_not_critical @
    expression cf;
    expression config_file;
    expression dev;
    int ret;
    identifier l;
    statement S;
    @@
    
    -	ret = request_firmware(&cf, config_file, dev);
    +	ret = request_firmware_direct(&cf, config_file, dev);
    	if (ret < 0) {
    		... when != goto l;
    		    when != return ret;
    		    when any
    	} else {
    		...
    		release_firmware(cf);
    		...
    	}
    
    Cc: Takashi Iwai <tiwai@suse.de>
    Cc: Christian Lamparter <chunkeey@googlemail.com>
    Cc: linux-wireless@vger.kernel.org
    Cc: cocci@systeme.lip6.fr
    Signed-off-by: NLuis R. Rodriguez <mcgrof@suse.com>
    Acked-By: NChristian Lamparter <chunkeey@googlemail.com>
    Signed-off-by: NJohn W. Linville <linville@tuxdriver.com>
    80140b71
p54spi.c 16.7 KB