• A
    USB: usbfs: keep async URBs until the device file is closed · 6ff10464
    Alan Stern 提交于
    The usbfs driver manages a list of completed asynchronous URBs.  But
    it is too eager to free the entries on this list: destroy_async() gets
    called whenever an interface is unbound or a device is removed, and it
    deallocates the outstanding struct async entries for all URBs on that
    interface or device.  This is wrong; the user program should be able
    to reap an URB any time after it has completed, regardless of whether
    or not the interface is still bound or the device is still present.
    
    This patch (as1222) moves the code for deallocating the completed list
    entries from destroy_async() to usbdev_release().  The outstanding
    entries won't be freed until the user program has closed the device
    file, thereby eliminating any possibility that the remaining URBs
    might still be reaped.
    
    This fixes a bug in which a program can hang in the USBDEVFS_REAPURB
    ioctl when the device is unplugged.
    Reported-and-tested-by: NMartin Poupe <martin.poupe@upek.com>
    Signed-off-by: NAlan Stern <stern@rowland.harvard.edu>
    Cc: stable <stable@kernel.org>
    Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
    6ff10464
devio.c 44.5 KB