• D
    bonding: remove bond read lock for bond_3ad_state_machine_handler() · 5cc172c6
    dingtianhong 提交于
    The bond slave list may change when the monitor is running, the slave list is no longer
    protected by bond->lock, only protected by rtnl lock(), so we have 3 ways to modify it:
    1.add bond_master_upper_dev_link() and bond_upper_dev_unlink() in bond->lock, but it is unsafe
    to call call_netdevice_notifiers() in write lock.
    2.remove unused bond->lock for monitor function, only use the existing rtnl lock().
    3.use rcu_read_lock() to protect it, of course, it will transform bond_for_each_slave to
    bond_for_each_slave_rcu() and performance is better, but in slow path, it is ignored.
    so I remove the bond->lock and move the rtnl lock to protect the whole monitor function.
    Signed-off-by: NDing Tianhong <dingtianhong@huawei.com>
    Signed-off-by: NDavid S. Miller <davem@davemloft.net>
    5cc172c6
bond_3ad.c 79.6 KB