• S
    btrfs: label should not contain return char · 48fcc3ff
    Satoru Takeuchi 提交于
    Rediffed remaining parts of original patch from Anand Jain.  This makes
    sure to avoid trailing newlines in the btrfs label output
    
    reproducer.sh:
    
    ===============================================================================
    
    TEST_DEV=/dev/vdb
    TEST_DIR=/home/sat/mnt
    
    umount /home/sat/mnt
    
    mkfs.btrfs -f $TEST_DEV
    UUID=$(btrfs fi show $TEST_DEV | head -1 | sed -e 's/.*uuid: \([-0-9a-z]*\)$/\1/')
    mount $TEST_DEV $TEST_DIR
    LABELFILE=/sys/fs/btrfs/$UUID/label
    
    echo "Test for empty label..." >&2
    LINES="$(cat $LABELFILE | wc -l | awk '{print $1}')"
    RET=0
    
    if [ $LINES -eq 0 ] ; then
        echo '[PASS] Trailing \n is removed correctly.' >&2
    else
        echo '[FAIL] Trailing \n still exists.' >&2
        RET=1
    fi
    
    echo "Test for non-empty label..." >&2
    
    echo testlabel >$LABELFILE
    LINES="$(cat $LABELFILE | wc -l | awk '{print $1}')"
    
    if [ $LINES -eq 1 ] ; then
        echo '[PASS] Trailing \n is removed correctly.' >&2
    else
        echo '[FAIL] Trailing \n still exists.' >&2
        RET=1
    fi
    
    exit $RET
    ===============================================================================
    Signed-off-by: NSatoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
    Signed-off-by: NChris Mason <clm@fb.com>
    48fcc3ff
sysfs.c 19.6 KB