• A
    perf hists browser: Fix handling of TAB/UNTAB for multiple events · 18eaf0b8
    Arnaldo Carvalho de Melo 提交于
    When using multiple events the 'top' and 'report' tools will first
    present the user with a menu to choose the event to browse.
    
    After that the user can either press <- to go back to the menu and
    choose another event or instead press TAB to go the next event without
    having to go back to the menu or shift-TAB (UNTAB) to go the previous
    event, useful to quickly visually see if multiple events are correlated.
    
    The handling of each hists browser return was broken by the ed7e5662,
    that combined both switches, the first that was for choosing the event
    and the second that was for checking if switching to the next event
    without passing thru the events menu.
    
    Repeat with me: Don't be clever like that.
    
    Fix it by moving the switch to right after the call to the hists
    browser, making abundantly clear that the two switches are unrelated.
    
    This also fixes a compiler warning about the 'pos' variable being
    possibly used unitialized.
    Reported-by: NIngo Molnar <mingo@elte.hu>
    [ committer note: the line above is for the compiler warning ]
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Link: http://lkml.kernel.org/n/tip-ujxkbvj9vy8w6xe2op5m51tb@git.kernel.orgSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
    18eaf0b8
hists.c 29.5 KB