drm_crtc_helper.c 33.2 KB
Newer Older
D
Dave Airlie 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31
/*
 * Copyright (c) 2006-2008 Intel Corporation
 * Copyright (c) 2007 Dave Airlie <airlied@linux.ie>
 *
 * DRM core CRTC related functions
 *
 * Permission to use, copy, modify, distribute, and sell this software and its
 * documentation for any purpose is hereby granted without fee, provided that
 * the above copyright notice appear in all copies and that both that copyright
 * notice and this permission notice appear in supporting documentation, and
 * that the name of the copyright holders not be used in advertising or
 * publicity pertaining to distribution of the software without specific,
 * written prior permission.  The copyright holders make no representations
 * about the suitability of this software for any purpose.  It is provided "as
 * is" without express or implied warranty.
 *
 * THE COPYRIGHT HOLDERS DISCLAIM ALL WARRANTIES WITH REGARD TO THIS SOFTWARE,
 * INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS, IN NO
 * EVENT SHALL THE COPYRIGHT HOLDERS BE LIABLE FOR ANY SPECIAL, INDIRECT OR
 * CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE,
 * DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER
 * TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE
 * OF THIS SOFTWARE.
 *
 * Authors:
 *      Keith Packard
 *	Eric Anholt <eric@anholt.net>
 *      Dave Airlie <airlied@linux.ie>
 *      Jesse Barnes <jesse.barnes@intel.com>
 */

32
#include <linux/export.h>
33
#include <linux/moduleparam.h>
34

35 36 37 38 39 40
#include <drm/drmP.h>
#include <drm/drm_crtc.h>
#include <drm/drm_fourcc.h>
#include <drm/drm_crtc_helper.h>
#include <drm/drm_fb_helper.h>
#include <drm/drm_edid.h>
D
Dave Airlie 已提交
41

42 43 44 45
MODULE_AUTHOR("David Airlie, Jesse Barnes");
MODULE_DESCRIPTION("DRM KMS helper");
MODULE_LICENSE("GPL and additional rights");

46 47 48 49 50 51 52 53 54 55 56
/**
 * drm_helper_move_panel_connectors_to_head() - move panels to the front in the
 * 						connector list
 * @dev: drm device to operate on
 *
 * Some userspace presumes that the first connected connector is the main
 * display, where it's supposed to display e.g. the login screen. For
 * laptops, this should be the main panel. Use this function to sort all
 * (eDP/LVDS) panels to the front of the connector list, instead of
 * painstakingly trying to initialize them in the right order.
 */
57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74
void drm_helper_move_panel_connectors_to_head(struct drm_device *dev)
{
	struct drm_connector *connector, *tmp;
	struct list_head panel_list;

	INIT_LIST_HEAD(&panel_list);

	list_for_each_entry_safe(connector, tmp,
				 &dev->mode_config.connector_list, head) {
		if (connector->connector_type == DRM_MODE_CONNECTOR_LVDS ||
		    connector->connector_type == DRM_MODE_CONNECTOR_eDP)
			list_move_tail(&connector->head, &panel_list);
	}

	list_splice(&panel_list, &dev->mode_config.connector_list);
}
EXPORT_SYMBOL(drm_helper_move_panel_connectors_to_head);

75 76 77
static bool drm_kms_helper_poll = true;
module_param_named(poll, drm_kms_helper_poll, bool, 0600);

78 79 80
static void drm_mode_validate_flag(struct drm_connector *connector,
				   int flags)
{
81
	struct drm_display_mode *mode;
82

83 84
	if (flags == (DRM_MODE_FLAG_DBLSCAN | DRM_MODE_FLAG_INTERLACE |
		      DRM_MODE_FLAG_3D_MASK))
85 86
		return;

87
	list_for_each_entry(mode, &connector->modes, head) {
88 89 90 91 92 93
		if ((mode->flags & DRM_MODE_FLAG_INTERLACE) &&
				!(flags & DRM_MODE_FLAG_INTERLACE))
			mode->status = MODE_NO_INTERLACE;
		if ((mode->flags & DRM_MODE_FLAG_DBLSCAN) &&
				!(flags & DRM_MODE_FLAG_DBLSCAN))
			mode->status = MODE_NO_DBLESCAN;
94 95 96
		if ((mode->flags & DRM_MODE_FLAG_3D_MASK) &&
				!(flags & DRM_MODE_FLAG_3D_MASK))
			mode->status = MODE_NO_STEREO;
97 98 99 100 101
	}

	return;
}

D
Dave Airlie 已提交
102
/**
103
 * drm_helper_probe_single_connector_modes - get complete set of display modes
104
 * @connector: connector to probe
D
Dave Airlie 已提交
105 106 107 108 109 110
 * @maxX: max width for modes
 * @maxY: max height for modes
 *
 * LOCKING:
 * Caller must hold mode config lock.
 *
111 112 113 114
 * Based on the helper callbacks implemented by @connector try to detect all
 * valid modes.  Modes will first be added to the connector's probed_modes list,
 * then culled (based on validity and the @maxX, @maxY parameters) and put into
 * the normal modes list.
D
Dave Airlie 已提交
115
 *
116 117 118
 * Intended to be use as a generic implementation of the ->fill_modes()
 * @connector vfunc for drivers that use the crtc helpers for output mode
 * filtering and detection.
J
Jesse Barnes 已提交
119 120 121
 *
 * RETURNS:
 * Number of modes found on @connector.
D
Dave Airlie 已提交
122
 */
J
Jesse Barnes 已提交
123 124
int drm_helper_probe_single_connector_modes(struct drm_connector *connector,
					    uint32_t maxX, uint32_t maxY)
D
Dave Airlie 已提交
125 126
{
	struct drm_device *dev = connector->dev;
127
	struct drm_display_mode *mode;
D
Dave Airlie 已提交
128 129
	struct drm_connector_helper_funcs *connector_funcs =
		connector->helper_private;
J
Jesse Barnes 已提交
130
	int count = 0;
131
	int mode_flags = 0;
132
	bool verbose_prune = true;
D
Dave Airlie 已提交
133

134 135
	DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n", connector->base.id,
			drm_get_connector_name(connector));
D
Dave Airlie 已提交
136
	/* set all modes to the unverified state */
137
	list_for_each_entry(mode, &connector->modes, head)
D
Dave Airlie 已提交
138 139
		mode->status = MODE_UNVERIFIED;

140 141 142 143 144 145 146
	if (connector->force) {
		if (connector->force == DRM_FORCE_ON)
			connector->status = connector_status_connected;
		else
			connector->status = connector_status_disconnected;
		if (connector->funcs->force)
			connector->funcs->force(connector);
147
	} else {
148
		connector->status = connector->funcs->detect(connector, true);
149
	}
D
Dave Airlie 已提交
150

151 152 153 154 155 156
	/* Re-enable polling in case the global poll config changed. */
	if (drm_kms_helper_poll != dev->mode_config.poll_running)
		drm_kms_helper_poll_enable(dev);

	dev->mode_config.poll_running = drm_kms_helper_poll;

D
Dave Airlie 已提交
157
	if (connector->status == connector_status_disconnected) {
158 159
		DRM_DEBUG_KMS("[CONNECTOR:%d:%s] disconnected\n",
			connector->base.id, drm_get_connector_name(connector));
160
		drm_mode_connector_update_edid_property(connector, NULL);
161
		verbose_prune = false;
162
		goto prune;
D
Dave Airlie 已提交
163 164
	}

165 166 167 168 169 170
#ifdef CONFIG_DRM_LOAD_EDID_FIRMWARE
	count = drm_load_edid_firmware(connector);
	if (count == 0)
#endif
		count = (*connector_funcs->get_modes)(connector);

171
	if (count == 0 && connector->status == connector_status_connected)
172
		count = drm_add_modes_noedid(connector, 1024, 768);
173 174
	if (count == 0)
		goto prune;
D
Dave Airlie 已提交
175

J
Jesse Barnes 已提交
176
	drm_mode_connector_list_update(connector);
D
Dave Airlie 已提交
177 178 179 180

	if (maxX && maxY)
		drm_mode_validate_size(dev, &connector->modes, maxX,
				       maxY, 0);
181 182 183 184 185

	if (connector->interlace_allowed)
		mode_flags |= DRM_MODE_FLAG_INTERLACE;
	if (connector->doublescan_allowed)
		mode_flags |= DRM_MODE_FLAG_DBLSCAN;
186 187
	if (connector->stereo_allowed)
		mode_flags |= DRM_MODE_FLAG_3D_MASK;
188 189
	drm_mode_validate_flag(connector, mode_flags);

190
	list_for_each_entry(mode, &connector->modes, head) {
D
Dave Airlie 已提交
191 192 193 194 195
		if (mode->status == MODE_OK)
			mode->status = connector_funcs->mode_valid(connector,
								   mode);
	}

196
prune:
197
	drm_mode_prune_invalid(dev, &connector->modes, verbose_prune);
D
Dave Airlie 已提交
198

J
Jesse Barnes 已提交
199 200
	if (list_empty(&connector->modes))
		return 0;
D
Dave Airlie 已提交
201

202 203 204
	list_for_each_entry(mode, &connector->modes, head)
		mode->vrefresh = drm_mode_vrefresh(mode);

D
Dave Airlie 已提交
205 206
	drm_mode_sort(&connector->modes);

207 208
	DRM_DEBUG_KMS("[CONNECTOR:%d:%s] probed modes :\n", connector->base.id,
			drm_get_connector_name(connector));
209
	list_for_each_entry(mode, &connector->modes, head) {
D
Dave Airlie 已提交
210 211 212
		drm_mode_set_crtcinfo(mode, CRTC_INTERLACE_HALVE_V);
		drm_mode_debug_printmodeline(mode);
	}
J
Jesse Barnes 已提交
213 214

	return count;
D
Dave Airlie 已提交
215 216 217
}
EXPORT_SYMBOL(drm_helper_probe_single_connector_modes);

218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240
/**
 * drm_helper_encoder_in_use - check if a given encoder is in use
 * @encoder: encoder to check
 *
 * LOCKING:
 * Caller must hold mode config lock.
 *
 * Walk @encoders's DRM device's mode_config and see if it's in use.
 *
 * RETURNS:
 * True if @encoder is part of the mode_config, false otherwise.
 */
bool drm_helper_encoder_in_use(struct drm_encoder *encoder)
{
	struct drm_connector *connector;
	struct drm_device *dev = encoder->dev;
	list_for_each_entry(connector, &dev->mode_config.connector_list, head)
		if (connector->encoder == encoder)
			return true;
	return false;
}
EXPORT_SYMBOL(drm_helper_encoder_in_use);

D
Dave Airlie 已提交
241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258
/**
 * drm_helper_crtc_in_use - check if a given CRTC is in a mode_config
 * @crtc: CRTC to check
 *
 * LOCKING:
 * Caller must hold mode config lock.
 *
 * Walk @crtc's DRM device's mode_config and see if it's in use.
 *
 * RETURNS:
 * True if @crtc is part of the mode_config, false otherwise.
 */
bool drm_helper_crtc_in_use(struct drm_crtc *crtc)
{
	struct drm_encoder *encoder;
	struct drm_device *dev = crtc->dev;
	/* FIXME: Locking around list access? */
	list_for_each_entry(encoder, &dev->mode_config.encoder_list, head)
259
		if (encoder->crtc == crtc && drm_helper_encoder_in_use(encoder))
D
Dave Airlie 已提交
260 261 262 263 264
			return true;
	return false;
}
EXPORT_SYMBOL(drm_helper_crtc_in_use);

265 266 267 268 269
static void
drm_encoder_disable(struct drm_encoder *encoder)
{
	struct drm_encoder_helper_funcs *encoder_funcs = encoder->helper_private;

S
Sean Paul 已提交
270 271 272
	if (encoder->bridge)
		encoder->bridge->funcs->disable(encoder->bridge);

273 274 275 276
	if (encoder_funcs->disable)
		(*encoder_funcs->disable)(encoder);
	else
		(*encoder_funcs->dpms)(encoder, DRM_MODE_DPMS_OFF);
S
Sean Paul 已提交
277 278 279

	if (encoder->bridge)
		encoder->bridge->funcs->post_disable(encoder->bridge);
280 281
}

D
Dave Airlie 已提交
282
/**
283
 * drm_helper_disable_unused_functions - disable unused objects
D
Dave Airlie 已提交
284 285 286 287 288 289 290 291 292 293 294
 * @dev: DRM device
 *
 * LOCKING:
 * Caller must hold mode config lock.
 *
 * If an connector or CRTC isn't part of @dev's mode_config, it can be disabled
 * by calling its dpms function, which should power it off.
 */
void drm_helper_disable_unused_functions(struct drm_device *dev)
{
	struct drm_encoder *encoder;
295
	struct drm_connector *connector;
D
Dave Airlie 已提交
296 297
	struct drm_crtc *crtc;

298 299 300 301 302 303 304
	list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
		if (!connector->encoder)
			continue;
		if (connector->status == connector_status_disconnected)
			connector->encoder = NULL;
	}

D
Dave Airlie 已提交
305
	list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {
306
		if (!drm_helper_encoder_in_use(encoder)) {
307
			drm_encoder_disable(encoder);
308 309
			/* disconnector encoder from any connector */
			encoder->crtc = NULL;
310
		}
D
Dave Airlie 已提交
311 312 313 314 315 316
	}

	list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) {
		struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private;
		crtc->enabled = drm_helper_crtc_in_use(crtc);
		if (!crtc->enabled) {
317 318 319 320
			if (crtc_funcs->disable)
				(*crtc_funcs->disable)(crtc);
			else
				(*crtc_funcs->dpms)(crtc, DRM_MODE_DPMS_OFF);
D
Dave Airlie 已提交
321 322 323 324 325 326
			crtc->fb = NULL;
		}
	}
}
EXPORT_SYMBOL(drm_helper_disable_unused_functions);

327 328 329 330 331 332 333 334 335 336 337 338 339 340
/**
 * drm_encoder_crtc_ok - can a given crtc drive a given encoder?
 * @encoder: encoder to test
 * @crtc: crtc to test
 *
 * Return false if @encoder can't be driven by @crtc, true otherwise.
 */
static bool drm_encoder_crtc_ok(struct drm_encoder *encoder,
				struct drm_crtc *crtc)
{
	struct drm_device *dev;
	struct drm_crtc *tmp;
	int crtc_mask = 1;

J
Joe Perches 已提交
341
	WARN(!crtc, "checking null crtc?\n");
342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370

	dev = crtc->dev;

	list_for_each_entry(tmp, &dev->mode_config.crtc_list, head) {
		if (tmp == crtc)
			break;
		crtc_mask <<= 1;
	}

	if (encoder->possible_crtcs & crtc_mask)
		return true;
	return false;
}

/*
 * Check the CRTC we're going to map each output to vs. its current
 * CRTC.  If they don't match, we have to disable the output and the CRTC
 * since the driver will have to re-route things.
 */
static void
drm_crtc_prepare_encoders(struct drm_device *dev)
{
	struct drm_encoder_helper_funcs *encoder_funcs;
	struct drm_encoder *encoder;

	list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {
		encoder_funcs = encoder->helper_private;
		/* Disable unused encoders */
		if (encoder->crtc == NULL)
371
			drm_encoder_disable(encoder);
372 373 374
		/* Disable encoders whose CRTC is about to change */
		if (encoder_funcs->get_crtc &&
		    encoder->crtc != (*encoder_funcs->get_crtc)(encoder))
375
			drm_encoder_disable(encoder);
376 377 378
	}
}

D
Dave Airlie 已提交
379
/**
380
 * drm_crtc_helper_set_mode - internal helper to set a mode
D
Dave Airlie 已提交
381 382
 * @crtc: CRTC to program
 * @mode: mode to use
383 384
 * @x: horizontal offset into the surface
 * @y: vertical offset into the surface
385
 * @old_fb: old framebuffer, for cleanup
D
Dave Airlie 已提交
386 387 388 389 390
 *
 * LOCKING:
 * Caller must hold mode config lock.
 *
 * Try to set @mode on @crtc.  Give @crtc and its associated connectors a chance
391 392 393 394 395 396 397
 * to fixup or reject the mode prior to trying to set it. This is an internal
 * helper that drivers could e.g. use to update properties that require the
 * entire output pipe to be disabled and re-enabled in a new configuration. For
 * example for changing whether audio is enabled on a hdmi link or for changing
 * panel fitter or dither attributes. It is also called by the
 * drm_crtc_helper_set_config() helper function to drive the mode setting
 * sequence.
D
Dave Airlie 已提交
398 399 400 401 402 403
 *
 * RETURNS:
 * True if the mode was set successfully, or false otherwise.
 */
bool drm_crtc_helper_set_mode(struct drm_crtc *crtc,
			      struct drm_display_mode *mode,
404 405
			      int x, int y,
			      struct drm_framebuffer *old_fb)
D
Dave Airlie 已提交
406 407
{
	struct drm_device *dev = crtc->dev;
408
	struct drm_display_mode *adjusted_mode, saved_mode, saved_hwmode;
D
Dave Airlie 已提交
409 410 411 412 413 414 415 416 417 418
	struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private;
	struct drm_encoder_helper_funcs *encoder_funcs;
	int saved_x, saved_y;
	struct drm_encoder *encoder;
	bool ret = true;

	crtc->enabled = drm_helper_crtc_in_use(crtc);
	if (!crtc->enabled)
		return true;

419
	adjusted_mode = drm_mode_duplicate(dev, mode);
420 421
	if (!adjusted_mode)
		return false;
422

423
	saved_hwmode = crtc->hwmode;
D
Dave Airlie 已提交
424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442
	saved_mode = crtc->mode;
	saved_x = crtc->x;
	saved_y = crtc->y;

	/* Update crtc values up front so the driver can rely on them for mode
	 * setting.
	 */
	crtc->mode = *mode;
	crtc->x = x;
	crtc->y = y;

	/* Pass our mode to the connectors and the CRTC to give them a chance to
	 * adjust it according to limitations or connector properties, and also
	 * a chance to reject the mode entirely.
	 */
	list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {

		if (encoder->crtc != crtc)
			continue;
S
Sean Paul 已提交
443 444 445 446 447 448 449 450 451 452

		if (encoder->bridge && encoder->bridge->funcs->mode_fixup) {
			ret = encoder->bridge->funcs->mode_fixup(
					encoder->bridge, mode, adjusted_mode);
			if (!ret) {
				DRM_DEBUG_KMS("Bridge fixup failed\n");
				goto done;
			}
		}

D
Dave Airlie 已提交
453 454 455
		encoder_funcs = encoder->helper_private;
		if (!(ret = encoder_funcs->mode_fixup(encoder, mode,
						      adjusted_mode))) {
456
			DRM_DEBUG_KMS("Encoder fixup failed\n");
D
Dave Airlie 已提交
457 458 459 460 461
			goto done;
		}
	}

	if (!(ret = crtc_funcs->mode_fixup(crtc, mode, adjusted_mode))) {
462
		DRM_DEBUG_KMS("CRTC fixup failed\n");
D
Dave Airlie 已提交
463 464
		goto done;
	}
465
	DRM_DEBUG_KMS("[CRTC:%d]\n", crtc->base.id);
D
Dave Airlie 已提交
466 467 468 469 470 471

	/* Prepare the encoders and CRTCs before setting the mode. */
	list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {

		if (encoder->crtc != crtc)
			continue;
S
Sean Paul 已提交
472 473 474 475

		if (encoder->bridge)
			encoder->bridge->funcs->disable(encoder->bridge);

D
Dave Airlie 已提交
476 477 478
		encoder_funcs = encoder->helper_private;
		/* Disable the encoders as the first thing we do. */
		encoder_funcs->prepare(encoder);
S
Sean Paul 已提交
479 480 481

		if (encoder->bridge)
			encoder->bridge->funcs->post_disable(encoder->bridge);
D
Dave Airlie 已提交
482 483
	}

484 485
	drm_crtc_prepare_encoders(dev);

D
Dave Airlie 已提交
486 487 488 489 490
	crtc_funcs->prepare(crtc);

	/* Set up the DPLL and any encoders state that needs to adjust or depend
	 * on the DPLL.
	 */
491 492 493
	ret = !crtc_funcs->mode_set(crtc, mode, adjusted_mode, x, y, old_fb);
	if (!ret)
	    goto done;
D
Dave Airlie 已提交
494 495 496 497 498 499

	list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {

		if (encoder->crtc != crtc)
			continue;

500 501 502
		DRM_DEBUG_KMS("[ENCODER:%d:%s] set [MODE:%d:%s]\n",
			encoder->base.id, drm_get_encoder_name(encoder),
			mode->base.id, mode->name);
D
Dave Airlie 已提交
503 504
		encoder_funcs = encoder->helper_private;
		encoder_funcs->mode_set(encoder, mode, adjusted_mode);
S
Sean Paul 已提交
505 506 507 508

		if (encoder->bridge && encoder->bridge->funcs->mode_set)
			encoder->bridge->funcs->mode_set(encoder->bridge, mode,
					adjusted_mode);
D
Dave Airlie 已提交
509 510 511 512 513 514 515 516 517 518
	}

	/* Now enable the clocks, plane, pipe, and connectors that we set up. */
	crtc_funcs->commit(crtc);

	list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {

		if (encoder->crtc != crtc)
			continue;

S
Sean Paul 已提交
519 520 521
		if (encoder->bridge)
			encoder->bridge->funcs->pre_enable(encoder->bridge);

D
Dave Airlie 已提交
522 523 524
		encoder_funcs = encoder->helper_private;
		encoder_funcs->commit(encoder);

S
Sean Paul 已提交
525 526
		if (encoder->bridge)
			encoder->bridge->funcs->enable(encoder->bridge);
D
Dave Airlie 已提交
527 528
	}

529 530 531 532 533 534 535 536 537
	/* Store real post-adjustment hardware mode. */
	crtc->hwmode = *adjusted_mode;

	/* Calculate and store various constants which
	 * are later needed by vblank and swap-completion
	 * timestamping. They are derived from true hwmode.
	 */
	drm_calc_timestamping_constants(crtc);

D
Dave Airlie 已提交
538 539
	/* FIXME: add subpixel order */
done:
540
	drm_mode_destroy(dev, adjusted_mode);
D
Dave Airlie 已提交
541
	if (!ret) {
542
		crtc->hwmode = saved_hwmode;
D
Dave Airlie 已提交
543 544 545 546 547 548 549 550 551 552
		crtc->mode = saved_mode;
		crtc->x = saved_x;
		crtc->y = saved_y;
	}

	return ret;
}
EXPORT_SYMBOL(drm_crtc_helper_set_mode);


553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569
static int
drm_crtc_helper_disable(struct drm_crtc *crtc)
{
	struct drm_device *dev = crtc->dev;
	struct drm_connector *connector;
	struct drm_encoder *encoder;

	/* Decouple all encoders and their attached connectors from this crtc */
	list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {
		if (encoder->crtc != crtc)
			continue;

		list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
			if (connector->encoder != encoder)
				continue;

			connector->encoder = NULL;
570 571 572 573 574 575 576 577

			/*
			 * drm_helper_disable_unused_functions() ought to be
			 * doing this, but since we've decoupled the encoder
			 * from the connector above, the required connection
			 * between them is henceforth no longer available.
			 */
			connector->dpms = DRM_MODE_DPMS_OFF;
578 579 580 581 582 583 584
		}
	}

	drm_helper_disable_unused_functions(dev);
	return 0;
}

D
Dave Airlie 已提交
585 586
/**
 * drm_crtc_helper_set_config - set a new config from userspace
587
 * @set: mode set configuration
D
Dave Airlie 已提交
588 589 590 591
 *
 * LOCKING:
 * Caller must hold mode config lock.
 *
592 593 594 595 596
 * Setup a new configuration, provided by the upper layers (either an ioctl call
 * from userspace or internally e.g. from the fbdev suppport code) in @set, and
 * enable it. This is the main helper functions for drivers that implement
 * kernel mode setting with the crtc helper functions and the assorted
 * ->prepare(), ->modeset() and ->commit() helper callbacks.
D
Dave Airlie 已提交
597 598
 *
 * RETURNS:
599
 * Returns 0 on success, -ERRNO on failure.
D
Dave Airlie 已提交
600 601 602 603
 */
int drm_crtc_helper_set_config(struct drm_mode_set *set)
{
	struct drm_device *dev;
604 605
	struct drm_crtc *save_crtcs, *new_crtc, *crtc;
	struct drm_encoder *save_encoders, *new_encoder, *encoder;
606 607
	bool mode_changed = false; /* if true do a full mode set */
	bool fb_changed = false; /* if true and !mode_changed just do a flip */
608
	struct drm_connector *save_connectors, *connector;
D
Dave Airlie 已提交
609 610
	int count = 0, ro, fail = 0;
	struct drm_crtc_helper_funcs *crtc_funcs;
611
	struct drm_mode_set save_set;
612
	int ret;
613
	int i;
D
Dave Airlie 已提交
614

615
	DRM_DEBUG_KMS("\n");
D
Dave Airlie 已提交
616

617 618 619
	BUG_ON(!set);
	BUG_ON(!set->crtc);
	BUG_ON(!set->crtc->helper_private);
D
Dave Airlie 已提交
620

621 622 623
	/* Enforce sane interface api - has been abused by the fb helper. */
	BUG_ON(!set->mode && set->fb);
	BUG_ON(set->fb && set->num_connectors == 0);
D
Dave Airlie 已提交
624 625 626

	crtc_funcs = set->crtc->helper_private;

627 628 629
	if (!set->mode)
		set->fb = NULL;

630 631 632 633 634
	if (set->fb) {
		DRM_DEBUG_KMS("[CRTC:%d] [FB:%d] #connectors=%d (x y) (%i %i)\n",
				set->crtc->base.id, set->fb->base.id,
				(int)set->num_connectors, set->x, set->y);
	} else {
635
		DRM_DEBUG_KMS("[CRTC:%d] [NOFB]\n", set->crtc->base.id);
636
		return drm_crtc_helper_disable(set->crtc);
637
	}
D
Dave Airlie 已提交
638 639 640

	dev = set->crtc->dev;

641 642 643 644
	/* Allocate space for the backup of all (non-pointer) crtc, encoder and
	 * connector data. */
	save_crtcs = kzalloc(dev->mode_config.num_crtc *
			     sizeof(struct drm_crtc), GFP_KERNEL);
D
Dave Airlie 已提交
645 646 647
	if (!save_crtcs)
		return -ENOMEM;

648 649
	save_encoders = kzalloc(dev->mode_config.num_encoder *
				sizeof(struct drm_encoder), GFP_KERNEL);
D
Dave Airlie 已提交
650 651 652 653 654
	if (!save_encoders) {
		kfree(save_crtcs);
		return -ENOMEM;
	}

655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681
	save_connectors = kzalloc(dev->mode_config.num_connector *
				sizeof(struct drm_connector), GFP_KERNEL);
	if (!save_connectors) {
		kfree(save_crtcs);
		kfree(save_encoders);
		return -ENOMEM;
	}

	/* Copy data. Note that driver private data is not affected.
	 * Should anything bad happen only the expected state is
	 * restored, not the drivers personal bookkeeping.
	 */
	count = 0;
	list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) {
		save_crtcs[count++] = *crtc;
	}

	count = 0;
	list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {
		save_encoders[count++] = *encoder;
	}

	count = 0;
	list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
		save_connectors[count++] = *connector;
	}

682 683 684 685 686 687
	save_set.crtc = set->crtc;
	save_set.mode = &set->crtc->mode;
	save_set.x = set->crtc->x;
	save_set.y = set->crtc->y;
	save_set.fb = set->crtc->fb;

D
Dave Airlie 已提交
688 689 690
	/* We should be able to check here if the fb has the same properties
	 * and then just flip_or_move it */
	if (set->crtc->fb != set->fb) {
691
		/* If we have no fb then treat it as a full mode set */
692
		if (set->crtc->fb == NULL) {
693
			DRM_DEBUG_KMS("crtc has no fb, full mode set\n");
694
			mode_changed = true;
695 696
		} else if (set->fb == NULL) {
			mode_changed = true;
697 698 699
		} else if (set->fb->pixel_format !=
			   set->crtc->fb->pixel_format) {
			mode_changed = true;
700
		} else
701
			fb_changed = true;
D
Dave Airlie 已提交
702 703 704
	}

	if (set->x != set->crtc->x || set->y != set->crtc->y)
705
		fb_changed = true;
D
Dave Airlie 已提交
706 707

	if (set->mode && !drm_mode_equal(set->mode, &set->crtc->mode)) {
708
		DRM_DEBUG_KMS("modes are different, full mode set\n");
D
Dave Airlie 已提交
709 710
		drm_mode_debug_printmodeline(&set->crtc->mode);
		drm_mode_debug_printmodeline(set->mode);
711
		mode_changed = true;
D
Dave Airlie 已提交
712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728
	}

	/* a) traverse passed in connector list and get encoders for them */
	count = 0;
	list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
		struct drm_connector_helper_funcs *connector_funcs =
			connector->helper_private;
		new_encoder = connector->encoder;
		for (ro = 0; ro < set->num_connectors; ro++) {
			if (set->connectors[ro] == connector) {
				new_encoder = connector_funcs->best_encoder(connector);
				/* if we can't get an encoder for a connector
				   we are setting now - then fail */
				if (new_encoder == NULL)
					/* don't break so fail path works correct */
					fail = 1;
				break;
729 730 731 732 733

				if (connector->dpms != DRM_MODE_DPMS_ON) {
					DRM_DEBUG_KMS("connector dpms not on, full mode switch\n");
					mode_changed = true;
				}
D
Dave Airlie 已提交
734 735 736 737
			}
		}

		if (new_encoder != connector->encoder) {
738
			DRM_DEBUG_KMS("encoder changed, full mode switch\n");
739
			mode_changed = true;
740 741 742
			/* If the encoder is reused for another connector, then
			 * the appropriate crtc will be set later.
			 */
743 744
			if (connector->encoder)
				connector->encoder->crtc = NULL;
D
Dave Airlie 已提交
745 746 747 748 749 750
			connector->encoder = new_encoder;
		}
	}

	if (fail) {
		ret = -EINVAL;
751
		goto fail;
D
Dave Airlie 已提交
752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767
	}

	count = 0;
	list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
		if (!connector->encoder)
			continue;

		if (connector->encoder->crtc == set->crtc)
			new_crtc = NULL;
		else
			new_crtc = connector->encoder->crtc;

		for (ro = 0; ro < set->num_connectors; ro++) {
			if (set->connectors[ro] == connector)
				new_crtc = set->crtc;
		}
768 769 770 771 772

		/* Make sure the new CRTC will work with the encoder */
		if (new_crtc &&
		    !drm_encoder_crtc_ok(connector->encoder, new_crtc)) {
			ret = -EINVAL;
773
			goto fail;
774
		}
D
Dave Airlie 已提交
775
		if (new_crtc != connector->encoder->crtc) {
776
			DRM_DEBUG_KMS("crtc changed, full mode switch\n");
777
			mode_changed = true;
D
Dave Airlie 已提交
778 779
			connector->encoder->crtc = new_crtc;
		}
780 781 782 783 784 785 786 787
		if (new_crtc) {
			DRM_DEBUG_KMS("[CONNECTOR:%d:%s] to [CRTC:%d]\n",
				connector->base.id, drm_get_connector_name(connector),
				new_crtc->base.id);
		} else {
			DRM_DEBUG_KMS("[CONNECTOR:%d:%s] to [NOCRTC]\n",
				connector->base.id, drm_get_connector_name(connector));
		}
D
Dave Airlie 已提交
788 789 790
	}

	/* mode_set_base is not a required function */
791 792
	if (fb_changed && !crtc_funcs->mode_set_base)
		mode_changed = true;
D
Dave Airlie 已提交
793

794
	if (mode_changed) {
795 796
		set->crtc->enabled = drm_helper_crtc_in_use(set->crtc);
		if (set->crtc->enabled) {
797 798
			DRM_DEBUG_KMS("attempting to set mode from"
					" userspace\n");
D
Dave Airlie 已提交
799
			drm_mode_debug_printmodeline(set->mode);
800
			set->crtc->fb = set->fb;
D
Dave Airlie 已提交
801
			if (!drm_crtc_helper_set_mode(set->crtc, set->mode,
802
						      set->x, set->y,
803
						      save_set.fb)) {
804 805
				DRM_ERROR("failed to set mode on [CRTC:%d]\n",
					  set->crtc->base.id);
806
				set->crtc->fb = save_set.fb;
D
Dave Airlie 已提交
807
				ret = -EINVAL;
808
				goto fail;
D
Dave Airlie 已提交
809
			}
810 811 812 813 814 815
			DRM_DEBUG_KMS("Setting connector DPMS state to on\n");
			for (i = 0; i < set->num_connectors; i++) {
				DRM_DEBUG_KMS("\t[CONNECTOR:%d:%s] set DPMS on\n", set->connectors[i]->base.id,
					      drm_get_connector_name(set->connectors[i]));
				set->connectors[i]->funcs->dpms(set->connectors[i], DRM_MODE_DPMS_ON);
			}
D
Dave Airlie 已提交
816 817
		}
		drm_helper_disable_unused_functions(dev);
818
	} else if (fb_changed) {
819 820
		set->crtc->x = set->x;
		set->crtc->y = set->y;
I
Ilija Hadzic 已提交
821
		set->crtc->fb = set->fb;
822
		ret = crtc_funcs->mode_set_base(set->crtc,
823
						set->x, set->y, save_set.fb);
824
		if (ret != 0) {
825 826
			set->crtc->x = save_set.x;
			set->crtc->y = save_set.y;
827
			set->crtc->fb = save_set.fb;
828
			goto fail;
829
		}
D
Dave Airlie 已提交
830 831
	}

832
	kfree(save_connectors);
D
Dave Airlie 已提交
833 834 835 836
	kfree(save_encoders);
	kfree(save_crtcs);
	return 0;

837 838
fail:
	/* Restore all previous data. */
D
Dave Airlie 已提交
839
	count = 0;
840 841 842
	list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) {
		*crtc = save_crtcs[count++];
	}
843

844 845 846
	count = 0;
	list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {
		*encoder = save_encoders[count++];
847
	}
848

D
Dave Airlie 已提交
849 850
	count = 0;
	list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
851
		*connector = save_connectors[count++];
D
Dave Airlie 已提交
852
	}
853

854 855 856 857 858 859
	/* Try to restore the config */
	if (mode_changed &&
	    !drm_crtc_helper_set_mode(save_set.crtc, save_set.mode, save_set.x,
				      save_set.y, save_set.fb))
		DRM_ERROR("failed to restore config after modeset failure\n");

860
	kfree(save_connectors);
D
Dave Airlie 已提交
861
	kfree(save_encoders);
862
	kfree(save_crtcs);
D
Dave Airlie 已提交
863 864 865 866
	return ret;
}
EXPORT_SYMBOL(drm_crtc_helper_set_config);

867 868 869 870 871 872 873 874 875 876 877 878 879
static int drm_helper_choose_encoder_dpms(struct drm_encoder *encoder)
{
	int dpms = DRM_MODE_DPMS_OFF;
	struct drm_connector *connector;
	struct drm_device *dev = encoder->dev;

	list_for_each_entry(connector, &dev->mode_config.connector_list, head)
		if (connector->encoder == encoder)
			if (connector->dpms < dpms)
				dpms = connector->dpms;
	return dpms;
}

S
Sean Paul 已提交
880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904
/* Helper which handles bridge ordering around encoder dpms */
static void drm_helper_encoder_dpms(struct drm_encoder *encoder, int mode)
{
	struct drm_bridge *bridge = encoder->bridge;
	struct drm_encoder_helper_funcs *encoder_funcs;

	if (bridge) {
		if (mode == DRM_MODE_DPMS_ON)
			bridge->funcs->pre_enable(bridge);
		else
			bridge->funcs->disable(bridge);
	}

	encoder_funcs = encoder->helper_private;
	if (encoder_funcs->dpms)
		encoder_funcs->dpms(encoder, mode);

	if (bridge) {
		if (mode == DRM_MODE_DPMS_ON)
			bridge->funcs->enable(bridge);
		else
			bridge->funcs->post_disable(bridge);
	}
}

905 906 907 908 909 910 911 912 913 914 915 916 917 918
static int drm_helper_choose_crtc_dpms(struct drm_crtc *crtc)
{
	int dpms = DRM_MODE_DPMS_OFF;
	struct drm_connector *connector;
	struct drm_device *dev = crtc->dev;

	list_for_each_entry(connector, &dev->mode_config.connector_list, head)
		if (connector->encoder && connector->encoder->crtc == crtc)
			if (connector->dpms < dpms)
				dpms = connector->dpms;
	return dpms;
}

/**
919 920 921
 * drm_helper_connector_dpms() - connector dpms helper implementation
 * @connector: affected connector
 * @mode: DPMS mode
922
 *
923 924 925 926
 * This is the main helper function provided by the crtc helper framework for
 * implementing the DPMS connector attribute. It computes the new desired DPMS
 * state for all encoders and crtcs in the output mesh and calls the ->dpms()
 * callback provided by the driver appropriately.
927 928 929 930 931
 */
void drm_helper_connector_dpms(struct drm_connector *connector, int mode)
{
	struct drm_encoder *encoder = connector->encoder;
	struct drm_crtc *crtc = encoder ? encoder->crtc : NULL;
S
Sean Paul 已提交
932
	int old_dpms, encoder_dpms = DRM_MODE_DPMS_OFF;
933 934 935 936 937 938 939

	if (mode == connector->dpms)
		return;

	old_dpms = connector->dpms;
	connector->dpms = mode;

S
Sean Paul 已提交
940 941 942
	if (encoder)
		encoder_dpms = drm_helper_choose_encoder_dpms(encoder);

943 944 945 946 947 948 949 950
	/* from off to on, do crtc then encoder */
	if (mode < old_dpms) {
		if (crtc) {
			struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private;
			if (crtc_funcs->dpms)
				(*crtc_funcs->dpms) (crtc,
						     drm_helper_choose_crtc_dpms(crtc));
		}
S
Sean Paul 已提交
951 952
		if (encoder)
			drm_helper_encoder_dpms(encoder, encoder_dpms);
953 954 955 956
	}

	/* from on to off, do encoder then crtc */
	if (mode > old_dpms) {
S
Sean Paul 已提交
957 958
		if (encoder)
			drm_helper_encoder_dpms(encoder, encoder_dpms);
959 960 961 962 963 964 965 966 967 968 969 970
		if (crtc) {
			struct drm_crtc_helper_funcs *crtc_funcs = crtc->helper_private;
			if (crtc_funcs->dpms)
				(*crtc_funcs->dpms) (crtc,
						     drm_helper_choose_crtc_dpms(crtc));
		}
	}

	return;
}
EXPORT_SYMBOL(drm_helper_connector_dpms);

D
Dave Airlie 已提交
971
int drm_helper_mode_fill_fb_struct(struct drm_framebuffer *fb,
972
				   struct drm_mode_fb_cmd2 *mode_cmd)
D
Dave Airlie 已提交
973
{
974 975
	int i;

D
Dave Airlie 已提交
976 977
	fb->width = mode_cmd->width;
	fb->height = mode_cmd->height;
978 979 980 981
	for (i = 0; i < 4; i++) {
		fb->pitches[i] = mode_cmd->pitches[i];
		fb->offsets[i] = mode_cmd->offsets[i];
	}
982
	drm_fb_get_bpp_depth(mode_cmd->pixel_format, &fb->depth,
983 984
				    &fb->bits_per_pixel);
	fb->pixel_format = mode_cmd->pixel_format;
D
Dave Airlie 已提交
985 986 987 988 989 990 991 992

	return 0;
}
EXPORT_SYMBOL(drm_helper_mode_fill_fb_struct);

int drm_helper_resume_force_mode(struct drm_device *dev)
{
	struct drm_crtc *crtc;
993 994
	struct drm_encoder *encoder;
	struct drm_crtc_helper_funcs *crtc_funcs;
S
Sean Paul 已提交
995
	int ret, encoder_dpms;
D
Dave Airlie 已提交
996 997 998 999 1000 1001

	list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) {

		if (!crtc->enabled)
			continue;

1002 1003
		ret = drm_crtc_helper_set_mode(crtc, &crtc->mode,
					       crtc->x, crtc->y, crtc->fb);
D
Dave Airlie 已提交
1004 1005 1006

		if (ret == false)
			DRM_ERROR("failed to set mode on crtc %p\n", crtc);
1007 1008 1009 1010 1011 1012 1013 1014

		/* Turn off outputs that were already powered off */
		if (drm_helper_choose_crtc_dpms(crtc)) {
			list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {

				if(encoder->crtc != crtc)
					continue;

S
Sean Paul 已提交
1015 1016 1017 1018
				encoder_dpms = drm_helper_choose_encoder_dpms(
							encoder);

				drm_helper_encoder_dpms(encoder, encoder_dpms);
1019
			}
1020 1021 1022 1023 1024

			crtc_funcs = crtc->helper_private;
			if (crtc_funcs->dpms)
				(*crtc_funcs->dpms) (crtc,
						     drm_helper_choose_crtc_dpms(crtc));
1025
		}
D
Dave Airlie 已提交
1026
	}
1027 1028
	/* disable the unused connectors while restoring the modesetting */
	drm_helper_disable_unused_functions(dev);
D
Dave Airlie 已提交
1029 1030 1031
	return 0;
}
EXPORT_SYMBOL(drm_helper_resume_force_mode);
1032

1033 1034 1035 1036 1037 1038 1039 1040 1041
void drm_kms_helper_hotplug_event(struct drm_device *dev)
{
	/* send a uevent + call fbdev */
	drm_sysfs_hotplug_event(dev);
	if (dev->mode_config.funcs->output_poll_changed)
		dev->mode_config.funcs->output_poll_changed(dev);
}
EXPORT_SYMBOL(drm_kms_helper_hotplug_event);

1042
#define DRM_OUTPUT_POLL_PERIOD (10*HZ)
1043
static void output_poll_execute(struct work_struct *work)
1044
{
1045 1046
	struct delayed_work *delayed_work = to_delayed_work(work);
	struct drm_device *dev = container_of(delayed_work, struct drm_device, mode_config.output_poll_work);
1047
	struct drm_connector *connector;
1048
	enum drm_connector_status old_status;
1049
	bool repoll = false, changed = false;
1050

1051 1052 1053
	if (!drm_kms_helper_poll)
		return;

1054 1055 1056
	mutex_lock(&dev->mode_config.mutex);
	list_for_each_entry(connector, &dev->mode_config.connector_list, head) {

D
Daniel Vetter 已提交
1057 1058 1059 1060
		/* Ignore forced connectors. */
		if (connector->force)
			continue;

1061 1062 1063
		/* Ignore HPD capable connectors and connectors where we don't
		 * want any hotplug detection at all for polling. */
		if (!connector->polled || connector->polled == DRM_CONNECTOR_POLL_HPD)
1064 1065
			continue;

1066
		repoll = true;
1067 1068 1069 1070 1071

		old_status = connector->status;
		/* if we are connected and don't want to poll for disconnect
		   skip it */
		if (old_status == connector_status_connected &&
1072
		    !(connector->polled & DRM_CONNECTOR_POLL_DISCONNECT))
1073 1074
			continue;

1075
		connector->status = connector->funcs->detect(connector, false);
1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087
		if (old_status != connector->status) {
			const char *old, *new;

			old = drm_get_connector_status_name(old_status);
			new = drm_get_connector_status_name(connector->status);

			DRM_DEBUG_KMS("[CONNECTOR:%d:%s] "
				      "status updated from %s to %s\n",
				      connector->base.id,
				      drm_get_connector_name(connector),
				      old, new);

1088
			changed = true;
1089
		}
1090 1091 1092 1093
	}

	mutex_unlock(&dev->mode_config.mutex);

1094 1095
	if (changed)
		drm_kms_helper_hotplug_event(dev);
1096

1097
	if (repoll)
1098
		schedule_delayed_work(delayed_work, DRM_OUTPUT_POLL_PERIOD);
1099 1100
}

1101 1102 1103 1104
void drm_kms_helper_poll_disable(struct drm_device *dev)
{
	if (!dev->mode_config.poll_enabled)
		return;
1105
	cancel_delayed_work_sync(&dev->mode_config.output_poll_work);
1106 1107 1108 1109
}
EXPORT_SYMBOL(drm_kms_helper_poll_disable);

void drm_kms_helper_poll_enable(struct drm_device *dev)
1110 1111
{
	bool poll = false;
1112
	struct drm_connector *connector;
1113

1114 1115 1116
	if (!dev->mode_config.poll_enabled || !drm_kms_helper_poll)
		return;

1117
	list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
1118 1119
		if (connector->polled & (DRM_CONNECTOR_POLL_CONNECT |
					 DRM_CONNECTOR_POLL_DISCONNECT))
1120 1121 1122
			poll = true;
	}

1123
	if (poll)
1124
		schedule_delayed_work(&dev->mode_config.output_poll_work, DRM_OUTPUT_POLL_PERIOD);
1125
}
1126 1127 1128 1129
EXPORT_SYMBOL(drm_kms_helper_poll_enable);

void drm_kms_helper_poll_init(struct drm_device *dev)
{
1130
	INIT_DELAYED_WORK(&dev->mode_config.output_poll_work, output_poll_execute);
1131 1132 1133 1134
	dev->mode_config.poll_enabled = true;

	drm_kms_helper_poll_enable(dev);
}
1135 1136 1137 1138
EXPORT_SYMBOL(drm_kms_helper_poll_init);

void drm_kms_helper_poll_fini(struct drm_device *dev)
{
1139
	drm_kms_helper_poll_disable(dev);
1140 1141 1142
}
EXPORT_SYMBOL(drm_kms_helper_poll_fini);

1143
bool drm_helper_hpd_irq_event(struct drm_device *dev)
1144
{
1145 1146 1147 1148
	struct drm_connector *connector;
	enum drm_connector_status old_status;
	bool changed = false;

1149
	if (!dev->mode_config.poll_enabled)
1150
		return false;
1151

1152 1153 1154 1155 1156 1157 1158 1159 1160 1161
	mutex_lock(&dev->mode_config.mutex);
	list_for_each_entry(connector, &dev->mode_config.connector_list, head) {

		/* Only handle HPD capable connectors. */
		if (!(connector->polled & DRM_CONNECTOR_POLL_HPD))
			continue;

		old_status = connector->status;

		connector->status = connector->funcs->detect(connector, false);
1162
		DRM_DEBUG_KMS("[CONNECTOR:%d:%s] status updated from %s to %s\n",
1163 1164
			      connector->base.id,
			      drm_get_connector_name(connector),
1165 1166
			      drm_get_connector_status_name(old_status),
			      drm_get_connector_status_name(connector->status));
1167 1168 1169 1170 1171 1172 1173 1174
		if (old_status != connector->status)
			changed = true;
	}

	mutex_unlock(&dev->mode_config.mutex);

	if (changed)
		drm_kms_helper_hotplug_event(dev);
1175 1176

	return changed;
1177
}
1178
EXPORT_SYMBOL(drm_helper_hpd_irq_event);