radio-mr800.c 19.0 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24
/*
 * A driver for the AverMedia MR 800 USB FM radio. This device plugs
 * into both the USB and an analog audio input, so this thing
 * only deals with initialization and frequency setting, the
 * audio data has to be handled by a sound driver.
 *
 * Copyright (c) 2008 Alexey Klimov <klimov.linux@gmail.com>
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
 */

/*
25
 * Big thanks to authors and contributors of dsbr100.c and radio-si470x.c
26 27 28 29 30 31 32
 *
 * When work was looked pretty good, i discover this:
 * http://av-usbradio.sourceforge.net/index.php
 * http://sourceforge.net/projects/av-usbradio/
 * Latest release of theirs project was in 2005.
 * Probably, this driver could be improved trough using their
 * achievements (specifications given).
33 34 35
 * Also, Faidon Liambotis <paravoid@debian.org> wrote nice driver for this radio
 * in 2007. He allowed to use his driver to improve current mr800 radio driver.
 * http://kerneltrap.org/mailarchive/linux-usb-devel/2007/10/11/342492
36 37 38 39
 *
 * Version 0.01:	First working version.
 * 			It's required to blacklist AverMedia USB Radio
 * 			in usbhid/hid-quirks.c
40 41 42 43 44 45
 * Version 0.10:	A lot of cleanups and fixes: unpluging the device,
 * 			few mutex locks were added, codinstyle issues, etc.
 * 			Added stereo support. Thanks to
 * 			Douglas Schilling Landgraf <dougsland@gmail.com> and
 * 			David Ellingsworth <david@identd.dyndns.org>
 * 			for discussion, help and support.
46
 * Version 0.11:	Converted to v4l2_device.
47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62
 *
 * Many things to do:
 * 	- Correct power managment of device (suspend & resume)
 * 	- Add code for scanning and smooth tuning
 * 	- Add code for sensitivity value
 * 	- Correct mistakes
 * 	- In Japan another FREQ_MIN and FREQ_MAX
 */

/* kernel includes */
#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/init.h>
#include <linux/slab.h>
#include <linux/input.h>
#include <linux/videodev2.h>
63
#include <media/v4l2-device.h>
64 65 66 67 68 69 70
#include <media/v4l2-ioctl.h>
#include <linux/usb.h>
#include <linux/version.h>	/* for KERNEL_VERSION MACRO */

/* driver and module definitions */
#define DRIVER_AUTHOR "Alexey Klimov <klimov.linux@gmail.com>"
#define DRIVER_DESC "AverMedia MR 800 USB FM radio driver"
71 72
#define DRIVER_VERSION "0.11"
#define RADIO_VERSION KERNEL_VERSION(0, 1, 1)
73 74 75 76 77 78 79 80

MODULE_AUTHOR(DRIVER_AUTHOR);
MODULE_DESCRIPTION(DRIVER_DESC);
MODULE_LICENSE("GPL");

#define USB_AMRADIO_VENDOR 0x07ca
#define USB_AMRADIO_PRODUCT 0xb800

81 82 83 84 85
/* dev_warn macro with driver name */
#define MR800_DRIVER_NAME "radio-mr800"
#define amradio_dev_warn(dev, fmt, arg...)				\
		dev_warn(dev, MR800_DRIVER_NAME " - " fmt, ##arg)

86 87 88 89 90 91 92 93 94 95
/* Probably USB_TIMEOUT should be modified in module parameter */
#define BUFFER_LENGTH 8
#define USB_TIMEOUT 500

/* Frequency limits in MHz -- these are European values.  For Japanese
devices, that would be 76 and 91.  */
#define FREQ_MIN  87.5
#define FREQ_MAX 108.0
#define FREQ_MUL 16000

96 97 98 99
/*
 * Commands that device should understand
 * List isnt full and will be updated with implementation of new functions
 */
100
#define AMRADIO_SET_FREQ	0xa4
101
#define AMRADIO_SET_MUTE	0xab
102
#define AMRADIO_SET_MONO	0xae
103 104 105 106 107

/* Comfortable defines for amradio_set_mute */
#define AMRADIO_START		0x00
#define AMRADIO_STOP		0x01

108 109 110 111
/* Comfortable defines for amradio_set_stereo */
#define WANT_STEREO		0x00
#define WANT_MONO		0x01

112 113 114 115 116 117 118 119
/* module parameter */
static int radio_nr = -1;
module_param(radio_nr, int, 0);
MODULE_PARM_DESC(radio_nr, "Radio Nr");

static int usb_amradio_probe(struct usb_interface *intf,
			     const struct usb_device_id *id);
static void usb_amradio_disconnect(struct usb_interface *intf);
120 121
static int usb_amradio_open(struct file *file);
static int usb_amradio_close(struct file *file);
122 123 124 125 126 127 128 129 130
static int usb_amradio_suspend(struct usb_interface *intf,
				pm_message_t message);
static int usb_amradio_resume(struct usb_interface *intf);

/* Data for one (physical) device */
struct amradio_device {
	/* reference to USB and video device */
	struct usb_device *usbdev;
	struct video_device *videodev;
131
	struct v4l2_device v4l2_dev;
132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152

	unsigned char *buffer;
	struct mutex lock;	/* buffer locking */
	int curfreq;
	int stereo;
	int users;
	int removed;
	int muted;
};

/* USB Device ID List */
static struct usb_device_id usb_amradio_device_table[] = {
	{USB_DEVICE_AND_INTERFACE_INFO(USB_AMRADIO_VENDOR, USB_AMRADIO_PRODUCT,
							USB_CLASS_HID, 0, 0) },
	{ }						/* Terminating entry */
};

MODULE_DEVICE_TABLE(usb, usb_amradio_device_table);

/* USB subsystem interface */
static struct usb_driver usb_amradio_driver = {
153
	.name			= MR800_DRIVER_NAME,
154 155 156 157 158 159
	.probe			= usb_amradio_probe,
	.disconnect		= usb_amradio_disconnect,
	.suspend		= usb_amradio_suspend,
	.resume			= usb_amradio_resume,
	.reset_resume		= usb_amradio_resume,
	.id_table		= usb_amradio_device_table,
160
	.supports_autosuspend	= 0,
161 162
};

163 164
/* switch on/off the radio. Send 8 bytes to device */
static int amradio_set_mute(struct amradio_device *radio, char argument)
165 166 167 168
{
	int retval;
	int size;

169 170 171 172
	/* safety check */
	if (radio->removed)
		return -EIO;

173 174 175 176 177 178
	mutex_lock(&radio->lock);

	radio->buffer[0] = 0x00;
	radio->buffer[1] = 0x55;
	radio->buffer[2] = 0xaa;
	radio->buffer[3] = 0x00;
179 180
	radio->buffer[4] = AMRADIO_SET_MUTE;
	radio->buffer[5] = argument;
181 182 183 184 185 186
	radio->buffer[6] = 0x00;
	radio->buffer[7] = 0x00;

	retval = usb_bulk_msg(radio->usbdev, usb_sndintpipe(radio->usbdev, 2),
		(void *) (radio->buffer), BUFFER_LENGTH, &size, USB_TIMEOUT);

187
	if (retval < 0 || size != BUFFER_LENGTH) {
188 189 190 191
		mutex_unlock(&radio->lock);
		return retval;
	}

192
	radio->muted = argument;
193

194 195
	mutex_unlock(&radio->lock);

196 197 198 199 200 201 202 203
	return retval;
}

/* set a frequency, freq is defined by v4l's TUNER_LOW, i.e. 1/16th kHz */
static int amradio_setfreq(struct amradio_device *radio, int freq)
{
	int retval;
	int size;
204
	unsigned short freq_send = 0x10 + (freq >> 3) / 25;
205

206 207 208 209
	/* safety check */
	if (radio->removed)
		return -EIO;

210 211 212 213 214 215
	mutex_lock(&radio->lock);

	radio->buffer[0] = 0x00;
	radio->buffer[1] = 0x55;
	radio->buffer[2] = 0xaa;
	radio->buffer[3] = 0x03;
216
	radio->buffer[4] = AMRADIO_SET_FREQ;
217 218 219 220 221 222 223
	radio->buffer[5] = 0x00;
	radio->buffer[6] = 0x00;
	radio->buffer[7] = 0x08;

	retval = usb_bulk_msg(radio->usbdev, usb_sndintpipe(radio->usbdev, 2),
		(void *) (radio->buffer), BUFFER_LENGTH, &size, USB_TIMEOUT);

224
	if (retval < 0 || size != BUFFER_LENGTH) {
225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240
		mutex_unlock(&radio->lock);
		return retval;
	}

	/* frequency is calculated from freq_send and placed in first 2 bytes */
	radio->buffer[0] = (freq_send >> 8) & 0xff;
	radio->buffer[1] = freq_send & 0xff;
	radio->buffer[2] = 0x01;
	radio->buffer[3] = 0x00;
	radio->buffer[4] = 0x00;
	/* 5 and 6 bytes of buffer already = 0x00 */
	radio->buffer[7] = 0x00;

	retval = usb_bulk_msg(radio->usbdev, usb_sndintpipe(radio->usbdev, 2),
		(void *) (radio->buffer), BUFFER_LENGTH, &size, USB_TIMEOUT);

241
	if (retval < 0 || size != BUFFER_LENGTH) {
242 243 244 245
		mutex_unlock(&radio->lock);
		return retval;
	}

246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280
	mutex_unlock(&radio->lock);

	return retval;
}

static int amradio_set_stereo(struct amradio_device *radio, char argument)
{
	int retval;
	int size;

	/* safety check */
	if (radio->removed)
		return -EIO;

	mutex_lock(&radio->lock);

	radio->buffer[0] = 0x00;
	radio->buffer[1] = 0x55;
	radio->buffer[2] = 0xaa;
	radio->buffer[3] = 0x00;
	radio->buffer[4] = AMRADIO_SET_MONO;
	radio->buffer[5] = argument;
	radio->buffer[6] = 0x00;
	radio->buffer[7] = 0x00;

	retval = usb_bulk_msg(radio->usbdev, usb_sndintpipe(radio->usbdev, 2),
		(void *) (radio->buffer), BUFFER_LENGTH, &size, USB_TIMEOUT);

	if (retval < 0 || size != BUFFER_LENGTH) {
		radio->stereo = -1;
		mutex_unlock(&radio->lock);
		return retval;
	}

	radio->stereo = 1;
281

282 283
	mutex_unlock(&radio->lock);

284 285 286
	return retval;
}

287 288 289 290 291
/* Handle unplugging the device.
 * We call video_unregister_device in any case.
 * The last function called in this procedure is
 * usb_amradio_device_release.
 */
292 293 294 295
static void usb_amradio_disconnect(struct usb_interface *intf)
{
	struct amradio_device *radio = usb_get_intfdata(intf);

296
	mutex_lock(&radio->lock);
297
	radio->removed = 1;
298
	mutex_unlock(&radio->lock);
299

300 301
	usb_set_intfdata(intf, NULL);
	video_unregister_device(radio->videodev);
302
	v4l2_device_disconnect(&radio->v4l2_dev);
303 304 305 306 307 308
}

/* vidioc_querycap - query device capabilities */
static int vidioc_querycap(struct file *file, void *priv,
					struct v4l2_capability *v)
{
309 310
	struct amradio_device *radio = video_drvdata(file);

311 312
	strlcpy(v->driver, "radio-mr800", sizeof(v->driver));
	strlcpy(v->card, "AverMedia MR 800 USB FM Radio", sizeof(v->card));
313
	usb_make_path(radio->usbdev, v->bus_info, sizeof(v->bus_info));
314 315 316 317 318 319 320 321 322 323
	v->version = RADIO_VERSION;
	v->capabilities = V4L2_CAP_TUNER;
	return 0;
}

/* vidioc_g_tuner - get tuner attributes */
static int vidioc_g_tuner(struct file *file, void *priv,
				struct v4l2_tuner *v)
{
	struct amradio_device *radio = video_get_drvdata(video_devdata(file));
324
	int retval;
325

326 327 328 329
	/* safety check */
	if (radio->removed)
		return -EIO;

330 331 332 333 334 335
	if (v->index > 0)
		return -EINVAL;

/* TODO: Add function which look is signal stereo or not
 * 	amradio_getstat(radio);
 */
336 337 338 339 340 341 342 343 344 345

/* we call amradio_set_stereo to set radio->stereo
 * Honestly, amradio_getstat should cover this in future and
 * amradio_set_stereo shouldn't be here
 */
	retval = amradio_set_stereo(radio, WANT_STEREO);
	if (retval < 0)
		amradio_dev_warn(&radio->videodev->dev,
			"set stereo failed\n");

346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364
	strcpy(v->name, "FM");
	v->type = V4L2_TUNER_RADIO;
	v->rangelow = FREQ_MIN * FREQ_MUL;
	v->rangehigh = FREQ_MAX * FREQ_MUL;
	v->rxsubchans = V4L2_TUNER_SUB_MONO | V4L2_TUNER_SUB_STEREO;
	v->capability = V4L2_TUNER_CAP_LOW;
	if (radio->stereo)
		v->audmode = V4L2_TUNER_MODE_STEREO;
	else
		v->audmode = V4L2_TUNER_MODE_MONO;
	v->signal = 0xffff;     /* Can't get the signal strength, sad.. */
	v->afc = 0; /* Don't know what is this */
	return 0;
}

/* vidioc_s_tuner - set tuner attributes */
static int vidioc_s_tuner(struct file *file, void *priv,
				struct v4l2_tuner *v)
{
365
	struct amradio_device *radio = video_get_drvdata(video_devdata(file));
366
	int retval;
367 368 369 370 371

	/* safety check */
	if (radio->removed)
		return -EIO;

372 373
	if (v->index > 0)
		return -EINVAL;
374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392

	/* mono/stereo selector */
	switch (v->audmode) {
	case V4L2_TUNER_MODE_MONO:
		retval = amradio_set_stereo(radio, WANT_MONO);
		if (retval < 0)
			amradio_dev_warn(&radio->videodev->dev,
				"set mono failed\n");
		break;
	case V4L2_TUNER_MODE_STEREO:
		retval = amradio_set_stereo(radio, WANT_STEREO);
		if (retval < 0)
			amradio_dev_warn(&radio->videodev->dev,
				"set stereo failed\n");
		break;
	default:
		return -EINVAL;
	}

393 394 395 396 397 398 399 400
	return 0;
}

/* vidioc_s_frequency - set tuner radio frequency */
static int vidioc_s_frequency(struct file *file, void *priv,
				struct v4l2_frequency *f)
{
	struct amradio_device *radio = video_get_drvdata(video_devdata(file));
401
	int retval;
402

403 404 405 406
	/* safety check */
	if (radio->removed)
		return -EIO;

407
	mutex_lock(&radio->lock);
408
	radio->curfreq = f->frequency;
409 410
	mutex_unlock(&radio->lock);

411 412
	retval = amradio_setfreq(radio, radio->curfreq);
	if (retval < 0)
413 414
		amradio_dev_warn(&radio->videodev->dev,
			"set frequency failed\n");
415 416 417 418 419 420 421 422 423
	return 0;
}

/* vidioc_g_frequency - get tuner radio frequency */
static int vidioc_g_frequency(struct file *file, void *priv,
				struct v4l2_frequency *f)
{
	struct amradio_device *radio = video_get_drvdata(video_devdata(file));

424 425 426 427
	/* safety check */
	if (radio->removed)
		return -EIO;

428 429 430 431 432 433 434 435 436
	f->type = V4L2_TUNER_RADIO;
	f->frequency = radio->curfreq;
	return 0;
}

/* vidioc_queryctrl - enumerate control items */
static int vidioc_queryctrl(struct file *file, void *priv,
				struct v4l2_queryctrl *qc)
{
437 438 439
	switch (qc->id) {
	case V4L2_CID_AUDIO_MUTE:
		return v4l2_ctrl_query_fill(qc, 0, 1, 1, 1);
440
	}
441

442 443 444 445 446 447 448 449 450
	return -EINVAL;
}

/* vidioc_g_ctrl - get the value of a control */
static int vidioc_g_ctrl(struct file *file, void *priv,
				struct v4l2_control *ctrl)
{
	struct amradio_device *radio = video_get_drvdata(video_devdata(file));

451 452 453 454
	/* safety check */
	if (radio->removed)
		return -EIO;

455 456 457 458 459 460 461 462 463 464 465 466 467
	switch (ctrl->id) {
	case V4L2_CID_AUDIO_MUTE:
		ctrl->value = radio->muted;
		return 0;
	}
	return -EINVAL;
}

/* vidioc_s_ctrl - set the value of a control */
static int vidioc_s_ctrl(struct file *file, void *priv,
				struct v4l2_control *ctrl)
{
	struct amradio_device *radio = video_get_drvdata(video_devdata(file));
468
	int retval;
469

470 471 472 473
	/* safety check */
	if (radio->removed)
		return -EIO;

474 475 476
	switch (ctrl->id) {
	case V4L2_CID_AUDIO_MUTE:
		if (ctrl->value) {
477
			retval = amradio_set_mute(radio, AMRADIO_STOP);
478
			if (retval < 0) {
479 480
				amradio_dev_warn(&radio->videodev->dev,
					"amradio_stop failed\n");
481 482 483
				return -1;
			}
		} else {
484
			retval = amradio_set_mute(radio, AMRADIO_START);
485
			if (retval < 0) {
486 487
				amradio_dev_warn(&radio->videodev->dev,
					"amradio_start failed\n");
488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532
				return -1;
			}
		}
		return 0;
	}
	return -EINVAL;
}

/* vidioc_g_audio - get audio attributes */
static int vidioc_g_audio(struct file *file, void *priv,
				struct v4l2_audio *a)
{
	if (a->index > 1)
		return -EINVAL;

	strcpy(a->name, "Radio");
	a->capability = V4L2_AUDCAP_STEREO;
	return 0;
}

/* vidioc_s_audio - set audio attributes  */
static int vidioc_s_audio(struct file *file, void *priv,
					struct v4l2_audio *a)
{
	if (a->index != 0)
		return -EINVAL;
	return 0;
}

/* vidioc_g_input - get input */
static int vidioc_g_input(struct file *filp, void *priv, unsigned int *i)
{
	*i = 0;
	return 0;
}

/* vidioc_s_input - set input */
static int vidioc_s_input(struct file *filp, void *priv, unsigned int i)
{
	if (i != 0)
		return -EINVAL;
	return 0;
}

/* open device - amradio_start() and amradio_setfreq() */
533
static int usb_amradio_open(struct file *file)
534 535
{
	struct amradio_device *radio = video_get_drvdata(video_devdata(file));
536
	int retval;
537

538 539
	lock_kernel();

540 541 542
	radio->users = 1;
	radio->muted = 1;

543
	retval = amradio_set_mute(radio, AMRADIO_START);
544
	if (retval < 0) {
545 546
		amradio_dev_warn(&radio->videodev->dev,
			"radio did not start up properly\n");
547
		radio->users = 0;
548
		unlock_kernel();
549 550
		return -EIO;
	}
551

552 553 554 555 556
	retval = amradio_set_stereo(radio, WANT_STEREO);
	if (retval < 0)
		amradio_dev_warn(&radio->videodev->dev,
			"set stereo failed\n");

557 558
	retval = amradio_setfreq(radio, radio->curfreq);
	if (retval < 0)
559 560
		amradio_dev_warn(&radio->videodev->dev,
			"set frequency failed\n");
561 562

	unlock_kernel();
563 564 565
	return 0;
}

566
/*close device */
567
static int usb_amradio_close(struct file *file)
568 569
{
	struct amradio_device *radio = video_get_drvdata(video_devdata(file));
570
	int retval;
571 572 573

	if (!radio)
		return -ENODEV;
574

575
	mutex_lock(&radio->lock);
576
	radio->users = 0;
577
	mutex_unlock(&radio->lock);
578

579
	if (!radio->removed) {
580
		retval = amradio_set_mute(radio, AMRADIO_STOP);
581 582 583
		if (retval < 0)
			amradio_dev_warn(&radio->videodev->dev,
				"amradio_stop failed\n");
584
	}
585

586 587 588 589 590 591 592
	return 0;
}

/* Suspend device - stop device. Need to be checked and fixed */
static int usb_amradio_suspend(struct usb_interface *intf, pm_message_t message)
{
	struct amradio_device *radio = usb_get_intfdata(intf);
593
	int retval;
594

595
	retval = amradio_set_mute(radio, AMRADIO_STOP);
596
	if (retval < 0)
597
		dev_warn(&intf->dev, "amradio_stop failed\n");
598

599
	dev_info(&intf->dev, "going into suspend..\n");
600 601 602 603 604 605 606 607

	return 0;
}

/* Resume device - start device. Need to be checked and fixed */
static int usb_amradio_resume(struct usb_interface *intf)
{
	struct amradio_device *radio = usb_get_intfdata(intf);
608
	int retval;
609

610
	retval = amradio_set_mute(radio, AMRADIO_START);
611
	if (retval < 0)
612
		dev_warn(&intf->dev, "amradio_start failed\n");
613

614
	dev_info(&intf->dev, "coming out of suspend..\n");
615 616 617 618 619

	return 0;
}

/* File system interface */
620
static const struct v4l2_file_operations usb_amradio_fops = {
621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641
	.owner		= THIS_MODULE,
	.open		= usb_amradio_open,
	.release	= usb_amradio_close,
	.ioctl		= video_ioctl2,
};

static const struct v4l2_ioctl_ops usb_amradio_ioctl_ops = {
	.vidioc_querycap    = vidioc_querycap,
	.vidioc_g_tuner     = vidioc_g_tuner,
	.vidioc_s_tuner     = vidioc_s_tuner,
	.vidioc_g_frequency = vidioc_g_frequency,
	.vidioc_s_frequency = vidioc_s_frequency,
	.vidioc_queryctrl   = vidioc_queryctrl,
	.vidioc_g_ctrl      = vidioc_g_ctrl,
	.vidioc_s_ctrl      = vidioc_s_ctrl,
	.vidioc_g_audio     = vidioc_g_audio,
	.vidioc_s_audio     = vidioc_s_audio,
	.vidioc_g_input     = vidioc_g_input,
	.vidioc_s_input     = vidioc_s_input,
};

642
static void usb_amradio_video_device_release(struct video_device *videodev)
643 644 645 646 647 648
{
	struct amradio_device *radio = video_get_drvdata(videodev);

	/* we call v4l to free radio->videodev */
	video_device_release(videodev);

649 650
	v4l2_device_unregister(&radio->v4l2_dev);

651 652 653 654 655
	/* free rest memory */
	kfree(radio->buffer);
	kfree(radio);
}

656
/* check if the device is present and register with v4l and usb if it is */
657 658 659 660
static int usb_amradio_probe(struct usb_interface *intf,
				const struct usb_device_id *id)
{
	struct amradio_device *radio;
661
	struct v4l2_device *v4l2_dev;
662
	int retval;
663

664
	radio = kzalloc(sizeof(struct amradio_device), GFP_KERNEL);
665

666 667
	if (!radio) {
		dev_err(&intf->dev, "kmalloc for amradio_device failed\n");
668
		return -ENOMEM;
669
	}
670 671 672

	radio->buffer = kmalloc(BUFFER_LENGTH, GFP_KERNEL);

673 674
	if (!radio->buffer) {
		dev_err(&intf->dev, "kmalloc for radio->buffer failed\n");
675 676 677 678
		kfree(radio);
		return -ENOMEM;
	}

679 680 681 682 683 684 685 686 687
	v4l2_dev = &radio->v4l2_dev;
	retval = v4l2_device_register(&intf->dev, v4l2_dev);
	if (retval < 0) {
		dev_err(&intf->dev, "couldn't register v4l2_device\n");
		kfree(radio->buffer);
		kfree(radio);
		return retval;
	}

688 689
	radio->videodev = video_device_alloc();

690 691
	if (!radio->videodev) {
		dev_err(&intf->dev, "video_device_alloc failed\n");
692 693 694 695 696
		kfree(radio->buffer);
		kfree(radio);
		return -ENOMEM;
	}

697 698 699 700 701
	strlcpy(radio->videodev->name, v4l2_dev->name, sizeof(radio->videodev->name));
	radio->videodev->v4l2_dev = v4l2_dev;
	radio->videodev->fops = &usb_amradio_fops;
	radio->videodev->ioctl_ops = &usb_amradio_ioctl_ops;
	radio->videodev->release = usb_amradio_video_device_release;
702 703 704 705 706

	radio->removed = 0;
	radio->users = 0;
	radio->usbdev = interface_to_usbdev(intf);
	radio->curfreq = 95.16 * FREQ_MUL;
707
	radio->stereo = -1;
708 709 710 711

	mutex_init(&radio->lock);

	video_set_drvdata(radio->videodev, radio);
712

713 714
	retval = video_register_device(radio->videodev,	VFL_TYPE_RADIO,	radio_nr);
	if (retval < 0) {
715
		dev_err(&intf->dev, "could not register video device\n");
716
		video_device_release(radio->videodev);
717
		v4l2_device_unregister(v4l2_dev);
718 719 720 721 722 723 724 725 726 727 728 729 730
		kfree(radio->buffer);
		kfree(radio);
		return -EIO;
	}

	usb_set_intfdata(intf, radio);
	return 0;
}

static int __init amradio_init(void)
{
	int retval = usb_register(&usb_amradio_driver);

731 732 733
	pr_info(KBUILD_MODNAME
		": version " DRIVER_VERSION " " DRIVER_DESC "\n");

734
	if (retval)
735 736 737
		pr_err(KBUILD_MODNAME
			": usb_register failed. Error number %d\n", retval);

738 739 740 741 742 743 744 745 746 747 748
	return retval;
}

static void __exit amradio_exit(void)
{
	usb_deregister(&usb_amradio_driver);
}

module_init(amradio_init);
module_exit(amradio_exit);