vmwgfx_ldu.c 16.2 KB
Newer Older
1 2
/**************************************************************************
 *
S
Sinclair Yeh 已提交
3
 * Copyright © 2009-2015 VMware, Inc., Palo Alto, CA., USA
4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28
 * All Rights Reserved.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the
 * "Software"), to deal in the Software without restriction, including
 * without limitation the rights to use, copy, modify, merge, publish,
 * distribute, sub license, and/or sell copies of the Software, and to
 * permit persons to whom the Software is furnished to do so, subject to
 * the following conditions:
 *
 * The above copyright notice and this permission notice (including the
 * next paragraph) shall be included in all copies or substantial portions
 * of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL
 * THE COPYRIGHT HOLDERS, AUTHORS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM,
 * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
 * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
 * USE OR OTHER DEALINGS IN THE SOFTWARE.
 *
 **************************************************************************/

#include "vmwgfx_kms.h"
29
#include <drm/drm_plane_helper.h>
30 31
#include <drm/drm_atomic.h>
#include <drm/drm_atomic_helper.h>
32

33

34 35 36 37 38 39 40 41 42 43 44
#define vmw_crtc_to_ldu(x) \
	container_of(x, struct vmw_legacy_display_unit, base.crtc)
#define vmw_encoder_to_ldu(x) \
	container_of(x, struct vmw_legacy_display_unit, base.encoder)
#define vmw_connector_to_ldu(x) \
	container_of(x, struct vmw_legacy_display_unit, base.connector)

struct vmw_legacy_display {
	struct list_head active;

	unsigned num_active;
45
	unsigned last_num_active;
46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61

	struct vmw_framebuffer *fb;
};

/**
 * Display unit using the legacy register interface.
 */
struct vmw_legacy_display_unit {
	struct vmw_display_unit base;

	struct list_head active;
};

static void vmw_ldu_destroy(struct vmw_legacy_display_unit *ldu)
{
	list_del_init(&ldu->active);
62
	vmw_du_cleanup(&ldu->base);
63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79
	kfree(ldu);
}


/*
 * Legacy Display Unit CRTC functions
 */

static void vmw_ldu_crtc_destroy(struct drm_crtc *crtc)
{
	vmw_ldu_destroy(vmw_crtc_to_ldu(crtc));
}

static int vmw_ldu_commit_list(struct vmw_private *dev_priv)
{
	struct vmw_legacy_display *lds = dev_priv->ldu_priv;
	struct vmw_legacy_display_unit *entry;
80 81
	struct drm_framebuffer *fb = NULL;
	struct drm_crtc *crtc = NULL;
82
	int i = 0;
83

84 85 86 87 88 89 90 91 92 93 94 95 96 97
	/* If there is no display topology the host just assumes
	 * that the guest will set the same layout as the host.
	 */
	if (!(dev_priv->capabilities & SVGA_CAP_DISPLAY_TOPOLOGY)) {
		int w = 0, h = 0;
		list_for_each_entry(entry, &lds->active, active) {
			crtc = &entry->base.crtc;
			w = max(w, crtc->x + crtc->mode.hdisplay);
			h = max(h, crtc->y + crtc->mode.vdisplay);
			i++;
		}

		if (crtc == NULL)
			return 0;
98
		fb = entry->base.crtc.primary->state->fb;
99

100
		return vmw_kms_write_svga(dev_priv, w, h, fb->pitches[0],
V
Ville Syrjälä 已提交
101
					  fb->format->cpp[0] * 8,
V
Ville Syrjälä 已提交
102
					  fb->format->depth);
103 104 105 106
	}

	if (!list_empty(&lds->active)) {
		entry = list_entry(lds->active.next, typeof(*entry), active);
107
		fb = entry->base.crtc.primary->state->fb;
108

109
		vmw_kms_write_svga(dev_priv, fb->width, fb->height, fb->pitches[0],
V
Ville Syrjälä 已提交
110
				   fb->format->cpp[0] * 8, fb->format->depth);
111 112
	}

113 114 115 116
	/* Make sure we always show something. */
	vmw_write(dev_priv, SVGA_REG_NUM_GUEST_DISPLAYS,
		  lds->num_active ? lds->num_active : 1);

117 118 119 120 121 122 123 124 125 126 127 128 129 130 131
	i = 0;
	list_for_each_entry(entry, &lds->active, active) {
		crtc = &entry->base.crtc;

		vmw_write(dev_priv, SVGA_REG_DISPLAY_ID, i);
		vmw_write(dev_priv, SVGA_REG_DISPLAY_IS_PRIMARY, !i);
		vmw_write(dev_priv, SVGA_REG_DISPLAY_POSITION_X, crtc->x);
		vmw_write(dev_priv, SVGA_REG_DISPLAY_POSITION_Y, crtc->y);
		vmw_write(dev_priv, SVGA_REG_DISPLAY_WIDTH, crtc->mode.hdisplay);
		vmw_write(dev_priv, SVGA_REG_DISPLAY_HEIGHT, crtc->mode.vdisplay);
		vmw_write(dev_priv, SVGA_REG_DISPLAY_ID, SVGA_ID_INVALID);

		i++;
	}

132 133 134 135
	BUG_ON(i != lds->num_active);

	lds->last_num_active = lds->num_active;

136 137 138 139 140 141 142 143 144 145
	return 0;
}

static int vmw_ldu_del_active(struct vmw_private *vmw_priv,
			      struct vmw_legacy_display_unit *ldu)
{
	struct vmw_legacy_display *ld = vmw_priv->ldu_priv;
	if (list_empty(&ldu->active))
		return 0;

146
	/* Must init otherwise list_empty(&ldu->active) will not work. */
147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165
	list_del_init(&ldu->active);
	if (--(ld->num_active) == 0) {
		BUG_ON(!ld->fb);
		if (ld->fb->unpin)
			ld->fb->unpin(ld->fb);
		ld->fb = NULL;
	}

	return 0;
}

static int vmw_ldu_add_active(struct vmw_private *vmw_priv,
			      struct vmw_legacy_display_unit *ldu,
			      struct vmw_framebuffer *vfb)
{
	struct vmw_legacy_display *ld = vmw_priv->ldu_priv;
	struct vmw_legacy_display_unit *entry;
	struct list_head *at;

166 167 168 169
	BUG_ON(!ld->num_active && ld->fb);
	if (vfb != ld->fb) {
		if (ld->fb && ld->fb->unpin)
			ld->fb->unpin(ld->fb);
170
		vmw_svga_enable(vmw_priv);
171 172 173 174 175
		if (vfb->pin)
			vfb->pin(vfb);
		ld->fb = vfb;
	}

176 177 178 179 180
	if (!list_empty(&ldu->active))
		return 0;

	at = &ld->active;
	list_for_each_entry(entry, &ld->active, active) {
181
		if (entry->base.unit > ldu->base.unit)
182 183 184 185 186 187
			break;

		at = &entry->active;
	}

	list_add(&ldu->active, at);
188 189

	ld->num_active++;
190 191 192 193

	return 0;
}

194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239
/**
 * vmw_ldu_crtc_mode_set_nofb - Enable svga
 *
 * @crtc: CRTC associated with the new screen
 *
 * For LDU, just enable the svga
 */
static void vmw_ldu_crtc_mode_set_nofb(struct drm_crtc *crtc)
{
}

/**
 * vmw_ldu_crtc_helper_prepare - Noop
 *
 * @crtc: CRTC associated with the new screen
 *
 * Prepares the CRTC for a mode set, but we don't need to do anything here.
 *
 */
static void vmw_ldu_crtc_helper_prepare(struct drm_crtc *crtc)
{
}

/**
 * vmw_ldu_crtc_helper_commit - Noop
 *
 * @crtc: CRTC associated with the new screen
 *
 * This is called after a mode set has been completed.  Here's
 * usually a good place to call vmw_ldu_add_active/vmw_ldu_del_active
 * but since for LDU the display plane is closely tied to the
 * CRTC, it makes more sense to do those at plane update time.
 */
static void vmw_ldu_crtc_helper_commit(struct drm_crtc *crtc)
{
}

/**
 * vmw_ldu_crtc_helper_disable - Turns off CRTC
 *
 * @crtc: CRTC to be turned off
 */
static void vmw_ldu_crtc_helper_disable(struct drm_crtc *crtc)
{
}

240
static const struct drm_crtc_funcs vmw_legacy_crtc_funcs = {
241
	.gamma_set = vmw_du_crtc_gamma_set,
242
	.destroy = vmw_ldu_crtc_destroy,
S
Sinclair Yeh 已提交
243 244 245
	.reset = vmw_du_crtc_reset,
	.atomic_duplicate_state = vmw_du_crtc_duplicate_state,
	.atomic_destroy_state = vmw_du_crtc_destroy_state,
246
	.set_config = vmw_kms_set_config,
247 248
};

249

250 251 252 253 254 255 256 257 258
/*
 * Legacy Display Unit encoder functions
 */

static void vmw_ldu_encoder_destroy(struct drm_encoder *encoder)
{
	vmw_ldu_destroy(vmw_encoder_to_ldu(encoder));
}

259
static const struct drm_encoder_funcs vmw_legacy_encoder_funcs = {
260 261 262 263 264 265 266 267 268 269 270 271
	.destroy = vmw_ldu_encoder_destroy,
};

/*
 * Legacy Display Unit connector functions
 */

static void vmw_ldu_connector_destroy(struct drm_connector *connector)
{
	vmw_ldu_destroy(vmw_connector_to_ldu(connector));
}

272
static const struct drm_connector_funcs vmw_legacy_connector_funcs = {
273 274 275 276
	.dpms = vmw_du_connector_dpms,
	.detect = vmw_du_connector_detect,
	.fill_modes = vmw_du_connector_fill_modes,
	.set_property = vmw_du_connector_set_property,
277
	.destroy = vmw_ldu_connector_destroy,
278 279 280 281 282
	.reset = vmw_du_connector_reset,
	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
	.atomic_set_property = vmw_du_connector_atomic_set_property,
	.atomic_get_property = vmw_du_connector_atomic_get_property,
283 284
};

285 286 287 288 289
static const struct
drm_connector_helper_funcs vmw_ldu_connector_helper_funcs = {
	.best_encoder = drm_atomic_helper_best_encoder,
};

290 291 292 293
/*
 * Legacy Display Plane Functions
 */

294
/**
295
 * vmw_ldu_primary_plane_cleanup_fb - Noop
296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311
 *
 * @plane:  display plane
 * @old_state: Contains the FB to clean up
 *
 * Unpins the display surface
 *
 * Returns 0 on success
 */
static void
vmw_ldu_primary_plane_cleanup_fb(struct drm_plane *plane,
				 struct drm_plane_state *old_state)
{
}


/**
312
 * vmw_ldu_primary_plane_prepare_fb - Noop
313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330
 *
 * @plane:  display plane
 * @new_state: info on the new plane state, including the FB
 *
 * Returns 0 on success
 */
static int
vmw_ldu_primary_plane_prepare_fb(struct drm_plane *plane,
				 struct drm_plane_state *new_state)
{
	return 0;
}


static void
vmw_ldu_primary_plane_atomic_update(struct drm_plane *plane,
				    struct drm_plane_state *old_state)
{
331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349
	struct vmw_private *dev_priv;
	struct vmw_legacy_display_unit *ldu;
	struct vmw_framebuffer *vfb;
	struct drm_framebuffer *fb;
	struct drm_crtc *crtc = plane->state->crtc ?: old_state->crtc;


	ldu = vmw_crtc_to_ldu(crtc);
	dev_priv = vmw_priv(plane->dev);
	fb       = plane->state->fb;

	vfb = (fb) ? vmw_framebuffer_to_vfb(fb) : NULL;

	if (vfb)
		vmw_ldu_add_active(dev_priv, ldu, vfb);
	else
		vmw_ldu_del_active(dev_priv, ldu);

	vmw_ldu_commit_list(dev_priv);
350 351 352
}


353
static const struct drm_plane_funcs vmw_ldu_plane_funcs = {
354 355
	.update_plane = drm_atomic_helper_update_plane,
	.disable_plane = drm_atomic_helper_disable_plane,
356
	.destroy = vmw_du_primary_plane_destroy,
S
Sinclair Yeh 已提交
357 358 359
	.reset = vmw_du_plane_reset,
	.atomic_duplicate_state = vmw_du_plane_duplicate_state,
	.atomic_destroy_state = vmw_du_plane_destroy_state,
360 361 362
};

static const struct drm_plane_funcs vmw_ldu_cursor_funcs = {
363 364
	.update_plane = drm_atomic_helper_update_plane,
	.disable_plane = drm_atomic_helper_disable_plane,
365
	.destroy = vmw_du_cursor_plane_destroy,
S
Sinclair Yeh 已提交
366 367 368
	.reset = vmw_du_plane_reset,
	.atomic_duplicate_state = vmw_du_plane_duplicate_state,
	.atomic_destroy_state = vmw_du_plane_destroy_state,
369 370
};

371 372 373
/*
 * Atomic Helpers
 */
374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389
static const struct
drm_plane_helper_funcs vmw_ldu_cursor_plane_helper_funcs = {
	.atomic_check = vmw_du_cursor_plane_atomic_check,
	.atomic_update = vmw_du_cursor_plane_atomic_update,
	.prepare_fb = vmw_du_cursor_plane_prepare_fb,
	.cleanup_fb = vmw_du_plane_cleanup_fb,
};

static const struct
drm_plane_helper_funcs vmw_ldu_primary_plane_helper_funcs = {
	.atomic_check = vmw_du_primary_plane_atomic_check,
	.atomic_update = vmw_ldu_primary_plane_atomic_update,
	.prepare_fb = vmw_ldu_primary_plane_prepare_fb,
	.cleanup_fb = vmw_ldu_primary_plane_cleanup_fb,
};

390 391 392 393 394 395 396 397 398 399
static const struct drm_crtc_helper_funcs vmw_ldu_crtc_helper_funcs = {
	.prepare = vmw_ldu_crtc_helper_prepare,
	.commit = vmw_ldu_crtc_helper_commit,
	.disable = vmw_ldu_crtc_helper_disable,
	.mode_set_nofb = vmw_ldu_crtc_mode_set_nofb,
	.atomic_check = vmw_du_crtc_atomic_check,
	.atomic_begin = vmw_du_crtc_atomic_begin,
	.atomic_flush = vmw_du_crtc_atomic_flush,
};

400

401 402 403 404 405 406
static int vmw_ldu_init(struct vmw_private *dev_priv, unsigned unit)
{
	struct vmw_legacy_display_unit *ldu;
	struct drm_device *dev = dev_priv->dev;
	struct drm_connector *connector;
	struct drm_encoder *encoder;
S
Sinclair Yeh 已提交
407
	struct drm_plane *primary, *cursor;
408
	struct drm_crtc *crtc;
409
	int ret;
410 411 412 413 414

	ldu = kzalloc(sizeof(*ldu), GFP_KERNEL);
	if (!ldu)
		return -ENOMEM;

415
	ldu->base.unit = unit;
416 417 418
	crtc = &ldu->base.crtc;
	encoder = &ldu->base.encoder;
	connector = &ldu->base.connector;
S
Sinclair Yeh 已提交
419 420
	primary = &ldu->base.primary;
	cursor = &ldu->base.cursor;
421

422 423
	INIT_LIST_HEAD(&ldu->active);

424
	ldu->base.pref_active = (unit == 0);
425 426
	ldu->base.pref_width = dev_priv->initial_width;
	ldu->base.pref_height = dev_priv->initial_height;
427
	ldu->base.pref_mode = NULL;
S
Sinclair Yeh 已提交
428 429 430 431 432

	/*
	 * Remove this after enabling atomic because property values can
	 * only exist in a state object
	 */
433
	ldu->base.is_implicit = true;
434

435
	/* Initialize primary plane */
S
Sinclair Yeh 已提交
436 437
	vmw_du_plane_reset(primary);

438 439 440 441 442 443 444 445 446 447
	ret = drm_universal_plane_init(dev, &ldu->base.primary,
				       0, &vmw_ldu_plane_funcs,
				       vmw_primary_plane_formats,
				       ARRAY_SIZE(vmw_primary_plane_formats),
				       DRM_PLANE_TYPE_PRIMARY, NULL);
	if (ret) {
		DRM_ERROR("Failed to initialize primary plane");
		goto err_free;
	}

448 449
	drm_plane_helper_add(primary, &vmw_ldu_primary_plane_helper_funcs);

450
	/* Initialize cursor plane */
S
Sinclair Yeh 已提交
451 452
	vmw_du_plane_reset(cursor);

453 454 455 456 457 458 459 460 461 462 463
	ret = drm_universal_plane_init(dev, &ldu->base.cursor,
			0, &vmw_ldu_cursor_funcs,
			vmw_cursor_plane_formats,
			ARRAY_SIZE(vmw_cursor_plane_formats),
			DRM_PLANE_TYPE_CURSOR, NULL);
	if (ret) {
		DRM_ERROR("Failed to initialize cursor plane");
		drm_plane_cleanup(&ldu->base.primary);
		goto err_free;
	}

464 465 466 467
	drm_plane_helper_add(cursor, &vmw_ldu_cursor_plane_helper_funcs);


	vmw_du_connector_reset(connector);
468 469 470 471 472 473
	ret = drm_connector_init(dev, connector, &vmw_legacy_connector_funcs,
				 DRM_MODE_CONNECTOR_VIRTUAL);
	if (ret) {
		DRM_ERROR("Failed to initialize connector\n");
		goto err_free;
	}
474 475

	drm_connector_helper_add(connector, &vmw_ldu_connector_helper_funcs);
476
	connector->status = vmw_du_connector_detect(connector, true);
477 478
	vmw_connector_state_to_vcs(connector->state)->is_implicit = true;

479

480 481 482 483 484 485 486 487
	ret = drm_encoder_init(dev, encoder, &vmw_legacy_encoder_funcs,
			       DRM_MODE_ENCODER_VIRTUAL, NULL);
	if (ret) {
		DRM_ERROR("Failed to initialize encoder\n");
		goto err_free_connector;
	}

	(void) drm_mode_connector_attach_encoder(connector, encoder);
488 489 490
	encoder->possible_crtcs = (1 << unit);
	encoder->possible_clones = 0;

491 492 493 494 495
	ret = drm_connector_register(connector);
	if (ret) {
		DRM_ERROR("Failed to register connector\n");
		goto err_free_encoder;
	}
496

497 498

	vmw_du_crtc_reset(crtc);
499 500 501 502 503 504 505
	ret = drm_crtc_init_with_planes(dev, crtc, &ldu->base.primary,
					&ldu->base.cursor,
					&vmw_legacy_crtc_funcs, NULL);
	if (ret) {
		DRM_ERROR("Failed to initialize CRTC\n");
		goto err_free_unregister;
	}
506

507 508
	drm_crtc_helper_add(crtc, &vmw_ldu_crtc_helper_funcs);

M
Michel Dänzer 已提交
509 510
	drm_mode_crtc_set_gamma_size(crtc, 256);

511 512 513 514 515 516
	drm_object_attach_property(&connector->base,
				   dev_priv->hotplug_mode_update_property, 1);
	drm_object_attach_property(&connector->base,
				   dev->mode_config.suggested_x_property, 0);
	drm_object_attach_property(&connector->base,
				   dev->mode_config.suggested_y_property, 0);
517 518 519 520 521
	if (dev_priv->implicit_placement_property)
		drm_object_attach_property
			(&connector->base,
			 dev_priv->implicit_placement_property,
			 1);
522 523

	return 0;
524 525 526 527 528 529 530 531 532 533

err_free_unregister:
	drm_connector_unregister(connector);
err_free_encoder:
	drm_encoder_cleanup(encoder);
err_free_connector:
	drm_connector_cleanup(connector);
err_free:
	kfree(ldu);
	return ret;
534 535
}

536
int vmw_kms_ldu_init_display(struct vmw_private *dev_priv)
537
{
538
	struct drm_device *dev = dev_priv->dev;
539
	int i, ret;
540

541 542 543 544 545
	if (dev_priv->ldu_priv) {
		DRM_INFO("ldu system already on\n");
		return -EINVAL;
	}

546
	dev_priv->ldu_priv = kmalloc(sizeof(*dev_priv->ldu_priv), GFP_KERNEL);
547 548 549 550 551
	if (!dev_priv->ldu_priv)
		return -ENOMEM;

	INIT_LIST_HEAD(&dev_priv->ldu_priv->active);
	dev_priv->ldu_priv->num_active = 0;
552
	dev_priv->ldu_priv->last_num_active = 0;
553 554
	dev_priv->ldu_priv->fb = NULL;

555 556 557 558 559 560 561
	/* for old hardware without multimon only enable one display */
	if (dev_priv->capabilities & SVGA_CAP_MULTIMON)
		ret = drm_vblank_init(dev, VMWGFX_NUM_DISPLAY_UNITS);
	else
		ret = drm_vblank_init(dev, 1);
	if (ret != 0)
		goto err_free;
562

563 564
	vmw_kms_create_implicit_placement_property(dev_priv, true);

565
	if (dev_priv->capabilities & SVGA_CAP_MULTIMON)
566
		for (i = 0; i < VMWGFX_NUM_DISPLAY_UNITS; ++i)
567
			vmw_ldu_init(dev_priv, i);
568
	else
569
		vmw_ldu_init(dev_priv, 0);
570

571 572 573 574
	dev_priv->active_display_unit = vmw_du_legacy;

	DRM_INFO("Legacy Display Unit initialized\n");

575 576 577 578 579
	return 0;

err_free:
	kfree(dev_priv->ldu_priv);
	dev_priv->ldu_priv = NULL;
580
	return ret;
581 582
}

583
int vmw_kms_ldu_close_display(struct vmw_private *dev_priv)
584
{
585 586
	struct drm_device *dev = dev_priv->dev;

587 588 589
	if (!dev_priv->ldu_priv)
		return -ENOSYS;

590 591
	drm_vblank_cleanup(dev);

592 593 594 595 596 597
	BUG_ON(!list_empty(&dev_priv->ldu_priv->active));

	kfree(dev_priv->ldu_priv);

	return 0;
}
598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622


int vmw_kms_ldu_do_dmabuf_dirty(struct vmw_private *dev_priv,
				struct vmw_framebuffer *framebuffer,
				unsigned flags, unsigned color,
				struct drm_clip_rect *clips,
				unsigned num_clips, int increment)
{
	size_t fifo_size;
	int i;

	struct {
		uint32_t header;
		SVGAFifoCmdUpdate body;
	} *cmd;

	fifo_size = sizeof(*cmd) * num_clips;
	cmd = vmw_fifo_reserve(dev_priv, fifo_size);
	if (unlikely(cmd == NULL)) {
		DRM_ERROR("Fifo reserve failed.\n");
		return -ENOMEM;
	}

	memset(cmd, 0, fifo_size);
	for (i = 0; i < num_clips; i++, clips += increment) {
623 624 625 626 627
		cmd[i].header = SVGA_CMD_UPDATE;
		cmd[i].body.x = clips->x1;
		cmd[i].body.y = clips->y1;
		cmd[i].body.width = clips->x2 - clips->x1;
		cmd[i].body.height = clips->y2 - clips->y1;
628 629 630 631 632
	}

	vmw_fifo_commit(dev_priv, fifo_size);
	return 0;
}