originator.c 17.2 KB
Newer Older
1
/* Copyright (C) 2009-2013 B.A.T.M.A.N. contributors:
2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20
 *
 * Marek Lindner, Simon Wunderlich
 *
 * This program is free software; you can redistribute it and/or
 * modify it under the terms of version 2 of the GNU General Public
 * License as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but
 * WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
 * General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
 * 02110-1301, USA
 */

#include "main.h"
21
#include "distributed-arp-table.h"
22 23 24 25 26 27 28 29
#include "originator.h"
#include "hash.h"
#include "translation-table.h"
#include "routing.h"
#include "gateway_client.h"
#include "hard-interface.h"
#include "unicast.h"
#include "soft-interface.h"
30
#include "bridge_loop_avoidance.h"
31

32 33 34
/* hash class keys */
static struct lock_class_key batadv_orig_hash_lock_class_key;

35
static void batadv_purge_orig(struct work_struct *work);
36

37
/* returns 1 if they are the same originator */
38
static int batadv_compare_orig(const struct hlist_node *node, const void *data2)
39
{
40 41
	const void *data1 = container_of(node, struct batadv_orig_node,
					 hash_entry);
42 43 44 45

	return (memcmp(data1, data2, ETH_ALEN) == 0 ? 1 : 0);
}

46
int batadv_originator_init(struct batadv_priv *bat_priv)
47 48
{
	if (bat_priv->orig_hash)
49
		return 0;
50

51
	bat_priv->orig_hash = batadv_hash_new(1024);
52 53 54 55

	if (!bat_priv->orig_hash)
		goto err;

56 57 58
	batadv_hash_set_lock_class(bat_priv->orig_hash,
				   &batadv_orig_hash_lock_class_key);

59 60 61 62 63
	INIT_DELAYED_WORK(&bat_priv->orig_work, batadv_purge_orig);
	queue_delayed_work(batadv_event_workqueue,
			   &bat_priv->orig_work,
			   msecs_to_jiffies(BATADV_ORIG_WORK_PERIOD));

64
	return 0;
65 66

err:
67
	return -ENOMEM;
68 69
}

70
void batadv_neigh_node_free_ref(struct batadv_neigh_node *neigh_node)
71
{
72
	if (atomic_dec_and_test(&neigh_node->refcount))
73
		kfree_rcu(neigh_node, rcu);
74 75
}

76
/* increases the refcounter of a found router */
77 78
struct batadv_neigh_node *
batadv_orig_node_get_router(struct batadv_orig_node *orig_node)
79
{
80
	struct batadv_neigh_node *router;
81 82 83 84 85 86 87 88 89 90 91

	rcu_read_lock();
	router = rcu_dereference(orig_node->router);

	if (router && !atomic_inc_not_zero(&router->refcount))
		router = NULL;

	rcu_read_unlock();
	return router;
}

92 93 94
struct batadv_neigh_node *
batadv_neigh_node_new(struct batadv_hard_iface *hard_iface,
		      const uint8_t *neigh_addr, uint32_t seqno)
95
{
96 97
	struct batadv_priv *bat_priv = netdev_priv(hard_iface->soft_iface);
	struct batadv_neigh_node *neigh_node;
98

99
	neigh_node = kzalloc(sizeof(*neigh_node), GFP_ATOMIC);
100
	if (!neigh_node)
101
		goto out;
102

103
	INIT_HLIST_NODE(&neigh_node->list);
104

105
	memcpy(neigh_node->addr, neigh_addr, ETH_ALEN);
106
	spin_lock_init(&neigh_node->lq_update_lock);
107 108 109

	/* extra reference for return */
	atomic_set(&neigh_node->refcount, 2);
110

111
	batadv_dbg(BATADV_DBG_BATMAN, bat_priv,
112 113
		   "Creating new neighbor %pM, initial seqno %d\n",
		   neigh_addr, seqno);
114 115

out:
116 117 118
	return neigh_node;
}

119
static void batadv_orig_node_free_rcu(struct rcu_head *rcu)
120
{
121
	struct hlist_node *node_tmp;
122 123
	struct batadv_neigh_node *neigh_node, *tmp_neigh_node;
	struct batadv_orig_node *orig_node;
124

125
	orig_node = container_of(rcu, struct batadv_orig_node, rcu);
126

127 128
	spin_lock_bh(&orig_node->neigh_list_lock);

129 130 131 132
	/* for all bonding members ... */
	list_for_each_entry_safe(neigh_node, tmp_neigh_node,
				 &orig_node->bond_list, bonding_list) {
		list_del_rcu(&neigh_node->bonding_list);
133
		batadv_neigh_node_free_ref(neigh_node);
134 135
	}

136
	/* for all neighbors towards this originator ... */
137
	hlist_for_each_entry_safe(neigh_node, node_tmp,
138
				  &orig_node->neigh_list, list) {
139
		hlist_del_rcu(&neigh_node->list);
140
		batadv_neigh_node_free_ref(neigh_node);
141 142
	}

143 144
	spin_unlock_bh(&orig_node->neigh_list_lock);

145
	batadv_frag_list_free(&orig_node->frag_list);
146 147
	batadv_tt_global_del_orig(orig_node->bat_priv, orig_node,
				  "originator timed out");
148

149
	kfree(orig_node->tt_buff);
150 151 152 153 154
	kfree(orig_node->bcast_own);
	kfree(orig_node->bcast_own_sum);
	kfree(orig_node);
}

155
void batadv_orig_node_free_ref(struct batadv_orig_node *orig_node)
156 157
{
	if (atomic_dec_and_test(&orig_node->refcount))
158
		call_rcu(&orig_node->rcu, batadv_orig_node_free_rcu);
159 160
}

161
void batadv_originator_free(struct batadv_priv *bat_priv)
162
{
163
	struct batadv_hashtable *hash = bat_priv->orig_hash;
164
	struct hlist_node *node_tmp;
165 166
	struct hlist_head *head;
	spinlock_t *list_lock; /* spinlock to protect write access */
167
	struct batadv_orig_node *orig_node;
168
	uint32_t i;
169 170

	if (!hash)
171 172 173 174 175
		return;

	cancel_delayed_work_sync(&bat_priv->orig_work);

	bat_priv->orig_hash = NULL;
176 177 178 179 180 181

	for (i = 0; i < hash->size; i++) {
		head = &hash->table[i];
		list_lock = &hash->list_locks[i];

		spin_lock_bh(list_lock);
182
		hlist_for_each_entry_safe(orig_node, node_tmp,
183
					  head, hash_entry) {
184
			hlist_del_rcu(&orig_node->hash_entry);
185
			batadv_orig_node_free_ref(orig_node);
186 187 188 189
		}
		spin_unlock_bh(list_lock);
	}

190
	batadv_hash_destroy(hash);
191 192 193
}

/* this function finds or creates an originator entry for the given
194 195
 * address if it does not exits
 */
196 197
struct batadv_orig_node *batadv_get_orig_node(struct batadv_priv *bat_priv,
					      const uint8_t *addr)
198
{
199
	struct batadv_orig_node *orig_node;
200 201
	int size;
	int hash_added;
202
	unsigned long reset_time;
203

204
	orig_node = batadv_orig_hash_find(bat_priv, addr);
205
	if (orig_node)
206 207
		return orig_node;

208 209
	batadv_dbg(BATADV_DBG_BATMAN, bat_priv,
		   "Creating new originator: %pM\n", addr);
210

211
	orig_node = kzalloc(sizeof(*orig_node), GFP_ATOMIC);
212 213 214
	if (!orig_node)
		return NULL;

215
	INIT_HLIST_HEAD(&orig_node->neigh_list);
216
	INIT_LIST_HEAD(&orig_node->bond_list);
217
	spin_lock_init(&orig_node->ogm_cnt_lock);
218
	spin_lock_init(&orig_node->bcast_seqno_lock);
219
	spin_lock_init(&orig_node->neigh_list_lock);
220
	spin_lock_init(&orig_node->tt_buff_lock);
221 222 223

	/* extra reference for return */
	atomic_set(&orig_node->refcount, 2);
224

225
	orig_node->tt_initialised = false;
226
	orig_node->bat_priv = bat_priv;
227
	memcpy(orig_node->orig, addr, ETH_ALEN);
228
	batadv_dat_init_orig_node_addr(orig_node);
229
	orig_node->router = NULL;
230 231
	orig_node->tt_crc = 0;
	atomic_set(&orig_node->last_ttvn, 0);
232
	orig_node->tt_buff = NULL;
233 234
	orig_node->tt_buff_len = 0;
	atomic_set(&orig_node->tt_size, 0);
235 236 237
	reset_time = jiffies - 1 - msecs_to_jiffies(BATADV_RESET_PROTECTION_MS);
	orig_node->bcast_seqno_reset = reset_time;
	orig_node->batman_seqno_reset = reset_time;
238

239 240
	atomic_set(&orig_node->bond_candidates, 0);

241
	size = bat_priv->num_ifaces * sizeof(unsigned long) * BATADV_NUM_WORDS;
242 243 244 245 246 247 248 249 250 251 252 253 254 255

	orig_node->bcast_own = kzalloc(size, GFP_ATOMIC);
	if (!orig_node->bcast_own)
		goto free_orig_node;

	size = bat_priv->num_ifaces * sizeof(uint8_t);
	orig_node->bcast_own_sum = kzalloc(size, GFP_ATOMIC);

	INIT_LIST_HEAD(&orig_node->frag_list);
	orig_node->last_frag_packet = 0;

	if (!orig_node->bcast_own_sum)
		goto free_bcast_own;

256
	hash_added = batadv_hash_add(bat_priv->orig_hash, batadv_compare_orig,
257
				     batadv_choose_orig, orig_node,
258
				     &orig_node->hash_entry);
259
	if (hash_added != 0)
260 261 262 263 264 265 266 267 268 269 270 271
		goto free_bcast_own_sum;

	return orig_node;
free_bcast_own_sum:
	kfree(orig_node->bcast_own_sum);
free_bcast_own:
	kfree(orig_node->bcast_own);
free_orig_node:
	kfree(orig_node);
	return NULL;
}

272 273 274 275
static bool
batadv_purge_orig_neighbors(struct batadv_priv *bat_priv,
			    struct batadv_orig_node *orig_node,
			    struct batadv_neigh_node **best_neigh_node)
276
{
277
	struct hlist_node *node_tmp;
278
	struct batadv_neigh_node *neigh_node;
279
	bool neigh_purged = false;
280
	unsigned long last_seen;
281
	struct batadv_hard_iface *if_incoming;
282 283 284

	*best_neigh_node = NULL;

285 286
	spin_lock_bh(&orig_node->neigh_list_lock);

287
	/* for all neighbors towards this originator ... */
288
	hlist_for_each_entry_safe(neigh_node, node_tmp,
289
				  &orig_node->neigh_list, list) {
290 291 292
		last_seen = neigh_node->last_seen;
		if_incoming = neigh_node->if_incoming;

293
		if ((batadv_has_timed_out(last_seen, BATADV_PURGE_TIMEOUT)) ||
294 295 296 297 298 299
		    (if_incoming->if_status == BATADV_IF_INACTIVE) ||
		    (if_incoming->if_status == BATADV_IF_NOT_IN_USE) ||
		    (if_incoming->if_status == BATADV_IF_TO_BE_REMOVED)) {
			if ((if_incoming->if_status == BATADV_IF_INACTIVE) ||
			    (if_incoming->if_status == BATADV_IF_NOT_IN_USE) ||
			    (if_incoming->if_status == BATADV_IF_TO_BE_REMOVED))
300
				batadv_dbg(BATADV_DBG_BATMAN, bat_priv,
301 302 303
					   "neighbor purge: originator %pM, neighbor: %pM, iface: %s\n",
					   orig_node->orig, neigh_node->addr,
					   if_incoming->net_dev->name);
304
			else
305
				batadv_dbg(BATADV_DBG_BATMAN, bat_priv,
306 307 308
					   "neighbor timeout: originator %pM, neighbor: %pM, last_seen: %u\n",
					   orig_node->orig, neigh_node->addr,
					   jiffies_to_msecs(last_seen));
309 310

			neigh_purged = true;
311

312
			hlist_del_rcu(&neigh_node->list);
313
			batadv_bonding_candidate_del(orig_node, neigh_node);
314
			batadv_neigh_node_free_ref(neigh_node);
315 316 317 318 319 320
		} else {
			if ((!*best_neigh_node) ||
			    (neigh_node->tq_avg > (*best_neigh_node)->tq_avg))
				*best_neigh_node = neigh_node;
		}
	}
321 322

	spin_unlock_bh(&orig_node->neigh_list_lock);
323 324 325
	return neigh_purged;
}

326 327
static bool batadv_purge_orig_node(struct batadv_priv *bat_priv,
				   struct batadv_orig_node *orig_node)
328
{
329
	struct batadv_neigh_node *best_neigh_node;
330

331 332
	if (batadv_has_timed_out(orig_node->last_seen,
				 2 * BATADV_PURGE_TIMEOUT)) {
333
		batadv_dbg(BATADV_DBG_BATMAN, bat_priv,
334 335 336
			   "Originator timeout: originator %pM, last_seen %u\n",
			   orig_node->orig,
			   jiffies_to_msecs(orig_node->last_seen));
337 338
		return true;
	} else {
339 340
		if (batadv_purge_orig_neighbors(bat_priv, orig_node,
						&best_neigh_node))
341 342
			batadv_update_route(bat_priv, orig_node,
					    best_neigh_node);
343 344 345 346 347
	}

	return false;
}

348
static void _batadv_purge_orig(struct batadv_priv *bat_priv)
349
{
350
	struct batadv_hashtable *hash = bat_priv->orig_hash;
351
	struct hlist_node *node_tmp;
352
	struct hlist_head *head;
353
	spinlock_t *list_lock; /* spinlock to protect write access */
354
	struct batadv_orig_node *orig_node;
355
	uint32_t i;
356 357 358 359 360 361 362

	if (!hash)
		return;

	/* for all origins... */
	for (i = 0; i < hash->size; i++) {
		head = &hash->table[i];
363
		list_lock = &hash->list_locks[i];
364

365
		spin_lock_bh(list_lock);
366
		hlist_for_each_entry_safe(orig_node, node_tmp,
367
					  head, hash_entry) {
368
			if (batadv_purge_orig_node(bat_priv, orig_node)) {
369
				if (orig_node->gw_flags)
370 371
					batadv_gw_node_delete(bat_priv,
							      orig_node);
372
				hlist_del_rcu(&orig_node->hash_entry);
373
				batadv_orig_node_free_ref(orig_node);
374
				continue;
375 376
			}

377
			if (batadv_has_timed_out(orig_node->last_frag_packet,
378
						 BATADV_FRAG_TIMEOUT))
379
				batadv_frag_list_free(&orig_node->frag_list);
380
		}
381
		spin_unlock_bh(list_lock);
382 383
	}

384 385
	batadv_gw_node_purge(bat_priv);
	batadv_gw_election(bat_priv);
386 387
}

388
static void batadv_purge_orig(struct work_struct *work)
389
{
390 391
	struct delayed_work *delayed_work;
	struct batadv_priv *bat_priv;
392

393 394
	delayed_work = container_of(work, struct delayed_work, work);
	bat_priv = container_of(delayed_work, struct batadv_priv, orig_work);
395
	_batadv_purge_orig(bat_priv);
396 397 398
	queue_delayed_work(batadv_event_workqueue,
			   &bat_priv->orig_work,
			   msecs_to_jiffies(BATADV_ORIG_WORK_PERIOD));
399 400
}

401
void batadv_purge_orig_ref(struct batadv_priv *bat_priv)
402
{
403
	_batadv_purge_orig(bat_priv);
404 405
}

406
int batadv_orig_seq_print_text(struct seq_file *seq, void *offset)
407 408
{
	struct net_device *net_dev = (struct net_device *)seq->private;
409
	struct batadv_priv *bat_priv = netdev_priv(net_dev);
410
	struct batadv_hashtable *hash = bat_priv->orig_hash;
411
	struct hlist_head *head;
412 413 414
	struct batadv_hard_iface *primary_if;
	struct batadv_orig_node *orig_node;
	struct batadv_neigh_node *neigh_node, *neigh_node_tmp;
415 416 417
	int batman_count = 0;
	int last_seen_secs;
	int last_seen_msecs;
418
	unsigned long last_seen_jiffies;
419
	uint32_t i;
420

421 422
	primary_if = batadv_seq_print_text_primary_if_get(seq);
	if (!primary_if)
423
		goto out;
424

425
	seq_printf(seq, "[B.A.T.M.A.N. adv %s, MainIF/MAC: %s/%pM (%s)]\n",
426
		   BATADV_SOURCE_VERSION, primary_if->net_dev->name,
427
		   primary_if->net_dev->dev_addr, net_dev->name);
428
	seq_printf(seq, "  %-15s %s (%s/%i) %17s [%10s]: %20s ...\n",
429 430
		   "Originator", "last-seen", "#", BATADV_TQ_MAX_VALUE,
		   "Nexthop", "outgoingIF", "Potential nexthops");
431 432 433 434

	for (i = 0; i < hash->size; i++) {
		head = &hash->table[i];

435
		rcu_read_lock();
436
		hlist_for_each_entry_rcu(orig_node, head, hash_entry) {
437
			neigh_node = batadv_orig_node_get_router(orig_node);
438
			if (!neigh_node)
439 440
				continue;

441 442
			if (neigh_node->tq_avg == 0)
				goto next;
443

444 445 446 447
			last_seen_jiffies = jiffies - orig_node->last_seen;
			last_seen_msecs = jiffies_to_msecs(last_seen_jiffies);
			last_seen_secs = last_seen_msecs / 1000;
			last_seen_msecs = last_seen_msecs % 1000;
448 449 450 451 452 453 454

			seq_printf(seq, "%pM %4i.%03is   (%3i) %pM [%10s]:",
				   orig_node->orig, last_seen_secs,
				   last_seen_msecs, neigh_node->tq_avg,
				   neigh_node->addr,
				   neigh_node->if_incoming->net_dev->name);

455
			hlist_for_each_entry_rcu(neigh_node_tmp,
456
						 &orig_node->neigh_list, list) {
457 458 459
				seq_printf(seq, " %pM (%3i)",
					   neigh_node_tmp->addr,
					   neigh_node_tmp->tq_avg);
460 461 462 463
			}

			seq_printf(seq, "\n");
			batman_count++;
464 465

next:
466
			batadv_neigh_node_free_ref(neigh_node);
467
		}
468
		rcu_read_unlock();
469 470
	}

471
	if (batman_count == 0)
472 473
		seq_printf(seq, "No batman nodes in range ...\n");

474 475
out:
	if (primary_if)
476
		batadv_hardif_free_ref(primary_if);
477
	return 0;
478 479
}

480 481
static int batadv_orig_node_add_if(struct batadv_orig_node *orig_node,
				   int max_if_num)
482 483
{
	void *data_ptr;
484
	size_t data_size, old_size;
485

486 487 488
	data_size = max_if_num * sizeof(unsigned long) * BATADV_NUM_WORDS;
	old_size = (max_if_num - 1) * sizeof(unsigned long) * BATADV_NUM_WORDS;
	data_ptr = kmalloc(data_size, GFP_ATOMIC);
489
	if (!data_ptr)
490
		return -ENOMEM;
491

492
	memcpy(data_ptr, orig_node->bcast_own, old_size);
493 494 495 496
	kfree(orig_node->bcast_own);
	orig_node->bcast_own = data_ptr;

	data_ptr = kmalloc(max_if_num * sizeof(uint8_t), GFP_ATOMIC);
497
	if (!data_ptr)
498
		return -ENOMEM;
499 500 501 502 503 504 505 506 507

	memcpy(data_ptr, orig_node->bcast_own_sum,
	       (max_if_num - 1) * sizeof(uint8_t));
	kfree(orig_node->bcast_own_sum);
	orig_node->bcast_own_sum = data_ptr;

	return 0;
}

508 509
int batadv_orig_hash_add_if(struct batadv_hard_iface *hard_iface,
			    int max_if_num)
510
{
511
	struct batadv_priv *bat_priv = netdev_priv(hard_iface->soft_iface);
512
	struct batadv_hashtable *hash = bat_priv->orig_hash;
513
	struct hlist_head *head;
514
	struct batadv_orig_node *orig_node;
515 516
	uint32_t i;
	int ret;
517 518

	/* resize all orig nodes because orig_node->bcast_own(_sum) depend on
519 520
	 * if_num
	 */
521 522 523
	for (i = 0; i < hash->size; i++) {
		head = &hash->table[i];

524
		rcu_read_lock();
525
		hlist_for_each_entry_rcu(orig_node, head, hash_entry) {
526
			spin_lock_bh(&orig_node->ogm_cnt_lock);
527
			ret = batadv_orig_node_add_if(orig_node, max_if_num);
528 529
			spin_unlock_bh(&orig_node->ogm_cnt_lock);

530
			if (ret == -ENOMEM)
531 532
				goto err;
		}
533
		rcu_read_unlock();
534 535 536 537 538
	}

	return 0;

err:
539
	rcu_read_unlock();
540 541 542
	return -ENOMEM;
}

543
static int batadv_orig_node_del_if(struct batadv_orig_node *orig_node,
544
				   int max_if_num, int del_if_num)
545 546 547 548 549 550 551 552
{
	void *data_ptr = NULL;
	int chunk_size;

	/* last interface was removed */
	if (max_if_num == 0)
		goto free_bcast_own;

553
	chunk_size = sizeof(unsigned long) * BATADV_NUM_WORDS;
554
	data_ptr = kmalloc(max_if_num * chunk_size, GFP_ATOMIC);
555
	if (!data_ptr)
556
		return -ENOMEM;
557 558 559 560 561

	/* copy first part */
	memcpy(data_ptr, orig_node->bcast_own, del_if_num * chunk_size);

	/* copy second part */
562
	memcpy((char *)data_ptr + del_if_num * chunk_size,
563 564 565 566 567 568 569 570 571 572 573
	       orig_node->bcast_own + ((del_if_num + 1) * chunk_size),
	       (max_if_num - del_if_num) * chunk_size);

free_bcast_own:
	kfree(orig_node->bcast_own);
	orig_node->bcast_own = data_ptr;

	if (max_if_num == 0)
		goto free_own_sum;

	data_ptr = kmalloc(max_if_num * sizeof(uint8_t), GFP_ATOMIC);
574
	if (!data_ptr)
575
		return -ENOMEM;
576 577 578 579

	memcpy(data_ptr, orig_node->bcast_own_sum,
	       del_if_num * sizeof(uint8_t));

580
	memcpy((char *)data_ptr + del_if_num * sizeof(uint8_t),
581 582 583 584 585 586 587 588 589 590
	       orig_node->bcast_own_sum + ((del_if_num + 1) * sizeof(uint8_t)),
	       (max_if_num - del_if_num) * sizeof(uint8_t));

free_own_sum:
	kfree(orig_node->bcast_own_sum);
	orig_node->bcast_own_sum = data_ptr;

	return 0;
}

591 592
int batadv_orig_hash_del_if(struct batadv_hard_iface *hard_iface,
			    int max_if_num)
593
{
594
	struct batadv_priv *bat_priv = netdev_priv(hard_iface->soft_iface);
595
	struct batadv_hashtable *hash = bat_priv->orig_hash;
596
	struct hlist_head *head;
597 598
	struct batadv_hard_iface *hard_iface_tmp;
	struct batadv_orig_node *orig_node;
599 600
	uint32_t i;
	int ret;
601 602

	/* resize all orig nodes because orig_node->bcast_own(_sum) depend on
603 604
	 * if_num
	 */
605 606 607
	for (i = 0; i < hash->size; i++) {
		head = &hash->table[i];

608
		rcu_read_lock();
609
		hlist_for_each_entry_rcu(orig_node, head, hash_entry) {
610
			spin_lock_bh(&orig_node->ogm_cnt_lock);
611 612
			ret = batadv_orig_node_del_if(orig_node, max_if_num,
						      hard_iface->if_num);
613
			spin_unlock_bh(&orig_node->ogm_cnt_lock);
614

615
			if (ret == -ENOMEM)
616 617
				goto err;
		}
618
		rcu_read_unlock();
619 620 621 622
	}

	/* renumber remaining batman interfaces _inside_ of orig_hash_lock */
	rcu_read_lock();
623
	list_for_each_entry_rcu(hard_iface_tmp, &batadv_hardif_list, list) {
624
		if (hard_iface_tmp->if_status == BATADV_IF_NOT_IN_USE)
625 626
			continue;

627
		if (hard_iface == hard_iface_tmp)
628 629
			continue;

630
		if (hard_iface->soft_iface != hard_iface_tmp->soft_iface)
631 632
			continue;

633 634
		if (hard_iface_tmp->if_num > hard_iface->if_num)
			hard_iface_tmp->if_num--;
635 636 637
	}
	rcu_read_unlock();

638
	hard_iface->if_num = -1;
639 640 641
	return 0;

err:
642
	rcu_read_unlock();
643 644
	return -ENOMEM;
}