intel_lvds.c 31.5 KB
Newer Older
J
Jesse Barnes 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29
/*
 * Copyright © 2006-2007 Intel Corporation
 * Copyright (c) 2006 Dave Airlie <airlied@linux.ie>
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 * DEALINGS IN THE SOFTWARE.
 *
 * Authors:
 *	Eric Anholt <eric@anholt.net>
 *      Dave Airlie <airlied@linux.ie>
 *      Jesse Barnes <jesse.barnes@intel.com>
 */

30
#include <acpi/button.h>
31
#include <linux/dmi.h>
J
Jesse Barnes 已提交
32
#include <linux/i2c.h>
33
#include <linux/slab.h>
J
Jesse Barnes 已提交
34 35 36 37 38 39 40
#include "drmP.h"
#include "drm.h"
#include "drm_crtc.h"
#include "drm_edid.h"
#include "intel_drv.h"
#include "i915_drm.h"
#include "i915_drv.h"
41
#include <linux/acpi.h>
J
Jesse Barnes 已提交
42

43
/* Private structure for the integrated LVDS support */
C
Chris Wilson 已提交
44 45
struct intel_lvds {
	struct intel_encoder base;
46

C
Chris Wilson 已提交
47
	struct edid *edid;
48

49 50 51
	int fitting_mode;
	u32 pfit_control;
	u32 pfit_pgm_ratios;
52
	bool pfit_dirty;
53 54

	struct drm_display_mode *fixed_mode;
55 56
};

57
static struct intel_lvds *to_intel_lvds(struct drm_encoder *encoder)
C
Chris Wilson 已提交
58
{
59
	return container_of(encoder, struct intel_lvds, base.base);
C
Chris Wilson 已提交
60 61
}

62 63 64 65 66 67
static struct intel_lvds *intel_attached_lvds(struct drm_connector *connector)
{
	return container_of(intel_attached_encoder(connector),
			    struct intel_lvds, base);
}

68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93
static bool intel_lvds_get_hw_state(struct intel_encoder *encoder,
				    enum pipe *pipe)
{
	struct drm_device *dev = encoder->base.dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
	u32 lvds_reg, tmp;

	if (HAS_PCH_SPLIT(dev)) {
		lvds_reg = PCH_LVDS;
	} else {
		lvds_reg = LVDS;
	}

	tmp = I915_READ(lvds_reg);

	if (!(tmp & LVDS_PORT_EN))
		return false;

	if (HAS_PCH_CPT(dev))
		*pipe = PORT_TO_PIPE_CPT(tmp);
	else
		*pipe = PORT_TO_PIPE(tmp);

	return true;
}

J
Jesse Barnes 已提交
94 95 96
/**
 * Sets the power state for the panel.
 */
97
static void intel_enable_lvds(struct intel_encoder *encoder)
J
Jesse Barnes 已提交
98
{
99 100 101
	struct drm_device *dev = encoder->base.dev;
	struct intel_lvds *intel_lvds = to_intel_lvds(&encoder->base);
	struct intel_crtc *intel_crtc = to_intel_crtc(encoder->base.crtc);
J
Jesse Barnes 已提交
102
	struct drm_i915_private *dev_priv = dev->dev_private;
103
	u32 ctl_reg, lvds_reg, stat_reg;
104

105
	if (HAS_PCH_SPLIT(dev)) {
106
		ctl_reg = PCH_PP_CONTROL;
107
		lvds_reg = PCH_LVDS;
108
		stat_reg = PCH_PP_STATUS;
109 110
	} else {
		ctl_reg = PP_CONTROL;
111
		lvds_reg = LVDS;
112
		stat_reg = PP_STATUS;
113
	}
J
Jesse Barnes 已提交
114

115
	I915_WRITE(lvds_reg, I915_READ(lvds_reg) | LVDS_PORT_EN);
116

117 118 119 120 121 122 123 124 125 126
	if (intel_lvds->pfit_dirty) {
		/*
		 * Enable automatic panel scaling so that non-native modes
		 * fill the screen.  The panel fitter should only be
		 * adjusted whilst the pipe is disabled, according to
		 * register description and PRM.
		 */
		DRM_DEBUG_KMS("applying panel-fitter: %x, %x\n",
			      intel_lvds->pfit_control,
			      intel_lvds->pfit_pgm_ratios);
127 128 129 130

		I915_WRITE(PFIT_PGM_RATIOS, intel_lvds->pfit_pgm_ratios);
		I915_WRITE(PFIT_CONTROL, intel_lvds->pfit_control);
		intel_lvds->pfit_dirty = false;
131 132 133 134
	}

	I915_WRITE(ctl_reg, I915_READ(ctl_reg) | POWER_TARGET_ON);
	POSTING_READ(lvds_reg);
135 136
	if (wait_for((I915_READ(stat_reg) & PP_ON) != 0, 1000))
		DRM_ERROR("timed out waiting for panel to power on\n");
137

138
	intel_panel_enable_backlight(dev, intel_crtc->pipe);
139 140
}

141
static void intel_disable_lvds(struct intel_encoder *encoder)
142
{
143 144
	struct drm_device *dev = encoder->base.dev;
	struct intel_lvds *intel_lvds = to_intel_lvds(&encoder->base);
145
	struct drm_i915_private *dev_priv = dev->dev_private;
146
	u32 ctl_reg, lvds_reg, stat_reg;
147 148 149 150

	if (HAS_PCH_SPLIT(dev)) {
		ctl_reg = PCH_PP_CONTROL;
		lvds_reg = PCH_LVDS;
151
		stat_reg = PCH_PP_STATUS;
152 153 154
	} else {
		ctl_reg = PP_CONTROL;
		lvds_reg = LVDS;
155
		stat_reg = PP_STATUS;
156 157
	}

158
	intel_panel_disable_backlight(dev);
159 160

	I915_WRITE(ctl_reg, I915_READ(ctl_reg) & ~POWER_TARGET_ON);
161 162
	if (wait_for((I915_READ(stat_reg) & PP_ON) == 0, 1000))
		DRM_ERROR("timed out waiting for panel to power off\n");
163 164 165 166

	if (intel_lvds->pfit_control) {
		I915_WRITE(PFIT_CONTROL, 0);
		intel_lvds->pfit_dirty = true;
J
Jesse Barnes 已提交
167
	}
168 169

	I915_WRITE(lvds_reg, I915_READ(lvds_reg) & ~LVDS_PORT_EN);
170
	POSTING_READ(lvds_reg);
J
Jesse Barnes 已提交
171 172 173 174 175
}

static int intel_lvds_mode_valid(struct drm_connector *connector,
				 struct drm_display_mode *mode)
{
176 177
	struct intel_lvds *intel_lvds = intel_attached_lvds(connector);
	struct drm_display_mode *fixed_mode = intel_lvds->fixed_mode;
J
Jesse Barnes 已提交
178

179 180 181 182
	if (mode->hdisplay > fixed_mode->hdisplay)
		return MODE_PANEL;
	if (mode->vdisplay > fixed_mode->vdisplay)
		return MODE_PANEL;
J
Jesse Barnes 已提交
183 184 185 186

	return MODE_OK;
}

187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206
static void
centre_horizontally(struct drm_display_mode *mode,
		    int width)
{
	u32 border, sync_pos, blank_width, sync_width;

	/* keep the hsync and hblank widths constant */
	sync_width = mode->crtc_hsync_end - mode->crtc_hsync_start;
	blank_width = mode->crtc_hblank_end - mode->crtc_hblank_start;
	sync_pos = (blank_width - sync_width + 1) / 2;

	border = (mode->hdisplay - width + 1) / 2;
	border += border & 1; /* make the border even */

	mode->crtc_hdisplay = width;
	mode->crtc_hblank_start = width + border;
	mode->crtc_hblank_end = mode->crtc_hblank_start + blank_width;

	mode->crtc_hsync_start = mode->crtc_hblank_start + sync_pos;
	mode->crtc_hsync_end = mode->crtc_hsync_start + sync_width;
207 208

	mode->private_flags |= INTEL_MODE_CRTC_TIMINGS_SET;
209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229
}

static void
centre_vertically(struct drm_display_mode *mode,
		  int height)
{
	u32 border, sync_pos, blank_width, sync_width;

	/* keep the vsync and vblank widths constant */
	sync_width = mode->crtc_vsync_end - mode->crtc_vsync_start;
	blank_width = mode->crtc_vblank_end - mode->crtc_vblank_start;
	sync_pos = (blank_width - sync_width + 1) / 2;

	border = (mode->vdisplay - height + 1) / 2;

	mode->crtc_vdisplay = height;
	mode->crtc_vblank_start = height + border;
	mode->crtc_vblank_end = mode->crtc_vblank_start + blank_width;

	mode->crtc_vsync_start = mode->crtc_vblank_start + sync_pos;
	mode->crtc_vsync_end = mode->crtc_vsync_start + sync_width;
230 231

	mode->private_flags |= INTEL_MODE_CRTC_TIMINGS_SET;
232 233 234 235 236 237 238 239 240 241 242 243 244 245 246
}

static inline u32 panel_fitter_scaling(u32 source, u32 target)
{
	/*
	 * Floating point operation is not supported. So the FACTOR
	 * is defined, which can avoid the floating point computation
	 * when calculating the panel ratio.
	 */
#define ACCURACY 12
#define FACTOR (1 << ACCURACY)
	u32 ratio = source * FACTOR / target;
	return (FACTOR * ratio + FACTOR/2) / FACTOR;
}

J
Jesse Barnes 已提交
247
static bool intel_lvds_mode_fixup(struct drm_encoder *encoder,
248
				  const struct drm_display_mode *mode,
J
Jesse Barnes 已提交
249 250 251 252
				  struct drm_display_mode *adjusted_mode)
{
	struct drm_device *dev = encoder->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
253
	struct intel_lvds *intel_lvds = to_intel_lvds(encoder);
254
	struct intel_crtc *intel_crtc = intel_lvds->base.new_crtc;
255
	u32 pfit_control = 0, pfit_pgm_ratios = 0, border = 0;
256
	int pipe;
J
Jesse Barnes 已提交
257 258

	/* Should never happen!! */
259
	if (INTEL_INFO(dev)->gen < 4 && intel_crtc->pipe == 0) {
260
		DRM_ERROR("Can't support LVDS on pipe A\n");
J
Jesse Barnes 已提交
261 262 263
		return false;
	}

264 265
	if (intel_encoder_check_is_cloned(&intel_lvds->base))
		return false;
266

J
Jesse Barnes 已提交
267
	/*
268
	 * We have timings from the BIOS for the panel, put them in
J
Jesse Barnes 已提交
269 270 271 272
	 * to the adjusted mode.  The CRTC will be set up for this mode,
	 * with the panel scaling set up to source from the H/VDisplay
	 * of the original mode.
	 */
273
	intel_fixed_panel_mode(intel_lvds->fixed_mode, adjusted_mode);
274 275 276 277 278 279

	if (HAS_PCH_SPLIT(dev)) {
		intel_pch_panel_fitting(dev, intel_lvds->fitting_mode,
					mode, adjusted_mode);
		return true;
	}
J
Jesse Barnes 已提交
280

281 282
	/* Native modes don't need fitting */
	if (adjusted_mode->hdisplay == mode->hdisplay &&
283
	    adjusted_mode->vdisplay == mode->vdisplay)
284 285 286
		goto out;

	/* 965+ wants fuzzy fitting */
287
	if (INTEL_INFO(dev)->gen >= 4)
288 289 290
		pfit_control |= ((intel_crtc->pipe << PFIT_PIPE_SHIFT) |
				 PFIT_FILTER_FUZZY);

291 292 293 294 295 296
	/*
	 * Enable automatic panel scaling for non-native modes so that they fill
	 * the screen.  Should be enabled before the pipe is enabled, according
	 * to register description and PRM.
	 * Change the value here to see the borders for debugging
	 */
297 298
	for_each_pipe(pipe)
		I915_WRITE(BCLRPAT(pipe), 0);
299

300 301
	drm_mode_set_crtcinfo(adjusted_mode, 0);

C
Chris Wilson 已提交
302
	switch (intel_lvds->fitting_mode) {
303
	case DRM_MODE_SCALE_CENTER:
304 305 306 307
		/*
		 * For centered modes, we have to calculate border widths &
		 * heights and modify the values programmed into the CRTC.
		 */
308 309 310
		centre_horizontally(adjusted_mode, mode->hdisplay);
		centre_vertically(adjusted_mode, mode->vdisplay);
		border = LVDS_BORDER_ENABLE;
311
		break;
312

313
	case DRM_MODE_SCALE_ASPECT:
314
		/* Scale but preserve the aspect ratio */
315
		if (INTEL_INFO(dev)->gen >= 4) {
316 317 318
			u32 scaled_width = adjusted_mode->hdisplay * mode->vdisplay;
			u32 scaled_height = mode->hdisplay * adjusted_mode->vdisplay;

319
			/* 965+ is easy, it does everything in hw */
320
			if (scaled_width > scaled_height)
321
				pfit_control |= PFIT_ENABLE | PFIT_SCALING_PILLAR;
322
			else if (scaled_width < scaled_height)
323 324 325
				pfit_control |= PFIT_ENABLE | PFIT_SCALING_LETTER;
			else if (adjusted_mode->hdisplay != mode->hdisplay)
				pfit_control |= PFIT_ENABLE | PFIT_SCALING_AUTO;
326
		} else {
327 328
			u32 scaled_width = adjusted_mode->hdisplay * mode->vdisplay;
			u32 scaled_height = mode->hdisplay * adjusted_mode->vdisplay;
329 330 331 332 333
			/*
			 * For earlier chips we have to calculate the scaling
			 * ratio by hand and program it into the
			 * PFIT_PGM_RATIO register
			 */
334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361
			if (scaled_width > scaled_height) { /* pillar */
				centre_horizontally(adjusted_mode, scaled_height / mode->vdisplay);

				border = LVDS_BORDER_ENABLE;
				if (mode->vdisplay != adjusted_mode->vdisplay) {
					u32 bits = panel_fitter_scaling(mode->vdisplay, adjusted_mode->vdisplay);
					pfit_pgm_ratios |= (bits << PFIT_HORIZ_SCALE_SHIFT |
							    bits << PFIT_VERT_SCALE_SHIFT);
					pfit_control |= (PFIT_ENABLE |
							 VERT_INTERP_BILINEAR |
							 HORIZ_INTERP_BILINEAR);
				}
			} else if (scaled_width < scaled_height) { /* letter */
				centre_vertically(adjusted_mode, scaled_width / mode->hdisplay);

				border = LVDS_BORDER_ENABLE;
				if (mode->hdisplay != adjusted_mode->hdisplay) {
					u32 bits = panel_fitter_scaling(mode->hdisplay, adjusted_mode->hdisplay);
					pfit_pgm_ratios |= (bits << PFIT_HORIZ_SCALE_SHIFT |
							    bits << PFIT_VERT_SCALE_SHIFT);
					pfit_control |= (PFIT_ENABLE |
							 VERT_INTERP_BILINEAR |
							 HORIZ_INTERP_BILINEAR);
				}
			} else
				/* Aspects match, Let hw scale both directions */
				pfit_control |= (PFIT_ENABLE |
						 VERT_AUTO_SCALE | HORIZ_AUTO_SCALE |
362 363 364 365 366 367 368 369 370 371
						 VERT_INTERP_BILINEAR |
						 HORIZ_INTERP_BILINEAR);
		}
		break;

	case DRM_MODE_SCALE_FULLSCREEN:
		/*
		 * Full scaling, even if it changes the aspect ratio.
		 * Fortunately this is all done for us in hw.
		 */
372 373 374 375 376 377 378 379 380 381 382
		if (mode->vdisplay != adjusted_mode->vdisplay ||
		    mode->hdisplay != adjusted_mode->hdisplay) {
			pfit_control |= PFIT_ENABLE;
			if (INTEL_INFO(dev)->gen >= 4)
				pfit_control |= PFIT_SCALING_AUTO;
			else
				pfit_control |= (VERT_AUTO_SCALE |
						 VERT_INTERP_BILINEAR |
						 HORIZ_AUTO_SCALE |
						 HORIZ_INTERP_BILINEAR);
		}
383
		break;
384

385 386 387 388 389
	default:
		break;
	}

out:
390
	/* If not enabling scaling, be consistent and always use 0. */
391 392 393 394
	if ((pfit_control & PFIT_ENABLE) == 0) {
		pfit_control = 0;
		pfit_pgm_ratios = 0;
	}
395 396 397 398 399

	/* Make sure pre-965 set dither correctly */
	if (INTEL_INFO(dev)->gen < 4 && dev_priv->lvds_dither)
		pfit_control |= PANEL_8TO6_DITHER_ENABLE;

400 401 402 403 404 405
	if (pfit_control != intel_lvds->pfit_control ||
	    pfit_pgm_ratios != intel_lvds->pfit_pgm_ratios) {
		intel_lvds->pfit_control = pfit_control;
		intel_lvds->pfit_pgm_ratios = pfit_pgm_ratios;
		intel_lvds->pfit_dirty = true;
	}
406 407
	dev_priv->lvds_border_bits = border;

J
Jesse Barnes 已提交
408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430
	/*
	 * XXX: It would be nice to support lower refresh rates on the
	 * panels to reduce power consumption, and perhaps match the
	 * user's requested refresh rate.
	 */

	return true;
}

static void intel_lvds_mode_set(struct drm_encoder *encoder,
				struct drm_display_mode *mode,
				struct drm_display_mode *adjusted_mode)
{
	/*
	 * The LVDS pin pair will already have been turned on in the
	 * intel_crtc_mode_set since it has a large impact on the DPLL
	 * settings.
	 */
}

/**
 * Detect the LVDS connection.
 *
431 432 433
 * Since LVDS doesn't have hotlug, we use the lid as a proxy.  Open means
 * connected and closed means disconnected.  We also send hotplug events as
 * needed, using lid status notification from the input layer.
J
Jesse Barnes 已提交
434
 */
435
static enum drm_connector_status
436
intel_lvds_detect(struct drm_connector *connector, bool force)
J
Jesse Barnes 已提交
437
{
438
	struct drm_device *dev = connector->dev;
439
	enum drm_connector_status status;
440

441 442 443
	status = intel_panel_detect(dev);
	if (status != connector_status_unknown)
		return status;
444

445
	return connector_status_connected;
J
Jesse Barnes 已提交
446 447 448 449 450 451 452
}

/**
 * Return the list of DDC modes if available, or the BIOS fixed mode otherwise.
 */
static int intel_lvds_get_modes(struct drm_connector *connector)
{
453
	struct intel_lvds *intel_lvds = intel_attached_lvds(connector);
J
Jesse Barnes 已提交
454
	struct drm_device *dev = connector->dev;
455
	struct drm_display_mode *mode;
J
Jesse Barnes 已提交
456

457
	if (intel_lvds->edid)
C
Chris Wilson 已提交
458
		return drm_add_edid_modes(connector, intel_lvds->edid);
J
Jesse Barnes 已提交
459

460
	mode = drm_mode_duplicate(dev, intel_lvds->fixed_mode);
C
Chris Wilson 已提交
461
	if (mode == NULL)
462
		return 0;
J
Jesse Barnes 已提交
463

464 465
	drm_mode_probed_add(connector, mode);
	return 1;
J
Jesse Barnes 已提交
466 467
}

468 469
static int intel_no_modeset_on_lid_dmi_callback(const struct dmi_system_id *id)
{
470
	DRM_INFO("Skipping forced modeset for %s\n", id->ident);
471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487
	return 1;
}

/* The GPU hangs up on these systems if modeset is performed on LID open */
static const struct dmi_system_id intel_no_modeset_on_lid[] = {
	{
		.callback = intel_no_modeset_on_lid_dmi_callback,
		.ident = "Toshiba Tecra A11",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
			DMI_MATCH(DMI_PRODUCT_NAME, "TECRA A11"),
		},
	},

	{ }	/* terminating entry */
};

488 489 490 491 492 493 494 495 496
/*
 * Lid events. Note the use of 'modeset_on_lid':
 *  - we set it on lid close, and reset it on open
 *  - we use it as a "only once" bit (ie we ignore
 *    duplicate events where it was already properly
 *    set/reset)
 *  - the suspend/resume paths will also set it to
 *    zero, since they restore the mode ("lid open").
 */
497 498 499 500 501 502
static int intel_lid_notify(struct notifier_block *nb, unsigned long val,
			    void *unused)
{
	struct drm_i915_private *dev_priv =
		container_of(nb, struct drm_i915_private, lid_notifier);
	struct drm_device *dev = dev_priv->dev;
503
	struct drm_connector *connector = dev_priv->int_lvds_connector;
504

505 506 507
	if (dev->switch_power_state != DRM_SWITCH_POWER_ON)
		return NOTIFY_OK;

508 509 510 511 512
	/*
	 * check and update the status of LVDS connector after receiving
	 * the LID nofication event.
	 */
	if (connector)
513
		connector->status = connector->funcs->detect(connector,
514
							     false);
515

516 517 518
	/* Don't force modeset on machines where it causes a GPU lockup */
	if (dmi_check_system(intel_no_modeset_on_lid))
		return NOTIFY_OK;
519 520 521
	if (!acpi_lid_open()) {
		dev_priv->modeset_on_lid = 1;
		return NOTIFY_OK;
522
	}
523

524 525 526 527 528 529
	if (!dev_priv->modeset_on_lid)
		return NOTIFY_OK;

	dev_priv->modeset_on_lid = 0;

	mutex_lock(&dev->mode_config.mutex);
D
Daniel Vetter 已提交
530
	intel_modeset_check_state(dev);
531
	mutex_unlock(&dev->mode_config.mutex);
532

533 534 535
	return NOTIFY_OK;
}

J
Jesse Barnes 已提交
536 537 538 539 540 541 542 543 544
/**
 * intel_lvds_destroy - unregister and free LVDS structures
 * @connector: connector to free
 *
 * Unregister the DDC bus for this connector then free the driver private
 * structure.
 */
static void intel_lvds_destroy(struct drm_connector *connector)
{
545 546
	struct drm_device *dev = connector->dev;
	struct drm_i915_private *dev_priv = dev->dev_private;
J
Jesse Barnes 已提交
547

548 549
	intel_panel_destroy_backlight(dev);

550 551
	if (dev_priv->lid_notifier.notifier_call)
		acpi_lid_notifier_unregister(&dev_priv->lid_notifier);
J
Jesse Barnes 已提交
552 553 554 555 556
	drm_sysfs_connector_remove(connector);
	drm_connector_cleanup(connector);
	kfree(connector);
}

557 558 559 560
static int intel_lvds_set_property(struct drm_connector *connector,
				   struct drm_property *property,
				   uint64_t value)
{
561
	struct intel_lvds *intel_lvds = intel_attached_lvds(connector);
562 563
	struct drm_device *dev = connector->dev;

564 565
	if (property == dev->mode_config.scaling_mode_property) {
		struct drm_crtc *crtc = intel_lvds->base.base.crtc;
566

567 568
		if (value == DRM_MODE_SCALE_NONE) {
			DRM_DEBUG_KMS("no scaling not supported\n");
569
			return -EINVAL;
570
		}
571

C
Chris Wilson 已提交
572
		if (intel_lvds->fitting_mode == value) {
573 574 575
			/* the LVDS scaling property is not changed */
			return 0;
		}
C
Chris Wilson 已提交
576
		intel_lvds->fitting_mode = value;
577 578 579 580 581
		if (crtc && crtc->enabled) {
			/*
			 * If the CRTC is enabled, the display will be changed
			 * according to the new panel fitting mode.
			 */
582 583
			intel_set_mode(crtc, &crtc->mode,
				       crtc->x, crtc->y, crtc->fb);
584 585 586
		}
	}

587 588 589
	return 0;
}

J
Jesse Barnes 已提交
590 591 592
static const struct drm_encoder_helper_funcs intel_lvds_helper_funcs = {
	.mode_fixup = intel_lvds_mode_fixup,
	.mode_set = intel_lvds_mode_set,
593
	.disable = intel_encoder_noop,
J
Jesse Barnes 已提交
594 595 596 597 598
};

static const struct drm_connector_helper_funcs intel_lvds_connector_helper_funcs = {
	.get_modes = intel_lvds_get_modes,
	.mode_valid = intel_lvds_mode_valid,
599
	.best_encoder = intel_best_encoder,
J
Jesse Barnes 已提交
600 601 602
};

static const struct drm_connector_funcs intel_lvds_connector_funcs = {
603
	.dpms = intel_connector_dpms,
J
Jesse Barnes 已提交
604 605
	.detect = intel_lvds_detect,
	.fill_modes = drm_helper_probe_single_connector_modes,
606
	.set_property = intel_lvds_set_property,
J
Jesse Barnes 已提交
607 608 609 610
	.destroy = intel_lvds_destroy,
};

static const struct drm_encoder_funcs intel_lvds_enc_funcs = {
C
Chris Wilson 已提交
611
	.destroy = intel_encoder_destroy,
J
Jesse Barnes 已提交
612 613
};

614 615
static int __init intel_no_lvds_dmi_callback(const struct dmi_system_id *id)
{
616
	DRM_INFO("Skipping LVDS initialization for %s\n", id->ident);
617 618
	return 1;
}
J
Jesse Barnes 已提交
619

620
/* These systems claim to have LVDS, but really don't */
621
static const struct dmi_system_id intel_no_lvds[] = {
622 623 624 625
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Apple Mac Mini (Core series)",
		.matches = {
626
			DMI_MATCH(DMI_SYS_VENDOR, "Apple"),
627 628 629 630 631 632 633
			DMI_MATCH(DMI_PRODUCT_NAME, "Macmini1,1"),
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Apple Mac Mini (Core 2 series)",
		.matches = {
634
			DMI_MATCH(DMI_SYS_VENDOR, "Apple"),
635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653
			DMI_MATCH(DMI_PRODUCT_NAME, "Macmini2,1"),
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "MSI IM-945GSE-A",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "MSI"),
			DMI_MATCH(DMI_PRODUCT_NAME, "A9830IMS"),
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Dell Studio Hybrid",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
			DMI_MATCH(DMI_PRODUCT_NAME, "Studio Hybrid 140g"),
		},
	},
654 655
	{
		.callback = intel_no_lvds_dmi_callback,
656 657 658 659 660 661 662 663
		.ident = "Dell OptiPlex FX170",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
			DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex FX170"),
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
664 665 666 667 668 669
		.ident = "AOpen Mini PC",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "AOpen"),
			DMI_MATCH(DMI_PRODUCT_NAME, "i965GMx-IF"),
		},
	},
670 671 672 673 674 675 676 677
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "AOpen Mini PC MP915",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "AOpen"),
			DMI_MATCH(DMI_BOARD_NAME, "i915GMx-F"),
		},
	},
678 679 680 681 682 683 684 685
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "AOpen i915GMm-HFS",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "AOpen"),
			DMI_MATCH(DMI_BOARD_NAME, "i915GMm-HFS"),
		},
	},
686 687 688 689 690 691 692 693
	{
		.callback = intel_no_lvds_dmi_callback,
                .ident = "AOpen i45GMx-I",
                .matches = {
                        DMI_MATCH(DMI_BOARD_VENDOR, "AOpen"),
                        DMI_MATCH(DMI_BOARD_NAME, "i45GMx-I"),
                },
        },
694 695 696 697 698 699 700
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Aopen i945GTt-VFA",
		.matches = {
			DMI_MATCH(DMI_PRODUCT_VERSION, "AO00001JW"),
		},
	},
701 702 703 704 705 706 707 708
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Clientron U800",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "Clientron"),
			DMI_MATCH(DMI_PRODUCT_NAME, "U800"),
		},
	},
709
	{
710 711 712 713 714 715 716 717
                .callback = intel_no_lvds_dmi_callback,
                .ident = "Clientron E830",
                .matches = {
                        DMI_MATCH(DMI_SYS_VENDOR, "Clientron"),
                        DMI_MATCH(DMI_PRODUCT_NAME, "E830"),
                },
        },
        {
718 719 720 721 722 723 724
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Asus EeeBox PC EB1007",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK Computer INC."),
			DMI_MATCH(DMI_PRODUCT_NAME, "EB1007"),
		},
	},
725 726 727 728 729 730 731 732
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Asus AT5NM10T-I",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
			DMI_MATCH(DMI_BOARD_NAME, "AT5NM10T-I"),
		},
	},
733 734 735 736 737 738 739 740
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Hewlett-Packard HP t5740e Thin Client",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
			DMI_MATCH(DMI_PRODUCT_NAME, "HP t5740e Thin Client"),
		},
	},
741 742 743 744 745
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Hewlett-Packard t5745",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
746
			DMI_MATCH(DMI_PRODUCT_NAME, "hp t5745"),
747 748 749 750 751 752 753
		},
	},
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Hewlett-Packard st5747",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
754
			DMI_MATCH(DMI_PRODUCT_NAME, "hp st5747"),
755 756
		},
	},
757 758 759 760 761 762 763 764
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "MSI Wind Box DC500",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "MICRO-STAR INTERNATIONAL CO., LTD"),
			DMI_MATCH(DMI_BOARD_NAME, "MS-7469"),
		},
	},
765 766 767 768 769 770 771 772
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "ZOTAC ZBOXSD-ID12/ID13",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "ZOTAC"),
			DMI_MATCH(DMI_BOARD_NAME, "ZBOXSD-ID12/ID13"),
		},
	},
773 774 775 776 777 778 779 780
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Gigabyte GA-D525TUD",
		.matches = {
			DMI_MATCH(DMI_BOARD_VENDOR, "Gigabyte Technology Co., Ltd."),
			DMI_MATCH(DMI_BOARD_NAME, "D525TUD"),
		},
	},
781 782 783 784 785 786 787 788
	{
		.callback = intel_no_lvds_dmi_callback,
		.ident = "Supermicro X7SPA-H",
		.matches = {
			DMI_MATCH(DMI_SYS_VENDOR, "Supermicro"),
			DMI_MATCH(DMI_PRODUCT_NAME, "X7SPA-H"),
		},
	},
789 790 791

	{ }	/* terminating entry */
};
J
Jesse Barnes 已提交
792

793 794 795 796 797 798 799 800
/**
 * intel_find_lvds_downclock - find the reduced downclock for LVDS in EDID
 * @dev: drm device
 * @connector: LVDS connector
 *
 * Find the reduced downclock for LVDS in EDID.
 */
static void intel_find_lvds_downclock(struct drm_device *dev,
801 802
				      struct drm_display_mode *fixed_mode,
				      struct drm_connector *connector)
803 804
{
	struct drm_i915_private *dev_priv = dev->dev_private;
805
	struct drm_display_mode *scan;
806 807
	int temp_downclock;

808
	temp_downclock = fixed_mode->clock;
809 810 811 812 813 814 815 816
	list_for_each_entry(scan, &connector->probed_modes, head) {
		/*
		 * If one mode has the same resolution with the fixed_panel
		 * mode while they have the different refresh rate, it means
		 * that the reduced downclock is found for the LVDS. In such
		 * case we can set the different FPx0/1 to dynamically select
		 * between low and high frequency.
		 */
817 818 819 820 821 822 823 824
		if (scan->hdisplay == fixed_mode->hdisplay &&
		    scan->hsync_start == fixed_mode->hsync_start &&
		    scan->hsync_end == fixed_mode->hsync_end &&
		    scan->htotal == fixed_mode->htotal &&
		    scan->vdisplay == fixed_mode->vdisplay &&
		    scan->vsync_start == fixed_mode->vsync_start &&
		    scan->vsync_end == fixed_mode->vsync_end &&
		    scan->vtotal == fixed_mode->vtotal) {
825 826 827 828 829 830 831 832 833
			if (scan->clock < temp_downclock) {
				/*
				 * The downclock is already found. But we
				 * expect to find the lower downclock.
				 */
				temp_downclock = scan->clock;
			}
		}
	}
834
	if (temp_downclock < fixed_mode->clock && i915_lvds_downclock) {
835 836 837 838
		/* We found the downclock for LVDS. */
		dev_priv->lvds_downclock_avail = 1;
		dev_priv->lvds_downclock = temp_downclock;
		DRM_DEBUG_KMS("LVDS downclock is found in EDID. "
839 840
			      "Normal clock %dKhz, downclock %dKhz\n",
			      fixed_mode->clock, temp_downclock);
841 842 843
	}
}

844 845 846 847 848 849 850
/*
 * Enumerate the child dev array parsed from VBT to check whether
 * the LVDS is present.
 * If it is present, return 1.
 * If it is not present, return false.
 * If no child dev is parsed from VBT, it assumes that the LVDS is present.
 */
851 852
static bool lvds_is_present_in_vbt(struct drm_device *dev,
				   u8 *i2c_pin)
853 854
{
	struct drm_i915_private *dev_priv = dev->dev_private;
855
	int i;
856 857

	if (!dev_priv->child_dev_num)
858
		return true;
859 860

	for (i = 0; i < dev_priv->child_dev_num; i++) {
861 862 863 864 865
		struct child_device_config *child = dev_priv->child_dev + i;

		/* If the device type is not LFP, continue.
		 * We have to check both the new identifiers as well as the
		 * old for compatibility with some BIOSes.
866
		 */
867 868
		if (child->device_type != DEVICE_TYPE_INT_LFP &&
		    child->device_type != DEVICE_TYPE_LFP)
869 870
			continue;

871 872
		if (intel_gmbus_is_port_valid(child->i2c_pin))
			*i2c_pin = child->i2c_pin;
873

874 875 876 877
		/* However, we cannot trust the BIOS writers to populate
		 * the VBT correctly.  Since LVDS requires additional
		 * information from AIM blocks, a non-zero addin offset is
		 * a good indicator that the LVDS is actually present.
878
		 */
879 880 881 882 883 884 885 886 887 888
		if (child->addin_offset)
			return true;

		/* But even then some BIOS writers perform some black magic
		 * and instantiate the device without reference to any
		 * additional data.  Trust that if the VBT was written into
		 * the OpRegion then they have validated the LVDS's existence.
		 */
		if (dev_priv->opregion.vbt)
			return true;
889
	}
890 891

	return false;
892 893
}

894 895 896 897 898 899 900 901 902 903 904 905
static bool intel_lvds_supported(struct drm_device *dev)
{
	/* With the introduction of the PCH we gained a dedicated
	 * LVDS presence pin, use it. */
	if (HAS_PCH_SPLIT(dev))
		return true;

	/* Otherwise LVDS was only attached to mobile products,
	 * except for the inglorious 830gm */
	return IS_MOBILE(dev) && !IS_I830(dev);
}

J
Jesse Barnes 已提交
906 907 908 909 910 911 912
/**
 * intel_lvds_init - setup LVDS connectors on this device
 * @dev: drm device
 *
 * Create the connector, register the LVDS DDC bus, and try to figure out what
 * modes we can display on the LVDS panel (if present).
 */
913
bool intel_lvds_init(struct drm_device *dev)
J
Jesse Barnes 已提交
914 915
{
	struct drm_i915_private *dev_priv = dev->dev_private;
C
Chris Wilson 已提交
916
	struct intel_lvds *intel_lvds;
917
	struct intel_encoder *intel_encoder;
918
	struct intel_connector *intel_connector;
J
Jesse Barnes 已提交
919 920 921 922 923
	struct drm_connector *connector;
	struct drm_encoder *encoder;
	struct drm_display_mode *scan; /* *modes, *bios_mode; */
	struct drm_crtc *crtc;
	u32 lvds;
924 925
	int pipe;
	u8 pin;
J
Jesse Barnes 已提交
926

927 928 929
	if (!intel_lvds_supported(dev))
		return false;

930 931
	/* Skip init on machines we know falsely report LVDS */
	if (dmi_check_system(intel_no_lvds))
932
		return false;
933

934 935
	pin = GMBUS_PORT_PANEL;
	if (!lvds_is_present_in_vbt(dev, &pin)) {
936
		DRM_DEBUG_KMS("LVDS is not present in VBT\n");
937
		return false;
A
Adam Jackson 已提交
938
	}
939

940
	if (HAS_PCH_SPLIT(dev)) {
941
		if ((I915_READ(PCH_LVDS) & LVDS_DETECTED) == 0)
942
			return false;
943
		if (dev_priv->edp.support) {
944
			DRM_DEBUG_KMS("disable LVDS for eDP support\n");
945
			return false;
946
		}
947 948
	}

C
Chris Wilson 已提交
949 950
	intel_lvds = kzalloc(sizeof(struct intel_lvds), GFP_KERNEL);
	if (!intel_lvds) {
951
		return false;
J
Jesse Barnes 已提交
952 953
	}

954 955
	intel_connector = kzalloc(sizeof(struct intel_connector), GFP_KERNEL);
	if (!intel_connector) {
C
Chris Wilson 已提交
956
		kfree(intel_lvds);
957
		return false;
958 959
	}

960 961 962 963
	if (!HAS_PCH_SPLIT(dev)) {
		intel_lvds->pfit_control = I915_READ(PFIT_CONTROL);
	}

C
Chris Wilson 已提交
964
	intel_encoder = &intel_lvds->base;
965
	encoder = &intel_encoder->base;
C
Chris Wilson 已提交
966
	connector = &intel_connector->base;
967
	drm_connector_init(dev, &intel_connector->base, &intel_lvds_connector_funcs,
J
Jesse Barnes 已提交
968 969
			   DRM_MODE_CONNECTOR_LVDS);

970
	drm_encoder_init(dev, &intel_encoder->base, &intel_lvds_enc_funcs,
J
Jesse Barnes 已提交
971 972
			 DRM_MODE_ENCODER_LVDS);

973 974
	intel_encoder->enable = intel_enable_lvds;
	intel_encoder->disable = intel_disable_lvds;
975 976
	intel_encoder->get_hw_state = intel_lvds_get_hw_state;
	intel_connector->get_hw_state = intel_connector_get_hw_state;
977

978
	intel_connector_attach_encoder(intel_connector, intel_encoder);
979
	intel_encoder->type = INTEL_OUTPUT_LVDS;
J
Jesse Barnes 已提交
980

981
	intel_encoder->cloneable = false;
J
Jesse Barnes 已提交
982 983
	if (HAS_PCH_SPLIT(dev))
		intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
984 985
	else if (IS_GEN4(dev))
		intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
J
Jesse Barnes 已提交
986 987 988
	else
		intel_encoder->crtc_mask = (1 << 1);

J
Jesse Barnes 已提交
989 990 991 992 993 994
	drm_encoder_helper_add(encoder, &intel_lvds_helper_funcs);
	drm_connector_helper_add(connector, &intel_lvds_connector_helper_funcs);
	connector->display_info.subpixel_order = SubPixelHorizontalRGB;
	connector->interlace_allowed = false;
	connector->doublescan_allowed = false;

995 996 997 998 999
	/* create the scaling mode property */
	drm_mode_create_scaling_mode_property(dev);
	/*
	 * the initial panel fitting mode will be FULL_SCREEN.
	 */
J
Jesse Barnes 已提交
1000

1001
	drm_connector_attach_property(&intel_connector->base,
1002
				      dev->mode_config.scaling_mode_property,
1003
				      DRM_MODE_SCALE_ASPECT);
C
Chris Wilson 已提交
1004
	intel_lvds->fitting_mode = DRM_MODE_SCALE_ASPECT;
J
Jesse Barnes 已提交
1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018
	/*
	 * LVDS discovery:
	 * 1) check for EDID on DDC
	 * 2) check for VBT data
	 * 3) check to see if LVDS is already on
	 *    if none of the above, no panel
	 * 4) make sure lid is open
	 *    if closed, act like it's not there for now
	 */

	/*
	 * Attempt to get the fixed panel mode from DDC.  Assume that the
	 * preferred mode is the right one.
	 */
C
Chris Wilson 已提交
1019
	intel_lvds->edid = drm_get_edid(connector,
1020 1021
					intel_gmbus_get_adapter(dev_priv,
								pin));
1022 1023 1024 1025 1026 1027 1028 1029 1030 1031
	if (intel_lvds->edid) {
		if (drm_add_edid_modes(connector,
				       intel_lvds->edid)) {
			drm_mode_connector_update_edid_property(connector,
								intel_lvds->edid);
		} else {
			kfree(intel_lvds->edid);
			intel_lvds->edid = NULL;
		}
	}
C
Chris Wilson 已提交
1032
	if (!intel_lvds->edid) {
1033 1034 1035 1036 1037 1038 1039 1040 1041
		/* Didn't get an EDID, so
		 * Set wide sync ranges so we get all modes
		 * handed to valid_mode for checking
		 */
		connector->display_info.min_vfreq = 0;
		connector->display_info.max_vfreq = 200;
		connector->display_info.min_hfreq = 0;
		connector->display_info.max_hfreq = 200;
	}
J
Jesse Barnes 已提交
1042 1043 1044

	list_for_each_entry(scan, &connector->probed_modes, head) {
		if (scan->type & DRM_MODE_TYPE_PREFERRED) {
1045
			intel_lvds->fixed_mode =
J
Jesse Barnes 已提交
1046
				drm_mode_duplicate(dev, scan);
1047 1048 1049
			intel_find_lvds_downclock(dev,
						  intel_lvds->fixed_mode,
						  connector);
1050
			goto out;
J
Jesse Barnes 已提交
1051 1052 1053 1054
		}
	}

	/* Failed to get EDID, what about VBT? */
1055
	if (dev_priv->lfp_lvds_vbt_mode) {
1056
		intel_lvds->fixed_mode =
1057
			drm_mode_duplicate(dev, dev_priv->lfp_lvds_vbt_mode);
1058 1059
		if (intel_lvds->fixed_mode) {
			intel_lvds->fixed_mode->type |=
1060 1061 1062
				DRM_MODE_TYPE_PREFERRED;
			goto out;
		}
J
Jesse Barnes 已提交
1063 1064 1065 1066 1067 1068 1069
	}

	/*
	 * If we didn't get EDID, try checking if the panel is already turned
	 * on.  If so, assume that whatever is currently programmed is the
	 * correct mode.
	 */
1070

1071
	/* Ironlake: FIXME if still fail, not try pipe mode now */
1072
	if (HAS_PCH_SPLIT(dev))
1073 1074
		goto failed;

J
Jesse Barnes 已提交
1075 1076
	lvds = I915_READ(LVDS);
	pipe = (lvds & LVDS_PIPEB_SELECT) ? 1 : 0;
1077
	crtc = intel_get_crtc_for_pipe(dev, pipe);
J
Jesse Barnes 已提交
1078 1079

	if (crtc && (lvds & LVDS_PORT_EN)) {
1080 1081 1082
		intel_lvds->fixed_mode = intel_crtc_mode_get(dev, crtc);
		if (intel_lvds->fixed_mode) {
			intel_lvds->fixed_mode->type |=
J
Jesse Barnes 已提交
1083
				DRM_MODE_TYPE_PREFERRED;
1084
			goto out;
J
Jesse Barnes 已提交
1085 1086 1087 1088
		}
	}

	/* If we still don't have a mode after all that, give up. */
1089
	if (!intel_lvds->fixed_mode)
J
Jesse Barnes 已提交
1090 1091 1092
		goto failed;

out:
1093 1094 1095 1096
	/*
	 * Unlock registers and just
	 * leave them unlocked
	 */
1097
	if (HAS_PCH_SPLIT(dev)) {
1098 1099 1100 1101 1102
		I915_WRITE(PCH_PP_CONTROL,
			   I915_READ(PCH_PP_CONTROL) | PANEL_UNLOCK_REGS);
	} else {
		I915_WRITE(PP_CONTROL,
			   I915_READ(PP_CONTROL) | PANEL_UNLOCK_REGS);
1103
	}
1104 1105
	dev_priv->lid_notifier.notifier_call = intel_lid_notify;
	if (acpi_lid_notifier_register(&dev_priv->lid_notifier)) {
1106
		DRM_DEBUG_KMS("lid notifier registration failed\n");
1107 1108
		dev_priv->lid_notifier.notifier_call = NULL;
	}
1109 1110
	/* keep the LVDS connector */
	dev_priv->int_lvds_connector = connector;
J
Jesse Barnes 已提交
1111
	drm_sysfs_connector_add(connector);
1112 1113 1114

	intel_panel_setup_backlight(dev);

1115
	return true;
J
Jesse Barnes 已提交
1116 1117

failed:
1118
	DRM_DEBUG_KMS("No LVDS modes found, disabling.\n");
J
Jesse Barnes 已提交
1119
	drm_connector_cleanup(connector);
1120
	drm_encoder_cleanup(encoder);
C
Chris Wilson 已提交
1121
	kfree(intel_lvds);
1122
	kfree(intel_connector);
1123
	return false;
J
Jesse Barnes 已提交
1124
}