options.c 15.7 KB
Newer Older
1 2 3 4
/*
 *  net/dccp/options.c
 *
 *  An implementation of the DCCP protocol
I
Ian McDonald 已提交
5 6 7
 *  Copyright (c) 2005 Aristeu Sergio Rozanski Filho <aris@cathedrallabs.org>
 *  Copyright (c) 2005 Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
 *  Copyright (c) 2005 Ian McDonald <iam4@cs.waikato.ac.nz>
8 9 10 11 12 13 14 15 16 17 18 19 20
 *
 *      This program is free software; you can redistribute it and/or
 *      modify it under the terms of the GNU General Public License
 *      as published by the Free Software Foundation; either version
 *      2 of the License, or (at your option) any later version.
 */
#include <linux/config.h>
#include <linux/dccp.h>
#include <linux/module.h>
#include <linux/types.h>
#include <linux/kernel.h>
#include <linux/skbuff.h>

21
#include "ackvec.h"
22 23
#include "ccid.h"
#include "dccp.h"
24
#include "feat.h"
25

26 27 28 29 30 31
int dccp_feat_default_sequence_window = DCCPF_INITIAL_SEQUENCE_WINDOW;
int dccp_feat_default_rx_ccid	      = DCCPF_INITIAL_CCID;
int dccp_feat_default_tx_ccid	      = DCCPF_INITIAL_CCID;
int dccp_feat_default_ack_ratio	      = DCCPF_INITIAL_ACK_RATIO;
int dccp_feat_default_send_ack_vector = DCCPF_INITIAL_SEND_ACK_VECTOR;
int dccp_feat_default_send_ndp_count  = DCCPF_INITIAL_SEND_NDP_COUNT;
32 33 34

void dccp_options_init(struct dccp_options *dccpo)
{
35 36 37 38 39 40
	dccpo->dccpo_sequence_window = dccp_feat_default_sequence_window;
	dccpo->dccpo_rx_ccid	     = dccp_feat_default_rx_ccid;
	dccpo->dccpo_tx_ccid	     = dccp_feat_default_tx_ccid;
	dccpo->dccpo_ack_ratio	     = dccp_feat_default_ack_ratio;
	dccpo->dccpo_send_ack_vector = dccp_feat_default_send_ack_vector;
	dccpo->dccpo_send_ndp_count  = dccp_feat_default_send_ndp_count;
41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61
}

static u32 dccp_decode_value_var(const unsigned char *bf, const u8 len)
{
	u32 value = 0;

	if (len > 3)
		value += *bf++ << 24;
	if (len > 2)
		value += *bf++ << 16;
	if (len > 1)
		value += *bf++ << 8;
	if (len > 0)
		value += *bf;

	return value;
}

int dccp_parse_options(struct sock *sk, struct sk_buff *skb)
{
	struct dccp_sock *dp = dccp_sk(sk);
62
#ifdef CONFIG_IP_DCCP_DEBUG
63 64
	const char *debug_prefix = dp->dccps_role == DCCP_ROLE_CLIENT ?
					"CLIENT rx opt: " : "server rx opt: ";
65 66 67 68 69
#endif
	const struct dccp_hdr *dh = dccp_hdr(skb);
	const u8 pkt_type = DCCP_SKB_CB(skb)->dccpd_type;
	unsigned char *options = (unsigned char *)dh + dccp_hdr_len(skb);
	unsigned char *opt_ptr = options;
70 71
	const unsigned char *opt_end = (unsigned char *)dh +
					(dh->dccph_doff * 4);
72 73 74
	struct dccp_options_received *opt_recv = &dp->dccps_options_received;
	unsigned char opt, len;
	unsigned char *value;
75
	u32 elapsed_time;
76 77
	int rc;
	int mandatory = 0;
78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108

	memset(opt_recv, 0, sizeof(*opt_recv));

	while (opt_ptr != opt_end) {
		opt   = *opt_ptr++;
		len   = 0;
		value = NULL;

		/* Check if this isn't a single byte option */
		if (opt > DCCPO_MAX_RESERVED) {
			if (opt_ptr == opt_end)
				goto out_invalid_option;

			len = *opt_ptr++;
			if (len < 3)
				goto out_invalid_option;
			/*
			 * Remove the type and len fields, leaving
			 * just the value size
			 */
			len	-= 2;
			value	= opt_ptr;
			opt_ptr += len;

			if (opt_ptr > opt_end)
				goto out_invalid_option;
		}

		switch (opt) {
		case DCCPO_PADDING:
			break;
109 110 111
		case DCCPO_MANDATORY:
			if (mandatory)
				goto out_invalid_option;
112 113
			if (pkt_type != DCCP_PKT_DATA)
				mandatory = 1;
114
			break;
115 116 117 118 119
		case DCCPO_NDP_COUNT:
			if (len > 3)
				goto out_invalid_option;

			opt_recv->dccpor_ndp = dccp_decode_value_var(value, len);
120 121
			dccp_pr_debug("%sNDP count=%d\n", debug_prefix,
				      opt_recv->dccpor_ndp);
122
			break;
123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147
		case DCCPO_CHANGE_L:
			/* fall through */
		case DCCPO_CHANGE_R:
			if (len < 2)
				goto out_invalid_option;
			rc = dccp_feat_change_recv(sk, opt, *value, value + 1,
						   len - 1);
			/*
			 * When there is a change error, change_recv is
			 * responsible for dealing with it.  i.e. reply with an
			 * empty confirm.
			 * If the change was mandatory, then we need to die.
			 */
			if (rc && mandatory)
				goto out_invalid_option;
			break;
		case DCCPO_CONFIRM_L:
			/* fall through */
		case DCCPO_CONFIRM_R:
			if (len < 2)
				goto out_invalid_option;
			if (dccp_feat_confirm_recv(sk, opt, *value,
						   value + 1, len - 1))
				goto out_invalid_option;
			break;
148
		case DCCPO_ACK_VECTOR_0:
149
		case DCCPO_ACK_VECTOR_1:
150 151 152
			if (pkt_type == DCCP_PKT_DATA)
				continue;

153 154 155
			if (dp->dccps_options.dccpo_send_ack_vector &&
			    dccp_ackvec_parse(sk, skb, opt, value, len))
				goto out_invalid_option;
156 157 158 159 160
			break;
		case DCCPO_TIMESTAMP:
			if (len != 4)
				goto out_invalid_option;

161
			opt_recv->dccpor_timestamp = ntohl(*(__be32 *)value);
162 163

			dp->dccps_timestamp_echo = opt_recv->dccpor_timestamp;
164
			dccp_timestamp(sk, &dp->dccps_timestamp_time);
165 166 167

			dccp_pr_debug("%sTIMESTAMP=%u, ackno=%llu\n",
				      debug_prefix, opt_recv->dccpor_timestamp,
168
				      (unsigned long long)
169 170 171
				      DCCP_SKB_CB(skb)->dccpd_ack_seq);
			break;
		case DCCPO_TIMESTAMP_ECHO:
I
Ian McDonald 已提交
172
			if (len != 4 && len != 6 && len != 8)
173 174
				goto out_invalid_option;

175
			opt_recv->dccpor_timestamp_echo = ntohl(*(__be32 *)value);
176

I
Ian McDonald 已提交
177
			dccp_pr_debug("%sTIMESTAMP_ECHO=%u, len=%d, ackno=%llu, ",
178 179
				      debug_prefix,
				      opt_recv->dccpor_timestamp_echo,
180 181
				      len + 2,
				      (unsigned long long)
I
Ian McDonald 已提交
182 183 184
				      DCCP_SKB_CB(skb)->dccpd_ack_seq);


185 186 187 188
			if (len == 4)
				break;

			if (len == 6)
189
				elapsed_time = ntohs(*(__be16 *)(value + 4));
190
			else
191
				elapsed_time = ntohl(*(__be32 *)(value + 4));
192 193 194 195

			/* Give precedence to the biggest ELAPSED_TIME */
			if (elapsed_time > opt_recv->dccpor_elapsed_time)
				opt_recv->dccpor_elapsed_time = elapsed_time;
196 197
			break;
		case DCCPO_ELAPSED_TIME:
I
Ian McDonald 已提交
198
			if (len != 2 && len != 4)
199 200 201 202
				goto out_invalid_option;

			if (pkt_type == DCCP_PKT_DATA)
				continue;
I
Ian McDonald 已提交
203 204

			if (len == 2)
205
				elapsed_time = ntohs(*(__be16 *)value);
I
Ian McDonald 已提交
206
			else
207
				elapsed_time = ntohl(*(__be32 *)value);
208 209 210

			if (elapsed_time > opt_recv->dccpor_elapsed_time)
				opt_recv->dccpor_elapsed_time = elapsed_time;
I
Ian McDonald 已提交
211

212
			dccp_pr_debug("%sELAPSED_TIME=%d\n", debug_prefix,
213
				      elapsed_time);
214 215 216 217
			break;
			/*
			 * From draft-ietf-dccp-spec-11.txt:
			 *
218 219 220 221 222
			 *	Option numbers 128 through 191 are for
			 *	options sent from the HC-Sender to the
			 *	HC-Receiver; option numbers 192 through 255
			 *	are for options sent from the HC-Receiver to
			 *	the HC-Sender.
223 224 225 226
			 */
		case 128 ... 191: {
			const u16 idx = value - options;

227 228 229
			if (ccid_hc_rx_parse_options(dp->dccps_hc_rx_ccid, sk,
						     opt, len, idx,
						     value) != 0)
230 231 232 233 234 235
				goto out_invalid_option;
		}
			break;
		case 192 ... 255: {
			const u16 idx = value - options;

236 237 238
			if (ccid_hc_tx_parse_options(dp->dccps_hc_tx_ccid, sk,
						     opt, len, idx,
						     value) != 0)
239 240 241 242
				goto out_invalid_option;
		}
			break;
		default:
243 244
			pr_info("DCCP(%p): option %d(len=%d) not "
				"implemented, ignoring\n",
245 246 247
				sk, opt, len);
			break;
	        }
248 249 250

		if (opt != DCCPO_MANDATORY)
			mandatory = 0;
251 252
	}

253 254 255 256
	/* mandatory was the last byte in option list -> reset connection */
	if (mandatory)
		goto out_invalid_option;

257 258 259 260 261 262 263 264 265
	return 0;

out_invalid_option:
	DCCP_INC_STATS_BH(DCCP_MIB_INVALIDOPT);
	DCCP_SKB_CB(skb)->dccpd_reset_code = DCCP_RESET_CODE_OPTION_ERROR;
	pr_info("DCCP(%p): invalid option %d, len=%d\n", sk, opt, len);
	return -1;
}

266 267
EXPORT_SYMBOL_GPL(dccp_parse_options);

268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292
static void dccp_encode_value_var(const u32 value, unsigned char *to,
				  const unsigned int len)
{
	if (len > 3)
		*to++ = (value & 0xFF000000) >> 24;
	if (len > 2)
		*to++ = (value & 0xFF0000) >> 16;
	if (len > 1)
		*to++ = (value & 0xFF00) >> 8;
	if (len > 0)
		*to++ = (value & 0xFF);
}

static inline int dccp_ndp_len(const int ndp)
{
	return likely(ndp <= 0xFF) ? 1 : ndp <= 0xFFFF ? 2 : 3;
}

void dccp_insert_option(struct sock *sk, struct sk_buff *skb,
			const unsigned char option,
			const void *value, const unsigned char len)
{
	unsigned char *to;

	if (DCCP_SKB_CB(skb)->dccpd_opt_len + len + 2 > DCCP_MAX_OPT_LEN) {
293 294
		LIMIT_NETDEBUG(KERN_INFO "DCCP: packet too small to insert "
			       "%d option!\n", option);
295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337
		return;
	}

	DCCP_SKB_CB(skb)->dccpd_opt_len += len + 2;

	to    = skb_push(skb, len + 2);
	*to++ = option;
	*to++ = len + 2;

	memcpy(to, value, len);
}

EXPORT_SYMBOL_GPL(dccp_insert_option);

static void dccp_insert_option_ndp(struct sock *sk, struct sk_buff *skb)
{
	struct dccp_sock *dp = dccp_sk(sk);
	int ndp = dp->dccps_ndp_count;

	if (dccp_non_data_packet(skb))
		++dp->dccps_ndp_count;
	else
		dp->dccps_ndp_count = 0;

	if (ndp > 0) {
		unsigned char *ptr;
		const int ndp_len = dccp_ndp_len(ndp);
		const int len = ndp_len + 2;

		if (DCCP_SKB_CB(skb)->dccpd_opt_len + len > DCCP_MAX_OPT_LEN)
			return;

		DCCP_SKB_CB(skb)->dccpd_opt_len += len;

		ptr = skb_push(skb, len);
		*ptr++ = DCCPO_NDP_COUNT;
		*ptr++ = len;
		dccp_encode_value_var(ndp, ptr, ndp_len);
	}
}

static inline int dccp_elapsed_time_len(const u32 elapsed_time)
{
338
	return elapsed_time == 0 ? 0 : elapsed_time <= 0xFFFF ? 2 : 4;
339 340 341 342 343 344
}

void dccp_insert_option_elapsed_time(struct sock *sk,
				     struct sk_buff *skb,
				     u32 elapsed_time)
{
345
#ifdef CONFIG_IP_DCCP_DEBUG
346
	struct dccp_sock *dp = dccp_sk(sk);
347 348
	const char *debug_prefix = dp->dccps_role == DCCP_ROLE_CLIENT ?
					"CLIENT TX opt: " : "server TX opt: ";
349 350 351 352 353
#endif
	const int elapsed_time_len = dccp_elapsed_time_len(elapsed_time);
	const int len = 2 + elapsed_time_len;
	unsigned char *to;

I
Ian McDonald 已提交
354
	if (elapsed_time_len == 0)
355 356 357
		return;

	if (DCCP_SKB_CB(skb)->dccpd_opt_len + len > DCCP_MAX_OPT_LEN) {
358 359
		LIMIT_NETDEBUG(KERN_INFO "DCCP: packet too small to "
					 "insert elapsed time!\n");
360 361 362 363 364 365 366 367 368
		return;
	}

	DCCP_SKB_CB(skb)->dccpd_opt_len += len;

	to    = skb_push(skb, len);
	*to++ = DCCPO_ELAPSED_TIME;
	*to++ = len;

I
Ian McDonald 已提交
369
	if (elapsed_time_len == 2) {
370
		const __be16 var16 = htons((u16)elapsed_time);
I
Ian McDonald 已提交
371 372
		memcpy(to, &var16, 2);
	} else {
373
		const __be32 var32 = htonl(elapsed_time);
I
Ian McDonald 已提交
374 375
		memcpy(to, &var32, 4);
	}
376 377 378

	dccp_pr_debug("%sELAPSED_TIME=%u, len=%d, seqno=%llu\n",
		      debug_prefix, elapsed_time,
379 380
		      len,
		      (unsigned long long) DCCP_SKB_CB(skb)->dccpd_seq);
381 382
}

383
EXPORT_SYMBOL_GPL(dccp_insert_option_elapsed_time);
384

385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400
void dccp_timestamp(const struct sock *sk, struct timeval *tv)
{
	const struct dccp_sock *dp = dccp_sk(sk);

	do_gettimeofday(tv);
	tv->tv_sec  -= dp->dccps_epoch.tv_sec;
	tv->tv_usec -= dp->dccps_epoch.tv_usec;

	while (tv->tv_usec < 0) {
		tv->tv_sec--;
		tv->tv_usec += USEC_PER_SEC;
	}
}

EXPORT_SYMBOL_GPL(dccp_timestamp);

401
void dccp_insert_option_timestamp(struct sock *sk, struct sk_buff *skb)
402
{
I
Ian McDonald 已提交
403
	struct timeval tv;
404
	__be32 now;
405

406
	dccp_timestamp(sk, &tv);
407
	now = htonl(timeval_usecs(&tv) / 10);
I
Ian McDonald 已提交
408 409 410
	/* yes this will overflow but that is the point as we want a
	 * 10 usec 32 bit timer which mean it wraps every 11.9 hours */

411 412 413
	dccp_insert_option(sk, skb, DCCPO_TIMESTAMP, &now, sizeof(now));
}

414 415
EXPORT_SYMBOL_GPL(dccp_insert_option_timestamp);

416 417
static void dccp_insert_option_timestamp_echo(struct sock *sk,
					      struct sk_buff *skb)
418 419
{
	struct dccp_sock *dp = dccp_sk(sk);
420
#ifdef CONFIG_IP_DCCP_DEBUG
421 422
	const char *debug_prefix = dp->dccps_role == DCCP_ROLE_CLIENT ?
					"CLIENT TX opt: " : "server TX opt: ";
423
#endif
424
	struct timeval now;
425
	__be32 tstamp_echo;
426 427
	u32 elapsed_time;
	int len, elapsed_time_len;
428 429
	unsigned char *to;

430 431 432 433 434
	dccp_timestamp(sk, &now);
	elapsed_time = timeval_delta(&now, &dp->dccps_timestamp_time) / 10;
	elapsed_time_len = dccp_elapsed_time_len(elapsed_time);
	len = 6 + elapsed_time_len;

435
	if (DCCP_SKB_CB(skb)->dccpd_opt_len + len > DCCP_MAX_OPT_LEN) {
436 437
		LIMIT_NETDEBUG(KERN_INFO "DCCP: packet too small to insert "
					 "timestamp echo!\n");
438 439 440 441 442 443 444 445 446 447 448 449
		return;
	}

	DCCP_SKB_CB(skb)->dccpd_opt_len += len;

	to    = skb_push(skb, len);
	*to++ = DCCPO_TIMESTAMP_ECHO;
	*to++ = len;

	tstamp_echo = htonl(dp->dccps_timestamp_echo);
	memcpy(to, &tstamp_echo, 4);
	to += 4;
450

I
Ian McDonald 已提交
451
	if (elapsed_time_len == 2) {
452
		const __be16 var16 = htons((u16)elapsed_time);
I
Ian McDonald 已提交
453 454
		memcpy(to, &var16, 2);
	} else if (elapsed_time_len == 4) {
455
		const __be32 var32 = htonl(elapsed_time);
I
Ian McDonald 已提交
456 457
		memcpy(to, &var32, 4);
	}
458 459 460

	dccp_pr_debug("%sTIMESTAMP_ECHO=%u, len=%d, seqno=%llu\n",
		      debug_prefix, dp->dccps_timestamp_echo,
461 462
		      len,
		      (unsigned long long) DCCP_SKB_CB(skb)->dccpd_seq);
463 464

	dp->dccps_timestamp_echo = 0;
I
Ian McDonald 已提交
465 466
	dp->dccps_timestamp_time.tv_sec = 0;
	dp->dccps_timestamp_time.tv_usec = 0;
467 468
}

469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555
static int dccp_insert_feat_opt(struct sk_buff *skb, u8 type, u8 feat,
			        u8 *val, u8 len)
{
	u8 *to;

	if (DCCP_SKB_CB(skb)->dccpd_opt_len + len + 3 > DCCP_MAX_OPT_LEN) {
		LIMIT_NETDEBUG(KERN_INFO "DCCP: packet too small"
			       " to insert feature %d option!\n", feat);
		return -1;
	}

	DCCP_SKB_CB(skb)->dccpd_opt_len += len + 3;

	to    = skb_push(skb, len + 3);
	*to++ = type;
	*to++ = len + 3;
	*to++ = feat;

	if (len)
		memcpy(to, val, len);
	dccp_pr_debug("option %d feat %d len %d\n", type, feat, len);

	return 0;
}

static void dccp_insert_feat(struct sock *sk, struct sk_buff *skb)
{
	struct dccp_sock *dp = dccp_sk(sk);
	struct dccp_opt_pend *opt, *next;
	int change = 0;

	/* confirm any options [NN opts] */
	list_for_each_entry_safe(opt, next, &dp->dccps_options.dccpo_conf,
				 dccpop_node) {
		dccp_insert_feat_opt(skb, opt->dccpop_type,
				     opt->dccpop_feat, opt->dccpop_val,
				     opt->dccpop_len);
		/* fear empty confirms */
		if (opt->dccpop_val)
			kfree(opt->dccpop_val);
		kfree(opt);
	}
	INIT_LIST_HEAD(&dp->dccps_options.dccpo_conf);

	/* see which features we need to send */
	list_for_each_entry(opt, &dp->dccps_options.dccpo_pending,
			    dccpop_node) {
		/* see if we need to send any confirm */
		if (opt->dccpop_sc) {
			dccp_insert_feat_opt(skb, opt->dccpop_type + 1,
					     opt->dccpop_feat,
					     opt->dccpop_sc->dccpoc_val,
					     opt->dccpop_sc->dccpoc_len);

			BUG_ON(!opt->dccpop_sc->dccpoc_val);
			kfree(opt->dccpop_sc->dccpoc_val);
			kfree(opt->dccpop_sc);
			opt->dccpop_sc = NULL;
		}

		/* any option not confirmed, re-send it */
		if (!opt->dccpop_conf) {
			dccp_insert_feat_opt(skb, opt->dccpop_type,
					     opt->dccpop_feat, opt->dccpop_val,
					     opt->dccpop_len);
			change++;
		}
	}

	/* Retransmit timer.
	 * If this is the master listening sock, we don't set a timer on it.  It
	 * should be fine because if the dude doesn't receive our RESPONSE
	 * [which will contain the CHANGE] he will send another REQUEST which
	 * will "retrnasmit" the change.
	 */
	if (change && dp->dccps_role != DCCP_ROLE_LISTEN) {
		dccp_pr_debug("reset feat negotiation timer %p\n", sk);

		/* XXX don't reset the timer on re-transmissions.  I.e. reset it
		 * only when sending new stuff i guess.  Currently the timer
		 * never backs off because on re-transmission it just resets it!
		 */
		inet_csk_reset_xmit_timer(sk, ICSK_TIME_RETRANS,
					  inet_csk(sk)->icsk_rto, DCCP_RTO_MAX);
	}
}

556 557 558 559 560 561 562 563 564 565 566
void dccp_insert_options(struct sock *sk, struct sk_buff *skb)
{
	struct dccp_sock *dp = dccp_sk(sk);

	DCCP_SKB_CB(skb)->dccpd_opt_len = 0;

	if (dp->dccps_options.dccpo_send_ndp_count)
		dccp_insert_option_ndp(sk, skb);

	if (!dccp_packet_without_ack(skb)) {
		if (dp->dccps_options.dccpo_send_ack_vector &&
567 568
		    dccp_ackvec_pending(dp->dccps_hc_rx_ackvec))
			dccp_insert_option_ackvec(sk, skb);
569 570 571 572
		if (dp->dccps_timestamp_echo != 0)
			dccp_insert_option_timestamp_echo(sk, skb);
	}

573 574 575 576 577 578 579 580
	if (dp->dccps_hc_rx_insert_options) {
		ccid_hc_rx_insert_options(dp->dccps_hc_rx_ccid, sk, skb);
		dp->dccps_hc_rx_insert_options = 0;
	}
	if (dp->dccps_hc_tx_insert_options) {
		ccid_hc_tx_insert_options(dp->dccps_hc_tx_ccid, sk, skb);
		dp->dccps_hc_tx_insert_options = 0;
	}
581

582 583 584 585 586 587 588 589 590 591 592
	/* Feature negotiation */
	switch(DCCP_SKB_CB(skb)->dccpd_type) {
		/* Data packets can't do feat negotiation */
	case DCCP_PKT_DATA:
	case DCCP_PKT_DATAACK:
		break;
	default:
		dccp_insert_feat(sk, skb);
		break;
	}

593 594 595 596 597 598 599 600 601 602 603 604 605
	/* XXX: insert other options when appropriate */

	if (DCCP_SKB_CB(skb)->dccpd_opt_len != 0) {
		/* The length of all options has to be a multiple of 4 */
		int padding = DCCP_SKB_CB(skb)->dccpd_opt_len % 4;

		if (padding != 0) {
			padding = 4 - padding;
			memset(skb_push(skb, padding), 0, padding);
			DCCP_SKB_CB(skb)->dccpd_opt_len += padding;
		}
	}
}