intel_dsi.c 46.5 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26
/*
 * Copyright © 2013 Intel Corporation
 *
 * Permission is hereby granted, free of charge, to any person obtaining a
 * copy of this software and associated documentation files (the "Software"),
 * to deal in the Software without restriction, including without limitation
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 * and/or sell copies of the Software, and to permit persons to whom the
 * Software is furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice (including the next
 * paragraph) shall be included in all copies or substantial portions of the
 * Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
 * DEALINGS IN THE SOFTWARE.
 *
 * Author: Jani Nikula <jani.nikula@intel.com>
 */

#include <drm/drmP.h>
27
#include <drm/drm_atomic_helper.h>
28 29 30
#include <drm/drm_crtc.h>
#include <drm/drm_edid.h>
#include <drm/i915_drm.h>
31
#include <drm/drm_panel.h>
32
#include <drm/drm_mipi_dsi.h>
33
#include <linux/slab.h>
34
#include <linux/gpio/consumer.h>
35 36 37 38
#include "i915_drv.h"
#include "intel_drv.h"
#include "intel_dsi.h"

39 40 41 42
static const struct {
	u16 panel_id;
	struct drm_panel * (*init)(struct intel_dsi *intel_dsi, u16 panel_id);
} intel_dsi_drivers[] = {
43 44
	{
		.panel_id = MIPI_DSI_GENERIC_PANEL_ID,
45
		.init = vbt_panel_init,
46
	},
47 48
};

49 50 51 52 53 54 55 56
/* return pixels in terms of txbyteclkhs */
static u16 txbyteclkhs(u16 pixels, int bpp, int lane_count,
		       u16 burst_mode_ratio)
{
	return DIV_ROUND_UP(DIV_ROUND_UP(pixels * bpp * burst_mode_ratio,
					 8 * 100), lane_count);
}

57 58 59 60 61 62 63 64
/* return pixels equvalent to txbyteclkhs */
static u16 pixels_from_txbyteclkhs(u16 clk_hs, int bpp, int lane_count,
			u16 burst_mode_ratio)
{
	return DIV_ROUND_UP((clk_hs * lane_count * 8 * 100),
						(bpp * burst_mode_ratio));
}

65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82
enum mipi_dsi_pixel_format pixel_format_from_register_bits(u32 fmt)
{
	/* It just so happens the VBT matches register contents. */
	switch (fmt) {
	case VID_MODE_FORMAT_RGB888:
		return MIPI_DSI_FMT_RGB888;
	case VID_MODE_FORMAT_RGB666:
		return MIPI_DSI_FMT_RGB666;
	case VID_MODE_FORMAT_RGB666_PACKED:
		return MIPI_DSI_FMT_RGB666_PACKED;
	case VID_MODE_FORMAT_RGB565:
		return MIPI_DSI_FMT_RGB565;
	default:
		MISSING_CASE(fmt);
		return MIPI_DSI_FMT_RGB666;
	}
}

83
static void wait_for_dsi_fifo_empty(struct intel_dsi *intel_dsi, enum port port)
84 85 86
{
	struct drm_encoder *encoder = &intel_dsi->base.base;
	struct drm_device *dev = encoder->dev;
87
	struct drm_i915_private *dev_priv = to_i915(dev);
88 89 90 91 92
	u32 mask;

	mask = LP_CTRL_FIFO_EMPTY | HS_CTRL_FIFO_EMPTY |
		LP_DATA_FIFO_EMPTY | HS_DATA_FIFO_EMPTY;

93 94 95
	if (intel_wait_for_register(dev_priv,
				    MIPI_GEN_FIFO_STAT(port), mask, mask,
				    100))
96 97 98
		DRM_ERROR("DPI FIFOs are not empty\n");
}

99 100
static void write_data(struct drm_i915_private *dev_priv,
		       i915_reg_t reg,
101 102 103 104 105 106 107 108 109 110 111 112 113 114
		       const u8 *data, u32 len)
{
	u32 i, j;

	for (i = 0; i < len; i += 4) {
		u32 val = 0;

		for (j = 0; j < min_t(u32, len - i, 4); j++)
			val |= *data++ << 8 * j;

		I915_WRITE(reg, val);
	}
}

115 116
static void read_data(struct drm_i915_private *dev_priv,
		      i915_reg_t reg,
117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133
		      u8 *data, u32 len)
{
	u32 i, j;

	for (i = 0; i < len; i += 4) {
		u32 val = I915_READ(reg);

		for (j = 0; j < min_t(u32, len - i, 4); j++)
			*data++ = val >> 8 * j;
	}
}

static ssize_t intel_dsi_host_transfer(struct mipi_dsi_host *host,
				       const struct mipi_dsi_msg *msg)
{
	struct intel_dsi_host *intel_dsi_host = to_intel_dsi_host(host);
	struct drm_device *dev = intel_dsi_host->intel_dsi->base.base.dev;
134
	struct drm_i915_private *dev_priv = to_i915(dev);
135 136 137 138
	enum port port = intel_dsi_host->port;
	struct mipi_dsi_packet packet;
	ssize_t ret;
	const u8 *header, *data;
139 140
	i915_reg_t data_reg, ctrl_reg;
	u32 data_mask, ctrl_mask;
141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162

	ret = mipi_dsi_create_packet(&packet, msg);
	if (ret < 0)
		return ret;

	header = packet.header;
	data = packet.payload;

	if (msg->flags & MIPI_DSI_MSG_USE_LPM) {
		data_reg = MIPI_LP_GEN_DATA(port);
		data_mask = LP_DATA_FIFO_FULL;
		ctrl_reg = MIPI_LP_GEN_CTRL(port);
		ctrl_mask = LP_CTRL_FIFO_FULL;
	} else {
		data_reg = MIPI_HS_GEN_DATA(port);
		data_mask = HS_DATA_FIFO_FULL;
		ctrl_reg = MIPI_HS_GEN_CTRL(port);
		ctrl_mask = HS_CTRL_FIFO_FULL;
	}

	/* note: this is never true for reads */
	if (packet.payload_length) {
163 164 165 166
		if (intel_wait_for_register(dev_priv,
					    MIPI_GEN_FIFO_STAT(port),
					    data_mask, 0,
					    50))
167 168 169 170 171 172 173 174 175 176
			DRM_ERROR("Timeout waiting for HS/LP DATA FIFO !full\n");

		write_data(dev_priv, data_reg, packet.payload,
			   packet.payload_length);
	}

	if (msg->rx_len) {
		I915_WRITE(MIPI_INTR_STAT(port), GEN_READ_DATA_AVAIL);
	}

177 178 179 180
	if (intel_wait_for_register(dev_priv,
				    MIPI_GEN_FIFO_STAT(port),
				    ctrl_mask, 0,
				    50)) {
181 182 183 184 185 186 187 188
		DRM_ERROR("Timeout waiting for HS/LP CTRL FIFO !full\n");
	}

	I915_WRITE(ctrl_reg, header[2] << 16 | header[1] << 8 | header[0]);

	/* ->rx_len is set only for reads */
	if (msg->rx_len) {
		data_mask = GEN_READ_DATA_AVAIL;
189 190 191 192
		if (intel_wait_for_register(dev_priv,
					    MIPI_INTR_STAT(port),
					    data_mask, data_mask,
					    50))
193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252
			DRM_ERROR("Timeout waiting for read data.\n");

		read_data(dev_priv, data_reg, msg->rx_buf, msg->rx_len);
	}

	/* XXX: fix for reads and writes */
	return 4 + packet.payload_length;
}

static int intel_dsi_host_attach(struct mipi_dsi_host *host,
				 struct mipi_dsi_device *dsi)
{
	return 0;
}

static int intel_dsi_host_detach(struct mipi_dsi_host *host,
				 struct mipi_dsi_device *dsi)
{
	return 0;
}

static const struct mipi_dsi_host_ops intel_dsi_host_ops = {
	.attach = intel_dsi_host_attach,
	.detach = intel_dsi_host_detach,
	.transfer = intel_dsi_host_transfer,
};

static struct intel_dsi_host *intel_dsi_host_init(struct intel_dsi *intel_dsi,
						  enum port port)
{
	struct intel_dsi_host *host;
	struct mipi_dsi_device *device;

	host = kzalloc(sizeof(*host), GFP_KERNEL);
	if (!host)
		return NULL;

	host->base.ops = &intel_dsi_host_ops;
	host->intel_dsi = intel_dsi;
	host->port = port;

	/*
	 * We should call mipi_dsi_host_register(&host->base) here, but we don't
	 * have a host->dev, and we don't have OF stuff either. So just use the
	 * dsi framework as a library and hope for the best. Create the dsi
	 * devices by ourselves here too. Need to be careful though, because we
	 * don't initialize any of the driver model devices here.
	 */
	device = kzalloc(sizeof(*device), GFP_KERNEL);
	if (!device) {
		kfree(host);
		return NULL;
	}

	device->host = &host->base;
	host->device = device;

	return host;
}

253 254 255 256 257 258 259 260 261 262
/*
 * send a video mode command
 *
 * XXX: commands with data in MIPI_DPI_DATA?
 */
static int dpi_send_cmd(struct intel_dsi *intel_dsi, u32 cmd, bool hs,
			enum port port)
{
	struct drm_encoder *encoder = &intel_dsi->base.base;
	struct drm_device *dev = encoder->dev;
263
	struct drm_i915_private *dev_priv = to_i915(dev);
264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281
	u32 mask;

	/* XXX: pipe, hs */
	if (hs)
		cmd &= ~DPI_LP_MODE;
	else
		cmd |= DPI_LP_MODE;

	/* clear bit */
	I915_WRITE(MIPI_INTR_STAT(port), SPL_PKT_SENT_INTERRUPT);

	/* XXX: old code skips write if control unchanged */
	if (cmd == I915_READ(MIPI_DPI_CONTROL(port)))
		DRM_ERROR("Same special packet %02x twice in a row.\n", cmd);

	I915_WRITE(MIPI_DPI_CONTROL(port), cmd);

	mask = SPL_PKT_SENT_INTERRUPT;
282 283 284
	if (intel_wait_for_register(dev_priv,
				    MIPI_INTR_STAT(port), mask, mask,
				    100))
285 286 287 288 289
		DRM_ERROR("Video mode command 0x%08x send failed.\n", cmd);

	return 0;
}

290
static void band_gap_reset(struct drm_i915_private *dev_priv)
S
Shobhit Kumar 已提交
291
{
V
Ville Syrjälä 已提交
292
	mutex_lock(&dev_priv->sb_lock);
S
Shobhit Kumar 已提交
293

294 295 296 297 298 299
	vlv_flisdsi_write(dev_priv, 0x08, 0x0001);
	vlv_flisdsi_write(dev_priv, 0x0F, 0x0005);
	vlv_flisdsi_write(dev_priv, 0x0F, 0x0025);
	udelay(150);
	vlv_flisdsi_write(dev_priv, 0x0F, 0x0000);
	vlv_flisdsi_write(dev_priv, 0x08, 0x0000);
S
Shobhit Kumar 已提交
300

V
Ville Syrjälä 已提交
301
	mutex_unlock(&dev_priv->sb_lock);
S
Shobhit Kumar 已提交
302 303
}

304 305
static inline bool is_vid_mode(struct intel_dsi *intel_dsi)
{
306
	return intel_dsi->operation_mode == INTEL_DSI_VIDEO_MODE;
307 308 309 310
}

static inline bool is_cmd_mode(struct intel_dsi *intel_dsi)
{
311
	return intel_dsi->operation_mode == INTEL_DSI_COMMAND_MODE;
312 313 314
}

static bool intel_dsi_compute_config(struct intel_encoder *encoder,
315 316
				     struct intel_crtc_state *pipe_config,
				     struct drm_connector_state *conn_state)
317
{
318
	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
319 320 321
	struct intel_dsi *intel_dsi = container_of(encoder, struct intel_dsi,
						   base);
	struct intel_connector *intel_connector = intel_dsi->attached_connector;
V
Ville Syrjälä 已提交
322 323
	struct intel_crtc *crtc = to_intel_crtc(pipe_config->base.crtc);
	const struct drm_display_mode *fixed_mode = intel_connector->panel.fixed_mode;
324
	struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
325
	int ret;
326 327 328

	DRM_DEBUG_KMS("\n");

V
Ville Syrjälä 已提交
329
	if (fixed_mode) {
330 331
		intel_fixed_panel_mode(fixed_mode, adjusted_mode);

V
Ville Syrjälä 已提交
332 333 334 335 336 337 338 339
		if (HAS_GMCH_DISPLAY(dev_priv))
			intel_gmch_panel_fitting(crtc, pipe_config,
						 intel_connector->panel.fitting_mode);
		else
			intel_pch_panel_fitting(crtc, pipe_config,
						intel_connector->panel.fitting_mode);
	}

340 341 342
	/* DSI uses short packets for sync events, so clear mode flags for DSI */
	adjusted_mode->flags = 0;

J
Jani Nikula 已提交
343 344 345 346 347 348 349 350
	if (IS_BROXTON(dev_priv)) {
		/* Dual link goes to DSI transcoder A. */
		if (intel_dsi->ports == BIT(PORT_C))
			pipe_config->cpu_transcoder = TRANSCODER_DSI_C;
		else
			pipe_config->cpu_transcoder = TRANSCODER_DSI_A;
	}

351 352 353 354
	ret = intel_compute_dsi_pll(encoder, pipe_config);
	if (ret)
		return false;

355 356
	pipe_config->clock_set = true;

357 358 359
	return true;
}

S
Shashank Sharma 已提交
360
static void bxt_dsi_device_ready(struct intel_encoder *encoder)
361
{
362
	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
363
	struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
364
	enum port port;
S
Shashank Sharma 已提交
365
	u32 val;
366

S
Shashank Sharma 已提交
367
	DRM_DEBUG_KMS("\n");
368

S
Shashank Sharma 已提交
369
	/* Exit Low power state in 4 steps*/
370
	for_each_dsi_port(port, intel_dsi->ports) {
371

S
Shashank Sharma 已提交
372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389
		/* 1. Enable MIPI PHY transparent latch */
		val = I915_READ(BXT_MIPI_PORT_CTRL(port));
		I915_WRITE(BXT_MIPI_PORT_CTRL(port), val | LP_OUTPUT_HOLD);
		usleep_range(2000, 2500);

		/* 2. Enter ULPS */
		val = I915_READ(MIPI_DEVICE_READY(port));
		val &= ~ULPS_STATE_MASK;
		val |= (ULPS_STATE_ENTER | DEVICE_READY);
		I915_WRITE(MIPI_DEVICE_READY(port), val);
		usleep_range(2, 3);

		/* 3. Exit ULPS */
		val = I915_READ(MIPI_DEVICE_READY(port));
		val &= ~ULPS_STATE_MASK;
		val |= (ULPS_STATE_EXIT | DEVICE_READY);
		I915_WRITE(MIPI_DEVICE_READY(port), val);
		usleep_range(1000, 1500);
390

S
Shashank Sharma 已提交
391 392 393 394 395
		/* Clear ULPS and set device ready */
		val = I915_READ(MIPI_DEVICE_READY(port));
		val &= ~ULPS_STATE_MASK;
		val |= DEVICE_READY;
		I915_WRITE(MIPI_DEVICE_READY(port), val);
396
	}
397 398
}

S
Shashank Sharma 已提交
399
static void vlv_dsi_device_ready(struct intel_encoder *encoder)
400
{
401
	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
402 403
	struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
	enum port port;
404 405
	u32 val;

406 407
	DRM_DEBUG_KMS("\n");

V
Ville Syrjälä 已提交
408
	mutex_lock(&dev_priv->sb_lock);
409 410 411
	/* program rcomp for compliance, reduce from 50 ohms to 45 ohms
	 * needed everytime after power gate */
	vlv_flisdsi_write(dev_priv, 0x04, 0x0004);
V
Ville Syrjälä 已提交
412
	mutex_unlock(&dev_priv->sb_lock);
413 414 415 416

	/* bandgap reset is needed after everytime we do power gate */
	band_gap_reset(dev_priv);

417
	for_each_dsi_port(port, intel_dsi->ports) {
418

419 420
		I915_WRITE(MIPI_DEVICE_READY(port), ULPS_STATE_ENTER);
		usleep_range(2500, 3000);
421

422 423 424 425
		/* Enable MIPI PHY transparent latch
		 * Common bit for both MIPI Port A & MIPI Port C
		 * No similar bit in MIPI Port C reg
		 */
426
		val = I915_READ(MIPI_PORT_CTRL(PORT_A));
427
		I915_WRITE(MIPI_PORT_CTRL(PORT_A), val | LP_OUTPUT_HOLD);
428
		usleep_range(1000, 1500);
429

430 431 432 433 434 435
		I915_WRITE(MIPI_DEVICE_READY(port), ULPS_STATE_EXIT);
		usleep_range(2500, 3000);

		I915_WRITE(MIPI_DEVICE_READY(port), DEVICE_READY);
		usleep_range(2500, 3000);
	}
436 437
}

S
Shashank Sharma 已提交
438 439
static void intel_dsi_device_ready(struct intel_encoder *encoder)
{
440
	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
S
Shashank Sharma 已提交
441

442
	if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv))
S
Shashank Sharma 已提交
443
		vlv_dsi_device_ready(encoder);
444
	else if (IS_BROXTON(dev_priv))
S
Shashank Sharma 已提交
445 446 447 448 449 450
		bxt_dsi_device_ready(encoder);
}

static void intel_dsi_port_enable(struct intel_encoder *encoder)
{
	struct drm_device *dev = encoder->base.dev;
451
	struct drm_i915_private *dev_priv = to_i915(dev);
S
Shashank Sharma 已提交
452 453 454 455 456
	struct intel_crtc *intel_crtc = to_intel_crtc(encoder->base.crtc);
	struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
	enum port port;

	if (intel_dsi->dual_link == DSI_DUAL_LINK_FRONT_BACK) {
457 458
		u32 temp;

S
Shashank Sharma 已提交
459 460 461 462 463 464 465 466
		temp = I915_READ(VLV_CHICKEN_3);
		temp &= ~PIXEL_OVERLAP_CNT_MASK |
					intel_dsi->pixel_overlap <<
					PIXEL_OVERLAP_CNT_SHIFT;
		I915_WRITE(VLV_CHICKEN_3, temp);
	}

	for_each_dsi_port(port, intel_dsi->ports) {
467
		i915_reg_t port_ctrl = IS_BROXTON(dev_priv) ?
468 469
			BXT_MIPI_PORT_CTRL(port) : MIPI_PORT_CTRL(port);
		u32 temp;
S
Shashank Sharma 已提交
470 471 472 473 474 475

		temp = I915_READ(port_ctrl);

		temp &= ~LANE_CONFIGURATION_MASK;
		temp &= ~DUAL_LINK_MODE_MASK;

476
		if (intel_dsi->ports == (BIT(PORT_A) | BIT(PORT_C))) {
S
Shashank Sharma 已提交
477 478
			temp |= (intel_dsi->dual_link - 1)
						<< DUAL_LINK_MODE_SHIFT;
479 480 481 482
			if (IS_BROXTON(dev_priv))
				temp |= LANE_CONFIGURATION_DUAL_LINK_A;
			else
				temp |= intel_crtc->pipe ?
S
Shashank Sharma 已提交
483 484 485 486 487 488 489 490 491 492 493 494
					LANE_CONFIGURATION_DUAL_LINK_B :
					LANE_CONFIGURATION_DUAL_LINK_A;
		}
		/* assert ip_tg_enable signal */
		I915_WRITE(port_ctrl, temp | DPI_ENABLE);
		POSTING_READ(port_ctrl);
	}
}

static void intel_dsi_port_disable(struct intel_encoder *encoder)
{
	struct drm_device *dev = encoder->base.dev;
495
	struct drm_i915_private *dev_priv = to_i915(dev);
S
Shashank Sharma 已提交
496 497 498 499
	struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
	enum port port;

	for_each_dsi_port(port, intel_dsi->ports) {
500
		i915_reg_t port_ctrl = IS_BROXTON(dev_priv) ?
501 502 503
			BXT_MIPI_PORT_CTRL(port) : MIPI_PORT_CTRL(port);
		u32 temp;

S
Shashank Sharma 已提交
504
		/* de-assert ip_tg_enable signal */
505 506 507
		temp = I915_READ(port_ctrl);
		I915_WRITE(port_ctrl, temp & ~DPI_ENABLE);
		POSTING_READ(port_ctrl);
S
Shashank Sharma 已提交
508 509 510
	}
}

511 512 513
static void intel_dsi_enable(struct intel_encoder *encoder)
{
	struct drm_device *dev = encoder->base.dev;
514
	struct drm_i915_private *dev_priv = to_i915(dev);
515
	struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
516
	enum port port;
517 518

	DRM_DEBUG_KMS("\n");
519

520 521 522 523
	if (is_cmd_mode(intel_dsi)) {
		for_each_dsi_port(port, intel_dsi->ports)
			I915_WRITE(MIPI_MAX_RETURN_PKT_SIZE(port), 8 * 4);
	} else {
524
		msleep(20); /* XXX */
525
		for_each_dsi_port(port, intel_dsi->ports)
526
			dpi_send_cmd(intel_dsi, TURN_ON, false, port);
527 528
		msleep(100);

529
		drm_panel_enable(intel_dsi->panel);
530

531 532
		for_each_dsi_port(port, intel_dsi->ports)
			wait_for_dsi_fifo_empty(intel_dsi, port);
533

534
		intel_dsi_port_enable(encoder);
535
	}
536 537

	intel_panel_enable_backlight(intel_dsi->attached_connector);
538 539
}

540 541
static void intel_dsi_prepare(struct intel_encoder *intel_encoder,
			      struct intel_crtc_state *pipe_config);
542

543 544 545
static void intel_dsi_pre_enable(struct intel_encoder *encoder,
				 struct intel_crtc_state *pipe_config,
				 struct drm_connector_state *conn_state)
546
{
547
	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
548
	struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
549
	enum port port;
550 551 552

	DRM_DEBUG_KMS("\n");

553 554 555 556 557
	/*
	 * The BIOS may leave the PLL in a wonky state where it doesn't
	 * lock. It needs to be fully powered down to fix it.
	 */
	intel_disable_dsi_pll(encoder);
558
	intel_enable_dsi_pll(encoder, pipe_config);
559

560
	intel_dsi_prepare(encoder, pipe_config);
561

562 563 564 565 566 567
	/* Panel Enable over CRC PMIC */
	if (intel_dsi->gpio_panel)
		gpiod_set_value_cansleep(intel_dsi->gpio_panel, 1);

	msleep(intel_dsi->panel_on_delay);

568 569 570
	if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) {
		u32 val;

571
		/* Disable DPOunit clock gating, can stall pipe */
572 573 574
		val = I915_READ(DSPCLK_GATE_D);
		val |= DPOUNIT_CLOCK_GATE_DISABLE;
		I915_WRITE(DSPCLK_GATE_D, val);
S
Shashank Sharma 已提交
575
	}
576 577 578

	/* put device in ready state */
	intel_dsi_device_ready(encoder);
579

580
	drm_panel_prepare(intel_dsi->panel);
581

582 583
	for_each_dsi_port(port, intel_dsi->ports)
		wait_for_dsi_fifo_empty(intel_dsi, port);
584

585 586 587 588 589
	/* Enable port in pre-enable phase itself because as per hw team
	 * recommendation, port should be enabled befor plane & pipe */
	intel_dsi_enable(encoder);
}

590 591 592
static void intel_dsi_enable_nop(struct intel_encoder *encoder,
				 struct intel_crtc_state *pipe_config,
				 struct drm_connector_state *conn_state)
593 594 595 596 597 598 599
{
	DRM_DEBUG_KMS("\n");

	/* for DSI port enable has to be done before pipe
	 * and plane enable, so port enable is done in
	 * pre_enable phase itself unlike other encoders
	 */
600 601
}

602 603 604
static void intel_dsi_pre_disable(struct intel_encoder *encoder,
				  struct intel_crtc_state *old_crtc_state,
				  struct drm_connector_state *old_conn_state)
605 606
{
	struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
607
	enum port port;
608 609 610

	DRM_DEBUG_KMS("\n");

611 612
	intel_panel_disable_backlight(intel_dsi->attached_connector);

613 614
	if (is_vid_mode(intel_dsi)) {
		/* Send Shutdown command to the panel in LP mode */
615
		for_each_dsi_port(port, intel_dsi->ports)
616
			dpi_send_cmd(intel_dsi, SHUTDOWN, false, port);
617 618 619 620
		msleep(10);
	}
}

621 622
static void intel_dsi_disable(struct intel_encoder *encoder)
{
623
	struct drm_device *dev = encoder->base.dev;
624
	struct drm_i915_private *dev_priv = to_i915(dev);
625
	struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
626
	enum port port;
627 628 629 630 631
	u32 temp;

	DRM_DEBUG_KMS("\n");

	if (is_vid_mode(intel_dsi)) {
632 633
		for_each_dsi_port(port, intel_dsi->ports)
			wait_for_dsi_fifo_empty(intel_dsi, port);
634

635
		intel_dsi_port_disable(encoder);
636 637 638
		msleep(2);
	}

639 640 641
	for_each_dsi_port(port, intel_dsi->ports) {
		/* Panel commands can be sent when clock is in LP11 */
		I915_WRITE(MIPI_DEVICE_READY(port), 0x0);
642

643
		intel_dsi_reset_clocks(encoder, port);
644
		I915_WRITE(MIPI_EOT_DISABLE(port), CLOCKSTOP);
645

646 647 648
		temp = I915_READ(MIPI_DSI_FUNC_PRG(port));
		temp &= ~VID_MODE_FORMAT_MASK;
		I915_WRITE(MIPI_DSI_FUNC_PRG(port), temp);
649

650 651
		I915_WRITE(MIPI_DEVICE_READY(port), 0x1);
	}
652 653
	/* if disable packets are sent before sending shutdown packet then in
	 * some next enable sequence send turn on packet error is observed */
654
	drm_panel_disable(intel_dsi->panel);
655

656 657
	for_each_dsi_port(port, intel_dsi->ports)
		wait_for_dsi_fifo_empty(intel_dsi, port);
658 659
}

660
static void intel_dsi_clear_device_ready(struct intel_encoder *encoder)
661
{
662
	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
663 664
	struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
	enum port port;
665

666
	DRM_DEBUG_KMS("\n");
667
	for_each_dsi_port(port, intel_dsi->ports) {
668
		/* Common bit for both MIPI Port A & MIPI Port C on VLV/CHV */
669
		i915_reg_t port_ctrl = IS_BROXTON(dev_priv) ?
670 671
			BXT_MIPI_PORT_CTRL(port) : MIPI_PORT_CTRL(PORT_A);
		u32 val;
672

673 674 675 676 677 678 679 680 681 682 683 684 685 686 687
		I915_WRITE(MIPI_DEVICE_READY(port), DEVICE_READY |
							ULPS_STATE_ENTER);
		usleep_range(2000, 2500);

		I915_WRITE(MIPI_DEVICE_READY(port), DEVICE_READY |
							ULPS_STATE_EXIT);
		usleep_range(2000, 2500);

		I915_WRITE(MIPI_DEVICE_READY(port), DEVICE_READY |
							ULPS_STATE_ENTER);
		usleep_range(2000, 2500);

		/* Wait till Clock lanes are in LP-00 state for MIPI Port A
		 * only. MIPI Port C has no similar bit for checking
		 */
688 689 690
		if (intel_wait_for_register(dev_priv,
					    port_ctrl, AFE_LATCHOUT, 0,
					    30))
691 692
			DRM_ERROR("DSI LP not going Low\n");

693 694 695
		/* Disable MIPI PHY transparent latch */
		val = I915_READ(port_ctrl);
		I915_WRITE(port_ctrl, val & ~LP_OUTPUT_HOLD);
696 697 698 699 700
		usleep_range(1000, 1500);

		I915_WRITE(MIPI_DEVICE_READY(port), 0x00);
		usleep_range(2000, 2500);
	}
701

702
	intel_disable_dsi_pll(encoder);
703
}
704

705 706 707
static void intel_dsi_post_disable(struct intel_encoder *encoder,
				   struct intel_crtc_state *pipe_config,
				   struct drm_connector_state *conn_state)
708
{
709
	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
710 711 712 713
	struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);

	DRM_DEBUG_KMS("\n");

714 715
	intel_dsi_disable(encoder);

716 717
	intel_dsi_clear_device_ready(encoder);

718
	if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) {
719 720 721 722 723 724
		u32 val;

		val = I915_READ(DSPCLK_GATE_D);
		val &= ~DPOUNIT_CLOCK_GATE_DISABLE;
		I915_WRITE(DSPCLK_GATE_D, val);
	}
725

726
	drm_panel_unprepare(intel_dsi->panel);
S
Shobhit Kumar 已提交
727 728

	msleep(intel_dsi->panel_off_delay);
729 730 731 732

	/* Panel Disable over CRC PMIC */
	if (intel_dsi->gpio_panel)
		gpiod_set_value_cansleep(intel_dsi->gpio_panel, 0);
733 734 735 736 737 738

	/*
	 * FIXME As we do with eDP, just make a note of the time here
	 * and perform the wait before the next panel power on.
	 */
	msleep(intel_dsi->panel_pwr_cycle_delay);
739
}
740 741 742 743

static bool intel_dsi_get_hw_state(struct intel_encoder *encoder,
				   enum pipe *pipe)
{
744
	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
745
	struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
746
	enum intel_display_power_domain power_domain;
747
	enum port port;
748
	bool active = false;
749 750 751

	DRM_DEBUG_KMS("\n");

752
	power_domain = intel_display_port_power_domain(encoder);
753
	if (!intel_display_power_get_if_enabled(dev_priv, power_domain))
754 755
		return false;

756 757 758 759 760 761 762 763
	/*
	 * On Broxton the PLL needs to be enabled with a valid divider
	 * configuration, otherwise accessing DSI registers will hang the
	 * machine. See BSpec North Display Engine registers/MIPI[BXT].
	 */
	if (IS_BROXTON(dev_priv) && !intel_dsi_pll_is_enabled(dev_priv))
		goto out_put_power;

764
	/* XXX: this only works for one DSI output */
765
	for_each_dsi_port(port, intel_dsi->ports) {
766
		i915_reg_t ctrl_reg = IS_BROXTON(dev_priv) ?
767
			BXT_MIPI_PORT_CTRL(port) : MIPI_PORT_CTRL(port);
768
		bool enabled = I915_READ(ctrl_reg) & DPI_ENABLE;
769

770 771 772 773
		/*
		 * Due to some hardware limitations on VLV/CHV, the DPI enable
		 * bit in port C control register does not get set. As a
		 * workaround, check pipe B conf instead.
774
		 */
775 776
		if ((IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) &&
		    port == PORT_C)
777
			enabled = I915_READ(PIPECONF(PIPE_B)) & PIPECONF_ENABLE;
778

779 780 781 782
		/* Try command mode if video mode not enabled */
		if (!enabled) {
			u32 tmp = I915_READ(MIPI_DSI_FUNC_PRG(port));
			enabled = tmp & CMD_MODE_DATA_WIDTH_MASK;
783
		}
784 785 786 787 788 789 790

		if (!enabled)
			continue;

		if (!(I915_READ(MIPI_DEVICE_READY(port)) & DEVICE_READY))
			continue;

791 792 793 794 795 796 797 798 799 800 801 802 803
		if (IS_BROXTON(dev_priv)) {
			u32 tmp = I915_READ(MIPI_CTRL(port));
			tmp &= BXT_PIPE_SELECT_MASK;
			tmp >>= BXT_PIPE_SELECT_SHIFT;

			if (WARN_ON(tmp > PIPE_C))
				continue;

			*pipe = tmp;
		} else {
			*pipe = port == PORT_A ? PIPE_A : PIPE_B;
		}

804 805
		active = true;
		break;
806
	}
807

808
out_put_power:
809
	intel_display_power_put(dev_priv, power_domain);
810

811
	return active;
812 813
}

814 815 816 817
static void bxt_dsi_get_pipe_config(struct intel_encoder *encoder,
				 struct intel_crtc_state *pipe_config)
{
	struct drm_device *dev = encoder->base.dev;
818
	struct drm_i915_private *dev_priv = to_i915(dev);
819 820
	struct drm_display_mode *adjusted_mode =
					&pipe_config->base.adjusted_mode;
821 822
	struct drm_display_mode *adjusted_mode_sw;
	struct intel_crtc *intel_crtc;
823
	struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
824
	unsigned int lane_count = intel_dsi->lane_count;
825 826
	unsigned int bpp, fmt;
	enum port port;
827
	u16 hactive, hfp, hsync, hbp, vfp, vsync, vbp;
828 829 830 831
	u16 hfp_sw, hsync_sw, hbp_sw;
	u16 crtc_htotal_sw, crtc_hsync_start_sw, crtc_hsync_end_sw,
				crtc_hblank_start_sw, crtc_hblank_end_sw;

832
	/* FIXME: hw readout should not depend on SW state */
833 834
	intel_crtc = to_intel_crtc(encoder->base.crtc);
	adjusted_mode_sw = &intel_crtc->config->base.adjusted_mode;
835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858

	/*
	 * Atleast one port is active as encoder->get_config called only if
	 * encoder->get_hw_state() returns true.
	 */
	for_each_dsi_port(port, intel_dsi->ports) {
		if (I915_READ(BXT_MIPI_PORT_CTRL(port)) & DPI_ENABLE)
			break;
	}

	fmt = I915_READ(MIPI_DSI_FUNC_PRG(port)) & VID_MODE_FORMAT_MASK;
	pipe_config->pipe_bpp =
			mipi_dsi_pixel_format_to_bpp(
				pixel_format_from_register_bits(fmt));
	bpp = pipe_config->pipe_bpp;

	/* In terms of pixels */
	adjusted_mode->crtc_hdisplay =
				I915_READ(BXT_MIPI_TRANS_HACTIVE(port));
	adjusted_mode->crtc_vdisplay =
				I915_READ(BXT_MIPI_TRANS_VACTIVE(port));
	adjusted_mode->crtc_vtotal =
				I915_READ(BXT_MIPI_TRANS_VTOTAL(port));

859 860 861
	hactive = adjusted_mode->crtc_hdisplay;
	hfp = I915_READ(MIPI_HFP_COUNT(port));

862
	/*
863 864
	 * Meaningful for video mode non-burst sync pulse mode only,
	 * can be zero for non-burst sync events and burst modes
865
	 */
866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881
	hsync = I915_READ(MIPI_HSYNC_PADDING_COUNT(port));
	hbp = I915_READ(MIPI_HBP_COUNT(port));

	/* harizontal values are in terms of high speed byte clock */
	hfp = pixels_from_txbyteclkhs(hfp, bpp, lane_count,
						intel_dsi->burst_mode_ratio);
	hsync = pixels_from_txbyteclkhs(hsync, bpp, lane_count,
						intel_dsi->burst_mode_ratio);
	hbp = pixels_from_txbyteclkhs(hbp, bpp, lane_count,
						intel_dsi->burst_mode_ratio);

	if (intel_dsi->dual_link) {
		hfp *= 2;
		hsync *= 2;
		hbp *= 2;
	}
882 883 884 885 886 887

	/* vertical values are in terms of lines */
	vfp = I915_READ(MIPI_VFP_COUNT(port));
	vsync = I915_READ(MIPI_VSYNC_PADDING_COUNT(port));
	vbp = I915_READ(MIPI_VBP_COUNT(port));

888 889 890
	adjusted_mode->crtc_htotal = hactive + hfp + hsync + hbp;
	adjusted_mode->crtc_hsync_start = hfp + adjusted_mode->crtc_hdisplay;
	adjusted_mode->crtc_hsync_end = hsync + adjusted_mode->crtc_hsync_start;
891
	adjusted_mode->crtc_hblank_start = adjusted_mode->crtc_hdisplay;
892
	adjusted_mode->crtc_hblank_end = adjusted_mode->crtc_htotal;
893

894 895
	adjusted_mode->crtc_vsync_start = vfp + adjusted_mode->crtc_vdisplay;
	adjusted_mode->crtc_vsync_end = vsync + adjusted_mode->crtc_vsync_start;
896 897 898
	adjusted_mode->crtc_vblank_start = adjusted_mode->crtc_vdisplay;
	adjusted_mode->crtc_vblank_end = adjusted_mode->crtc_vtotal;

899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970
	/*
	 * In BXT DSI there is no regs programmed with few horizontal timings
	 * in Pixels but txbyteclkhs.. So retrieval process adds some
	 * ROUND_UP ERRORS in the process of PIXELS<==>txbyteclkhs.
	 * Actually here for the given adjusted_mode, we are calculating the
	 * value programmed to the port and then back to the horizontal timing
	 * param in pixels. This is the expected value, including roundup errors
	 * And if that is same as retrieved value from port, then
	 * (HW state) adjusted_mode's horizontal timings are corrected to
	 * match with SW state to nullify the errors.
	 */
	/* Calculating the value programmed to the Port register */
	hfp_sw = adjusted_mode_sw->crtc_hsync_start -
					adjusted_mode_sw->crtc_hdisplay;
	hsync_sw = adjusted_mode_sw->crtc_hsync_end -
					adjusted_mode_sw->crtc_hsync_start;
	hbp_sw = adjusted_mode_sw->crtc_htotal -
					adjusted_mode_sw->crtc_hsync_end;

	if (intel_dsi->dual_link) {
		hfp_sw /= 2;
		hsync_sw /= 2;
		hbp_sw /= 2;
	}

	hfp_sw = txbyteclkhs(hfp_sw, bpp, lane_count,
						intel_dsi->burst_mode_ratio);
	hsync_sw = txbyteclkhs(hsync_sw, bpp, lane_count,
			    intel_dsi->burst_mode_ratio);
	hbp_sw = txbyteclkhs(hbp_sw, bpp, lane_count,
						intel_dsi->burst_mode_ratio);

	/* Reverse calculating the adjusted mode parameters from port reg vals*/
	hfp_sw = pixels_from_txbyteclkhs(hfp_sw, bpp, lane_count,
						intel_dsi->burst_mode_ratio);
	hsync_sw = pixels_from_txbyteclkhs(hsync_sw, bpp, lane_count,
						intel_dsi->burst_mode_ratio);
	hbp_sw = pixels_from_txbyteclkhs(hbp_sw, bpp, lane_count,
						intel_dsi->burst_mode_ratio);

	if (intel_dsi->dual_link) {
		hfp_sw *= 2;
		hsync_sw *= 2;
		hbp_sw *= 2;
	}

	crtc_htotal_sw = adjusted_mode_sw->crtc_hdisplay + hfp_sw +
							hsync_sw + hbp_sw;
	crtc_hsync_start_sw = hfp_sw + adjusted_mode_sw->crtc_hdisplay;
	crtc_hsync_end_sw = hsync_sw + crtc_hsync_start_sw;
	crtc_hblank_start_sw = adjusted_mode_sw->crtc_hdisplay;
	crtc_hblank_end_sw = crtc_htotal_sw;

	if (adjusted_mode->crtc_htotal == crtc_htotal_sw)
		adjusted_mode->crtc_htotal = adjusted_mode_sw->crtc_htotal;

	if (adjusted_mode->crtc_hsync_start == crtc_hsync_start_sw)
		adjusted_mode->crtc_hsync_start =
					adjusted_mode_sw->crtc_hsync_start;

	if (adjusted_mode->crtc_hsync_end == crtc_hsync_end_sw)
		adjusted_mode->crtc_hsync_end =
					adjusted_mode_sw->crtc_hsync_end;

	if (adjusted_mode->crtc_hblank_start == crtc_hblank_start_sw)
		adjusted_mode->crtc_hblank_start =
					adjusted_mode_sw->crtc_hblank_start;

	if (adjusted_mode->crtc_hblank_end == crtc_hblank_end_sw)
		adjusted_mode->crtc_hblank_end =
					adjusted_mode_sw->crtc_hblank_end;
}
971

972
static void intel_dsi_get_config(struct intel_encoder *encoder,
973
				 struct intel_crtc_state *pipe_config)
974
{
975
	struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
976
	u32 pclk;
977 978
	DRM_DEBUG_KMS("\n");

979
	if (IS_BROXTON(dev_priv))
980 981
		bxt_dsi_get_pipe_config(encoder, pipe_config);

982 983
	pclk = intel_dsi_get_pclk(encoder, pipe_config->pipe_bpp,
				  pipe_config);
984 985 986
	if (!pclk)
		return;

987
	pipe_config->base.adjusted_mode.crtc_clock = pclk;
988
	pipe_config->port_clock = pclk;
989 990
}

991 992 993
static enum drm_mode_status
intel_dsi_mode_valid(struct drm_connector *connector,
		     struct drm_display_mode *mode)
994 995
{
	struct intel_connector *intel_connector = to_intel_connector(connector);
V
Ville Syrjälä 已提交
996
	const struct drm_display_mode *fixed_mode = intel_connector->panel.fixed_mode;
M
Mika Kahola 已提交
997
	int max_dotclk = to_i915(connector->dev)->max_dotclk_freq;
998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010

	DRM_DEBUG_KMS("\n");

	if (mode->flags & DRM_MODE_FLAG_DBLSCAN) {
		DRM_DEBUG_KMS("MODE_NO_DBLESCAN\n");
		return MODE_NO_DBLESCAN;
	}

	if (fixed_mode) {
		if (mode->hdisplay > fixed_mode->hdisplay)
			return MODE_PANEL;
		if (mode->vdisplay > fixed_mode->vdisplay)
			return MODE_PANEL;
M
Mika Kahola 已提交
1011 1012
		if (fixed_mode->clock > max_dotclk)
			return MODE_CLOCK_HIGH;
1013 1014
	}

1015
	return MODE_OK;
1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032
}

/* return txclkesc cycles in terms of divider and duration in us */
static u16 txclkesc(u32 divider, unsigned int us)
{
	switch (divider) {
	case ESCAPE_CLOCK_DIVIDER_1:
	default:
		return 20 * us;
	case ESCAPE_CLOCK_DIVIDER_2:
		return 10 * us;
	case ESCAPE_CLOCK_DIVIDER_4:
		return 5 * us;
	}
}

static void set_dsi_timings(struct drm_encoder *encoder,
1033
			    const struct drm_display_mode *adjusted_mode)
1034 1035
{
	struct drm_device *dev = encoder->dev;
1036
	struct drm_i915_private *dev_priv = to_i915(dev);
1037
	struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
1038
	enum port port;
1039
	unsigned int bpp = mipi_dsi_pixel_format_to_bpp(intel_dsi->pixel_format);
1040 1041 1042 1043
	unsigned int lane_count = intel_dsi->lane_count;

	u16 hactive, hfp, hsync, hbp, vfp, vsync, vbp;

1044 1045 1046 1047
	hactive = adjusted_mode->crtc_hdisplay;
	hfp = adjusted_mode->crtc_hsync_start - adjusted_mode->crtc_hdisplay;
	hsync = adjusted_mode->crtc_hsync_end - adjusted_mode->crtc_hsync_start;
	hbp = adjusted_mode->crtc_htotal - adjusted_mode->crtc_hsync_end;
1048

1049 1050 1051 1052 1053 1054 1055 1056 1057
	if (intel_dsi->dual_link) {
		hactive /= 2;
		if (intel_dsi->dual_link == DSI_DUAL_LINK_FRONT_BACK)
			hactive += intel_dsi->pixel_overlap;
		hfp /= 2;
		hsync /= 2;
		hbp /= 2;
	}

1058 1059 1060
	vfp = adjusted_mode->crtc_vsync_start - adjusted_mode->crtc_vdisplay;
	vsync = adjusted_mode->crtc_vsync_end - adjusted_mode->crtc_vsync_start;
	vbp = adjusted_mode->crtc_vtotal - adjusted_mode->crtc_vsync_end;
1061 1062

	/* horizontal values are in terms of high speed byte clock */
1063
	hactive = txbyteclkhs(hactive, bpp, lane_count,
1064
			      intel_dsi->burst_mode_ratio);
1065 1066
	hfp = txbyteclkhs(hfp, bpp, lane_count, intel_dsi->burst_mode_ratio);
	hsync = txbyteclkhs(hsync, bpp, lane_count,
1067
			    intel_dsi->burst_mode_ratio);
1068
	hbp = txbyteclkhs(hbp, bpp, lane_count, intel_dsi->burst_mode_ratio);
1069

1070
	for_each_dsi_port(port, intel_dsi->ports) {
1071
		if (IS_BROXTON(dev_priv)) {
1072 1073 1074 1075 1076 1077 1078
			/*
			 * Program hdisplay and vdisplay on MIPI transcoder.
			 * This is different from calculated hactive and
			 * vactive, as they are calculated per channel basis,
			 * whereas these values should be based on resolution.
			 */
			I915_WRITE(BXT_MIPI_TRANS_HACTIVE(port),
1079
				   adjusted_mode->crtc_hdisplay);
1080
			I915_WRITE(BXT_MIPI_TRANS_VACTIVE(port),
1081
				   adjusted_mode->crtc_vdisplay);
1082
			I915_WRITE(BXT_MIPI_TRANS_VTOTAL(port),
1083
				   adjusted_mode->crtc_vtotal);
1084 1085
		}

1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098
		I915_WRITE(MIPI_HACTIVE_AREA_COUNT(port), hactive);
		I915_WRITE(MIPI_HFP_COUNT(port), hfp);

		/* meaningful for video mode non-burst sync pulse mode only,
		 * can be zero for non-burst sync events and burst modes */
		I915_WRITE(MIPI_HSYNC_PADDING_COUNT(port), hsync);
		I915_WRITE(MIPI_HBP_COUNT(port), hbp);

		/* vertical values are in terms of lines */
		I915_WRITE(MIPI_VFP_COUNT(port), vfp);
		I915_WRITE(MIPI_VSYNC_PADDING_COUNT(port), vsync);
		I915_WRITE(MIPI_VBP_COUNT(port), vbp);
	}
1099 1100
}

1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117
static u32 pixel_format_to_reg(enum mipi_dsi_pixel_format fmt)
{
	switch (fmt) {
	case MIPI_DSI_FMT_RGB888:
		return VID_MODE_FORMAT_RGB888;
	case MIPI_DSI_FMT_RGB666:
		return VID_MODE_FORMAT_RGB666;
	case MIPI_DSI_FMT_RGB666_PACKED:
		return VID_MODE_FORMAT_RGB666_PACKED;
	case MIPI_DSI_FMT_RGB565:
		return VID_MODE_FORMAT_RGB565;
	default:
		MISSING_CASE(fmt);
		return VID_MODE_FORMAT_RGB666;
	}
}

1118 1119
static void intel_dsi_prepare(struct intel_encoder *intel_encoder,
			      struct intel_crtc_state *pipe_config)
1120 1121 1122
{
	struct drm_encoder *encoder = &intel_encoder->base;
	struct drm_device *dev = encoder->dev;
1123
	struct drm_i915_private *dev_priv = to_i915(dev);
1124
	struct intel_crtc *intel_crtc = to_intel_crtc(pipe_config->base.crtc);
1125
	struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
1126
	const struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
1127
	enum port port;
1128
	unsigned int bpp = mipi_dsi_pixel_format_to_bpp(intel_dsi->pixel_format);
1129
	u32 val, tmp;
1130
	u16 mode_hdisplay;
1131

1132
	DRM_DEBUG_KMS("pipe %c\n", pipe_name(intel_crtc->pipe));
1133

1134
	mode_hdisplay = adjusted_mode->crtc_hdisplay;
1135

1136 1137 1138 1139 1140
	if (intel_dsi->dual_link) {
		mode_hdisplay /= 2;
		if (intel_dsi->dual_link == DSI_DUAL_LINK_FRONT_BACK)
			mode_hdisplay += intel_dsi->pixel_overlap;
	}
1141

1142
	for_each_dsi_port(port, intel_dsi->ports) {
1143
		if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) {
1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157
			/*
			 * escape clock divider, 20MHz, shared for A and C.
			 * device ready must be off when doing this! txclkesc?
			 */
			tmp = I915_READ(MIPI_CTRL(PORT_A));
			tmp &= ~ESCAPE_CLOCK_DIVIDER_MASK;
			I915_WRITE(MIPI_CTRL(PORT_A), tmp |
					ESCAPE_CLOCK_DIVIDER_1);

			/* read request priority is per pipe */
			tmp = I915_READ(MIPI_CTRL(port));
			tmp &= ~READ_REQUEST_PRIORITY_MASK;
			I915_WRITE(MIPI_CTRL(port), tmp |
					READ_REQUEST_PRIORITY_HIGH);
1158
		} else if (IS_BROXTON(dev_priv)) {
1159 1160
			enum pipe pipe = intel_crtc->pipe;

1161 1162 1163
			tmp = I915_READ(MIPI_CTRL(port));
			tmp &= ~BXT_PIPE_SELECT_MASK;

1164
			tmp |= BXT_PIPE_SELECT(pipe);
1165 1166
			I915_WRITE(MIPI_CTRL(port), tmp);
		}
1167 1168 1169 1170 1171 1172 1173 1174

		/* XXX: why here, why like this? handling in irq handler?! */
		I915_WRITE(MIPI_INTR_STAT(port), 0xffffffff);
		I915_WRITE(MIPI_INTR_EN(port), 0xffffffff);

		I915_WRITE(MIPI_DPHY_PARAM(port), intel_dsi->dphy_reg);

		I915_WRITE(MIPI_DPI_RESOLUTION(port),
1175
			adjusted_mode->crtc_vdisplay << VERTICAL_ADDRESS_SHIFT |
1176 1177
			mode_hdisplay << HORIZONTAL_ADDRESS_SHIFT);
	}
1178 1179 1180 1181 1182 1183 1184 1185 1186

	set_dsi_timings(encoder, adjusted_mode);

	val = intel_dsi->lane_count << DATA_LANES_PRG_REG_SHIFT;
	if (is_cmd_mode(intel_dsi)) {
		val |= intel_dsi->channel << CMD_MODE_CHANNEL_NUMBER_SHIFT;
		val |= CMD_MODE_DATA_WIDTH_8_BIT; /* XXX */
	} else {
		val |= intel_dsi->channel << VID_MODE_CHANNEL_NUMBER_SHIFT;
1187
		val |= pixel_format_to_reg(intel_dsi->pixel_format);
1188 1189
	}

1190 1191 1192 1193 1194
	tmp = 0;
	if (intel_dsi->eotp_pkt == 0)
		tmp |= EOT_DISABLE;
	if (intel_dsi->clock_stop)
		tmp |= CLOCKSTOP;
1195

1196 1197 1198 1199 1200 1201
	if (IS_BROXTON(dev_priv)) {
		tmp |= BXT_DPHY_DEFEATURE_EN;
		if (!is_cmd_mode(intel_dsi))
			tmp |= BXT_DEFEATURE_DPI_FIFO_CTR;
	}

1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220
	for_each_dsi_port(port, intel_dsi->ports) {
		I915_WRITE(MIPI_DSI_FUNC_PRG(port), val);

		/* timeouts for recovery. one frame IIUC. if counter expires,
		 * EOT and stop state. */

		/*
		 * In burst mode, value greater than one DPI line Time in byte
		 * clock (txbyteclkhs) To timeout this timer 1+ of the above
		 * said value is recommended.
		 *
		 * In non-burst mode, Value greater than one DPI frame time in
		 * byte clock(txbyteclkhs) To timeout this timer 1+ of the above
		 * said value is recommended.
		 *
		 * In DBI only mode, value greater than one DBI frame time in
		 * byte clock(txbyteclkhs) To timeout this timer 1+ of the above
		 * said value is recommended.
		 */
1221

1222 1223 1224
		if (is_vid_mode(intel_dsi) &&
			intel_dsi->video_mode_format == VIDEO_MODE_BURST) {
			I915_WRITE(MIPI_HS_TX_TIMEOUT(port),
1225
				txbyteclkhs(adjusted_mode->crtc_htotal, bpp,
1226 1227
					    intel_dsi->lane_count,
					    intel_dsi->burst_mode_ratio) + 1);
1228 1229
		} else {
			I915_WRITE(MIPI_HS_TX_TIMEOUT(port),
1230 1231
				txbyteclkhs(adjusted_mode->crtc_vtotal *
					    adjusted_mode->crtc_htotal,
1232 1233
					    bpp, intel_dsi->lane_count,
					    intel_dsi->burst_mode_ratio) + 1);
1234 1235 1236 1237 1238 1239
		}
		I915_WRITE(MIPI_LP_RX_TIMEOUT(port), intel_dsi->lp_rx_timeout);
		I915_WRITE(MIPI_TURN_AROUND_TIMEOUT(port),
						intel_dsi->turn_arnd_val);
		I915_WRITE(MIPI_DEVICE_RESET_TIMER(port),
						intel_dsi->rst_timer_val);
1240

1241
		/* dphy stuff */
1242

1243 1244 1245
		/* in terms of low power clock */
		I915_WRITE(MIPI_INIT_COUNT(port),
				txclkesc(intel_dsi->escape_clk_div, 100));
1246

1247
		if (IS_BROXTON(dev_priv) && (!intel_dsi->dual_link)) {
1248 1249 1250 1251 1252 1253 1254 1255 1256 1257
			/*
			 * BXT spec says write MIPI_INIT_COUNT for
			 * both the ports, even if only one is
			 * getting used. So write the other port
			 * if not in dual link mode.
			 */
			I915_WRITE(MIPI_INIT_COUNT(port ==
						PORT_A ? PORT_C : PORT_A),
					intel_dsi->init_count);
		}
1258

1259
		/* recovery disables */
1260
		I915_WRITE(MIPI_EOT_DISABLE(port), tmp);
1261

1262 1263
		/* in terms of low power clock */
		I915_WRITE(MIPI_INIT_COUNT(port), intel_dsi->init_count);
1264

1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299 1300 1301
		/* in terms of txbyteclkhs. actual high to low switch +
		 * MIPI_STOP_STATE_STALL * MIPI_LP_BYTECLK.
		 *
		 * XXX: write MIPI_STOP_STATE_STALL?
		 */
		I915_WRITE(MIPI_HIGH_LOW_SWITCH_COUNT(port),
						intel_dsi->hs_to_lp_count);

		/* XXX: low power clock equivalence in terms of byte clock.
		 * the number of byte clocks occupied in one low power clock.
		 * based on txbyteclkhs and txclkesc.
		 * txclkesc time / txbyteclk time * (105 + MIPI_STOP_STATE_STALL
		 * ) / 105.???
		 */
		I915_WRITE(MIPI_LP_BYTECLK(port), intel_dsi->lp_byte_clk);

		/* the bw essential for transmitting 16 long packets containing
		 * 252 bytes meant for dcs write memory command is programmed in
		 * this register in terms of byte clocks. based on dsi transfer
		 * rate and the number of lanes configured the time taken to
		 * transmit 16 long packets in a dsi stream varies. */
		I915_WRITE(MIPI_DBI_BW_CTRL(port), intel_dsi->bw_timer);

		I915_WRITE(MIPI_CLK_LANE_SWITCH_TIME_CNT(port),
		intel_dsi->clk_lp_to_hs_count << LP_HS_SSW_CNT_SHIFT |
		intel_dsi->clk_hs_to_lp_count << HS_LP_PWR_SW_CNT_SHIFT);

		if (is_vid_mode(intel_dsi))
			/* Some panels might have resolution which is not a
			 * multiple of 64 like 1366 x 768. Enable RANDOM
			 * resolution support for such panels by default */
			I915_WRITE(MIPI_VIDEO_MODE_FORMAT(port),
				intel_dsi->video_frmt_cfg_bits |
				intel_dsi->video_mode_format |
				IP_TG_CONFIG |
				RANDOM_DPI_DISPLAY_RESOLUTION);
	}
1302 1303 1304 1305 1306
}

static enum drm_connector_status
intel_dsi_detect(struct drm_connector *connector, bool force)
{
1307
	return connector_status_connected;
1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332
}

static int intel_dsi_get_modes(struct drm_connector *connector)
{
	struct intel_connector *intel_connector = to_intel_connector(connector);
	struct drm_display_mode *mode;

	DRM_DEBUG_KMS("\n");

	if (!intel_connector->panel.fixed_mode) {
		DRM_DEBUG_KMS("no fixed mode\n");
		return 0;
	}

	mode = drm_mode_duplicate(connector->dev,
				  intel_connector->panel.fixed_mode);
	if (!mode) {
		DRM_DEBUG_KMS("drm_mode_duplicate failed\n");
		return 0;
	}

	drm_mode_probed_add(connector, mode);
	return 1;
}

V
Ville Syrjälä 已提交
1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350
static int intel_dsi_set_property(struct drm_connector *connector,
				  struct drm_property *property,
				  uint64_t val)
{
	struct drm_device *dev = connector->dev;
	struct intel_connector *intel_connector = to_intel_connector(connector);
	struct drm_crtc *crtc;
	int ret;

	ret = drm_object_property_set_value(&connector->base, property, val);
	if (ret)
		return ret;

	if (property == dev->mode_config.scaling_mode_property) {
		if (val == DRM_MODE_SCALE_NONE) {
			DRM_DEBUG_KMS("no scaling not supported\n");
			return -EINVAL;
		}
1351
		if (HAS_GMCH_DISPLAY(to_i915(dev)) &&
1352 1353 1354 1355
		    val == DRM_MODE_SCALE_CENTER) {
			DRM_DEBUG_KMS("centering not supported\n");
			return -EINVAL;
		}
V
Ville Syrjälä 已提交
1356 1357 1358 1359 1360 1361 1362

		if (intel_connector->panel.fitting_mode == val)
			return 0;

		intel_connector->panel.fitting_mode = val;
	}

1363
	crtc = connector->state->crtc;
V
Ville Syrjälä 已提交
1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374
	if (crtc && crtc->state->enable) {
		/*
		 * If the CRTC is enabled, the display will be changed
		 * according to the new panel fitting mode.
		 */
		intel_crtc_restore_mode(crtc);
	}

	return 0;
}

1375
static void intel_dsi_connector_destroy(struct drm_connector *connector)
1376 1377 1378 1379 1380 1381 1382 1383 1384
{
	struct intel_connector *intel_connector = to_intel_connector(connector);

	DRM_DEBUG_KMS("\n");
	intel_panel_fini(&intel_connector->panel);
	drm_connector_cleanup(connector);
	kfree(connector);
}

1385 1386 1387 1388 1389 1390 1391 1392 1393
static void intel_dsi_encoder_destroy(struct drm_encoder *encoder)
{
	struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);

	if (intel_dsi->panel) {
		drm_panel_detach(intel_dsi->panel);
		/* XXX: Logically this call belongs in the panel driver. */
		drm_panel_remove(intel_dsi->panel);
	}
1394 1395 1396 1397 1398

	/* dispose of the gpios */
	if (intel_dsi->gpio_panel)
		gpiod_put(intel_dsi->gpio_panel);

1399 1400 1401
	intel_encoder_destroy(encoder);
}

1402
static const struct drm_encoder_funcs intel_dsi_funcs = {
1403
	.destroy = intel_dsi_encoder_destroy,
1404 1405 1406 1407 1408 1409 1410 1411
};

static const struct drm_connector_helper_funcs intel_dsi_connector_helper_funcs = {
	.get_modes = intel_dsi_get_modes,
	.mode_valid = intel_dsi_mode_valid,
};

static const struct drm_connector_funcs intel_dsi_connector_funcs = {
1412
	.dpms = drm_atomic_helper_connector_dpms,
1413
	.detect = intel_dsi_detect,
1414
	.late_register = intel_connector_register,
1415
	.early_unregister = intel_connector_unregister,
1416
	.destroy = intel_dsi_connector_destroy,
1417
	.fill_modes = drm_helper_probe_single_connector_modes,
V
Ville Syrjälä 已提交
1418
	.set_property = intel_dsi_set_property,
1419
	.atomic_get_property = intel_connector_atomic_get_property,
1420
	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
1421
	.atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
1422 1423
};

V
Ville Syrjälä 已提交
1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436
static void intel_dsi_add_properties(struct intel_connector *connector)
{
	struct drm_device *dev = connector->base.dev;

	if (connector->panel.fixed_mode) {
		drm_mode_create_scaling_mode_property(dev);
		drm_object_attach_property(&connector->base.base,
					   dev->mode_config.scaling_mode_property,
					   DRM_MODE_SCALE_ASPECT);
		connector->panel.fitting_mode = DRM_MODE_SCALE_ASPECT;
	}
}

1437
void intel_dsi_init(struct drm_i915_private *dev_priv)
1438
{
1439
	struct drm_device *dev = &dev_priv->drm;
1440 1441 1442 1443 1444
	struct intel_dsi *intel_dsi;
	struct intel_encoder *intel_encoder;
	struct drm_encoder *encoder;
	struct intel_connector *intel_connector;
	struct drm_connector *connector;
1445
	struct drm_display_mode *scan, *fixed_mode = NULL;
1446
	enum port port;
1447 1448 1449 1450
	unsigned int i;

	DRM_DEBUG_KMS("\n");

1451
	/* There is no detection method for MIPI so rely on VBT */
1452
	if (!intel_bios_is_dsi_present(dev_priv, &port))
1453
		return;
1454

1455
	if (IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) {
1456
		dev_priv->mipi_mmio_base = VLV_MIPI_BASE;
1457
	} else if (IS_BROXTON(dev_priv)) {
1458
		dev_priv->mipi_mmio_base = BXT_MIPI_BASE;
1459 1460 1461 1462
	} else {
		DRM_ERROR("Unsupported Mipi device to reg base");
		return;
	}
1463

1464 1465
	intel_dsi = kzalloc(sizeof(*intel_dsi), GFP_KERNEL);
	if (!intel_dsi)
1466
		return;
1467

1468
	intel_connector = intel_connector_alloc();
1469 1470
	if (!intel_connector) {
		kfree(intel_dsi);
1471
		return;
1472 1473 1474 1475 1476 1477 1478 1479
	}

	intel_encoder = &intel_dsi->base;
	encoder = &intel_encoder->base;
	intel_dsi->attached_connector = intel_connector;

	connector = &intel_connector->base;

1480
	drm_encoder_init(dev, encoder, &intel_dsi_funcs, DRM_MODE_ENCODER_DSI,
1481
			 "DSI %c", port_name(port));
1482 1483 1484

	intel_encoder->compute_config = intel_dsi_compute_config;
	intel_encoder->pre_enable = intel_dsi_pre_enable;
1485
	intel_encoder->enable = intel_dsi_enable_nop;
1486
	intel_encoder->disable = intel_dsi_pre_disable;
1487 1488 1489 1490 1491 1492
	intel_encoder->post_disable = intel_dsi_post_disable;
	intel_encoder->get_hw_state = intel_dsi_get_hw_state;
	intel_encoder->get_config = intel_dsi_get_config;

	intel_connector->get_hw_state = intel_connector_get_hw_state;

1493
	intel_encoder->port = port;
1494 1495 1496 1497 1498 1499 1500
	/*
	 * On BYT/CHV, pipe A maps to MIPI DSI port A, pipe B maps to MIPI DSI
	 * port C. BXT isn't limited like this.
	 */
	if (IS_BROXTON(dev_priv))
		intel_encoder->crtc_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C);
	else if (port == PORT_A)
1501
		intel_encoder->crtc_mask = BIT(PIPE_A);
1502
	else
1503
		intel_encoder->crtc_mask = BIT(PIPE_B);
1504

1505
	if (dev_priv->vbt.dsi.config->dual_link) {
1506
		intel_dsi->ports = BIT(PORT_A) | BIT(PORT_C);
1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519

		switch (dev_priv->vbt.dsi.config->dl_dcs_backlight_ports) {
		case DL_DCS_PORT_A:
			intel_dsi->dcs_backlight_ports = BIT(PORT_A);
			break;
		case DL_DCS_PORT_C:
			intel_dsi->dcs_backlight_ports = BIT(PORT_C);
			break;
		default:
		case DL_DCS_PORT_A_AND_C:
			intel_dsi->dcs_backlight_ports = BIT(PORT_A) | BIT(PORT_C);
			break;
		}
1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532

		switch (dev_priv->vbt.dsi.config->dl_dcs_cabc_ports) {
		case DL_DCS_PORT_A:
			intel_dsi->dcs_cabc_ports = BIT(PORT_A);
			break;
		case DL_DCS_PORT_C:
			intel_dsi->dcs_cabc_ports = BIT(PORT_C);
			break;
		default:
		case DL_DCS_PORT_A_AND_C:
			intel_dsi->dcs_cabc_ports = BIT(PORT_A) | BIT(PORT_C);
			break;
		}
1533
	} else {
1534
		intel_dsi->ports = BIT(port);
1535
		intel_dsi->dcs_backlight_ports = BIT(port);
1536
		intel_dsi->dcs_cabc_ports = BIT(port);
1537
	}
1538

1539 1540 1541
	if (!dev_priv->vbt.dsi.config->cabc_supported)
		intel_dsi->dcs_cabc_ports = 0;

1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552
	/* Create a DSI host (and a device) for each port. */
	for_each_dsi_port(port, intel_dsi->ports) {
		struct intel_dsi_host *host;

		host = intel_dsi_host_init(intel_dsi, port);
		if (!host)
			goto err;

		intel_dsi->dsi_hosts[port] = host;
	}

1553 1554 1555 1556
	for (i = 0; i < ARRAY_SIZE(intel_dsi_drivers); i++) {
		intel_dsi->panel = intel_dsi_drivers[i].init(intel_dsi,
							     intel_dsi_drivers[i].panel_id);
		if (intel_dsi->panel)
1557 1558 1559
			break;
	}

1560
	if (!intel_dsi->panel) {
1561 1562 1563 1564
		DRM_DEBUG_KMS("no device found\n");
		goto err;
	}

1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578
	/*
	 * In case of BYT with CRC PMIC, we need to use GPIO for
	 * Panel control.
	 */
	if (dev_priv->vbt.dsi.config->pwm_blc == PPS_BLC_PMIC) {
		intel_dsi->gpio_panel =
			gpiod_get(dev->dev, "panel", GPIOD_OUT_HIGH);

		if (IS_ERR(intel_dsi->gpio_panel)) {
			DRM_ERROR("Failed to own gpio for panel control\n");
			intel_dsi->gpio_panel = NULL;
		}
	}

1579
	intel_encoder->type = INTEL_OUTPUT_DSI;
1580
	intel_encoder->cloneable = 0;
1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591
	drm_connector_init(dev, connector, &intel_dsi_connector_funcs,
			   DRM_MODE_CONNECTOR_DSI);

	drm_connector_helper_add(connector, &intel_dsi_connector_helper_funcs);

	connector->display_info.subpixel_order = SubPixelHorizontalRGB; /*XXX*/
	connector->interlace_allowed = false;
	connector->doublescan_allowed = false;

	intel_connector_attach_encoder(intel_connector, intel_encoder);

1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603
	drm_panel_attach(intel_dsi->panel, connector);

	mutex_lock(&dev->mode_config.mutex);
	drm_panel_get_modes(intel_dsi->panel);
	list_for_each_entry(scan, &connector->probed_modes, head) {
		if ((scan->type & DRM_MODE_TYPE_PREFERRED)) {
			fixed_mode = drm_mode_duplicate(dev, scan);
			break;
		}
	}
	mutex_unlock(&dev->mode_config.mutex);

1604 1605 1606 1607 1608
	if (!fixed_mode) {
		DRM_DEBUG_KMS("no fixed mode\n");
		goto err;
	}

1609 1610 1611
	connector->display_info.width_mm = fixed_mode->width_mm;
	connector->display_info.height_mm = fixed_mode->height_mm;

1612
	intel_panel_init(&intel_connector->panel, fixed_mode, NULL);
1613
	intel_panel_setup_backlight(connector, INVALID_PIPE);
V
Ville Syrjälä 已提交
1614 1615 1616

	intel_dsi_add_properties(intel_connector);

1617
	return;
1618 1619 1620 1621 1622 1623

err:
	drm_encoder_cleanup(&intel_encoder->base);
	kfree(intel_dsi);
	kfree(intel_connector);
}