br_fdb.c 16.0 KB
Newer Older
L
Linus Torvalds 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15
/*
 *	Forwarding database
 *	Linux ethernet bridge
 *
 *	Authors:
 *	Lennert Buytenhek		<buytenh@gnu.org>
 *
 *	This program is free software; you can redistribute it and/or
 *	modify it under the terms of the GNU General Public License
 *	as published by the Free Software Foundation; either version
 *	2 of the License, or (at your option) any later version.
 */

#include <linux/kernel.h>
#include <linux/init.h>
16
#include <linux/rculist.h>
L
Linus Torvalds 已提交
17 18 19 20 21
#include <linux/spinlock.h>
#include <linux/times.h>
#include <linux/netdevice.h>
#include <linux/etherdevice.h>
#include <linux/jhash.h>
22
#include <linux/random.h>
23
#include <linux/slab.h>
A
Arun Sharma 已提交
24
#include <linux/atomic.h>
25
#include <asm/unaligned.h>
L
Linus Torvalds 已提交
26 27
#include "br_private.h"

28
static struct kmem_cache *br_fdb_cache __read_mostly;
L
Linus Torvalds 已提交
29 30
static int fdb_insert(struct net_bridge *br, struct net_bridge_port *source,
		      const unsigned char *addr);
31
static void fdb_notify(const struct net_bridge_fdb_entry *, int);
L
Linus Torvalds 已提交
32

33 34
static u32 fdb_salt __read_mostly;

35
int __init br_fdb_init(void)
L
Linus Torvalds 已提交
36 37 38 39
{
	br_fdb_cache = kmem_cache_create("bridge_fdb_cache",
					 sizeof(struct net_bridge_fdb_entry),
					 0,
40
					 SLAB_HWCACHE_ALIGN, NULL);
41 42 43
	if (!br_fdb_cache)
		return -ENOMEM;

44
	get_random_bytes(&fdb_salt, sizeof(fdb_salt));
45
	return 0;
L
Linus Torvalds 已提交
46 47
}

A
Andrew Morton 已提交
48
void br_fdb_fini(void)
L
Linus Torvalds 已提交
49 50 51 52 53 54 55 56
{
	kmem_cache_destroy(br_fdb_cache);
}


/* if topology_changing then use forward_delay (default 15 sec)
 * otherwise keep longer (default 5 minutes)
 */
57
static inline unsigned long hold_time(const struct net_bridge *br)
L
Linus Torvalds 已提交
58 59 60 61
{
	return br->topology_change ? br->forward_delay : br->ageing_time;
}

62
static inline int has_expired(const struct net_bridge *br,
L
Linus Torvalds 已提交
63 64
				  const struct net_bridge_fdb_entry *fdb)
{
65
	return !fdb->is_static &&
66
		time_before_eq(fdb->updated + hold_time(br), jiffies);
L
Linus Torvalds 已提交
67 68
}

69
static inline int br_mac_hash(const unsigned char *mac)
L
Linus Torvalds 已提交
70
{
71 72 73
	/* use 1 byte of OUI cnd 3 bytes of NIC */
	u32 key = get_unaligned((u32 *)(mac + 2));
	return jhash_1word(key, fdb_salt) & (BR_HASH_SIZE - 1);
L
Linus Torvalds 已提交
74 75
}

76 77 78 79 80 81 82
static void fdb_rcu_free(struct rcu_head *head)
{
	struct net_bridge_fdb_entry *ent
		= container_of(head, struct net_bridge_fdb_entry, rcu);
	kmem_cache_free(br_fdb_cache, ent);
}

83
static inline void fdb_delete(struct net_bridge_fdb_entry *f)
L
Linus Torvalds 已提交
84
{
85
	fdb_notify(f, RTM_DELNEIGH);
L
Linus Torvalds 已提交
86
	hlist_del_rcu(&f->hlist);
87
	call_rcu(&f->rcu, fdb_rcu_free);
L
Linus Torvalds 已提交
88 89 90 91 92 93
}

void br_fdb_changeaddr(struct net_bridge_port *p, const unsigned char *newaddr)
{
	struct net_bridge *br = p->br;
	int i;
94

L
Linus Torvalds 已提交
95 96 97 98 99 100 101 102 103 104 105 106 107
	spin_lock_bh(&br->hash_lock);

	/* Search all chains since old address/hash is unknown */
	for (i = 0; i < BR_HASH_SIZE; i++) {
		struct hlist_node *h;
		hlist_for_each(h, &br->hash[i]) {
			struct net_bridge_fdb_entry *f;

			f = hlist_entry(h, struct net_bridge_fdb_entry, hlist);
			if (f->dst == p && f->is_local) {
				/* maybe another port has same hw addr? */
				struct net_bridge_port *op;
				list_for_each_entry(op, &br->port_list, list) {
108
					if (op != p &&
S
Stephen Hemminger 已提交
109 110
					    !compare_ether_addr(op->dev->dev_addr,
								f->addr.addr)) {
L
Linus Torvalds 已提交
111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132
						f->dst = op;
						goto insert;
					}
				}

				/* delete old one */
				fdb_delete(f);
				goto insert;
			}
		}
	}
 insert:
	/* insert new address,  may fail if invalid address or dup. */
	fdb_insert(br, p, newaddr);

	spin_unlock_bh(&br->hash_lock);
}

void br_fdb_cleanup(unsigned long _data)
{
	struct net_bridge *br = (struct net_bridge *)_data;
	unsigned long delay = hold_time(br);
133
	unsigned long next_timer = jiffies + br->ageing_time;
L
Linus Torvalds 已提交
134 135 136 137 138 139 140 141
	int i;

	spin_lock_bh(&br->hash_lock);
	for (i = 0; i < BR_HASH_SIZE; i++) {
		struct net_bridge_fdb_entry *f;
		struct hlist_node *h, *n;

		hlist_for_each_entry_safe(f, h, n, &br->hash[i], hlist) {
142 143 144
			unsigned long this_timer;
			if (f->is_static)
				continue;
145
			this_timer = f->updated + delay;
146
			if (time_before_eq(this_timer, jiffies))
L
Linus Torvalds 已提交
147
				fdb_delete(f);
148
			else if (time_before(this_timer, next_timer))
149
				next_timer = this_timer;
L
Linus Torvalds 已提交
150 151 152 153
		}
	}
	spin_unlock_bh(&br->hash_lock);

154
	mod_timer(&br->gc_timer, round_jiffies_up(next_timer));
L
Linus Torvalds 已提交
155 156
}

157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172
/* Completely flush all dynamic entries in forwarding database.*/
void br_fdb_flush(struct net_bridge *br)
{
	int i;

	spin_lock_bh(&br->hash_lock);
	for (i = 0; i < BR_HASH_SIZE; i++) {
		struct net_bridge_fdb_entry *f;
		struct hlist_node *h, *n;
		hlist_for_each_entry_safe(f, h, n, &br->hash[i], hlist) {
			if (!f->is_static)
				fdb_delete(f);
		}
	}
	spin_unlock_bh(&br->hash_lock);
}
173

L
Lucas De Marchi 已提交
174
/* Flush all entries referring to a specific port.
175 176
 * if do_all is set also flush static entries
 */
177 178 179
void br_fdb_delete_by_port(struct net_bridge *br,
			   const struct net_bridge_port *p,
			   int do_all)
L
Linus Torvalds 已提交
180 181 182 183 184 185
{
	int i;

	spin_lock_bh(&br->hash_lock);
	for (i = 0; i < BR_HASH_SIZE; i++) {
		struct hlist_node *h, *g;
186

L
Linus Torvalds 已提交
187 188 189
		hlist_for_each_safe(h, g, &br->hash[i]) {
			struct net_bridge_fdb_entry *f
				= hlist_entry(h, struct net_bridge_fdb_entry, hlist);
190
			if (f->dst != p)
L
Linus Torvalds 已提交
191 192
				continue;

193 194
			if (f->is_static && !do_all)
				continue;
L
Linus Torvalds 已提交
195 196 197 198 199 200 201 202
			/*
			 * if multiple ports all have the same device address
			 * then when one port is deleted, assign
			 * the local entry to other port
			 */
			if (f->is_local) {
				struct net_bridge_port *op;
				list_for_each_entry(op, &br->port_list, list) {
203
					if (op != p &&
S
Stephen Hemminger 已提交
204 205
					    !compare_ether_addr(op->dev->dev_addr,
								f->addr.addr)) {
L
Linus Torvalds 已提交
206 207 208 209 210 211 212 213 214 215 216 217 218
						f->dst = op;
						goto skip_delete;
					}
				}
			}

			fdb_delete(f);
		skip_delete: ;
		}
	}
	spin_unlock_bh(&br->hash_lock);
}

219
/* No locking or refcounting, assumes caller has rcu_read_lock */
L
Linus Torvalds 已提交
220 221 222 223 224 225 226
struct net_bridge_fdb_entry *__br_fdb_get(struct net_bridge *br,
					  const unsigned char *addr)
{
	struct hlist_node *h;
	struct net_bridge_fdb_entry *fdb;

	hlist_for_each_entry_rcu(fdb, h, &br->hash[br_mac_hash(addr)], hlist) {
S
Stephen Hemminger 已提交
227
		if (!compare_ether_addr(fdb->addr.addr, addr)) {
L
Linus Torvalds 已提交
228 229 230 231 232 233 234 235 236
			if (unlikely(has_expired(br, fdb)))
				break;
			return fdb;
		}
	}

	return NULL;
}

237 238 239 240
#if defined(CONFIG_ATM_LANE) || defined(CONFIG_ATM_LANE_MODULE)
/* Interface used by ATM LANE hook to test
 * if an addr is on some other bridge port */
int br_fdb_test_addr(struct net_device *dev, unsigned char *addr)
L
Linus Torvalds 已提交
241 242
{
	struct net_bridge_fdb_entry *fdb;
243
	struct net_bridge_port *port;
244 245
	int ret;

L
Linus Torvalds 已提交
246
	rcu_read_lock();
247 248 249 250 251 252 253 254
	port = br_port_get_rcu(dev);
	if (!port)
		ret = 0;
	else {
		fdb = __br_fdb_get(port->br, addr);
		ret = fdb && fdb->dst->dev != dev &&
			fdb->dst->state == BR_STATE_FORWARDING;
	}
L
Linus Torvalds 已提交
255 256
	rcu_read_unlock();

257
	return ret;
L
Linus Torvalds 已提交
258
}
259
#endif /* CONFIG_ATM_LANE */
L
Linus Torvalds 已提交
260 261

/*
262
 * Fill buffer with forwarding table records in
L
Linus Torvalds 已提交
263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280
 * the API format.
 */
int br_fdb_fillbuf(struct net_bridge *br, void *buf,
		   unsigned long maxnum, unsigned long skip)
{
	struct __fdb_entry *fe = buf;
	int i, num = 0;
	struct hlist_node *h;
	struct net_bridge_fdb_entry *f;

	memset(buf, 0, maxnum*sizeof(struct __fdb_entry));

	rcu_read_lock();
	for (i = 0; i < BR_HASH_SIZE; i++) {
		hlist_for_each_entry_rcu(f, h, &br->hash[i], hlist) {
			if (num >= maxnum)
				goto out;

281
			if (has_expired(br, f))
L
Linus Torvalds 已提交
282 283 284 285 286 287 288 289 290
				continue;

			if (skip) {
				--skip;
				continue;
			}

			/* convert from internal format to API */
			memcpy(fe->mac_addr, f->addr.addr, ETH_ALEN);
291 292

			/* due to ABI compat need to split into hi/lo */
L
Linus Torvalds 已提交
293
			fe->port_no = f->dst->port_no;
294 295
			fe->port_hi = f->dst->port_no >> 8;

L
Linus Torvalds 已提交
296 297
			fe->is_local = f->is_local;
			if (!f->is_static)
298
				fe->ageing_timer_value = jiffies_to_clock_t(jiffies - f->updated);
L
Linus Torvalds 已提交
299 300 301 302 303 304 305 306 307 308 309
			++fe;
			++num;
		}
	}

 out:
	rcu_read_unlock();

	return num;
}

310 311 312 313 314 315 316 317 318 319 320 321 322 323 324
static struct net_bridge_fdb_entry *fdb_find(struct hlist_head *head,
					     const unsigned char *addr)
{
	struct hlist_node *h;
	struct net_bridge_fdb_entry *fdb;

	hlist_for_each_entry(fdb, h, head, hlist) {
		if (!compare_ether_addr(fdb->addr.addr, addr))
			return fdb;
	}
	return NULL;
}

static struct net_bridge_fdb_entry *fdb_find_rcu(struct hlist_head *head,
						 const unsigned char *addr)
L
Linus Torvalds 已提交
325 326 327 328 329
{
	struct hlist_node *h;
	struct net_bridge_fdb_entry *fdb;

	hlist_for_each_entry_rcu(fdb, h, head, hlist) {
S
Stephen Hemminger 已提交
330
		if (!compare_ether_addr(fdb->addr.addr, addr))
L
Linus Torvalds 已提交
331 332 333 334 335 336 337
			return fdb;
	}
	return NULL;
}

static struct net_bridge_fdb_entry *fdb_create(struct hlist_head *head,
					       struct net_bridge_port *source,
338
					       const unsigned char *addr)
L
Linus Torvalds 已提交
339 340 341 342 343 344 345
{
	struct net_bridge_fdb_entry *fdb;

	fdb = kmem_cache_alloc(br_fdb_cache, GFP_ATOMIC);
	if (fdb) {
		memcpy(fdb->addr.addr, addr, ETH_ALEN);
		fdb->dst = source;
346 347
		fdb->is_local = 0;
		fdb->is_static = 0;
348
		fdb->updated = fdb->used = jiffies;
349
		hlist_add_head_rcu(&fdb->hlist, head);
350
		fdb_notify(fdb, RTM_NEWNEIGH);
L
Linus Torvalds 已提交
351 352 353 354 355 356 357 358 359 360 361 362 363 364 365
	}
	return fdb;
}

static int fdb_insert(struct net_bridge *br, struct net_bridge_port *source,
		  const unsigned char *addr)
{
	struct hlist_head *head = &br->hash[br_mac_hash(addr)];
	struct net_bridge_fdb_entry *fdb;

	if (!is_valid_ether_addr(addr))
		return -EINVAL;

	fdb = fdb_find(head, addr);
	if (fdb) {
366
		/* it is okay to have multiple ports with same
L
Linus Torvalds 已提交
367 368
		 * address, just use the first one.
		 */
369
		if (fdb->is_local)
L
Linus Torvalds 已提交
370
			return 0;
371
		br_warn(br, "adding interface %s with same address "
L
Linus Torvalds 已提交
372 373 374
		       "as a received packet\n",
		       source->dev->name);
		fdb_delete(fdb);
375
	}
L
Linus Torvalds 已提交
376

377 378
	fdb = fdb_create(head, source, addr);
	if (!fdb)
L
Linus Torvalds 已提交
379 380
		return -ENOMEM;

381
	fdb->is_local = fdb->is_static = 1;
L
Linus Torvalds 已提交
382 383 384
	return 0;
}

385
/* Add entry for local address of interface */
L
Linus Torvalds 已提交
386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406
int br_fdb_insert(struct net_bridge *br, struct net_bridge_port *source,
		  const unsigned char *addr)
{
	int ret;

	spin_lock_bh(&br->hash_lock);
	ret = fdb_insert(br, source, addr);
	spin_unlock_bh(&br->hash_lock);
	return ret;
}

void br_fdb_update(struct net_bridge *br, struct net_bridge_port *source,
		   const unsigned char *addr)
{
	struct hlist_head *head = &br->hash[br_mac_hash(addr)];
	struct net_bridge_fdb_entry *fdb;

	/* some users want to always flood. */
	if (hold_time(br) == 0)
		return;

407 408 409 410 411
	/* ignore packets unless we are using this port */
	if (!(source->state == BR_STATE_LEARNING ||
	      source->state == BR_STATE_FORWARDING))
		return;

412
	fdb = fdb_find_rcu(head, addr);
L
Linus Torvalds 已提交
413 414 415
	if (likely(fdb)) {
		/* attempt to update an entry for a local interface */
		if (unlikely(fdb->is_local)) {
416
			if (net_ratelimit())
417 418 419
				br_warn(br, "received packet on %s with "
					"own address as source address\n",
					source->dev->name);
L
Linus Torvalds 已提交
420 421 422
		} else {
			/* fastpath: update of existing entry */
			fdb->dst = source;
423
			fdb->updated = jiffies;
L
Linus Torvalds 已提交
424 425
		}
	} else {
426
		spin_lock(&br->hash_lock);
427 428 429
		if (likely(!fdb_find(head, addr)))
			fdb_create(head, source, addr);

L
Linus Torvalds 已提交
430 431 432
		/* else  we lose race and someone else inserts
		 * it first, don't bother updating
		 */
433
		spin_unlock(&br->hash_lock);
L
Linus Torvalds 已提交
434 435
	}
}
436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557

static int fdb_to_nud(const struct net_bridge_fdb_entry *fdb)
{
	if (fdb->is_local)
		return NUD_PERMANENT;
	else if (fdb->is_static)
		return NUD_NOARP;
	else if (has_expired(fdb->dst->br, fdb))
		return NUD_STALE;
	else
		return NUD_REACHABLE;
}

static int fdb_fill_info(struct sk_buff *skb,
			 const struct net_bridge_fdb_entry *fdb,
			 u32 pid, u32 seq, int type, unsigned int flags)
{
	unsigned long now = jiffies;
	struct nda_cacheinfo ci;
	struct nlmsghdr *nlh;
	struct ndmsg *ndm;

	nlh = nlmsg_put(skb, pid, seq, type, sizeof(*ndm), flags);
	if (nlh == NULL)
		return -EMSGSIZE;


	ndm = nlmsg_data(nlh);
	ndm->ndm_family	 = AF_BRIDGE;
	ndm->ndm_pad1    = 0;
	ndm->ndm_pad2    = 0;
	ndm->ndm_flags	 = 0;
	ndm->ndm_type	 = 0;
	ndm->ndm_ifindex = fdb->dst->dev->ifindex;
	ndm->ndm_state   = fdb_to_nud(fdb);

	NLA_PUT(skb, NDA_LLADDR, ETH_ALEN, &fdb->addr);

	ci.ndm_used	 = jiffies_to_clock_t(now - fdb->used);
	ci.ndm_confirmed = 0;
	ci.ndm_updated	 = jiffies_to_clock_t(now - fdb->updated);
	ci.ndm_refcnt	 = 0;
	NLA_PUT(skb, NDA_CACHEINFO, sizeof(ci), &ci);

	return nlmsg_end(skb, nlh);

nla_put_failure:
	nlmsg_cancel(skb, nlh);
	return -EMSGSIZE;
}

static inline size_t fdb_nlmsg_size(void)
{
	return NLMSG_ALIGN(sizeof(struct ndmsg))
		+ nla_total_size(ETH_ALEN) /* NDA_LLADDR */
		+ nla_total_size(sizeof(struct nda_cacheinfo));
}

static void fdb_notify(const struct net_bridge_fdb_entry *fdb, int type)
{
	struct net *net = dev_net(fdb->dst->dev);
	struct sk_buff *skb;
	int err = -ENOBUFS;

	skb = nlmsg_new(fdb_nlmsg_size(), GFP_ATOMIC);
	if (skb == NULL)
		goto errout;

	err = fdb_fill_info(skb, fdb, 0, 0, type, 0);
	if (err < 0) {
		/* -EMSGSIZE implies BUG in fdb_nlmsg_size() */
		WARN_ON(err == -EMSGSIZE);
		kfree_skb(skb);
		goto errout;
	}
	rtnl_notify(skb, net, 0, RTNLGRP_NEIGH, NULL, GFP_ATOMIC);
	return;
errout:
	if (err < 0)
		rtnl_set_sk_err(net, RTNLGRP_NEIGH, err);
}

/* Dump information about entries, in response to GETNEIGH */
int br_fdb_dump(struct sk_buff *skb, struct netlink_callback *cb)
{
	struct net *net = sock_net(skb->sk);
	struct net_device *dev;
	int idx = 0;

	rcu_read_lock();
	for_each_netdev_rcu(net, dev) {
		struct net_bridge *br = netdev_priv(dev);
		int i;

		if (!(dev->priv_flags & IFF_EBRIDGE))
			continue;

		for (i = 0; i < BR_HASH_SIZE; i++) {
			struct hlist_node *h;
			struct net_bridge_fdb_entry *f;

			hlist_for_each_entry_rcu(f, h, &br->hash[i], hlist) {
				if (idx < cb->args[0])
					goto skip;

				if (fdb_fill_info(skb, f,
						  NETLINK_CB(cb->skb).pid,
						  cb->nlh->nlmsg_seq,
						  RTM_NEWNEIGH,
						  NLM_F_MULTI) < 0)
					break;
skip:
				++idx;
			}
		}
	}
	rcu_read_unlock();

	cb->args[0] = idx;

	return skb->len;
}
558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696

/* Create new static fdb entry */
static int fdb_add_entry(struct net_bridge_port *source, const __u8 *addr,
			 __u16 state)
{
	struct net_bridge *br = source->br;
	struct hlist_head *head = &br->hash[br_mac_hash(addr)];
	struct net_bridge_fdb_entry *fdb;

	fdb = fdb_find(head, addr);
	if (fdb)
		return -EEXIST;

	fdb = fdb_create(head, source, addr);
	if (!fdb)
		return -ENOMEM;

	if (state & NUD_PERMANENT)
		fdb->is_local = fdb->is_static = 1;
	else if (state & NUD_NOARP)
		fdb->is_static = 1;
	return 0;
}

/* Add new permanent fdb entry with RTM_NEWNEIGH */
int br_fdb_add(struct sk_buff *skb, struct nlmsghdr *nlh, void *arg)
{
	struct net *net = sock_net(skb->sk);
	struct ndmsg *ndm;
	struct nlattr *tb[NDA_MAX+1];
	struct net_device *dev;
	struct net_bridge_port *p;
	const __u8 *addr;
	int err;

	ASSERT_RTNL();
	err = nlmsg_parse(nlh, sizeof(*ndm), tb, NDA_MAX, NULL);
	if (err < 0)
		return err;

	ndm = nlmsg_data(nlh);
	if (ndm->ndm_ifindex == 0) {
		pr_info("bridge: RTM_NEWNEIGH with invalid ifindex\n");
		return -EINVAL;
	}

	dev = __dev_get_by_index(net, ndm->ndm_ifindex);
	if (dev == NULL) {
		pr_info("bridge: RTM_NEWNEIGH with unknown ifindex\n");
		return -ENODEV;
	}

	if (!tb[NDA_LLADDR] || nla_len(tb[NDA_LLADDR]) != ETH_ALEN) {
		pr_info("bridge: RTM_NEWNEIGH with invalid address\n");
		return -EINVAL;
	}

	addr = nla_data(tb[NDA_LLADDR]);
	if (!is_valid_ether_addr(addr)) {
		pr_info("bridge: RTM_NEWNEIGH with invalid ether address\n");
		return -EINVAL;
	}

	p = br_port_get_rtnl(dev);
	if (p == NULL) {
		pr_info("bridge: RTM_NEWNEIGH %s not a bridge port\n",
			dev->name);
		return -EINVAL;
	}

	spin_lock_bh(&p->br->hash_lock);
	err = fdb_add_entry(p, addr, ndm->ndm_state);
	spin_unlock_bh(&p->br->hash_lock);

	return err;
}

static int fdb_delete_by_addr(struct net_bridge_port *p, const u8 *addr)
{
	struct net_bridge *br = p->br;
	struct hlist_head *head = &br->hash[br_mac_hash(addr)];
	struct net_bridge_fdb_entry *fdb;

	fdb = fdb_find(head, addr);
	if (!fdb)
		return -ENOENT;

	fdb_delete(fdb);
	return 0;
}

/* Remove neighbor entry with RTM_DELNEIGH */
int br_fdb_delete(struct sk_buff *skb, struct nlmsghdr *nlh, void *arg)
{
	struct net *net = sock_net(skb->sk);
	struct ndmsg *ndm;
	struct net_bridge_port *p;
	struct nlattr *llattr;
	const __u8 *addr;
	struct net_device *dev;
	int err;

	ASSERT_RTNL();
	if (nlmsg_len(nlh) < sizeof(*ndm))
		return -EINVAL;

	ndm = nlmsg_data(nlh);
	if (ndm->ndm_ifindex == 0) {
		pr_info("bridge: RTM_DELNEIGH with invalid ifindex\n");
		return -EINVAL;
	}

	dev = __dev_get_by_index(net, ndm->ndm_ifindex);
	if (dev == NULL) {
		pr_info("bridge: RTM_DELNEIGH with unknown ifindex\n");
		return -ENODEV;
	}

	llattr = nlmsg_find_attr(nlh, sizeof(*ndm), NDA_LLADDR);
	if (llattr == NULL || nla_len(llattr) != ETH_ALEN) {
		pr_info("bridge: RTM_DELNEIGH with invalid address\n");
		return -EINVAL;
	}

	addr = nla_data(llattr);

	p = br_port_get_rtnl(dev);
	if (p == NULL) {
		pr_info("bridge: RTM_DELNEIGH %s not a bridge port\n",
			dev->name);
		return -EINVAL;
	}

	spin_lock_bh(&p->br->hash_lock);
	err = fdb_delete_by_addr(p, addr);
	spin_unlock_bh(&p->br->hash_lock);

	return err;
}