gpiolib-sysfs.c 18.7 KB
Newer Older
1 2 3 4 5 6 7 8
#include <linux/idr.h>
#include <linux/mutex.h>
#include <linux/device.h>
#include <linux/sysfs.h>
#include <linux/gpio/consumer.h>
#include <linux/gpio/driver.h>
#include <linux/interrupt.h>
#include <linux/kdev_t.h>
9
#include <linux/slab.h>
10 11 12

#include "gpiolib.h"

13 14 15 16
struct gpiod_data {
	struct gpio_desc *desc;
};

17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45
static DEFINE_IDR(dirent_idr);


/* lock protects against unexport_gpio() being called while
 * sysfs files are active.
 */
static DEFINE_MUTEX(sysfs_lock);

/*
 * /sys/class/gpio/gpioN... only for GPIOs that are exported
 *   /direction
 *      * MAY BE OMITTED if kernel won't allow direction changes
 *      * is read/write as "in" or "out"
 *      * may also be written as "high" or "low", initializing
 *        output value as specified ("out" implies "low")
 *   /value
 *      * always readable, subject to hardware behavior
 *      * may be writable, as zero/nonzero
 *   /edge
 *      * configures behavior of poll(2) on /value
 *      * available only if pin can generate IRQs on input
 *      * is read/write as "none", "falling", "rising", or "both"
 *   /active_low
 *      * configures polarity of /value
 *      * is read/write as zero/nonzero
 *      * also affects existing and subsequent "falling" and "rising"
 *        /edge configuration
 */

46
static ssize_t direction_show(struct device *dev,
47 48
		struct device_attribute *attr, char *buf)
{
49 50
	struct gpiod_data *data = dev_get_drvdata(dev);
	struct gpio_desc *desc = data->desc;
51 52 53 54
	ssize_t			status;

	mutex_lock(&sysfs_lock);

55 56
	gpiod_get_direction(desc);
	status = sprintf(buf, "%s\n",
57 58 59 60 61 62 63
			test_bit(FLAG_IS_OUT, &desc->flags)
				? "out" : "in");

	mutex_unlock(&sysfs_lock);
	return status;
}

64
static ssize_t direction_store(struct device *dev,
65 66
		struct device_attribute *attr, const char *buf, size_t size)
{
67 68
	struct gpiod_data *data = dev_get_drvdata(dev);
	struct gpio_desc *desc = data->desc;
69 70 71 72
	ssize_t			status;

	mutex_lock(&sysfs_lock);

73
	if (sysfs_streq(buf, "high"))
74 75 76 77 78 79 80 81 82 83 84
		status = gpiod_direction_output_raw(desc, 1);
	else if (sysfs_streq(buf, "out") || sysfs_streq(buf, "low"))
		status = gpiod_direction_output_raw(desc, 0);
	else if (sysfs_streq(buf, "in"))
		status = gpiod_direction_input(desc);
	else
		status = -EINVAL;

	mutex_unlock(&sysfs_lock);
	return status ? : size;
}
85
static DEVICE_ATTR_RW(direction);
86

87
static ssize_t value_show(struct device *dev,
88 89
		struct device_attribute *attr, char *buf)
{
90 91
	struct gpiod_data *data = dev_get_drvdata(dev);
	struct gpio_desc *desc = data->desc;
92 93 94 95
	ssize_t			status;

	mutex_lock(&sysfs_lock);

96
	status = sprintf(buf, "%d\n", gpiod_get_value_cansleep(desc));
97 98 99 100 101

	mutex_unlock(&sysfs_lock);
	return status;
}

102
static ssize_t value_store(struct device *dev,
103 104
		struct device_attribute *attr, const char *buf, size_t size)
{
105 106
	struct gpiod_data *data = dev_get_drvdata(dev);
	struct gpio_desc *desc = data->desc;
107 108 109 110
	ssize_t			status;

	mutex_lock(&sysfs_lock);

111
	if (!test_bit(FLAG_IS_OUT, &desc->flags)) {
112
		status = -EPERM;
113
	} else {
114 115 116 117 118 119 120 121 122 123 124 125
		long		value;

		status = kstrtol(buf, 0, &value);
		if (status == 0) {
			gpiod_set_value_cansleep(desc, value);
			status = size;
		}
	}

	mutex_unlock(&sysfs_lock);
	return status;
}
126
static DEVICE_ATTR_RW(value);
127 128 129 130 131 132 133 134 135

static irqreturn_t gpio_sysfs_irq(int irq, void *priv)
{
	struct kernfs_node	*value_sd = priv;

	sysfs_notify_dirent(value_sd);
	return IRQ_HANDLED;
}

136
static int gpio_setup_irq(struct device *dev, unsigned long gpio_flags)
137
{
138 139
	struct gpiod_data	*data = dev_get_drvdata(dev);
	struct gpio_desc	*desc = data->desc;
140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158
	struct kernfs_node	*value_sd;
	unsigned long		irq_flags;
	int			ret, irq, id;

	if ((desc->flags & GPIO_TRIGGER_MASK) == gpio_flags)
		return 0;

	irq = gpiod_to_irq(desc);
	if (irq < 0)
		return -EIO;

	id = desc->flags >> ID_SHIFT;
	value_sd = idr_find(&dirent_idr, id);
	if (value_sd)
		free_irq(irq, value_sd);

	desc->flags &= ~GPIO_TRIGGER_MASK;

	if (!gpio_flags) {
159
		gpiochip_unlock_as_irq(desc->chip, gpio_chip_hwgpio(desc));
160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192
		ret = 0;
		goto free_id;
	}

	irq_flags = IRQF_SHARED;
	if (test_bit(FLAG_TRIG_FALL, &gpio_flags))
		irq_flags |= test_bit(FLAG_ACTIVE_LOW, &desc->flags) ?
			IRQF_TRIGGER_RISING : IRQF_TRIGGER_FALLING;
	if (test_bit(FLAG_TRIG_RISE, &gpio_flags))
		irq_flags |= test_bit(FLAG_ACTIVE_LOW, &desc->flags) ?
			IRQF_TRIGGER_FALLING : IRQF_TRIGGER_RISING;

	if (!value_sd) {
		value_sd = sysfs_get_dirent(dev->kobj.sd, "value");
		if (!value_sd) {
			ret = -ENODEV;
			goto err_out;
		}

		ret = idr_alloc(&dirent_idr, value_sd, 1, 0, GFP_KERNEL);
		if (ret < 0)
			goto free_sd;
		id = ret;

		desc->flags &= GPIO_FLAGS_MASK;
		desc->flags |= (unsigned long)id << ID_SHIFT;

		if (desc->flags >> ID_SHIFT != id) {
			ret = -ERANGE;
			goto free_id;
		}
	}

193 194 195 196 197 198 199 200 201
	/*
	 * FIXME: This should be done in the irq_request_resources callback
	 *        when the irq is requested, but a few drivers currently fail
	 *        to do so.
	 *
	 *        Remove this redundant call (along with the corresponding
	 *        unlock) when those drivers have been fixed.
	 */
	ret = gpiochip_lock_as_irq(desc->chip, gpio_chip_hwgpio(desc));
202 203 204
	if (ret < 0)
		goto free_id;

205 206 207 208
	ret = request_any_context_irq(irq, gpio_sysfs_irq, irq_flags,
				"gpiolib", value_sd);
	if (ret < 0)
		goto err_unlock;
209 210 211 212

	desc->flags |= gpio_flags;
	return 0;

213 214
err_unlock:
	gpiochip_unlock_as_irq(desc->chip, gpio_chip_hwgpio(desc));
215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234
free_id:
	idr_remove(&dirent_idr, id);
	desc->flags &= GPIO_FLAGS_MASK;
free_sd:
	if (value_sd)
		sysfs_put(value_sd);
err_out:
	return ret;
}

static const struct {
	const char *name;
	unsigned long flags;
} trigger_types[] = {
	{ "none",    0 },
	{ "falling", BIT(FLAG_TRIG_FALL) },
	{ "rising",  BIT(FLAG_TRIG_RISE) },
	{ "both",    BIT(FLAG_TRIG_FALL) | BIT(FLAG_TRIG_RISE) },
};

235
static ssize_t edge_show(struct device *dev,
236 237
		struct device_attribute *attr, char *buf)
{
238 239
	struct gpiod_data *data = dev_get_drvdata(dev);
	struct gpio_desc *desc = data->desc;
240 241 242
	unsigned long mask;
	ssize_t	status = 0;
	int i;
243 244 245

	mutex_lock(&sysfs_lock);

246 247 248 249 250 251
	for (i = 0; i < ARRAY_SIZE(trigger_types); i++) {
		mask = desc->flags & GPIO_TRIGGER_MASK;
		if (mask == trigger_types[i].flags) {
			status = sprintf(buf, "%s\n", trigger_types[i].name);
			break;
		}
252 253 254 255 256 257
	}

	mutex_unlock(&sysfs_lock);
	return status;
}

258
static ssize_t edge_store(struct device *dev,
259 260 261 262 263 264 265 266 267 268 269 270 271
		struct device_attribute *attr, const char *buf, size_t size)
{
	ssize_t			status;
	int			i;

	for (i = 0; i < ARRAY_SIZE(trigger_types); i++)
		if (sysfs_streq(trigger_types[i].name, buf))
			goto found;
	return -EINVAL;

found:
	mutex_lock(&sysfs_lock);

272
	status = gpio_setup_irq(dev, trigger_types[i].flags);
273 274
	if (!status)
		status = size;
275 276 277 278 279

	mutex_unlock(&sysfs_lock);

	return status;
}
280
static DEVICE_ATTR_RW(edge);
281

282
static int sysfs_set_active_low(struct device *dev, int value)
283
{
284 285
	struct gpiod_data	*data = dev_get_drvdata(dev);
	struct gpio_desc	*desc = data->desc;
286 287 288 289 290 291 292 293 294 295 296
	int			status = 0;

	if (!!test_bit(FLAG_ACTIVE_LOW, &desc->flags) == !!value)
		return 0;

	if (value)
		set_bit(FLAG_ACTIVE_LOW, &desc->flags);
	else
		clear_bit(FLAG_ACTIVE_LOW, &desc->flags);

	/* reconfigure poll(2) support if enabled on one edge only */
297 298
	if (!!test_bit(FLAG_TRIG_RISE, &desc->flags) ^
				!!test_bit(FLAG_TRIG_FALL, &desc->flags)) {
299 300
		unsigned long trigger_flags = desc->flags & GPIO_TRIGGER_MASK;

301 302
		gpio_setup_irq(dev, 0);
		status = gpio_setup_irq(dev, trigger_flags);
303 304 305 306 307
	}

	return status;
}

308
static ssize_t active_low_show(struct device *dev,
309 310
		struct device_attribute *attr, char *buf)
{
311 312
	struct gpiod_data *data = dev_get_drvdata(dev);
	struct gpio_desc *desc = data->desc;
313 314 315 316
	ssize_t			status;

	mutex_lock(&sysfs_lock);

317
	status = sprintf(buf, "%d\n",
318 319 320 321 322 323 324
				!!test_bit(FLAG_ACTIVE_LOW, &desc->flags));

	mutex_unlock(&sysfs_lock);

	return status;
}

325
static ssize_t active_low_store(struct device *dev,
326 327 328
		struct device_attribute *attr, const char *buf, size_t size)
{
	ssize_t			status;
329
	long			value;
330 331 332

	mutex_lock(&sysfs_lock);

333 334
	status = kstrtol(buf, 0, &value);
	if (status == 0)
335
		status = sysfs_set_active_low(dev, value != 0);
336 337 338 339 340

	mutex_unlock(&sysfs_lock);

	return status ? : size;
}
341
static DEVICE_ATTR_RW(active_low);
342

343 344 345 346
static umode_t gpio_is_visible(struct kobject *kobj, struct attribute *attr,
			       int n)
{
	struct device *dev = container_of(kobj, struct device, kobj);
347 348
	struct gpiod_data *data = dev_get_drvdata(dev);
	struct gpio_desc *desc = data->desc;
349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364
	umode_t mode = attr->mode;
	bool show_direction = test_bit(FLAG_SYSFS_DIR, &desc->flags);

	if (attr == &dev_attr_direction.attr) {
		if (!show_direction)
			mode = 0;
	} else if (attr == &dev_attr_edge.attr) {
		if (gpiod_to_irq(desc) < 0)
			mode = 0;
		if (!show_direction && test_bit(FLAG_IS_OUT, &desc->flags))
			mode = 0;
	}

	return mode;
}

365
static struct attribute *gpio_attrs[] = {
366 367
	&dev_attr_direction.attr,
	&dev_attr_edge.attr,
368 369 370 371
	&dev_attr_value.attr,
	&dev_attr_active_low.attr,
	NULL,
};
372 373 374 375 376 377 378 379 380 381

static const struct attribute_group gpio_group = {
	.attrs = gpio_attrs,
	.is_visible = gpio_is_visible,
};

static const struct attribute_group *gpio_groups[] = {
	&gpio_group,
	NULL
};
382 383 384 385 386 387 388 389

/*
 * /sys/class/gpio/gpiochipN/
 *   /base ... matching gpio_chip.base (N)
 *   /label ... matching gpio_chip.label
 *   /ngpio ... matching gpio_chip.ngpio
 */

390
static ssize_t base_show(struct device *dev,
391 392 393 394 395 396
			       struct device_attribute *attr, char *buf)
{
	const struct gpio_chip	*chip = dev_get_drvdata(dev);

	return sprintf(buf, "%d\n", chip->base);
}
397
static DEVICE_ATTR_RO(base);
398

399
static ssize_t label_show(struct device *dev,
400 401 402 403 404 405
			       struct device_attribute *attr, char *buf)
{
	const struct gpio_chip	*chip = dev_get_drvdata(dev);

	return sprintf(buf, "%s\n", chip->label ? : "");
}
406
static DEVICE_ATTR_RO(label);
407

408
static ssize_t ngpio_show(struct device *dev,
409 410 411 412 413 414
			       struct device_attribute *attr, char *buf)
{
	const struct gpio_chip	*chip = dev_get_drvdata(dev);

	return sprintf(buf, "%u\n", chip->ngpio);
}
415
static DEVICE_ATTR_RO(ngpio);
416

417
static struct attribute *gpiochip_attrs[] = {
418 419 420 421 422
	&dev_attr_base.attr,
	&dev_attr_label.attr,
	&dev_attr_ngpio.attr,
	NULL,
};
423
ATTRIBUTE_GROUPS(gpiochip);
424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538

/*
 * /sys/class/gpio/export ... write-only
 *	integer N ... number of GPIO to export (full access)
 * /sys/class/gpio/unexport ... write-only
 *	integer N ... number of GPIO to unexport
 */
static ssize_t export_store(struct class *class,
				struct class_attribute *attr,
				const char *buf, size_t len)
{
	long			gpio;
	struct gpio_desc	*desc;
	int			status;

	status = kstrtol(buf, 0, &gpio);
	if (status < 0)
		goto done;

	desc = gpio_to_desc(gpio);
	/* reject invalid GPIOs */
	if (!desc) {
		pr_warn("%s: invalid GPIO %ld\n", __func__, gpio);
		return -EINVAL;
	}

	/* No extra locking here; FLAG_SYSFS just signifies that the
	 * request and export were done by on behalf of userspace, so
	 * they may be undone on its behalf too.
	 */

	status = gpiod_request(desc, "sysfs");
	if (status < 0) {
		if (status == -EPROBE_DEFER)
			status = -ENODEV;
		goto done;
	}
	status = gpiod_export(desc, true);
	if (status < 0)
		gpiod_free(desc);
	else
		set_bit(FLAG_SYSFS, &desc->flags);

done:
	if (status)
		pr_debug("%s: status %d\n", __func__, status);
	return status ? : len;
}

static ssize_t unexport_store(struct class *class,
				struct class_attribute *attr,
				const char *buf, size_t len)
{
	long			gpio;
	struct gpio_desc	*desc;
	int			status;

	status = kstrtol(buf, 0, &gpio);
	if (status < 0)
		goto done;

	desc = gpio_to_desc(gpio);
	/* reject bogus commands (gpio_unexport ignores them) */
	if (!desc) {
		pr_warn("%s: invalid GPIO %ld\n", __func__, gpio);
		return -EINVAL;
	}

	status = -EINVAL;

	/* No extra locking here; FLAG_SYSFS just signifies that the
	 * request and export were done by on behalf of userspace, so
	 * they may be undone on its behalf too.
	 */
	if (test_and_clear_bit(FLAG_SYSFS, &desc->flags)) {
		status = 0;
		gpiod_free(desc);
	}
done:
	if (status)
		pr_debug("%s: status %d\n", __func__, status);
	return status ? : len;
}

static struct class_attribute gpio_class_attrs[] = {
	__ATTR(export, 0200, NULL, export_store),
	__ATTR(unexport, 0200, NULL, unexport_store),
	__ATTR_NULL,
};

static struct class gpio_class = {
	.name =		"gpio",
	.owner =	THIS_MODULE,

	.class_attrs =	gpio_class_attrs,
};


/**
 * gpiod_export - export a GPIO through sysfs
 * @gpio: gpio to make available, already requested
 * @direction_may_change: true if userspace may change gpio direction
 * Context: arch_initcall or later
 *
 * When drivers want to make a GPIO accessible to userspace after they
 * have requested it -- perhaps while debugging, or as part of their
 * public interface -- they may use this routine.  If the GPIO can
 * change direction (some can't) and the caller allows it, userspace
 * will see "direction" sysfs attribute which may be used to change
 * the gpio's direction.  A "value" attribute will always be provided.
 *
 * Returns zero on success, else an error.
 */
int gpiod_export(struct gpio_desc *desc, bool direction_may_change)
{
539
	struct gpio_chip	*chip;
540
	struct gpiod_data	*data;
541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557
	unsigned long		flags;
	int			status;
	const char		*ioname = NULL;
	struct device		*dev;
	int			offset;

	/* can't export until sysfs is available ... */
	if (!gpio_class.p) {
		pr_debug("%s: called too early!\n", __func__);
		return -ENOENT;
	}

	if (!desc) {
		pr_debug("%s: invalid gpio descriptor\n", __func__);
		return -EINVAL;
	}

558 559
	chip = desc->chip;

560 561
	mutex_lock(&sysfs_lock);

562
	/* check if chip is being removed */
563
	if (!chip || !chip->cdev) {
564
		status = -ENODEV;
565
		goto err_unlock;
566 567
	}

568 569 570 571 572 573 574 575 576
	spin_lock_irqsave(&gpio_lock, flags);
	if (!test_bit(FLAG_REQUESTED, &desc->flags) ||
	     test_bit(FLAG_EXPORT, &desc->flags)) {
		spin_unlock_irqrestore(&gpio_lock, flags);
		gpiod_dbg(desc, "%s: unavailable (requested=%d, exported=%d)\n",
				__func__,
				test_bit(FLAG_REQUESTED, &desc->flags),
				test_bit(FLAG_EXPORT, &desc->flags));
		status = -EPERM;
577
		goto err_unlock;
578 579
	}

580
	if (chip->direction_input && chip->direction_output &&
581 582 583 584
			direction_may_change) {
		set_bit(FLAG_SYSFS_DIR, &desc->flags);
	}

585 586
	spin_unlock_irqrestore(&gpio_lock, flags);

587 588 589 590 591 592 593 594
	data = kzalloc(sizeof(*data), GFP_KERNEL);
	if (!data) {
		status = -ENOMEM;
		goto err_unlock;
	}

	data->desc = desc;

595
	offset = gpio_chip_hwgpio(desc);
596 597
	if (chip->names && chip->names[offset])
		ioname = chip->names[offset];
598

599
	dev = device_create_with_groups(&gpio_class, chip->dev,
600
					MKDEV(0, 0), data, gpio_groups,
601 602
					ioname ? ioname : "gpio%u",
					desc_to_gpio(desc));
603 604
	if (IS_ERR(dev)) {
		status = PTR_ERR(dev);
605
		goto err_free_data;
606 607 608 609 610 611
	}

	set_bit(FLAG_EXPORT, &desc->flags);
	mutex_unlock(&sysfs_lock);
	return 0;

612 613 614
err_free_data:
	kfree(data);
err_unlock:
615 616 617 618 619 620
	mutex_unlock(&sysfs_lock);
	gpiod_dbg(desc, "%s: status %d\n", __func__, status);
	return status;
}
EXPORT_SYMBOL_GPL(gpiod_export);

621
static int match_export(struct device *dev, const void *desc)
622
{
623 624 625
	struct gpiod_data *data = dev_get_drvdata(dev);

	return data->desc == desc;
626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657
}

/**
 * gpiod_export_link - create a sysfs link to an exported GPIO node
 * @dev: device under which to create symlink
 * @name: name of the symlink
 * @gpio: gpio to create symlink to, already exported
 *
 * Set up a symlink from /sys/.../dev/name to /sys/class/gpio/gpioN
 * node. Caller is responsible for unlinking.
 *
 * Returns zero on success, else an error.
 */
int gpiod_export_link(struct device *dev, const char *name,
		      struct gpio_desc *desc)
{
	int			status = -EINVAL;

	if (!desc) {
		pr_warn("%s: invalid GPIO\n", __func__);
		return -EINVAL;
	}

	mutex_lock(&sysfs_lock);

	if (test_bit(FLAG_EXPORT, &desc->flags)) {
		struct device *tdev;

		tdev = class_find_device(&gpio_class, NULL, desc, match_export);
		if (tdev != NULL) {
			status = sysfs_create_link(&dev->kobj, &tdev->kobj,
						name);
658
			put_device(tdev);
659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680
		} else {
			status = -ENODEV;
		}
	}

	mutex_unlock(&sysfs_lock);

	if (status)
		gpiod_dbg(desc, "%s: status %d\n", __func__, status);

	return status;
}
EXPORT_SYMBOL_GPL(gpiod_export_link);

/**
 * gpiod_unexport - reverse effect of gpio_export()
 * @gpio: gpio to make unavailable
 *
 * This is implicit on gpio_free().
 */
void gpiod_unexport(struct gpio_desc *desc)
{
681
	struct gpiod_data	*data;
682 683 684 685 686 687 688 689 690 691 692 693 694 695
	int			status = 0;
	struct device		*dev = NULL;

	if (!desc) {
		pr_warn("%s: invalid GPIO\n", __func__);
		return;
	}

	mutex_lock(&sysfs_lock);

	if (test_bit(FLAG_EXPORT, &desc->flags)) {

		dev = class_find_device(&gpio_class, NULL, desc, match_export);
		if (dev) {
696
			clear_bit(FLAG_SYSFS_DIR, &desc->flags);
697 698 699 700 701 702 703 704
			clear_bit(FLAG_EXPORT, &desc->flags);
		} else
			status = -ENODEV;
	}

	mutex_unlock(&sysfs_lock);

	if (dev) {
705
		data = dev_get_drvdata(dev);
706
		device_unregister(dev);
707 708 709 710
		/*
		 * Release irq after deregistration to prevent race with
		 * edge_store.
		 */
711
		gpio_setup_irq(dev, 0);
712
		put_device(dev);
713
		kfree(data);
714 715 716 717 718 719 720
	}

	if (status)
		gpiod_dbg(desc, "%s: status %d\n", __func__, status);
}
EXPORT_SYMBOL_GPL(gpiod_unexport);

721
int gpiochip_sysfs_register(struct gpio_chip *chip)
722 723 724
{
	struct device	*dev;

725 726
	/*
	 * Many systems add gpio chips for SOC support very early,
727
	 * before driver model support is available.  In those cases we
728
	 * register later, in gpiolib_sysfs_init() ... here we just
729 730 731 732 733 734
	 * verify that _some_ field of gpio_class got initialized.
	 */
	if (!gpio_class.p)
		return 0;

	/* use chip->base for the ID; it's already known to be unique */
735 736 737 738
	dev = device_create_with_groups(&gpio_class, chip->dev, MKDEV(0, 0),
					chip, gpiochip_groups,
					"gpiochip%d", chip->base);
	if (IS_ERR(dev))
739
		return PTR_ERR(dev);
740 741

	mutex_lock(&sysfs_lock);
742
	chip->cdev = dev;
743 744
	mutex_unlock(&sysfs_lock);

745
	return 0;
746 747
}

748
void gpiochip_sysfs_unregister(struct gpio_chip *chip)
749
{
750 751
	struct gpio_desc *desc;
	unsigned int i;
752

753 754
	if (!chip->cdev)
		return;
755

756 757 758 759 760 761
	device_unregister(chip->cdev);

	/* prevent further gpiod exports */
	mutex_lock(&sysfs_lock);
	chip->cdev = NULL;
	mutex_unlock(&sysfs_lock);
762 763 764 765 766 767 768

	/* unregister gpiod class devices owned by sysfs */
	for (i = 0; i < chip->ngpio; i++) {
		desc = &chip->desc[i];
		if (test_and_clear_bit(FLAG_SYSFS, &desc->flags))
			gpiod_free(desc);
	}
769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788
}

static int __init gpiolib_sysfs_init(void)
{
	int		status;
	unsigned long	flags;
	struct gpio_chip *chip;

	status = class_register(&gpio_class);
	if (status < 0)
		return status;

	/* Scan and register the gpio_chips which registered very
	 * early (e.g. before the class_register above was called).
	 *
	 * We run before arch_initcall() so chip->dev nodes can have
	 * registered, and so arch_initcall() can always gpio_export().
	 */
	spin_lock_irqsave(&gpio_lock, flags);
	list_for_each_entry(chip, &gpio_chips, list) {
789
		if (chip->cdev)
790 791
			continue;

792
		/*
793 794 795
		 * TODO we yield gpio_lock here because
		 * gpiochip_sysfs_register() acquires a mutex. This is unsafe
		 * and needs to be fixed.
796 797 798 799 800
		 *
		 * Also it would be nice to use gpiochip_find() here so we
		 * can keep gpio_chips local to gpiolib.c, but the yield of
		 * gpio_lock prevents us from doing this.
		 */
801
		spin_unlock_irqrestore(&gpio_lock, flags);
802
		status = gpiochip_sysfs_register(chip);
803 804 805 806 807 808 809 810
		spin_lock_irqsave(&gpio_lock, flags);
	}
	spin_unlock_irqrestore(&gpio_lock, flags);


	return status;
}
postcore_initcall(gpiolib_sysfs_init);