1. 17 5月, 2017 1 次提交
    • E
      qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable · e90f2a8c
      Eduardo Habkost 提交于
      cannot_instantiate_with_device_add_yet was introduced by commit
      efec3dd6 to replace no_user. It was
      supposed to be a temporary measure.
      
      When it was introduced, we had 54
      cannot_instantiate_with_device_add_yet=true lines in the code.
      Today (3 years later) this number has not shrunk: we now have
      57 cannot_instantiate_with_device_add_yet=true lines. I think it
      is safe to say it is not a temporary measure, and we won't see
      the flag go away soon.
      
      Instead of a long field name that misleads people to believe it
      is temporary, replace it a shorter and less misleading field:
      user_creatable.
      
      Except for code comments, changes were generated using the
      following Coccinelle patch:
      
        @@
        expression DC;
        @@
        (
        -DC->cannot_instantiate_with_device_add_yet = false;
        +DC->user_creatable = true;
        |
        -DC->cannot_instantiate_with_device_add_yet = true;
        +DC->user_creatable = false;
        )
      
        @@
        typedef ObjectClass;
        expression dc;
        identifier class, data;
        @@
         static void device_class_init(ObjectClass *class, void *data)
         {
         ...
         dc->hotpluggable = true;
        +dc->user_creatable = true;
         ...
         }
      
        @@
        @@
         struct DeviceClass {
         ...
        -bool cannot_instantiate_with_device_add_yet;
        +bool user_creatable;
         ...
        }
      
        @@
        expression DC;
        @@
        (
        -!DC->cannot_instantiate_with_device_add_yet
        +DC->user_creatable
        |
        -DC->cannot_instantiate_with_device_add_yet
        +!DC->user_creatable
        )
      
      Cc: Alistair Francis <alistair.francis@xilinx.com>
      Cc: Laszlo Ersek <lersek@redhat.com>
      Cc: Marcel Apfelbaum <marcel@redhat.com>
      Cc: Markus Armbruster <armbru@redhat.com>
      Cc: Peter Maydell <peter.maydell@linaro.org>
      Cc: Thomas Huth <thuth@redhat.com>
      Acked-by: NAlistair Francis <alistair.francis@xilinx.com>
      Reviewed-by: NThomas Huth <thuth@redhat.com>
      Reviewed-by: NMarcel Apfelbaum <marcel@redhat.com>
      Acked-by: NMarcel Apfelbaum <marcel@redhat.com>
      Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>
      Message-Id: <20170503203604.31462-2-ehabkost@redhat.com>
      [ehabkost: kept "TODO remove once we're there" comment]
      Reviewed-by: NMarkus Armbruster <armbru@redhat.com>
      Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>
      e90f2a8c
  2. 21 4月, 2017 1 次提交
  3. 01 3月, 2017 1 次提交
  4. 28 2月, 2017 1 次提交
    • K
      ARM i.MX timers: fix reset handling · c98c9eba
      Kurban Mallachiev 提交于
      The i.MX timer device can be reset by writing to the SWR bit
      of the CR register. This has to behave differently from hard
      (power-on) reset because it does not reset all of the bits
      in the CR register.
      
      We were incorrectly implementing soft reset and hard reset
      the same way, and in addition had a logic error which meant
      that we were clearing the bits that soft-reset is supposed
      to preserve and not touching the bits that soft-reset clears.
      This was not correct behaviour for either kind of reset.
      
      Separate out the soft reset and hard reset code paths, and
      correct the handling of reset of the CR register so that it
      is correct in both cases.
      Signed-off-by: NKurban Mallachiev <mallachiev@ispras.ru>
      [PMM: rephrased commit message, spacing on operators;
       use bool rather than int for is_soft_reset]
      Reviewed-by: NPeter Maydell <peter.maydell@linaro.org>
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      c98c9eba
  5. 22 2月, 2017 1 次提交
  6. 14 2月, 2017 1 次提交
  7. 06 2月, 2017 1 次提交
  8. 28 1月, 2017 1 次提交
  9. 25 1月, 2017 2 次提交
  10. 19 1月, 2017 2 次提交
  11. 17 1月, 2017 1 次提交
    • H
      bugfix: vm halt when in reset looping · bf7bb91e
      hangaohuai 提交于
      reset mc146818rtc device when RESET event happens.
      
      Fix the problem:
        1. Guest boot the second cpu, set CMOS_RESET_CODE 0x0a to protect selfboot;
        2. VM being reset by others, hmp_system_reset;
        3. seabios resume check the CMOS_RESET_CODE, if 0x0a, jump to the BDA
           resume execution by jump via 40h:0067h;
        4. Guest halt;
      Signed-off-by: Nhangaohuai <hangaohuai@huawei.com>
      Message-Id: <20161219060336.10176-1-hangaohuai@huawei.com>
      Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
      bf7bb91e
  12. 09 1月, 2017 1 次提交
  13. 27 12月, 2016 1 次提交
  14. 28 10月, 2016 1 次提交
  15. 24 10月, 2016 3 次提交
  16. 04 10月, 2016 2 次提交
  17. 23 9月, 2016 2 次提交
  18. 12 8月, 2016 1 次提交
  19. 12 7月, 2016 1 次提交
    • Y
      hw/mips: implement GIC Interval Timer · 40514051
      Yongbok Kim 提交于
      The interval timer is similar to the CP0 Count/Compare timer within
      each processor. The difference is the GIC_SH_COUNTER register is global
      to the system so that all processors have the same time reference.
      
      To ease implementation, all VPs are having its own QEMU timer but sharing
      global settings and registers such as GIC_SH_CONFIG.COUTNSTOP and
      GIC_SH_COUNTER.
      
      MIPS GIC Interval Timer does support upto 64 bits of Count register but
      in this implementation it is limited to 32 bits only.
      Signed-off-by: NYongbok Kim <yongbok.kim@imgtec.com>
      Signed-off-by: NLeon Alrae <leon.alrae@imgtec.com>
      40514051
  20. 07 7月, 2016 1 次提交
    • J
      i.MX: split the GPT timer implementation into per SOC definitions · 66542f63
      Jean-Christophe Dubois 提交于
      In various Freescale SOCs, the GPT timers can be configured to select
      its input clock.
      
      Depending on the SOC the set of available input clocks may vary.
      
      The actual single GPT definition was no good enough and because of it
      booting the sabrelite board with a i.MX6DL device tree would fail
      because of an incorrect input clock definition for the i.MX6DL SOC.
      
      This patch fixes the i.MX6DL boot failure by adding the ability to
      define a different set of input clocks depending on the considered SOC.
      
      A different class has been defined for i.MX25, i.MX31 and i.MX6 each with
      its specific set of input clocks.
      
      The patch has been tested by booting KZM, i.MX25 PDK, i.MX6Q sabrelite
      and i.MX6DL sabrelite.
      Signed-off-by: NJean-Christophe Dubois <jcd@tribudubois.net>
      Message-id: 1467325619-8374-1-git-send-email-jcd@tribudubois.net
      Reviewed-by: NPeter Maydell <peter.maydell@linaro.org>
      [PMM: fixed spacing round '/' operator]
      Signed-off-by: NPeter Maydell <peter.maydell@linaro.org>
      66542f63
  21. 29 6月, 2016 1 次提交
  22. 21 6月, 2016 4 次提交
  23. 20 6月, 2016 1 次提交
    • E
      coccinelle: Remove unnecessary variables for function return value · 9be38598
      Eduardo Habkost 提交于
      Use Coccinelle script to replace 'ret = E; return ret' with
      'return E'. The script will do the substitution only when the
      function return type and variable type are the same.
      
      Manual fixups:
      
      * audio/audio.c: coding style of "read (...)" and "write (...)"
      * block/qcow2-cluster.c: wrap line to make it shorter
      * block/qcow2-refcount.c: change indentation of wrapped line
      * target-tricore/op_helper.c: fix coding style of
        "remainder|quotient"
      * target-mips/dsp_helper.c: reverted changes because I don't
        want to argue about checkpatch.pl
      * ui/qemu-pixman.c: fix line indentation
      * block/rbd.c: restore blank line between declarations and
        statements
      Reviewed-by: NEric Blake <eblake@redhat.com>
      Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>
      Message-Id: <1465855078-19435-4-git-send-email-ehabkost@redhat.com>
      Reviewed-by: NMarkus Armbruster <armbru@redhat.com>
      [Unused Coccinelle rule name dropped along with a redundant comment;
      whitespace touched up in block/qcow2-cluster.c; stale commit message
      paragraph deleted]
      Signed-off-by: NMarkus Armbruster <armbru@redhat.com>
      9be38598
  24. 17 6月, 2016 1 次提交
  25. 07 6月, 2016 2 次提交
  26. 20 5月, 2016 1 次提交
  27. 19 5月, 2016 1 次提交
  28. 18 5月, 2016 1 次提交
  29. 08 4月, 2016 1 次提交
  30. 23 3月, 2016 1 次提交