提交 · e77f083292916ba43b940fdacd2fc1001b750d1d · openeuler / qemu

26 2月, 2013 2 次提交

由 Richard Henderson 提交于 2月 25, 2013

While T0+~T1+CF = T0-T1+CF-1 is true for the low 32-bits,
it does not produce the correct carry-out to bit 33.  Do
exactly what the manual says.

Using the ~T1 makes the add and subtract code paths nearly
identical, so have sbc_CC use adc_CC.

Cc: Peter Maydell <peter.maydell@linaro.org>
Reported-by: NLaurent Desnogues <laurent.desnogues@gmail.com>
Reviewed-by: NPeter Maydell <peter.maydell@linaro.org>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NAnthony Liguori <aliguori@us.ibm.com>

e77f0832

arm/translate.c: Fix adc_CC/sbc_CC implementation · 8c3ac601

由 Peter Crosthwaite 提交于 2月 25, 2013

commits 49b4c31e and
2de68a49 reworked the implementation of adc_CC
and sub_CC. The new implementations (on the TCG_TARGET_HAS_add2_i32 code path)
are incorrect. The new logic is:

CF:NF = 0:A +/- 0:CF
CF:NF = CF:A +/- 0:B

The lower 32 bits of the intermediate result stored in NF needs to be passes
into the second addition in place of A (s/CF:A/CF:NF):

CF:NF = 0:A +/- 0:CF
CF:NF = CF:NF +/- 0:B

This patch fixes the issue.

Cc: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: NPeter Maydell <peter.maydell@linaro.org>
Signed-off-by: NPeter Crosthwaite <peter.crosthwaite@xilinx.com>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NAnthony Liguori <aliguori@us.ibm.com>

8c3ac601

24 2月, 2013 38 次提交

target-mips: fix for sign-issue in MULQ_W helper · a345481b

由 Petar Jovanovic 提交于 2月 07, 2013

Correct sign-propagation before multiplication in MULQ_W helper.
The change also fixes previously incorrect expected values in the
tests for MULQ_RS.W and MULQ_S.W.
Signed-off-by: NPetar Jovanovic <petarj@mips.com>
Richard Henderson <rth@twiddle.net>
Signed-off-by: NAurelien Jarno <aurelien@aurel32.net>

a345481b

target-mips: fix for incorrect multiplication with MULQ_S.PH · 9c19eb1e

由 Petar Jovanovic 提交于 2月 06, 2013

The change corrects sign-related issue with MULQ_S.PH. It also includes
extension to the already existing test which will trigger the issue.
Signed-off-by: NPetar Jovanovic <petarj@mips.com>
Signed-off-by: NAurelien Jarno <aurelien@aurel32.net>

9c19eb1e

target-xtensa: Use add2/sub2 for mac · d2123a07

由 Richard Henderson 提交于 2月 19, 2013

Cc: Max Filippov <jcmvbkbc@gmail.com>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

d2123a07

target-xtensa: Use mul*2 for mul*hi · c9cda20b

由 Richard Henderson 提交于 2月 19, 2013

Cc: Max Filippov <jcmvbkbc@gmail.com>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

c9cda20b

target-unicore32: Use mul*2 for do_mult · d1f8cd83

由 Richard Henderson 提交于 2月 19, 2013

Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

d1f8cd83

target-sh4: Use mul*2 for dmul* · 1d3b7084

由 Richard Henderson 提交于 2月 19, 2013

Cc: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

1d3b7084

target-sparc: Use mul*2 for multiply · 528692a8

由 Richard Henderson 提交于 2月 19, 2013

Cc: Blue Swirl <blauwirbel@gmail.com>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

528692a8

target-sparc: Use official add2/sub2 interfaces for addx/subx · 15fe216f

由 Richard Henderson 提交于 2月 19, 2013

Cc: Blue Swirl <blauwirbel@gmail.com>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

15fe216f

target-ppc: Compute mullwo without branches · e4a2c846

由 Richard Henderson 提交于 2月 19, 2013

Cc: Alexander Graf <agraf@suse.de>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

e4a2c846

target-ppc: Compute arithmetic shift carry without branches · ba4af3e4

由 Richard Henderson 提交于 2月 19, 2013

Cc: Alexander Graf <agraf@suse.de>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

ba4af3e4

target-ppc: Implement neg in terms of subf · fd3f0081

由 Richard Henderson 提交于 2月 19, 2013

Cc: Alexander Graf <agraf@suse.de>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

fd3f0081

target-ppc: Use add2 for carry generation · b5a73f8d

由 Richard Henderson 提交于 2月 19, 2013

Cc: Alexander Graf <agraf@suse.de>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

b5a73f8d

target-ppc: Compute addition carry with setcond · 146de60d

由 Richard Henderson 提交于 2月 19, 2013

Cc: Alexander Graf <agraf@suse.de>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

146de60d

target-ppc: Compute addition overflow without branches · ffe30937

由 Richard Henderson 提交于 2月 19, 2013

Cc: Alexander Graf <agraf@suse.de>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

ffe30937

target-ppc: Use setcond in gen_op_cmp · 2fdcb629

由 Richard Henderson 提交于 2月 19, 2013

Which means that callers need not copy data into local tmps.

Cc: Alexander Graf <agraf@suse.de>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

2fdcb629

target-ppc: Split out SO, OV, CA fields from XER · da91a00f

由 Richard Henderson 提交于 2月 19, 2013

In preparation for more efficient setting of these fields.

Cc: Alexander Graf <agraf@suse.de>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

da91a00f

target-ppc: Use mul*2 in mulh* insns · 23ad1d5d

由 Richard Henderson 提交于 2月 19, 2013

Cc: Alexander Graf <agraf@suse.de>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

23ad1d5d

target-cris: Use mul*2 in mul* insns · bf45f971

由 Richard Henderson 提交于 2月 19, 2013

Cc: Edgar E. Iglesias <edgar.iglesias@gmail.com>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

bf45f971

target-mips: Use mul[us]2 in [D]MULT[U] insns · ce1dd5d1

由 Richard Henderson 提交于 2月 19, 2013

Cc: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

ce1dd5d1

target-arm: Implement sbc_cc inline · 2de68a49

由 Richard Henderson 提交于 2月 19, 2013

Use sub2 if available, otherwise use 64-bit arithmetic.

Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

2de68a49

target-arm: Implement adc_cc inline · 49b4c31e

由 Richard Henderson 提交于 2月 19, 2013

Use add2 if available, otherwise use 64-bit arithmetic.

Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

49b4c31e

target-arm: Use add2 in gen_add_CC · e3482cb8

由 Richard Henderson 提交于 2月 19, 2013

Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

e3482cb8

target-arm: Use mul[us]2 and add2 in umlal et al · c9f10124

由 Richard Henderson 提交于 2月 19, 2013

Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

c9f10124

target-arm: Use mul[us]2 in gen_mul[us]_i64_i32 · 831d7fe8

由 Richard Henderson 提交于 2月 19, 2013

Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

831d7fe8

target-s390x: Use mulu2 for mlgr insn · dc46d1c6

由 Richard Henderson 提交于 2月 19, 2013

Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

dc46d1c6

target-alpha: Use mulu2 for umulh insn · 962415fc

由 Richard Henderson 提交于 2月 19, 2013

Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

962415fc

R
tcg: Apply life analysis to 64-bit multiword arithmetic ops · f1fae40c
由 Richard Henderson 提交于 2月 19, 2013
```
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>
```
f1fae40c

tcg: Implement muls2 with mulu2 · f402f38f

由 Richard Henderson 提交于 2月 19, 2013

Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

f402f38f

R
target-i386: Use add2 to implement the ADX extension · 76f13133
由 Richard Henderson 提交于 2月 19, 2013
```
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>
```
76f13133

tcg-arm: Implement muls2_i32 · d693e147

由 Richard Henderson 提交于 2月 19, 2013

We even had the encoding of smull already handy...

Cc: Andrzej Zaborowski <balrogg@gmail.com>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

d693e147

tcg-i386: Implement multiword arithmetic ops · 624988a5

由 Richard Henderson 提交于 2月 19, 2013

Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

624988a5

tcg: Implement multiword addition helpers · f6953a73

由 Richard Henderson 提交于 2月 19, 2013

Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

f6953a73

tcg: Implement multiword multiply helpers · 696a8be6

由 Richard Henderson 提交于 2月 19, 2013

Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

696a8be6

tcg: Implement a 64-bit to 32-bit extraction helper · 3c51a985

由 Richard Henderson 提交于 2月 19, 2013

We're going to have use for this shortly in implementing other helpers.
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

3c51a985

R
tcg: Add signed multiword multiplication operations · 4d3203fd
由 Richard Henderson 提交于 2月 19, 2013
```
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>
```
4d3203fd

tcg: Add 64-bit multiword arithmetic operations · d7156f7c

由 Richard Henderson 提交于 2月 19, 2013

Matching the 32-bit multiword arithmetic that we already have.
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

d7156f7c

tcg-sparc: Always implement 32-bit multiword ops · 803d805b

由 Richard Henderson 提交于 2月 19, 2013

Cc: Blue Swirl <blauwirbel@gmail.com>
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>

803d805b

R
tcg-i386: Always implement 32-bit multiword ops · bbc863bf
由 Richard Henderson 提交于 2月 19, 2013
```
Signed-off-by: NRichard Henderson <rth@twiddle.net>
Signed-off-by: NBlue Swirl <blauwirbel@gmail.com>
```
bbc863bf