1. 02 7月, 2010 2 次提交
  2. 22 6月, 2010 1 次提交
    • E
      monitor: allow device to be ejected if no disk is inserted · 3b5276b5
      Eduardo Habkost 提交于
      This changes the monitor eject_device() function to not check for
      bdrv_is_inserted().
      
      Example run where the bug manifests itself:
      
      (output of 'info block' is stripped to include only the CD-ROM device)
      
        (qemu) info block
        ide1-cd0: type=cdrom removable=1 locked=0 [not inserted]
        (qemu) change ide1-cd0 /dev/cdrom host_cdrom
        (qemu) info block
        ide1-cd0: type=cdrom removable=1 locked=0 file=/dev/cdrom ro=1 drv=host_cdrom encrypted=0
        (qemu) eject ide1-cd0
        (qemu) info block
        ide1-cd0: type=cdrom removable=1 locked=0 file=/dev/cdrom ro=1 drv=host_cdrom encrypted=0
      
        # at this point, a disk was inserted on the host CD-ROM drive
      
        (qemu) info block
        ide1-cd0: type=cdrom removable=1 locked=0 file=/dev/cdrom ro=1 drv=host_cdrom encrypted=0
        (qemu) eject ide1-cd0
        (qemu) info block
        ide1-cd0: type=cdrom removable=1 locked=0 [not inserted]
        (qemu)
      
      The first eject command didn't work because the is_inserted() check
      failed.
      
      I have no clue why the code had the is_inserted() check, as it doesn't matter
      if there is a disk present at the host drive, when the user wants the virtual
      device to be disconnected from the host device.
      
      The is_inserted() check has another side effect: a memory leak if the "change"
      command is used multiple times, as do_change() calls eject_device() before
      re-opening the block device, but bdrv_close() is never called.
      Signed-off-by: NEduardo Habkost <ehabkost@redhat.com>
      Signed-off-by: NKevin Wolf <kwolf@redhat.com>
      3b5276b5
  3. 15 6月, 2010 5 次提交
  4. 04 6月, 2010 2 次提交