Skip to content

Q
qemu

openeuler / qemu

通知 10
Star 0
Fork 0
Q
qemu
切换分支/标签
  1. 16 6月, 2014 1 次提交
  3. 21 11月, 2013 1 次提交
    • M
      Revert "e1000/rtl8139: update HMP NIC when every bit is written" · 90d131fb
      由 Michael S. Tsirkin 提交于 
      This reverts commit cd5be582.
Digging into hardware specs shows this does not
actually make QEMU behave more like hardware:

There are valid arguments backed by the spec to indicate why the version
of e1000 prior to cd5be582 was more correct: the high byte actually
includes a valid bit, this is why all guests write it last.

For rtl8139 there's actually a separate undocumented valid bit, but we
don't implement it yet.

To summarize all the drivers we know about behave in one way
that allows us to make an assumption about write order and avoid
spurious, incorrect mac address updates to the monitor.

Let's stick to the tried heuristic for 1.7 and
possibly revisit for 1.8.
Reported-by: NVlad Yasevich <vyasevic@redhat.com>
Reviewed-by: NVlad Yasevich <vyasevic@redhat.com>
Cc: Amos Kong <akong@redhat.com>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>
      90d131fb
  5. 07 11月, 2013 1 次提交
  7. 18 10月, 2013 2 次提交
  9. 14 10月, 2013 1 次提交
  11. 23 8月, 2013 1 次提交
  13. 29 7月, 2013 1 次提交
  15. 23 7月, 2013 2 次提交
  17. 04 7月, 2013 2 次提交
  19. 24 5月, 2013 1 次提交
    • S
      rtl8139: flush queued packets when RxBufPtr is written · 00b7ade8
      由 Stefan Hajnoczi 提交于 
      Net queues support efficient "receive disable".  For example, tap's file
descriptor will not be polled while its peer has receive disabled.  This
saves CPU cycles for needlessly copying and then dropping packets which
the peer cannot receive.

rtl8139 is missing the qemu_flush_queued_packets() call that wakes the
queue up when receive becomes possible again.

As a result, the Windows 7 guest driver reaches a state where the
rtl8139 cannot receive packets.  The driver has actually refilled the
receive buffer but we never resume reception.

The bug can be reproduced by running a large FTP 'get' inside a Windows
7 guest:

  $ qemu -netdev tap,id=tap0,...
         -device rtl8139,netdev=tap0

The Linux guest driver does not trigger the bug, probably due to a
different buffer management strategy.
Reported-by: NOliver Francke <oliver.francke@filoo.de>
Signed-off-by: NStefan Hajnoczi <stefanha@redhat.com>
      00b7ade8
  21. 09 4月, 2013 1 次提交
  23. 18 3月, 2013 1 次提交
    • G
      Switch to efi-enabled nic roms by default · c45e5b5b
      由 Gerd Hoffmann 提交于 
      All PCI nics are switched to EFI-enabled roms by default.  They are
composed from three images (legacy, efi ia32 & efi x86), so classic
pxe booting will continue to work.

Exception: eepro100 is not switched, it uses a single rom for all
emulated eepro100 variants, then goes patch the rom header on the
fly with the correct PCI IDs.  I doubt that will work as-is with
the efi roms.

Keep old roms for 1.4+older machine types via compat properties,
needed because the efi-enabled roms are larger so the pci rom bar
size would change.
Signed-off-by: NGerd Hoffmann <kraxel@redhat.com>
      c45e5b5b
  25. 01 3月, 2013 1 次提交
    • P
      hw: include hw header files with full paths · 83c9f4ca
      由 Paolo Bonzini 提交于 
      Done with this script:

cd hw
for i in `find . -name '*.h' | sed 's/^..//'`; do
  echo '\,^#.*include.*["<]'$i'[">], s,'$i',hw/&,'
done | sed -i -f - `find . -type f`

This is so that paths remain valid as files are moved.

Instead, files in hw/dataplane are referenced with the relative path.
We know they are not going to move to include/, and they are the only
include files that are in subdirectories _and_ move.
Signed-off-by: NPaolo Bonzini <pbonzini@redhat.com>
      83c9f4ca
  27. 02 2月, 2013 3 次提交
  29. 11 1月, 2013 1 次提交
    • A
      Make all static TypeInfos const · 8c43a6f0
      由 Andreas Färber 提交于 
      Since 39bffca2 (qdev: register all
types natively through QEMU Object Model), TypeInfo as used in
the common, non-iterative pattern is no longer amended with information
and should therefore be const.

Fix the documented QOM examples:

 sed -i 's/static TypeInfo/static const TypeInfo/g' include/qom/object.h

Since frequently the wrong examples are being copied by contributors of
new devices, fix all types in the tree:

 sed -i 's/^static TypeInfo/static const TypeInfo/g' */*.c
 sed -i 's/^static TypeInfo/static const TypeInfo/g' */*/*.c

This also avoids to piggy-back these changes onto real functional
changes or other refactorings.
Signed-off-by: NAndreas Färber <afaerber@suse.de>
Signed-off-by: NAnthony Liguori <aliguori@us.ibm.com>
      8c43a6f0
  31. 07 1月, 2013 1 次提交
  33. 19 12月, 2012 3 次提交
  35. 17 12月, 2012 1 次提交
  37. 29 10月, 2012 1 次提交
  39. 23 10月, 2012 1 次提交
    • A
      Rename target_phys_addr_t to hwaddr · a8170e5e
      由 Avi Kivity 提交于 
      target_phys_addr_t is unwieldly, violates the C standard (_t suffixes are
reserved) and its purpose doesn't match the name (most target_phys_addr_t
addresses are not target specific).  Replace it with a finger-friendly,
standards conformant hwaddr.

Outstanding patchsets can be fixed up with the command

  git rebase -i --exec 'find -name "*.[ch]"
                        | xargs s/target_phys_addr_t/hwaddr/g' origin
Signed-off-by: NAvi Kivity <avi@redhat.com>
Signed-off-by: NAnthony Liguori <aliguori@us.ibm.com>
      a8170e5e
  41. 08 10月, 2012 1 次提交
  43. 05 10月, 2012 1 次提交
  45. 01 8月, 2012 2 次提交
  47. 23 7月, 2012 1 次提交
  49. 04 7月, 2012 1 次提交
  51. 28 6月, 2012 1 次提交
  53. 08 6月, 2012 1 次提交
    • M
      change iov_* function prototypes to be more appropriate · dcf6f5e1
      由 Michael Tokarev 提交于 
      Reorder arguments to be more natural, readable and
consistent with other iov_* functions, and change
argument names, from:
 iov_from_buf(iov, iov_cnt, buf, iov_off, size)
to
 iov_from_buf(iov, iov_cnt, offset, buf, bytes)

The result becomes natural English:

 copy data to this `iov' vector with `iov_cnt'
 elements starting at byte offset `offset'
 from memory buffer `buf', processing `bytes'
 bytes max.

(Try to read the original prototype this way).

Also change iov_clear() to more general iov_memset()
(it uses memset() internally anyway).

While at it, add comments to the header file
describing what the routines actually does.

The patch only renames argumens in the header, but
keeps old names in the implementation.  The next
patch will touch actual code to match.

Now, it might look wrong to pay so much attention
to so small things.  But we've so many badly designed
interfaces already so the whole thing becomes rather
confusing or error prone.  One example of this is
previous commit and small discussion which emerged
from it, with an outcome that the utility functions
like these aren't well-understdandable, leading to
strange usage cases.  That's why I paid quite some
attention to this set of functions and a few
others in subsequent patches.
Signed-off-by: NMichael Tokarev <mjt@tls.msk.ru>
      dcf6f5e1
  55. 07 6月, 2012 1 次提交
    • F
      rtl8139: honor RxOverflow flag in can_receive method · fee9d348
      由 Fernando Luis Vazquez Cao 提交于 
      Some drivers (Linux' 8139too among them) rely on the NIC
injecting an interrupt in the event of a receive buffer overflow
and, accordingly, set the RxOverflow bit in the interrupt
mask. Unfortunately rtl8139's can_receive method ignores the
RxOverflow flag, which may lead to a situation where rtl8139
stops receiving packets (can_receive returns 0) when the receive
buffer becomes full.

If the driver eventually read from the receive buffer or reset
the card the emulator could recover from this situation. However
some implementations only do this upon receiving an interrupt
with either RxOK or RxOverflow set in the ISR; interrupt that
will never come because QEMU's flow control mechanisms would
prevent rtl8139 from receiving any packet.

Letting packets go through when the overflow interrupt is enabled
makes the QEMU emulator compliant to the spec and solves the
problem.

This patch should fix a relatively common (in our experience)
network stall observed when running enterprise distros with
rtl8139 as the NIC; in some cases the 8139too device driver gets
loaded and when under heavy load the network eventually stops
working.
Reported-by: NHayato Kakuta <kakuta.hayato@oss.ntt.co.jp>
Tested-by: NHayato Kakuta <kakuta.hayato@oss.ntt.co.jp>
Acked-by: NIgor Kovalenko <igor.v.kovalenko@gmail.com>
Signed-off-by: NFernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
Signed-off-by: NMichael S. Tsirkin <mst@redhat.com>
      fee9d348
  57. 05 6月, 2012 1 次提交
  59. 04 6月, 2012 1 次提交
  61. 08 5月, 2012 1 次提交
  63. 12 4月, 2012 1 次提交