1. 15 5月, 2012 1 次提交
  2. 14 5月, 2012 1 次提交
    • J
      fix some common typos · a31f0531
      Jim Meyering 提交于
      These were identified using: http://github.com/lyda/misspell-check
      and run like this to create a bourne shell script using GNU sed's
      -i option:
      
      git ls-files|grep -vF .bin | misspellings -f - |grep -v '^ERROR:' |perl \
      -pe 's/^(.*?)\[(\d+)\]: (\w+) -> "(.*?)"$/sed -i '\''${2}s!$3!$4!'\'' $1/'
      
      Manually eliding the FP, "rela->real" and resolving "addres" to
      address (not "adders") we get this:
      
        sed -i '450s!thru!through!' Changelog
        sed -i '260s!neccessary!necessary!' coroutine-sigaltstack.c
        sed -i '54s!miniscule!minuscule!' disas.c
        sed -i '1094s!thru!through!' hw/usb/hcd-ehci.c
        sed -i '1095s!thru!through!' hw/usb/hcd-ehci.c
        sed -i '21s!unecessary!unnecessary!' qapi-schema-guest.json
        sed -i '307s!explictly!explicitly!' qemu-ga.c
        sed -i '490s!preceeding!preceding!' qga/commands-posix.c
        sed -i '792s!addres!address!' qga/commands-posix.c
        sed -i '6s!beeing!being!' tests/tcg/test-mmap.c
      
      Also, manually fix "arithmentic", spotted by Peter Maydell:
      
        sed -i 's!arithmentic!arithmetic!' coroutine-sigaltstack.c
      Signed-off-by: NJim Meyering <meyering@redhat.com>
      Reviewed-by: NPeter Maydell <peter.maydell@linaro.org>
      a31f0531
  3. 30 4月, 2012 2 次提交
    • M
      qemu-ga: persist tracking of fsfreeze state via filesystem · f789aa7b
      Michael Roth 提交于
      Currently, qemu-ga may die/get killed/go away for whatever reason after
      guest-fsfreeze-freeze has been issued, and before guest-fsfreeze-thaw
      has been issued. This means the only way to unfreeze the guest is via
      VNC/network/console access, but obtaining that access after-the-fact can
      often be very difficult when filesystems are frozen. Logins will almost
      always hang, for instance. In many cases the only recourse would be to
      reboot the guest without any quiescing of volatile state, which makes
      this a corner-case worth giving some attention to.
      
      A likely failsafe for this situation would be to use a watchdog to
      restart qemu-ga if it goes away. There are some precautions qemu-ga
      needs to take in order to avoid immediately hanging itself on I/O,
      however, namely, we must disable logging and defer to processing/creation
      of user-specific logfiles, along with creation of the pid file if we're
      running as a daemon. We also need to disable non-fsfreeze-safe commands,
      as we normally would when processing the guest-fsfreeze-freeze command.
      
      To track when we need to do this in a way that persists between multiple
      invocations of qemu-ga, we create a file on the guest filesystem before
      issuing the fsfreeze, and delete it when doing the thaw. On qemu-ga
      startup, we check for the existance of this file to determine
      the need to take the above precautions.
      
      We're forced to do it this way since a more traditional approach such as
      reading/writing state to a dedicated state file will cause
      access/modification time updates, respectively, both of which will hang
      if the file resides on a frozen filesystem. Both can occur even if
      relatime is enabled. Checking for file existence will not update the
      access time, however, so it's a safe way to check for fsfreeze state.
      
      An actual watchdog-based restart of qemu-ga can itself cause an access
      time update that would thus hang the invocation of qemu-ga, but the
      logic to workaround that can be handled via the watchdog, so we don't
      address that here (for relatime we'd periodically touch the qemu-ga
      binary if the file $qga_statedir/qga.state.isfrozen is not present, this
      avoids qemu-ga updates or the 1 day relatime threshold causing an
      access-time update if we try to respawn qemu-ga shortly after it goes
      away)
      Signed-off-by: NMichael Roth <mdroth@linux.vnet.ibm.com>
      f789aa7b
    • M
      qemu-ga: add a whitelist for fsfreeze-safe commands · f22d85e9
      Michael Roth 提交于
      Currently we rely on fsfreeze/thaw commands disabling/enabling logging
      then having other commands check whether logging is disabled to avoid
      executing if they aren't safe for running while a filesystem is frozen.
      
      Instead, have an explicit whitelist of fsfreeze-safe commands, and
      consolidate logging and command enablement/disablement into a pair
      of helper functions: ga_set_frozen()/ga_unset_frozen()
      Signed-off-by: NMichael Roth <mdroth@linux.vnet.ibm.com>
      f22d85e9
  4. 19 4月, 2012 1 次提交
  5. 13 3月, 2012 2 次提交
    • M
      qemu-ga: add guest-sync-delimited · 3cf0bed8
      Michael Roth 提交于
      guest-sync leaves it as an exercise to the user as to how to reliably
      obtain the response to guest-sync if the client had previously read in a
      partial response (due qemu-ga previously being restarted mid-"sentence"
      due to reboot, forced restart, etc).
      
      qemu-ga handles this situation on its end by having a client precede
      their guest-sync request with a 0xFF byte (invalid UTF-8), which
      qemu-ga/QEMU JSON parsers will treat as a flush event. Thus we can
      reliably flush the qemu-ga parser state in preparation for receiving
      the guest-sync request.
      
      guest-sync-delimited provides the same functionality for a client: when
      a guest-sync-delimited is issued, qemu-ga will precede it's response
      with a 0xFF byte that the client can use as an indicator to flush its
      buffer/parser state in preparation for reliably receiving the
      guest-sync-delimited response.
      
      It is also useful as an optimization for clients, since, after issuing a
      guest-sync-delimited, clients can safely discard all stale data read
      from the channel until the 0xFF is found.
      
      More information available on the wiki:
      
      http://wiki.qemu.org/Features/QAPI/GuestAgent#QEMU_Guest_Agent_ProtocolSigned-off-by: NMichael Roth <mdroth@linux.vnet.ibm.com>
      3cf0bed8
    • L
      qemu-ga: add guest-suspend-disk · 11d0f125
      Luiz Capitulino 提交于
      As the command name implies, this command suspends the guest to disk.
      
      The suspend operation is implemented by two functions: bios_supports_mode()
      and guest_suspend(). Both functions are generic enough to be used by
      other suspend modes (introduced by next commits).
      
      Both functions will try to use the scripts provided by the pm-utils
      package if it's available. If it's not available, a manual method,
      which consists of directly writing to '/sys/power/state', will be used.
      
      To reap terminated children, a new signal handler is installed in the
      parent to catch SIGCHLD signals and a non-blocking call to waitpid()
      is done to collect their exit statuses. The statuses, however, are
      discarded.
      
      The approach used to query the guest for suspend support deserves some
      explanation. It's implemented by bios_supports_mode() and shown below:
      
        qemu-ga
           |
       create pipe
           |
         fork()
           -----------------
           |               |
           |               |
           |             fork()
           |               --------------------------
           |               |                        |
           |               |                        |
           |               |               exec('pm-is-supported')
           |               |
           |              wait()
           |       write exit status to pipe
           |              exit
           |
        read pipe
      
      This might look complex, but the resulting code is quite simple.
      The purpose of that approach is to allow qemu-ga to reap its children
      (semi-)automatically from its SIGCHLD handler.
      
      Implementing this the obvious way, that's, doing the exec() call from
      the first child process, would force us to introduce a more complex way
      to reap qemu-ga's children. Like registering PIDs to be reaped and
      having a way to wait for them when returning their exit status to
      qemu-ga is necessary. The approach explained above avoids that complexity.
      Signed-off-by: NLuiz Capitulino <lcapitulino@redhat.com>
      11d0f125
  6. 24 2月, 2012 4 次提交
    • M
      qemu-ga: add Windows service integration · bc62fa03
      Michael Roth 提交于
      This allows qemu-ga to function as a Windows service:
      
       - to install the service (will auto-start on boot):
           qemu-ga --service install
       - to start the service:
           net start qemu-ga
       - to stop the service:
           net stop qemu-ga
       - to uninstall service:
           qemu-ga --service uninstall
      
      Original patch by Gal Hammer <ghammer@redhat.com>
      bc62fa03
    • M
      qemu-ga: add initial win32 support · 7868e26e
      Michael Roth 提交于
      This adds a win32 channel implementation that makes qemu-ga functional
      on Windows using virtio-serial (unix-listen/isa-serial not currently
      implemented). Unlike with the posix implementation, we do not use
      GIOChannel for the following reasons:
      
       - glib calls stat() on an fd to check whether S_IFCHR is set, which is
         the case for virtio-serial on win32. Because of that, a one-time
         check to determine whether the channel is readable is done by making
         a call to PeekConsoleInput(), which reports the underlying handle is
         not a valid console handle, and thus we can never read from the
         channel.
      
       - if one goes as far as to "trick" glib into thinking it is a normal
         file descripter, the buffering is done in such a way that data
         written to the output stream will subsequently result in that same
         data being read back as if it were input, causing an error loop.
         furthermore, a forced flush of the channel only moves the data into a
         secondary buffer managed by glib, so there's no way to prevent output
         from getting read back as input.
      
      The implementation here ties into the glib main loop by implementing a
      custom GSource that continually submits asynchronous/overlapped I/O to
      fill an GAChannel-managed read buffer, and tells glib to poll the
      corresponding event handle for a completion whenever there is no
      data/RPC in the read buffer to notify the main application about.
      7868e26e
    • M
      qemu-ga: fixes for win32 build of qemu-ga · d8ca685a
      Michael Roth 提交于
      Various stubs and #ifdefs to compile for Windows using mingw
      cross-build. Still has 1 linker error due to a dependency on the
      forthcoming win32 versions of the GAChannel/transport class.
      d8ca685a
    • M
      qemu-ga: move channel/transport functionality into wrapper class · 125b310e
      Michael Roth 提交于
      This is mostly in preparation for the win32 port, which won't use
      GIO channels for reasons that will be made clearer later. Here the
      GAChannel class is just a loose wrapper around GIOChannel
      calls/callbacks, but we also roll in the logic/configuration for
      various channel types and managing unix socket connections, which makes
      the abstraction much more complete and further aids in the win32 port
      since isa-serial/unix-listen will not be supported initially.
      
      There's also a bit of refactoring in the main logic to consolidate the
      exit paths so we can do common cleanup for things like pid files, which
      weren't always cleaned up previously.
      125b310e
  7. 13 1月, 2012 1 次提交
  8. 13 12月, 2011 1 次提交
  9. 29 8月, 2011 1 次提交
  10. 22 8月, 2011 1 次提交
  11. 21 8月, 2011 1 次提交
  12. 24 7月, 2011 1 次提交
  13. 22 7月, 2011 2 次提交
    • M
      guest agent: add guest agent RPCs/commands · e3d4d252
      Michael Roth 提交于
      This adds the initial set of QMP/QAPI commands provided by the guest
      agent:
      
      guest-sync
      guest-ping
      guest-info
      guest-shutdown
      guest-file-open
      guest-file-read
      guest-file-write
      guest-file-seek
      guest-file-flush
      guest-file-close
      guest-fsfreeze-freeze
      guest-fsfreeze-thaw
      guest-fsfreeze-status
      
      The input/output specification for these commands are documented in the
      schema.
      
      Example usage:
      
        host:
          qemu -device virtio-serial \
               -chardev socket,path=/tmp/vs0.sock,server,nowait,id=qga0 \
               -device virtserialport,chardev=qga0,name=org.qemu.quest_agent.0
               ...
      
          echo "{'execute':'guest-info'}" | socat stdio unix-connect:/tmp/qga0.sock
      
        guest:
          qemu-ga -m virtio-serial -p /dev/virtio-ports/org.qemu.guest_agent.0 \
                  -p /var/run/qemu-guest-agent.pid -d
      Signed-off-by: NMichael Roth <mdroth@linux.vnet.ibm.com>
      Signed-off-by: NLuiz Capitulino <lcapitulino@gmail.com>
      e3d4d252
    • M
      guest agent: qemu-ga daemon · 48ff7a62
      Michael Roth 提交于
      This is the actual guest daemon, it listens for requests over a
      virtio-serial/isa-serial/unix socket channel and routes them through
      to dispatch routines, and writes the results back to the channel in
      a manner similar to QMP.
      
      A shorthand invocation:
      
        qemu-ga -d
      
      Is equivalent to:
      
        qemu-ga -m virtio-serial -p /dev/virtio-ports/org.qemu.guest_agent.0 \
                -f /var/run/qemu-ga.pid -d
      Signed-off-by: NMichael Roth <mdroth@linux.vnet.ibm.com>
      Signed-off-by: NLuiz Capitulino <lcapitulino@gmail.com>
      48ff7a62