1. 01 7月, 2014 4 次提交
  2. 30 6月, 2014 1 次提交
  3. 19 6月, 2014 1 次提交
  4. 25 4月, 2014 1 次提交
  5. 12 4月, 2014 1 次提交
  6. 20 3月, 2014 4 次提交
    • S
      qom: Add check() argument to object_property_add_link() · 39f72ef9
      Stefan Hajnoczi 提交于
      There are currently three types of object_property_add_link() callers:
      
      1. The link property may be set at any time.
      2. The link property of a DeviceState instance may only be set before
         realize.
      3. The link property may never be set, it is read-only.
      
      Something similar can already be achieved with
      object_property_add_str()'s set() argument.  Follow its example and add
      a check() argument to object_property_add_link().
      
      Also provide default check() functions for case #1 and #2.  Case #3 is
      covered by passing a NULL function pointer.
      
      Cc: Peter Crosthwaite <peter.crosthwaite@petalogix.com>
      Cc: Alexander Graf <agraf@suse.de>
      Cc: Anthony Liguori <aliguori@amazon.com>
      Cc: "Michael S. Tsirkin" <mst@redhat.com>
      Signed-off-by: NStefan Hajnoczi <stefanha@redhat.com>
      Reviewed-by: NPaolo Bonzini <pbonzini@redhat.com>
      [AF: Tweaked documentation comment]
      Signed-off-by: NAndreas Färber <afaerber@suse.de>
      39f72ef9
    • S
      qom: Make QOM link property unref optional · 9561fda8
      Stefan Hajnoczi 提交于
      Some object_property_add_link() callers expect property deletion to
      unref the link property object.  Other callers expect to manage the
      refcount themselves.  The former are currently broken and therefore leak
      the link property object.
      
      This patch adds a flags argument to object_property_add_link() so the
      caller can specify which refcount behavior they require.  The new
      OBJ_PROP_LINK_UNREF_ON_RELEASE flag causes the link pointer to be
      unreferenced when the property is deleted.
      
      This fixes refcount leaks in qdev.c, xilinx_axidma.c, xilinx_axienet.c,
      s390-virtio-bus.c, virtio-pci.c, virtio-rng.c, and ui/console.c.
      
      Rationale for refcount behavior:
      
       * hw/core/qdev.c
         - bus children are explicitly unreferenced, don't interfere
         - parent_bus is essentially a read-only property that doesn't hold a
           refcount, don't unref
         - hotplug_handler is leaked, do unref
      
       * hw/dma/xilinx_axidma.c
         - rx stream "dma" links are set using set_link, therefore they
           need unref
         - tx streams are set using set_link, therefore they need unref
      
       * hw/net/xilinx_axienet.c
         - same reasoning as hw/dma/xilinx_axidma.c
      
       * hw/pcmcia/pxa2xx.c
         - pxa2xx bypasses set_link and therefore does not use refcounts
      
       * hw/s390x/s390-virtio-bus.c
       * hw/virtio/virtio-pci.c
       * hw/virtio/virtio-rng.c
       * ui/console.c
         - set_link is used and there is no explicit unref, do unref
      
      Cc: Peter Crosthwaite <peter.crosthwaite@petalogix.com>
      Cc: Alexander Graf <agraf@suse.de>
      Cc: Anthony Liguori <aliguori@amazon.com>
      Cc: "Michael S. Tsirkin" <mst@redhat.com>
      Signed-off-by: NStefan Hajnoczi <stefanha@redhat.com>
      Reviewed-by: NPaolo Bonzini <pbonzini@redhat.com>
      Signed-off-by: NAndreas Färber <afaerber@suse.de>
      9561fda8
    • S
      qom: Don't make link NULL on object_property_set_link() failure · c6aed983
      Stefan Hajnoczi 提交于
      The error behavior of object_property_set_link() is dangerous.  It sets
      the link property object to NULL if an error occurs.  A setter function
      should either succeed or fail, it shouldn't leave the value NULL on
      failure.
      Signed-off-by: NStefan Hajnoczi <stefanha@redhat.com>
      Reviewed-by: NPaolo Bonzini <pbonzini@redhat.com>
      Signed-off-by: NAndreas Färber <afaerber@suse.de>
      c6aed983
    • S
      qom: Split object_property_set_link() · f5ec6704
      Stefan Hajnoczi 提交于
      The path resolution logic in object_property_set_link() should be a
      separate function.  This makes the code easier to read and maintain.
      Signed-off-by: NStefan Hajnoczi <stefanha@redhat.com>
      Reviewed-by: NPaolo Bonzini <pbonzini@redhat.com>
      Signed-off-by: NAndreas Färber <afaerber@suse.de>
      f5ec6704
  7. 14 3月, 2014 9 次提交
  8. 13 3月, 2014 2 次提交
  9. 15 2月, 2014 1 次提交
  10. 29 1月, 2014 1 次提交
    • I
      add optional 2nd stage initialization to -object/object-add commands · 269e09f3
      Igor Mammedov 提交于
      Introduces USER_CREATABLE interface that must be implemented by
      objects which are designed to created with -object CLI option or
      object-add QMP command.
      
      Interface provides an ability to do an optional second stage
      initialization of the object created with -object/object-add
      commands. By providing complete() callback, which is called
      after the object properties were set.
      
      It allows to:
       * prevents misusing of -object/object-add by filtering out
         objects that are not designed for it.
       * generalize second stage backend initialization instead of
         adding custom APIs to perform it
       * early error detection of backend initialization at -object/
         object-add time rather than through a proxy DEVICE object
         that tries to use backend.
      Signed-off-by: NIgor Mammedov <imammedo@redhat.com>
      Reviewed-by: NStefan Hajnoczi <stefanha@redhat.com>
      Signed-off-by: NLuiz Capitulino <lcapitulino@redhat.com>
      269e09f3
  11. 07 1月, 2014 1 次提交
  12. 25 12月, 2013 3 次提交
  13. 23 12月, 2013 2 次提交
  14. 19 11月, 2013 1 次提交
  15. 14 10月, 2013 1 次提交
  16. 20 9月, 2013 1 次提交
    • J
      cpu: Move cpu state syncs up into cpu_dump_state() · 97577fd4
      James Hogan 提交于
      The x86 and ppc targets call cpu_synchronize_state() from their
      *_cpu_dump_state() callbacks to ensure that up to date state is dumped
      when KVM is enabled (for example when a KVM internal error occurs).
      
      Move this call up into the generic cpu_dump_state() function so that
      other KVM targets (namely MIPS) can take advantage of it.
      
      This requires kvm_cpu_synchronize_state() and cpu_synchronize_state() to
      be moved out of the #ifdef NEED_CPU_H in <sysemu/kvm.h> so that they're
      accessible to qom/cpu.c.
      Signed-off-by: NJames Hogan <james.hogan@imgtec.com>
      Cc: Andreas Färber <afaerber@suse.de>
      Cc: Alexander Graf <agraf@suse.de>
      Cc: Gleb Natapov <gleb@redhat.com>
      Cc: qemu-ppc@nongnu.org
      Cc: kvm@vger.kernel.org
      Signed-off-by: NGleb Natapov <gleb@redhat.com>
      97577fd4
  17. 03 9月, 2013 1 次提交
  18. 31 8月, 2013 2 次提交
  19. 17 8月, 2013 2 次提交
  20. 29 7月, 2013 1 次提交
    • A
      cpu: Partially revert "cpu: Change qemu_init_vcpu() argument to CPUState" · 14a10fc3
      Andreas Färber 提交于
      Commit c643bed9 moved qemu_init_vcpu() calls to common CPUState code.
      This causes x86 cpu-add to fail with "KVM: setting VAPIC address failed".
      
      The reason for the failure is that CPUClass::kvm_fd is not yet
      initialized in the following call graph:
      ->x86_cpu_realizefn
       ->x86_cpu_apic_realize
        ->qdev_init
         ->device_set_realized
          ->device_reset (hotplugged == 1)
           ->apic_reset_common
            ->vapic_base_update
             ->kvm_apic_vapic_base_update
      This causes attempted KVM vCPU ioctls to fail.
      
      By contrast, in the non-hotplug case the APIC is reset much later, when
      the vCPU is already initialized.
      
      As a quick and safe solution, move the qemu_init_vcpu() call back into
      the targets' realize functions.
      Reported-by: NChen Fan <chen.fan.fnst@cn.fujitsu.com>
      Acked-by: Igor Mammedov <imammedo@redhat.com> (for i386)
      Tested-by: Jia Liu <proljc@gmail.com> (for openrisc)
      Signed-off-by: NAndreas Färber <afaerber@suse.de>
      14a10fc3